stephencelis-kvc 0.0.2 → 0.0.3

data/History.txt

@@ -1,3 +1,15 @@
+=== 0.0.3 / 2009-06-27
+
+* 1 minor enhancement
+
+  * Optimize by relying less on method_missing.
+
+
+* 1 bugfix
+
+  * Don't confuse strings and symbols.
+
+
 === 0.0.2 / 2009-04-04
 
 * 1 minor enhancement

data/lib/kvc.rb

@@ -35,30 +35,32 @@
 #
 # Failed validations will raise <tt>ActiveRecord::RecordInvalid</tt>.
 module KVC
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 
   class << self
+    def [](key)
+      if setting = KVC::Settings.find_by_key(key.to_s)
+        KVC::SettingsProxy.new setting
+      elsif KVC::Settings.strict_keys?
+        raise NoMethodError,
+          "undefined method `#{key}' for #{self}:#{self.class}"
+      end
+    end
+
+    def []=(key, value)
+      setting = KVC::Settings.find_or_initialize_by_key key.to_s
+      setting.update_attributes! :value => value
+    end
+
     private
 
     # Handles the key-value magic.
     def method_missing(method, *args, &block)
       key = method.to_s
-      key.sub!(/^\[\](=?)$/) { "#{args.shift}#{$1}" }
-    
       if key.sub!(/=$/) {} # Is it a writer method?
-        returning args.shift do |value|
-          setting = KVC::Settings.find_or_initialize_by_key(key)
-          setting.update_attributes!(:value => value)
-        end
-      elsif setting = KVC::Settings.find_by_key(key) # Is it a reader?
-        if args.present?
-          error_message = "wrong number of arguments (#{args.length} for 0)"
-          raise ArgumentError, error_message
-        end
-    
-        KVC::SettingsProxy.new(setting)
-      elsif args.present? || KVC::Settings.strict_keys?
-        raise NoMethodError
+        self[key] = *args
+      else
+        self[key, *args]
       end
     end
   end

data/lib/kvc/settings.rb

@@ -43,14 +43,12 @@ class KVC::Settings < ActiveRecord::Base
 
   # Deserializes value from database.
   def value
-    @value ||= YAML.load(read_attribute(:value))
+    @value ||= YAML.load read_attribute(:value)
   end
 
   # Serializes value for database.
   def value=(input)
-    returning @value = input do
-      write_attribute :value, input.to_yaml
-    end
+    write_attribute :value, (@value = input).to_yaml
   end
 
   private

data/test/kvc_test.rb

@@ -26,7 +26,7 @@ class KVCTest < ActiveSupport::TestCase
   end
 
   test "method_missing should re-raise if there are arguments" do
-    assert_raise NoMethodError do
+    assert_raise ArgumentError do
       KVC.this_should("not_work")
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: stephencelis-kvc
 version: !ruby/object:Gem::Version 
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors: 
 - Stephen Celis
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-04-04 00:00:00 -07:00
+date: 2009-06-27 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -20,7 +20,7 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        version: 1.11.0
+        version: 2.0.0
     version: 
 description: KVC (Key-Value Configuration) provides a powerful, transparent way to maintain mutable app settings in the database.
 email: 
@@ -44,7 +44,7 @@ files:
 - tasks/kvc_tasks.rake
 - test/kvc_test.rb
 - uninstall.rb
-has_rdoc: true
+has_rdoc: false
 homepage: http://github.com/stephencelis/kvc
 post_install_message: 
 rdoc_options: 
@@ -69,7 +69,7 @@ requirements: []
 rubyforge_project: kvc
 rubygems_version: 1.2.0
 signing_key: 
-specification_version: 2
+specification_version: 3
 summary: KVC (Key-Value Configuration) provides a powerful, transparent way to maintain mutable app settings in the database.
 test_files: []