stephencelis-ghi 0.0.7 → 0.0.8

data/History.rdoc

@@ -1,3 +1,15 @@
+=== 0.0.8 / 2009-04-26
+
+* 1 major enhancement
+
+  * Flag to return issues URLs.
+
+
+* 1 minor enhancement
+
+  * Preliminary specs for top-level module and API class.
+
+
 === 0.0.7 / 2009-04-25
 
 * 1 major enhancement

data/README.rdoc

@@ -27,6 +27,7 @@ Go:
       -t, --label [number] [label]
           --claim [number]
       -d, --unlabel [number] [label]
+      -u, --url [number]
       -V, --version
       -h, --help
 
@@ -52,6 +53,8 @@ ghi works simply from within a repository. Some short examples:
   ghi -t1 "tag"             # Labels issue 1 with "tag"
   ghi -d1 "tag"             # Removes the label, "tag"
   ghi --claim 1             # Tags issue 1 with your GitHub username
+  open `ghi -u`             # Loads issues in your browser.
+  open `ghi -u1`            # Loads an issue in your browser.
 
 
 ghi also works anywhere:

data/lib/ghi/cli.rb

@@ -162,6 +162,8 @@ module GHI::CLI #:nodoc:
         when :comment       then comment
         when :label, :claim then add_label
         when :unlabel       then remove_label
+
+        when :url           then url
       end
     rescue GHI::API::InvalidConnection
       warn "#{File.basename $0}: not a GitHub repo"
@@ -188,13 +190,15 @@ module GHI::CLI #:nodoc:
         opts.on("-l", "--list", "--search", "--show [state|term|number]") do |v|
           @action = :list
           case v
-          when nil, /^o$/
+          when nil, /^o(?:pen)?$/
             @state = :open
           when /^\d+$/
             @action = :show
             @number = v.to_i
-          when /^c$/
+          when /^c(?:losed)?$/
             @state = :closed
+          when /^u$/
+            @action = :url
           else
             @action = :search
             @state ||= :open
@@ -213,6 +217,8 @@ module GHI::CLI #:nodoc:
             @state = :open
           when /^m$/
             @title = ARGV * " "
+          when /^u$/
+            @action = :url
           else
             @title = v
           end
@@ -221,11 +227,14 @@ module GHI::CLI #:nodoc:
         opts.on("-c", "--closed", "--close [number]") do |v|
           case v
           when /^\d+$/
-            @action = :close
-            @number = v.to_i
-          when /^l/, nil
+            @action ||= :close
+            @number = v.to_i unless v.nil?
+          when /^l$/, nil
             @action = :list
             @state = :closed
+          when /^u$/, nil
+            @action = :url
+            @state = :closed
           when nil
             raise OptionParser::MissingArgument
           else
@@ -286,6 +295,16 @@ module GHI::CLI #:nodoc:
           end
         end
 
+        opts.on("-u", "--url [number]") do |v|
+          @action = :url
+          case v
+          when /^\d+$/
+            @number = v.to_i
+          when /^c/
+            @state = :closed
+          end
+        end
+
         opts.on_tail("-V", "--version") do
           puts "#{File.basename($0)}: v#{GHI::VERSION}"
           exit
@@ -375,7 +394,14 @@ module GHI::CLI #:nodoc:
       body = gets_from_editor api.show(number)
       comment = api.comment(number, body)
       delete_message
-      puts "comment #{comment["status"]}"
+      puts "(comment #{comment["status"]})"
+    end
+
+    def url
+      url = "http://github.com/#{user}/#{repo}/issues"
+      url << "/#{state}"       unless state.nil?
+      url << "/#{number}/find" unless number.nil?
+      puts url
     end
   end
 end

data/lib/ghi.rb

@@ -2,7 +2,7 @@ require "net/http"
 require "yaml"
 
 module GHI
-  VERSION = "0.0.7"
+  VERSION = "0.0.8"
 
   def self.login
     return @login if defined? @login
@@ -39,15 +39,15 @@ module GHI
   def self.user?(username)
     url = "http://github.com/api/v2/yaml/user/show/#{username}"
     !YAML.load(Net::HTTP.get(URI.parse(url)))["user"].nil?
-  rescue ArgumentError # Failure to parse YAML.
+  rescue ArgumentError, URI::InvalidURIError
     false
   end
 
   def self.token?(token)
     url  = "http://github.com/api/v2/yaml/user/show/#{GHI.login}"
     url += "?login=#{GHI.login}&token=#{token}"
-    !YAML.load(Net::HTTP.get(URI.parse(url)))["user"].nil?
-  rescue ArgumentError, NoMethodError # Failure to parse YAML.
+    !YAML.load(Net::HTTP.get(URI.parse(url)))["user"]["plan"].nil?
+  rescue ArgumentError, NoMethodError, URI::InvalidURIError
     false
   end
 end

data/spec/ghi/api_spec.rb

@@ -1,8 +1,57 @@
 $: << File.expand_path(File.dirname(__FILE__) + "/../lib")
 require "ghi"
 require "ghi/api"
+require "ghi/issue"
 include GHI
 
+ISSUES_YAML = <<-YAML
+---
+issues: 
+- number: 1
+  votes: 0
+  created_at: 2009-04-17 14:55:33 -07:00
+  body: my sweet, sweet issue
+  title: new issue
+  updated_at: 2009-04-17 14:55:33 -07:00
+  user: schacon
+  state: open
+- number: 2
+  votes: 0
+  created_at: 2009-04-17 15:16:47 -07:00
+  body: the body of a second issue
+  title: another issue
+  updated_at: 2009-04-17 15:16:47 -07:00
+  user: schacon
+  state: open
+YAML
+
+ISSUE_YAML = <<-YAML
+--- 
+issue: 
+  number: 1
+  votes: 0
+  created_at: 2009-04-17 14:55:33 -07:00
+  body: my sweet, sweet issue
+  title: new issue
+  updated_at: 2009-04-17 14:55:33 -07:00
+  user: schacon
+  state: open
+YAML
+
+LABELS_YAML = <<-YAML
+--- 
+labels: 
+- testing
+- test_label
+YAML
+
+COMMENT_YAML = <<-YAML
+---
+comment:
+  comment: this is amazing
+  status: saved
+YAML
+
 describe GHI::API do
   it "should require user and repo" do
     proc { API.new(nil, nil) }.should raise_error(API::InvalidConnection)
@@ -10,4 +59,138 @@ describe GHI::API do
     proc { API.new(nil, "r") }.should raise_error(API::InvalidConnection)
     proc { API.new("u", "r") }.should_not raise_error(API::InvalidConnection)
   end
+
+  describe "requests" do
+    before :all do
+      @api = API.new "stephencelis", "ghi"
+      GHI.stub!(:login).and_return "stephencelis"
+      GHI.stub!(:token).and_return "token"
+    end
+
+    it "should substitute url tokens" do
+      @api.send(:url, :open).should ==
+        "http://github.com/api/v2/yaml/issues/open/stephencelis/ghi"
+      @api.send(:url, :show, 1).should ==
+        "http://github.com/api/v2/yaml/issues/show/stephencelis/ghi/1"
+      @api.send(:url, :search, :open, "me").should ==
+        "http://github.com/api/v2/yaml/issues/search/stephencelis/ghi/open/me"
+      @api.send(:url, "label/add", "me").should ==
+        "http://github.com/api/v2/yaml/issues/label/add/stephencelis/ghi/me"
+    end
+
+    it "should process gets" do
+      url   = "http://github.com/api/v2/yaml/issues/open/stephencelis/ghi"
+      query = "?login=stephencelis&token=d1cd249db48d51c9847cbf2b291f5ae9"
+      @api.stub!(:url).and_return url
+      URI.should_receive(:parse).once.with(url + query).and_return("mock")
+      Net::HTTP.should_receive(:get).once.with("mock").and_return ISSUES_YAML
+      @api.list
+    end
+
+    it "should process posts" do
+      url   = "http://github.com/api/v2/yaml/issues/open/stephencelis/ghi"
+      query = { :login => "stephencelis",
+                :token => "d1cd249db48d51c9847cbf2b291f5ae9",
+                :title => "Title",
+                :body  => "Body" }
+      @api.stub!(:url).and_return url
+      r = mock(Net::HTTPRequest)
+      r.should_receive(:body).once.and_return ISSUE_YAML
+      URI.should_receive(:parse).once.with(url).and_return "u"
+      Net::HTTP.should_receive(:post_form).once.with("u", query).and_return r
+      @api.open "Title", "Body"
+    end
+
+    it "should search open by default" do
+      @api.should_receive(:url).with(:search, :open, "me").and_return "u"
+      Net::HTTP.stub!(:get).and_return ISSUES_YAML
+      issues = @api.search "me"
+      issues.should be_an_instance_of(Array)
+      issues.each { |issue| issue.should be_an_instance_of(Issue) }
+    end
+
+    it "should search closed" do
+      @api.should_receive(:url).with(:search, :closed, "me").and_return "u"
+      Net::HTTP.stub!(:get).and_return ISSUES_YAML
+      @api.search "me", :closed
+    end
+
+    it "should list open by default" do
+      @api.should_receive(:url).with(:list, :open).and_return "u"
+      Net::HTTP.stub!(:get).and_return ISSUES_YAML
+      issues = @api.list
+      issues.should be_an_instance_of(Array)
+      issues.each { |issue| issue.should be_an_instance_of(Issue) }
+    end
+
+    it "should list closed" do
+      @api.should_receive(:url).with(:list, :closed).and_return "u"
+      Net::HTTP.stub!(:get).and_return ISSUES_YAML
+      @api.list :closed
+    end
+
+    it "should show" do
+      @api.should_receive(:url).with(:show, 1).and_return "u"
+      Net::HTTP.stub!(:get).and_return ISSUE_YAML
+      @api.show(1).should be_an_instance_of(Issue)
+    end
+
+    it "should open" do
+      @api.should_receive(:url).with(:open).and_return "u"
+      response = mock(Net::HTTPRequest)
+      response.stub!(:body).and_return ISSUE_YAML
+      Net::HTTP.stub!(:post_form).and_return response
+      @api.open("Title", "Body").should be_an_instance_of(Issue)
+    end
+
+    it "should edit" do
+      @api.should_receive(:url).with(:edit, 1).and_return "u"
+      response = mock(Net::HTTPRequest)
+      response.stub!(:body).and_return ISSUE_YAML
+      Net::HTTP.stub!(:post_form).and_return response
+      @api.edit(1, "Title", "Body").should be_an_instance_of(Issue)
+    end
+
+    it "should close" do
+      @api.should_receive(:url).with(:close, 1).and_return "u"
+      response = mock(Net::HTTPRequest)
+      response.stub!(:body).and_return ISSUE_YAML
+      Net::HTTP.stub!(:post_form).and_return response
+      @api.close(1).should be_an_instance_of(Issue)
+    end
+
+    it "should reopen" do
+      @api.should_receive(:url).with(:reopen, 1).and_return "u"
+      response = mock(Net::HTTPRequest)
+      response.stub!(:body).and_return ISSUE_YAML
+      Net::HTTP.stub!(:post_form).and_return response
+      @api.reopen(1).should be_an_instance_of(Issue)
+    end
+
+    it "should add labels" do
+      @api.should_receive(:url).with("label/add", 1, "l").and_return "u"
+      response = mock(Net::HTTPRequest)
+      response.stub!(:body).and_return LABELS_YAML
+      Net::HTTP.stub!(:post_form).and_return response
+      @api.add_label(1, "l").should be_an_instance_of(Array)
+    end
+
+    it "should remove labels" do
+      @api.should_receive(:url).with("label/remove", 1, "l").and_return "u"
+      response = mock(Net::HTTPRequest)
+      response.stub!(:body).and_return LABELS_YAML
+      Net::HTTP.stub!(:post_form).and_return response
+      @api.remove_label(1, "l").should be_an_instance_of(Array)
+    end
+
+    it "should comment" do
+      @api.should_receive(:url).with(:comment, 1).and_return "u"
+      URI.stub!(:parse).and_return "u"
+      response = mock(Net::HTTPRequest)
+      response.stub!(:body).and_return COMMENT_YAML
+      Net::HTTP.should_receive(:post_form).with("u",
+        hash_including(:comment => "Comment")).and_return response
+      @api.comment(1, "Comment").should be_an_instance_of(Hash)
+    end
+  end
 end

data/spec/ghi_spec.rb

@@ -1,14 +1,93 @@
-$: << File.expand_path(File.dirname(__FILE__) + "/../lib")
+$LOAD_PATH << File.expand_path(File.dirname(__FILE__) + "/../lib")
 require "ghi"
 
+LOGGED_OUT_YAML = <<-YAML
+---
+user: 
+  id: 23
+  login: defunkt
+  name: Kristopher Walken Wanstrath
+  company: LA
+  location: SF
+  email: me@email.com
+  blog: http://myblog.com
+  following_count: 13
+  followers_count: 63
+  public_gist_count: 0
+  public_repo_count: 2
+YAML
+
+LOGGED_IN_YAML = <<-YAML
+---
+user: 
+  id: 23
+  login: defunkt
+  name: Kristopher Walken Wanstrath
+  company: LA
+  location: SF
+  email: me@email.com
+  blog: http://myblog.com
+  following_count: 13
+  followers_count: 63
+  public_gist_count: 0
+  public_repo_count: 2
+  total_private_repo_count: 1
+  collaborators: 3
+  disk_usage: 50384
+  owned_private_repo_count: 1
+  private_gist_count: 0
+  plan: 
+    name: mega
+    collaborators: 60
+    space: 20971520
+    private_repos: 125
+YAML
+
 describe GHI do
+  before :each do
+    GHI.instance_eval do
+      remove_instance_variable :@login if instance_variable_defined? :@login
+      remove_instance_variable :@token if instance_variable_defined? :@token
+    end
+  end
+
   it "should return login" do
-    GHI.stub!(:`).and_return "stephencelis\n"
+    GHI.should_receive(:`).once.and_return "stephencelis\n"
     GHI.login.should == "stephencelis"
   end
   
   it "should return token" do
-    GHI.stub!(:`).and_return "da39a3ee5e6b4b0d3255bfef95601890\n"
+    GHI.should_receive(:`).once.and_return "da39a3ee5e6b4b0d3255bfef95601890\n"
     GHI.token.should == "da39a3ee5e6b4b0d3255bfef95601890"
   end
+
+  it "should approve login input" do
+    GHI.instance_eval { instance_variable_defined?(:@login).should == false }
+    GHI.should_receive(:`).with("git config --get github.user").
+      and_return "\n"
+    GHI.should_receive(:print).twice
+    GHI.should_receive(:gets).twice.and_return "defunct\n", "defunkt\n"
+    Net::HTTP.should_receive(:get).and_return "500: invalid: response",
+      LOGGED_OUT_YAML
+    GHI.should_receive(:warn).once
+    GHI.should_receive(:`).with("git config --global github.user defunkt").
+      and_return "\n"
+    GHI.login.should == "defunkt"
+  end
+
+  it "should approve token input" do
+    GHI.instance_eval { instance_variable_defined?(:@token).should == false }
+    GHI.stub!(:login).and_return "defunkt"
+    GHI.should_receive(:`).with("git config --get github.token").
+      and_return "\n"
+    GHI.should_receive(:print).twice
+    token = "da39a3ee5e6b4b0d3255bfef95601890"
+    GHI.should_receive(:gets).and_return "invalid\n", "#{token}\n"
+    Net::HTTP.should_receive(:get).and_return LOGGED_OUT_YAML, LOGGED_IN_YAML
+    GHI.should_receive(:warn).once
+    # FIXME: Passes on its own...but failing for `spec spec`.
+    GHI.should_receive(:`).with("git config --global github.token #{token}").
+      and_return "\n"
+    GHI.token.should == token
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: stephencelis-ghi
 version: !ruby/object:Gem::Version 
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors: 
 - Stephen Celis
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-04-25 00:00:00 -07:00
+date: 2009-04-26 00:00:00 -07:00
 default_executable: ghi
 dependencies: []