step_by_step 0.0.1.5 → 0.0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 914546dc63e40d0896c7b86b82b42671ae777299
-  data.tar.gz: 95cf8bf3d06b7c14d629669f214a23e4fae5c76a
+  metadata.gz: 6b64d9c4cfa6b4c77891f18ea104026433d41053
+  data.tar.gz: 9f983742023547cf519014cde73a7b904598bbcd
 SHA512:
-  metadata.gz: 1d06e4a64e8249df4fa010ab93952490c8fb1aecabaa01c0d17ff1ac7cc64a3bc926a2bb18f091805f18994a7b5b6fc2927b7883acc5eb18624db7208fbd1fdb
-  data.tar.gz: 5ce8f9b3a8b4a796242ea15e6b0d8722de1c1c80a0e0250b5c7fe20468029509631cacfd89547843b7a25a4a10fa13e28f0f3f9ba61ddfc259353acbbc8887b1
+  metadata.gz: 578b543150c9db5cb5f83c7e7cf28d6c0aa7a5b19c9f87156624989058e1995a3fbbae5da8645cba37fdf1dd294b3ec44802bb8ed2c70e78ee42f553d1cd73ba
+  data.tar.gz: 755afe31c41c9d7a9fcf972d85cfa4b99847ea149701957a69bc75b450284b9081e755e4944d76595464c231acd520b83ba9d253a072860edbe61b8ddc6f5e3d

data/README.md

@@ -77,7 +77,7 @@ Now your first user can see the comments feature.
 StepByStep::Rollout.activate(:comments)
 ```
 
-Now everyone can see the comments feature. This is theoretically the same as activating a percentage with value 100 or defining a group with a block that always returns true.
+Now everyone can see the comments feature. This also includes users who are not authenticated. If you want to roll out a feature to all authenticated users, but not to the public, roll it out to a percentage of 100 instead.
 
 Activating a feature for everyone is common after you have determined that your rollout phase was successful.
 

data/lib/step_by_step/rollout.rb

@@ -1,7 +1,11 @@
 module StepByStep
   class Rollout < ActiveRecord::Base
     def match?(user)
-      user && enabled? && (match_group?(user) || match_user?(user) || match_percentage?(user))
+      public? || user && enabled? && (match_group?(user) || match_user?(user) || match_percentage?(user))
+    end
+
+    def public?
+      group == 'all'
     end
 
     # Activates a feature for everyone
@@ -64,14 +68,16 @@ module StepByStep
         # Find the group whose block should be evaluated based on its name
         g = @@groups.select { |i| i.first.to_sym == group.to_sym }
 
-        # There could theoretically be multiple groups with the same name;
-        # only take the last one
-        g = g.last
+        if g.present?
+          # There could theoretically be multiple groups with the same name;
+          # only take the last one
+          g = g.last
 
-        # g is now an array that looks like this:
-        # [:group_name, code_block]
-        # Call the code block here with the user
-        g.last.call(user)
+          # g is now an array that looks like this:
+          # [:group_name, code_block]
+          # Call the code block here with the user
+          g.last.call(user)
+        end
       end
     end
 

data/lib/step_by_step/version.rb

@@ -1,3 +1,3 @@
 module StepByStep
-  VERSION = "0.0.1.5"
+  VERSION = "0.0.1.6"
 end

data/spec/rollout_spec.rb

@@ -22,6 +22,11 @@ module StepByStep
       end
     end
 
+    it 'rolls out to the public' do
+      rollout = Rollout.activate(:feature)
+      expect(rollout.match?(user_3)).to be_truthy
+    end
+
     it 'rolls out to all' do
       rollout = Rollout.activate(:feature)
       expect(rollout.match?(user_1)).to be_truthy
@@ -40,6 +45,12 @@ module StepByStep
       expect(rollout.match?(user_2)).to be_falsey
     end
 
+    it 'rolls out to a user while group is empty string instead of `nil`' do
+      rollout = Rollout.create(user_id: user_1.id, group: '')
+      expect(rollout.match?(user_1)).to be_truthy
+      expect(rollout.match?(user_2)).to be_falsey
+    end
+
     it 'rolls out to a percentage' do
       rollout = Rollout.activate_percentage(:feature, 50)
 

data/step_by_step.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["dennis.hackethal@gmail.com"]
   spec.summary       = %q{Active Record alternative to https://github.com/FetLife/rollout.}
   spec.description   = %q{Alternative to https://github.com/FetLife/rollout, with an Active Record backend and additional helpers, partially based on Ryan Bates's custom solution in http://railscasts.com/episodes/315-rollout-and-degrade.}
-  spec.homepage      = ""
+  spec.homepage      = "https://github.com/cobalthq/step_by_step"
   spec.license       = "MIT"
 
   spec.files         = `git ls-files -z`.split("\x0")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: step_by_step
 version: !ruby/object:Gem::Version
-  version: 0.0.1.5
+  version: 0.0.1.6
 platform: ruby
 authors:
 - Dennis Charles Hackethal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-01 00:00:00.000000000 Z
+date: 2015-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -118,7 +118,7 @@ files:
 - spec/step_by_step.sqlite3
 - spec/support/schema.rb
 - step_by_step.gemspec
-homepage: ''
+homepage: https://github.com/cobalthq/step_by_step
 licenses:
 - MIT
 metadata: {}
@@ -138,7 +138,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Active Record alternative to https://github.com/FetLife/rollout.