stellar_base-rails 0.5.4 → 0.5.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 417896ba7988ec6ba5a584c65eb0868fc2f1b3a13db4dc10cd836d61b349ed85
-  data.tar.gz: 5e0821667ef3c212485ffa19d9e81f4fb3ff4cafd6f8009bbee7a0e9aa8558bb
+  metadata.gz: 1b032a3ab1820d7411b5151c7b61350fca291a36c38cf64d84fa9ce11065d2df
+  data.tar.gz: 22c699cd39b19dfb2e96e5b1ea000aa5362cc45bd8393300770a0d2a052f9b2b
 SHA512:
-  metadata.gz: b4032435b981acf1440eea54554fd22a553c4453f5d7e70fe49437437b2ded22275f1e5cc6010dca9f518c9437eefbde3d25b354fc70b19902ee1e4e8b5addc6
-  data.tar.gz: b2836acfe40a614015241f658597592aecfb466b165e6c6e07ef4567672b09241dec5c776a436c7ee3c874e6f081ad267dc400b3af6ddcd6fe9a0e2004039b18
+  metadata.gz: 7702503356c3cf28d2c03f35367d0793d13bde5cc3d45dd87b681840ce1fff444632eccb6a78497ec246b8e767d2fe5a02e900985194aff87346d300ee2fec2a
+  data.tar.gz: ad913b47be20ff81a91b577f55213444e01aa1aa4f0c29a1ee1fd9ae552ff84f85ce729882e68be4cf9ed0c83ed2af748a7eb6051c373ebcced6eec4935161ac

data/README.md

@@ -56,17 +56,17 @@ This is the same distribution account that is setup in bridge. Currently, it is
 - Value(s): Hash, follow Stellar's [documentation](https://www.stellar.org/developers/guides/concepts/stellar-toml.html) for `stellar.toml`
 - Example:
 ```
-c.stellar_toml = {
-  TRANSFER_SERVER: ...,
-  FEDERATION_SERVER: ...,
-  AUTH_SERVER: ...,
-}
+c.stellar_toml = { TRANSFER_SERVER: ... }
 ```
-- Default:
+- When adding the URL of the transfer server, make sure not to add `/` at the end as described in the Stellar documentation:
 ```
-c.stellar_toml = {
-  TRANSFER_SERVER: ...,
-}
+# Correct:
+https://example.com/stellar
+https://example.com
+
+# Bad:
+https://example.com/stellar/
+https://example.com/
 ```
 
 ## Installation

data/app/concepts/stellar_base/withdrawal_requests/contracts/create.rb

@@ -7,30 +7,32 @@ module StellarBase
         property :asset_code
         property :dest
         property :dest_extra
-        property :issuer
-        property :account_id
-        property :memo_type
-        property :memo
-        property :eta
-        property :min_amount
-        property :max_amount
-        property :fee_fixed
-        property :fee_percent
         property :fee_network
 
         validates(
-          *%i[
-            asset_type
-            asset_code
-            dest
-            issuer
-            account_id
-            fee_network
-            fee_fixed
-            fee_percent
-          ],
-          presence: true
+          :asset_type,
+          :asset_code,
+          :dest,
+          :fee_network,
+          presence: true,
         )
+        validate :check_valid_asset_code
+
+        def check_valid_asset_code
+          asset_codes = StellarBase
+            .configuration
+            .withdrawable_assets
+            &.map do |asset|
+              asset[:asset_code]
+            end
+
+          return if asset_codes.include? asset_code
+
+          errors.add(
+            :asset_code,
+            "invalid asset_code. Valid asset_codes: #{asset_codes.join(', ')}",
+          )
+        end
 
       end
     end

data/app/concepts/stellar_base/withdrawal_requests/operations/create.rb

@@ -7,44 +7,52 @@ module StellarBase
 
         step self::Policy::Pundit(WithdrawalRequestPolicy, :create?)
         step Model(WithdrawalRequest, :new)
-        step :find_withdrawal_asset_details!
-        success :set_defaults!
+        step :setup_params!
         step Contract::Build(constant: Contracts::Create)
         step Contract::Validate(key: :withdrawal_request)
-        step Contract::Persist()
+        step Contract::Persist(method: :sync)
+        step :find_withdrawal_asset_details!
+        success :set_defaults!
+        step Contract::Persist(method: :save)
 
         private
 
+        def setup_params!(options, params:, **)
+          params[:withdrawal_request].merge!({
+            asset_type: params[:withdrawal_request][:type],
+          })
+        end
+
         def find_withdrawal_asset_details!(options, params:, **)
           withdrawable_assets = StellarBase.configuration.withdrawable_assets
           details = withdrawable_assets.find do |e|
             e[:asset_code] == params[:withdrawal_request][:asset_code]
           end
 
-          return Railway.fail_fast! if details.nil?
-
-          options["withdrawal_asset_details"] = details
-          return true
+          params[:withdrawal_asset_details] = details.presence || {}
         end
 
-        def set_defaults!(options, withdrawal_asset_details:, params:, **)
+        def set_defaults!(options, params:, **)
+          withdrawal_asset_details = params[:withdrawal_asset_details]
+
           fee_network = DetermineFee.network(
             withdrawal_asset_details[:network],
             params[:withdrawal_request][:fee_network],
           )
-          params[:withdrawal_request].merge!({
-            asset_type: params[:withdrawal_request][:type],
-            issuer: withdrawal_asset_details[:issuer],
-            account_id: StellarBase.configuration.distribution_account,
-            memo_type: "text",
-            memo: GenMemo.(),
-            eta: DEFAULT_ETA,
-            min_amount: 0.0,
-            max_amount: nil,
-            fee_fixed: DetermineFee.(withdrawal_asset_details[:fee_fixed]),
-            fee_percent: DetermineFee.(withdrawal_asset_details[:fee_percent]),
-            fee_network: fee_network,
-          })
+
+          options["model"].issuer = withdrawal_asset_details[:issuer]
+          options["model"].account_id =
+            StellarBase.configuration.distribution_account
+          options["model"].memo_type = "text"
+          options["model"].memo = GenMemo.()
+          options["model"].eta = DEFAULT_ETA
+          options["model"].min_amount = 0.0
+          options["model"].max_amount = nil
+          options["model"].fee_fixed =
+            DetermineFee.(withdrawal_asset_details[:fee_fixed])
+          options["model"].fee_percent =
+            DetermineFee.(withdrawal_asset_details[:fee_percent])
+          options["model"].fee_network = fee_network
         end
 
       end

data/app/controllers/stellar_base/withdraw_controller.rb

@@ -11,7 +11,10 @@ module StellarBase
             representer = WithdrawalRequestRepresenter.new(twin)
             render json: representer
           else
-            render json: {error: op["contract.default"].errors}, status: :unprocessable_entity
+            render(
+              json: { error: op["contract.default"].errors },
+              status: :unprocessable_entity,
+            )
           end
         end
       end

data/lib/stellar_base/version.rb

@@ -1,3 +1,3 @@
 module StellarBase
-  VERSION = "0.5.4".freeze
+  VERSION = "0.5.5".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stellar_base-rails
 version: !ruby/object:Gem::Version
-  version: 0.5.4
+  version: 0.5.5
 platform: ruby
 authors:
 - Ace Subido
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-02 00:00:00.000000000 Z
+date: 2018-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: disposable
@@ -366,7 +366,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Mountable Stellar API Endpoints for Rails