stefon 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 99ed35b6e8b0b48f9ba4059038361a137926a1c3
-  data.tar.gz: 3bcab6111636a36d3fd7436cf4f777f4cfc63de7
+  metadata.gz: 8de9d96b587955909cd3f13739ae73e93c2c6a56
+  data.tar.gz: 3b1bdf0537aba3ee67e061e0379ed0d222ba0796
 SHA512:
-  metadata.gz: 40eca70e12bc892bbcee99cc785d0bb15171216902e3e5d5d62e3eb04f256a8e6eb96c628fd80a1f31dd2322f4bc4a4eb08491be834b85773b314bf05bd60cde
-  data.tar.gz: 43a61da24cd1a4c433eadf84d4a1e4d17fee58527b7a888e6d5cd735fa962164c01c31eea3e443c750f2b02eabda70b75e6edc1b8689f8ed3f1c62dac1affb28
+  metadata.gz: 1db71348b554b5038ac9243dd84b53d43780b55eae48899f1d6e3456aa38dab2004af2679ae90fdfe5c7d3934d97ccd0907321069e259b78719744674add8396
+  data.tar.gz: 1485ecd44bf051997b0107b297e5e5e3f4190791f98a39837e4489bbfc6484bbb975b4584eb1a97ecfc725ee0acf9f3be52edb56acd4a0ed6e4e2e63be4292ec

data/README.md

@@ -1,6 +1,6 @@
 # Stefon
 
-Get tips on who to ask for a code review.
+Get tips on who to ask for a code review, runs on Ruby 1.9.2 and above.
 
 A name inspired by the SNL character Bill Hader played:
 ![stefon on wikipedia](http://upload.wikimedia.org/wikipedia/en/c/c1/Stefon%2C_SNL_Character.jpg)
@@ -52,7 +52,6 @@ which is identical to `stefon -f`, to see something like:
 
 
 ## Todos / Comming improvements
-* use rugged instead of grit for ruby 2 support
 * use Github API to get a list of contributors for a project (and filter suggestions)
 * loading user preferences (list of users to exclude) - maybe with dotfiles instead of yml files
 * handle errors from surveryors

data/lib/stefon/cli.rb

@@ -28,12 +28,12 @@ module Stefon
           where [options] are:
         EOS
         opt :limit,
-            'Limit the number of people that stephon suggests ' +
+            'Limit the number of people that stephon suggests '\
               'sending a code review to',
             default: 4,
             short: '-l'
         opt :full_report,
-            'Boolean for whether or not to include ' +
+            'Boolean for whether or not to include '\
               "information about how you affected someone's code",
             default: false,
             short: '-f'

data/lib/stefon/surveyor/grit_util.rb

@@ -27,7 +27,7 @@ module Stefon
       # recent commit, since in this case, stefon would always recommend
       # the current user anyway. In the future, an error may be raised here
       def initialize
-        @repo = Grit::Repo.new('.')
+        @repo = Grit::Repo.new find_git_repo
         commits = @repo.commits(GitUtil::CURRENT_BRANCH)
         @num_sui_commits = commits.find_index do |commit|
           commit.author.name != @repo.config['user.name']
@@ -36,6 +36,14 @@ module Stefon
         @last_xeno_commit = commits[@num_sui_commits]
       end
 
+      def find_git_repo
+        until File.exist?('.git')
+          fail 'Could not find a git repository!' if Dir.pwd == '/'
+          Dir.chdir '..'
+        end
+        Dir.pwd
+      end
+
       def blame_for(filename)
         @repo.blame(filename, @last_xeno_commit)
       end

data/lib/stefon/version.rb

@@ -2,5 +2,5 @@
 
 # The outermost container for the gem, here with the version info
 module Stefon
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/spec/surveyor/grit_util_spec.rb

@@ -0,0 +1,33 @@
+# encoding: utf-8
+
+require 'spec_helper'
+require 'fakefs/safe'
+
+describe Stefon::Surveyor::GritUtil do
+  context 'when there is no git repo in the current directory' do
+    before :each do
+      Grit::Repo.any_instance.stub(:commits).and_return([])
+    end
+    around :each do |example|
+      @randomizer = (1..99_999).to_a.sample # FakeFS doesn't reset btw tests!
+      FakeFS do
+        Dir.mkdir "/repo_root_#{@randomizer}"
+        Dir.mkdir "/repo_root_#{@randomizer}/1_dir_too_deep"
+        Dir.mkdir "/repo_root_#{@randomizer}/1_dir_too_deep/2_dirs_too_deep"
+        Dir.chdir "/repo_root_#{@randomizer}/1_dir_too_deep/2_dirs_too_deep"
+        example.run
+      end
+    end
+    it 'can still initialize if there is a git repo in a parent directory' do
+      Dir.mkdir "/repo_root_#{@randomizer}/.git/"
+      grit = Stefon::Surveyor::GritUtil.new
+      grit.repo.should_not be_nil
+    end
+
+    it 'raises an error if there is no git repo in parent directories' do
+      expect do
+        Stefon::Surveyor::GritUtil.new
+      end.to raise_error 'Could not find a git repository!'
+    end
+  end
+end

data/stefon.gemspec

@@ -25,6 +25,7 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency 'gitlab-grit', '1.0.0'
   spec.add_runtime_dependency 'trollop', '~> 2.0'
+  spec.add_development_dependency 'fakefs', '~> 0.5'
   spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency('rake', '~> 10.1')
+  spec.add_development_dependency 'rake', '~> 10.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stefon
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Ilya Kavalerov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-02 00:00:00.000000000 Z
+date: 2014-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gitlab-grit
@@ -28,42 +28,56 @@ dependencies:
   name: trollop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: fakefs
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.1'
 description: |2
@@ -76,7 +90,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -100,6 +114,7 @@ files:
 - spec/spec_helper.rb
 - spec/surveyor/editor_spec.rb
 - spec/surveyor/git_util_spec.rb
+- spec/surveyor/grit_util_spec.rb
 - spec/surveyor/surveyor_spec.rb
 - stefon.gemspec
 homepage: https://github.com/ilyakava/stefon
@@ -112,12 +127,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -132,4 +147,5 @@ test_files:
 - spec/spec_helper.rb
 - spec/surveyor/editor_spec.rb
 - spec/surveyor/git_util_spec.rb
+- spec/surveyor/grit_util_spec.rb
 - spec/surveyor/surveyor_spec.rb