steep 1.8.0 → 1.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 298dd973658fa586efbf59424298b54eb540a3e8f5b5c423f10ede9ae83d0d65
-  data.tar.gz: f9a21241e44c10744d3305111b9afe499855931acda999b8671a2276ade4b2d9
+  metadata.gz: 6f40f4acb0e71a6cfd2b751297f2fc1a9cd18a87545d24cec51c0da5f1e9792e
+  data.tar.gz: 947ea73b078a7c1b9dc37e2855a6e483d1bbc919414b97226a3393bf92cb6bf8
 SHA512:
-  metadata.gz: e110b36e04ba367ba26ce2f2a74b7aa6be20bb25df742af696803be795f7b372a92948f923c4b30548ad4c78657b0dcb19702a602721ef80136eb4f9d4e9daa1
-  data.tar.gz: 2a4e44c76e29539b8692e31aa5cdd3f438715b978ef5d4e264d26191f634ff3c0ff58488d0334816ca8e6e6b1ff0ce3d0a35140c51e1dea78d7e3b56a31a3fdd
+  metadata.gz: b146bd6a93a59b5ec7a3029b061fc352c1e93c9bd87cfac89783b9a54175f076bc208a6f94adc32fa2a1802fdc94a422f1c64fbca555eb5ad93481ce7ff88b5d
+  data.tar.gz: d746bee9df6ab60f43811ec81a415348927bde046cba2cf7b2dd5e4204438e9dc317456ed9d61358fbbfe22125c569451687b9d528b17d1792e470e29dac43c1

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # CHANGELOG
 
+## 1.8.2 (2024-10-24)
+
+### Language server
+
+* Ignore `didChangeWatchedFiles notification` for open files ([#1290](https://github.com/soutaro/steep/pull/1290))
+
+## 1.8.1 (2024-10-08)
+
+### Language server
+
+* Skip sending response to `$/steep/typecheck` request from `steep langserver` ([#1268](https://github.com/soutaro/steep/pull/1268), backport [#1267](https://github.com/soutaro/steep/pull/1267))
+
 ## 1.8.0 (2024-09-30)
 
 ### Type checker core

data/lib/steep/drivers/checkfile.rb

@@ -165,6 +165,7 @@ module Steep
           request.signature_paths << project.absolute_path(path)
         end
 
+        request.needs_response = true
         master.start_type_check(request: request, last_request: nil, report_progress_threshold: 0)
 
         Steep.logger.info { "Starting type checking: #{request_guid}" }

data/lib/steep/drivers/stats.rb

@@ -162,7 +162,7 @@ module Steep
         master.job_queue << -> do
           Steep.logger.info { "Type checking for stats..." }
           progress = master.work_done_progress(typecheck_guid)
-          master.start_type_check(last_request: nil, progress: progress, include_unchanged: true, report_progress_threshold: 0)
+          master.start_type_check(last_request: nil, progress: progress, include_unchanged: true, report_progress_threshold: 0, needs_response: true)
         end
         wait_for_message(reader: client_reader) do |message|
           message[:id] == typecheck_guid

data/lib/steep/server/master.rb

@@ -12,6 +12,7 @@ module Steep
         attr_reader :checked_paths
         attr_reader :work_done_progress
         attr_reader :started_at
+        attr_accessor :needs_response
 
         def initialize(guid:, progress:)
           @guid = guid
@@ -22,6 +23,7 @@ module Steep
           @checked_paths = Set[]
           @work_done_progress = progress
           @started_at = Time.now
+          @needs_response = false
         end
 
         def uri(path)
@@ -700,13 +702,17 @@ module Steep
           end
 
         when "workspace/didChangeWatchedFiles"
+          updated_watched_files = [] #: Array[Pathname]
+
           message[:params][:changes].each do |change|
             uri = change[:uri]
             type = change[:type]
 
-            path = PathHelper.to_pathname(uri) or next
+            path = PathHelper.to_pathname!(uri)
 
             unless controller.priority_paths.include?(path)
+              updated_watched_files << path
+
               controller.push_changes(path)
 
               case type
@@ -718,10 +724,16 @@ module Steep
               end
 
               content or raise
+
               broadcast_notification(CustomMethods::FileReset.notification({ uri: uri, content: content }))
             end
           end
 
+          if updated_watched_files.empty?
+            Steep.logger.info { "Exit from workspace/didChangeWatchedFiles notification because all of the changed files are already open" }
+            return
+          end
+
           if typecheck_automatically
             start_type_checking_queue.execute do
               job_queue.push(
@@ -732,7 +744,8 @@ module Steep
                   start_type_check(
                     last_request: last_request,
                     include_unchanged: true,
-                    progress: work_done_progress(guid)
+                    progress: work_done_progress(guid),
+                    needs_response: false
                   )
                 end
               )
@@ -755,7 +768,8 @@ module Steep
 
                     start_type_check(
                       last_request: last_request,
-                      progress: work_done_progress(guid)
+                      progress: work_done_progress(guid),
+                      needs_response: false
                     )
                   end
                 )
@@ -859,7 +873,8 @@ module Steep
           start_type_check(
             last_request: current_type_check_request,
             include_unchanged: true,
-            progress: work_done_progress(guid || SecureRandom.uuid)
+            progress: work_done_progress(guid || SecureRandom.uuid),
+            needs_response: true
           )
 
         when "$/ping"
@@ -920,25 +935,27 @@ module Steep
         finished_at = Time.now
         duration = finished_at - request.started_at
 
-        enqueue_write_job(
-          SendMessageJob.to_client(
-            message: CustomMethods::TypeCheck.response(
-              request.guid,
-              {
-                guid: request.guid,
-                completed: request.finished?,
-                started_at: request.started_at.iso8601,
-                finished_at: finished_at.iso8601,
-                duration: duration.to_i
-              }
+        if request.needs_response
+          enqueue_write_job(
+            SendMessageJob.to_client(
+              message: CustomMethods::TypeCheck.response(
+                request.guid,
+                {
+                  guid: request.guid,
+                  completed: request.finished?,
+                  started_at: request.started_at.iso8601,
+                  finished_at: finished_at.iso8601,
+                  duration: duration.to_i
+                }
+              )
             )
           )
-        )
-
-        nil
+        else
+          Steep.logger.debug { "Skip sending response to #{CustomMethods::TypeCheck::METHOD} request" }
+        end
       end
 
-      def start_type_check(request: nil, last_request:, progress: nil, include_unchanged: false, report_progress_threshold: 10)
+      def start_type_check(request: nil, last_request:, progress: nil, include_unchanged: false, report_progress_threshold: 10, needs_response: nil)
         Steep.logger.tagged "#start_type_check(#{progress&.guid || request&.guid}, #{last_request&.guid}" do
           if last_request
             finish_type_check(last_request)
@@ -947,6 +964,7 @@ module Steep
           unless request
             progress or raise
             request = controller.make_request(guid: progress.guid, include_unchanged: include_unchanged, progress: progress) or return
+            request.needs_response = needs_response ? true : false
           end
 
           if request.total > report_progress_threshold
@@ -960,7 +978,8 @@ module Steep
             end
 
             if request.finished?
-              @current_type_check_request = finish_type_check(request)
+              finish_type_check(request)
+              @current_type_check_request = nil
               return
             end
           else
@@ -992,7 +1011,8 @@ module Steep
             current.work_done_progress.report(percentage, "#{percentage}%")
 
             if current.finished?
-              @current_type_check_request = finish_type_check(current)
+              finish_type_check(current)
+              @current_type_check_request = nil
             end
           end
         end

data/lib/steep/version.rb

@@ -1,3 +1,3 @@
 module Steep
-  VERSION = "1.8.0"
+  VERSION = "1.8.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: steep
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.8.2
 platform: ruby
 authors:
 - Soutaro Matsumoto
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-09-30 00:00:00.000000000 Z
+date: 2024-10-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser