steep 1.6.0.pre.1 → 1.6.0.pre.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d8a5efa97a65add83ffc658ddfbdf9a436accc8dd4472969610b2224140543ea
-  data.tar.gz: 537d28e28ae6b3bc47392170948db46d3d7fa50d61f6f274182b922a253394ea
+  metadata.gz: 89c50cdd644b4f90f2b7f5a18c262c181088eda18b116b7604f8ca4b4d17363c
+  data.tar.gz: 6191d664a4a348dfdc43559c40a75ded920b83a2b245d28d10f84c3c72f7d324
 SHA512:
-  metadata.gz: 386ddbecc785a37748b8a6d9dcf514af55cec3bcafca945e363d5e76e56fd266cd91238183b3c99635595168b0049e93b065f3154569d10909c2ecd6ccdd9519
-  data.tar.gz: 15a3baf8009e78767015a4529f71b20300edc221aaf0b218efdee5a894f73d619d2c3078c68f4e3511bec4dbb67aece479e9a95c6b1ae1fb9066da86094fc810
+  metadata.gz: 833394273e491c154a8fd6ca60c693f1fd28f51d4dcb2f864c4d60abe4645e7dceb4d9914261d8237fb339e0c7f27a7625baedea3cd9ac1680d0d32a98b2867c
+  data.tar.gz: 827261fdcffe5a0d3b32ee5771bbc6577a7a9b71a0aa2f25f3cff5eb1c6a2817e592a56f6c7189d8a028a686b7a1d8e24b313e919427c253f372de3316ed6353

data/CHANGELOG.md

@@ -2,6 +2,24 @@
 
 ## master
 
+## 1.6.0.pre.3 (2023-11-01)
+
+### Type checker core
+
+* Object methods are moved to Kernel ([#952](https://github.com/soutaro/steep/pull/952))
+* Check if `rescue` body has `bot` type ([#953](https://github.com/soutaro/steep/pull/953))
+
+## 1.6.0.pre.2 (2023-10-31)
+
+### Type checker core
+
+* Assign types on method calls in mlhs node ([#951](https://github.com/soutaro/steep/pull/951))
+* Change severity of block diagnostics ([#950](https://github.com/soutaro/steep/pull/950))
+
+### Commandline tool
+
+* Match with `**` in pattern ([#949](https://github.com/soutaro/steep/pull/949))
+
 ## 1.6.0.pre.1 (2023-10-27)
 
 ### Type checker core

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    steep (1.6.0.pre.1)
+    steep (1.6.0.pre.3)
       activesupport (>= 5.1)
       concurrent-ruby (>= 1.1.10)
       csv (>= 3.0.9)
@@ -68,7 +68,7 @@ GEM
       stringio
     racc (1.7.1)
     rainbow (3.1.1)
-    rake (13.0.6)
+    rake (13.1.0)
     rb-fsevent (0.11.2)
     rb-inotify (0.10.1)
       ffi (~> 1.0)

data/lib/steep/diagnostic/ruby.rb

@@ -1013,8 +1013,8 @@ module Steep
         @default ||= _ = all_error.merge(
           {
             ArgumentTypeMismatch => :error,
-            BlockBodyTypeMismatch => :hint,
-            BlockTypeMismatch => :hint,
+            BlockBodyTypeMismatch => :warning,
+            BlockTypeMismatch => :warning,
             BreakTypeMismatch => :hint,
             DifferentMethodParameterKind => :hint,
             FallbackAny => :hint,
@@ -1129,8 +1129,8 @@ module Steep
         @lenient ||= _ = all_error.merge(
           {
             ArgumentTypeMismatch => :information,
-            BlockBodyTypeMismatch => :hint,
-            BlockTypeMismatch => :hint,
+            BlockBodyTypeMismatch => :information,
+            BlockTypeMismatch => :information,
             BreakTypeMismatch => :hint,
             DifferentMethodParameterKind => nil,
             FallbackAny => nil,

data/lib/steep/interface/builder.rb

@@ -1,4 +1,3 @@
-
 module Steep
   module Interface
     class Builder
@@ -718,22 +717,30 @@ module Steep
         if member.is_a?(RBS::AST::Members::MethodDefinition)
           case method_name.method_name
           when :is_a?, :kind_of?, :instance_of?
-            if defined_in == RBS::BuiltinNames::Object.name && member.instance?
-              return method_type.with(
-                type: method_type.type.with(
-                  return_type: AST::Types::Logic::ReceiverIsArg.new(location: method_type.type.return_type.location)
+            case
+            when RBS::BuiltinNames::Object.name,
+              RBS::BuiltinNames::Kernel.name
+              if member.instance?
+                return method_type.with(
+                  type: method_type.type.with(
+                    return_type: AST::Types::Logic::ReceiverIsArg.new(location: method_type.type.return_type.location)
+                  )
                 )
-              )
+              end
             end
 
           when :nil?
             case defined_in
-            when RBS::BuiltinNames::Object.name, AST::Builtin::NilClass.module_name
-              return method_type.with(
-                type: method_type.type.with(
-                  return_type: AST::Types::Logic::ReceiverIsNil.new(location: method_type.type.return_type.location)
+            when RBS::BuiltinNames::Object.name,
+              AST::Builtin::NilClass.module_name,
+              RBS::BuiltinNames::Kernel.name
+              if member.instance?
+                return method_type.with(
+                  type: method_type.type.with(
+                    return_type: AST::Types::Logic::ReceiverIsNil.new(location: method_type.type.return_type.location)
+                  )
                 )
-              )
+            end
             end
 
           when :!
@@ -757,8 +764,14 @@ module Steep
                   return_type: AST::Types::Logic::ArgIsReceiver.new(location: method_type.type.return_type.location)
                 )
               )
-            when RBS::BuiltinNames::Object.name, RBS::BuiltinNames::String.name, RBS::BuiltinNames::Integer.name, RBS::BuiltinNames::Symbol.name,
-              RBS::BuiltinNames::TrueClass.name, RBS::BuiltinNames::FalseClass.name, TypeName("::NilClass")
+            when RBS::BuiltinNames::Object.name,
+              RBS::BuiltinNames::Kernel.name,
+              RBS::BuiltinNames::String.name,
+              RBS::BuiltinNames::Integer.name,
+              RBS::BuiltinNames::Symbol.name,
+              RBS::BuiltinNames::TrueClass.name,
+              RBS::BuiltinNames::FalseClass.name,
+              TypeName("::NilClass")
               # Value based type-case works on literal types which is available for String, Integer, Symbol, TrueClass, FalseClass, and NilClass
               return method_type.with(
                 type: method_type.type.with(
@@ -783,3 +796,4 @@ module Steep
     end
   end
 end
+

data/lib/steep/project/pattern.rb

@@ -48,7 +48,7 @@ module Steep
         string = path.to_s
         extension = path.extname
 
-        patterns.any? {|pat| File.fnmatch(pat, string) } ||
+        patterns.any? {|pat| File.fnmatch(pat, string, File::FNM_PATHNAME) } ||
           prefixes.any? {|prefix| string.start_with?(prefix) && extension == ext }
       end
     end

data/lib/steep/services/completion_provider.rb

@@ -663,7 +663,7 @@ module Steep
         if parent
           case parent.type
           when :const
-            const_name = typing.source_index.reference(constant_node: parent)
+            const_name = typing.source_index.reference(constant_node: parent) or raise "Unknown node in source_index: #{parent}"
             consts = context.type_env.constant_env.children(const_name)
           end
         else

data/lib/steep/type_construction.rb

@@ -2214,6 +2214,10 @@ module Steep
               end
             end
 
+            resbody_pairs.select! do |pair|
+              no_subtyping?(sub_type: pair.type, super_type: AST::Types::Bot.new)
+            end
+
             resbody_types = resbody_pairs.map(&:type)
             resbody_envs = resbody_pairs.map {|pair| pair.context.type_env }
 
@@ -2225,8 +2229,13 @@ module Steep
                 .update_type_env {|env| env.join(*resbody_envs, env) }
                 .add_typing(node, type: union_type(else_type, *resbody_types))
             else
-              update_type_env {|env| env.join(*resbody_envs, else_constr.context.type_env) }
-                .add_typing(node, type: union_type(*[body_pair&.type, *resbody_types].compact))
+              if resbody_types.empty?
+                constr = body_pair ? body_pair.constr : self
+                constr.add_typing(node, type: body_pair&.type || AST::Builtin.nil_type)
+              else
+                update_type_env {|env| env.join(*resbody_envs, else_constr.context.type_env) }
+                  .add_typing(node, type: union_type(*[body_pair&.type, *resbody_types].compact))
+              end
             end
           end
 
@@ -2908,6 +2917,8 @@ module Steep
             _, constr = constr.gvasgn(asgn_node, type)
           when :mlhs
             constr = (constr.type_masgn_type(asgn_node, type, masgn: masgn, optional: optional) or return)
+          else
+            _, constr = constr.synthesize_children(asgn_node).add_typing(asgn_node, type: AST::Builtin.any_type)
           end
 
           if node.type == :splat

data/lib/steep/version.rb

@@ -1,3 +1,3 @@
 module Steep
-  VERSION = "1.6.0.pre.1"
+  VERSION = "1.6.0.pre.3"
 end

data/sig/steep/project/pattern.rbs

@@ -1,22 +1,44 @@
 module Steep
   class Project
+    # `Pattern` class represents a pair of *positive* and *negative* patterns that may match with a pathname
+    #
+    # ```rb
+    # pat = Pattern.new(patterns: ["app/models"], ignores: ["app/models/account.rb"], ext: ".rbs")
+    #
+    # pat =~ "app/models/group.rb"    # => true
+    # pat =~ "app/models/account.rb"  # => false
+    # ```
+    #
+    # The pattern may be:
+    #
+    # 1. Directory name pattern -- `lib`, or
+    # 2. *Glob* pattern -- `foo/**/bar.rb`
+    #
     class Pattern
+      # Positive patterns, which is tested with `fnmatch`
       attr_reader patterns: Array[String]
 
+      # Negative patterns, which is tested with `fnmatch`
       attr_reader ignores: Array[String]
 
+      # Positive *dir name* pattern constructed from `#patterns`, which is tested with `start_with?`
       attr_reader prefixes: Array[String]
 
+      # Negative *dir name* pattern constructed from `#ignores`, which is tested with `start_with?`
       attr_reader ignore_prefixes: Array[String]
 
       attr_reader ext: String
 
       def initialize: (patterns: Array[String], ext: String, ?ignores: Array[String]) -> void
 
+      # Returns `true` if given path matches to *positive* pattern, but doesn't match to *negative* pattern
+      #
       def =~: (Pathname | String path) -> bool
 
+      # Returns true if given `Pathname` matches to *positive* pattern
       def match?: (Pathname path) -> bool
 
+      # Returns true if given `Pathname` matches to *negative* pattern
       def ignore?: (Pathname path) -> bool
 
       def test_string: (Pathname path, Array[String] patterns, Array[String] prefixes) -> bool

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: steep
 version: !ruby/object:Gem::Version
-  version: 1.6.0.pre.1
+  version: 1.6.0.pre.3
 platform: ruby
 authors:
 - Soutaro Matsumoto
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-10-27 00:00:00.000000000 Z
+date: 2023-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser