steep 1.4.0.dev.3 → 1.4.0.dev.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ef7faa0702c27679ca29580b02273241fcfac188f2462f79a95ea26e633a231d
-  data.tar.gz: b9a7add36c30c5fcb76b89bb5a994fcea4e8749ddb06b9b43d5ebcada4fa51f6
+  metadata.gz: 0c5431b7816a655799dcfc5ab49aff4d630062176b52b14f377b4d6ca754674f
+  data.tar.gz: ea016b12eac32d93fffcbb315009aeb143626fd831669b36ade6c7d01b55a475
 SHA512:
-  metadata.gz: f5b67c4723ec0aec87a215eb874f73ebc62de658b50cc4118399691f9451d0d540ea4640623d94771430839a40399097da2310c98f40e6c50669ceba8d1de026
-  data.tar.gz: d6da7929577c2071c43b6c13ca28b2b0017626ffb760618b2a5551d1824c1c0ba3cbad6c915c522ea1d784caa4bd13ac5364e052972a4573a717c72fd029528d
+  metadata.gz: a6e97f6c64d6e5dfc86a0d28e6129b1fe66aa75e1b28290092c47b12dda165fc9ce87187f8f27358cef169d2a3a2b3eb4eae42aa4702dd11d9586aad8d7733e2
+  data.tar.gz: 94f611f5db76c09c853af7f5a333d43a0650e21fadde356990acb447231a86eb18bc3b63aa1ed1ead1c6d39066427eedf14f7379932dc077a1b4f9446184e749

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    steep (1.4.0.dev.3)
+    steep (1.4.0.dev.4)
       activesupport (>= 5.1)
       csv (>= 3.0.9)
       fileutils (>= 1.1.0)
@@ -46,7 +46,7 @@ GEM
       minitest (> 5.3)
     minitest-slow_test (0.2.0)
       minitest (>= 5.0)
-    parallel (1.22.1)
+    parallel (1.23.0)
     parser (3.2.2.0)
       ast (~> 2.4.1)
     rainbow (3.1.1)
@@ -58,7 +58,7 @@ GEM
     ruby-debug-ide (0.7.3)
       rake (>= 0.8.1)
     securerandom (0.2.2)
-    stackprof (0.2.23)
+    stackprof (0.2.25)
     strscan (3.0.6)
     terminal-table (3.0.2)
       unicode-display_width (>= 1.1.1, < 3)

data/Gemfile.steep.lock

@@ -1,7 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.4.2)
+    activesupport (7.0.4.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
@@ -10,7 +10,7 @@ GEM
     concurrent-ruby (1.2.2)
     csv (3.2.6)
     ffi (1.15.5)
-    fileutils (1.7.0)
+    fileutils (1.7.1)
     i18n (1.12.0)
       concurrent-ruby (~> 1.0)
     json (2.6.3)
@@ -19,18 +19,17 @@ GEM
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
     logger (1.5.3)
-    minitest (5.17.0)
+    minitest (5.18.0)
     parallel (1.22.1)
-    parser (3.2.1.0)
+    parser (3.2.2.0)
       ast (~> 2.4.1)
-    pathname (0.2.1)
     rainbow (3.1.1)
     rb-fsevent (0.11.2)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
     rbs (3.0.4)
     securerandom (0.2.2)
-    steep (1.4.0.dev.2)
+    steep (1.4.0.dev.3)
       activesupport (>= 5.1)
       csv (>= 3.0.9)
       fileutils (>= 1.1.0)
@@ -40,7 +39,6 @@ GEM
       logger (>= 1.3.0)
       parallel (>= 1.0.0)
       parser (>= 3.1)
-      pathname (>= 0.2.1)
       rainbow (>= 2.2.2, < 4.0)
       rbs (>= 2.8.0)
       securerandom (>= 0.1)

data/lib/steep/diagnostic/ruby.rb

@@ -914,8 +914,7 @@ module Steep
       end
 
       def self.all_error
-        @all_error ||= ALL.each.with_object({}) do |klass, hash|
-          # @type var hash: Hash[singleton(Base), LSPFormatter::severity]
+        @all_error ||= ALL.each.with_object({}) do |klass, hash| #$ Hash[singleton(Base), LSPFormatter::severity]
           hash[klass] = LSPFormatter::ERROR
         end.freeze
       end

data/lib/steep/interface/builder.rb

@@ -373,15 +373,15 @@ module Steep
                 types1 = shape1.methods[name]&.method_types or raise
                 types2 = shape2.methods[name]&.method_types or raise
 
-                if types1 == types2
+                if types1 == types2 && types1.map {|type| type.method_decls.to_a }.to_set == types2.map {|type| type.method_decls.to_a }.to_set
                   shape.methods[name] = (shape1.methods[name] or raise)
                 else
-                  method_types = {}
+                  method_types = {} #: Hash[MethodType, true]
 
                   types1.each do |type1|
                     types2.each do |type2|
                       if type1 == type2
-                        method_types[type1] = true
+                        method_types[type1.with(method_decls: type1.method_decls + type2.method_decls)] = true
                       else
                         if type = MethodType.union(type1, type2, subtyping)
                           method_types[type] = true

data/lib/steep/method_name.rb

@@ -4,6 +4,10 @@ module Steep
     def to_s
       "#{type_name}##{method_name}"
     end
+
+    def relative
+      InstanceMethodName.new(type_name: type_name.relative!, method_name: method_name)
+    end
   end
 
   SingletonMethodName = _ = Struct.new(:type_name, :method_name, keyword_init: true) do
@@ -11,6 +15,10 @@ module Steep
     def to_s
       "#{type_name}.#{method_name}"
     end
+
+    def relative
+      SingletonMethodName.new(type_name: type_name.relative!, method_name: method_name)
+    end
   end
 
   class ::Object

data/lib/steep/server/interaction_worker.rb

@@ -6,6 +6,7 @@ module Steep
       ApplyChangeJob = _ = Class.new()
       HoverJob = _ = Struct.new(:id, :path, :line, :column, keyword_init: true)
       CompletionJob = _ = Struct.new(:id, :path, :line, :column, :trigger, keyword_init: true)
+      SignatureHelpJob = _ = Struct.new(:id, :path, :line, :column, keyword_init: true)
 
       LSP = LanguageServer::Protocol
 
@@ -35,6 +36,8 @@ module Steep
             writer.write({ id: job.id, result: process_hover(job) })
           when CompletionJob
             writer.write({ id: job.id, result: process_completion(job) })
+          when SignatureHelpJob
+            writer.write({ id: job.id, result: process_signature_help(job) })
           end
         end
       end
@@ -53,7 +56,7 @@ module Steep
         when "textDocument/hover"
           id = request[:id]
 
-          path = project.relative_path(Steep::PathHelper.to_pathname!(request[:params][:textDocument][:uri]))
+          path = project.relative_path(PathHelper.to_pathname!(request[:params][:textDocument][:uri]))
           line = request[:params][:position][:line]+1
           column = request[:params][:position][:character]
 
@@ -64,11 +67,18 @@ module Steep
 
           params = request[:params]
 
-          path = project.relative_path(Steep::PathHelper.to_pathname!(params[:textDocument][:uri]))
+          path = project.relative_path(PathHelper.to_pathname!(params[:textDocument][:uri]))
           line, column = params[:position].yield_self {|hash| [hash[:line]+1, hash[:character]] }
           trigger = params.dig(:context, :triggerCharacter)
 
           queue << CompletionJob.new(id: id, path: path, line: line, column: column, trigger: trigger)
+        when "textDocument/signatureHelp"
+          id = request[:id]
+          params = request[:params]
+          path = project.relative_path(PathHelper.to_pathname!(params[:textDocument][:uri]))
+          line, column = params[:position].yield_self {|hash| [hash[:line]+1, hash[:character]] }
+
+          queue << SignatureHelpJob.new(id: id, path: path, line: line, column: column)
         end
       end
 
@@ -81,16 +91,13 @@ module Steep
             if content
               range = content.location.yield_self do |location|
                 lsp_range = location.as_lsp_range
-                start_position = { line: lsp_range[:start][:line], character: lsp_range[:start][:character] }
-                end_position = { line: lsp_range[:end][:line], character: lsp_range[:end][:character] }
-                { start: start_position, end: end_position }
+                start_position = LSP::Interface::Position.new(line: lsp_range[:start][:line], character: lsp_range[:start][:character])
+                end_position = LSP::Interface::Position.new(line: lsp_range[:end][:line], character: lsp_range[:end][:character])
+                LSP::Interface::Range.new(start: start_position, end: end_position)
               end
 
               LSP::Interface::Hover.new(
-                contents: {
-                  kind: "markdown",
-                  value: LSPFormatter.format_hover_content(content).to_s
-                },
+                contents:  LSP::Interface::MarkupContent.new(kind: "markdown", value: LSPFormatter.format_hover_content(content).to_s),
                 range: range
               )
             end
@@ -136,7 +143,7 @@ module Steep
               context = nil #: RBS::Resolver::context
 
               case sig_service.status
-              when Steep::Services::SignatureService::SyntaxErrorStatus, Steep::Services::SignatureService::AncestorErrorStatus
+              when Services::SignatureService::SyntaxErrorStatus, Services::SignatureService::AncestorErrorStatus
 
                 if buffer = sig_service.latest_env.buffers.find {|buf| Pathname(buf.name) == Pathname(relative_path) }
                   dirs = sig_service.latest_env.signatures[buffer][0]
@@ -172,23 +179,22 @@ module Steep
               type_names = completion.find_type_names(prefix)
               prefix_size = prefix ? prefix.size : 0
 
-              completion_items = type_names.map {|type_name|
+              completion_items = type_names.map do |type_name|
                 absolute_name, relative_name = completion.resolve_name_in_context(type_name)
-
                 format_completion_item_for_rbs(sig_service, absolute_name, job, relative_name.to_s, prefix_size)
-              }
+              end
 
               ["untyped", "void", "bool", "class", "module", "instance", "nil"].each do |name|
-                completion_items << LanguageServer::Protocol::Interface::CompletionItem.new(
+                completion_items << LSP::Interface::CompletionItem.new(
                   label: name,
                   detail: "(builtin type)",
-                  text_edit: LanguageServer::Protocol::Interface::TextEdit.new(
-                    range: LanguageServer::Protocol::Interface::Range.new(
-                      start: LanguageServer::Protocol::Interface::Position.new(
+                  text_edit: LSP::Interface::TextEdit.new(
+                    range: LSP::Interface::Range.new(
+                      start: LSP::Interface::Position.new(
                         line: job.line - 1,
                         character: job.column - prefix_size
                       ),
-                      end: LanguageServer::Protocol::Interface::Position.new(
+                      end: LSP::Interface::Position.new(
                         line: job.line - 1,
                         character: job.column
                       )
@@ -211,12 +217,12 @@ module Steep
       end
 
       def format_completion_item_for_rbs(sig_service, type_name, job, complete_text, prefix_size)
-        range = LanguageServer::Protocol::Interface::Range.new(
-          start: LanguageServer::Protocol::Interface::Position.new(
+        range = LSP::Interface::Range.new(
+          start: LSP::Interface::Position.new(
             line: job.line - 1,
             character: job.column - prefix_size
           ),
-          end: LanguageServer::Protocol::Interface::Position.new(
+          end: LSP::Interface::Position.new(
             line: job.line - 1,
             character: job.column
           )
@@ -227,88 +233,63 @@ module Steep
           env = sig_service.latest_env #: RBS::Environment
           class_entry = env.module_class_entry(type_name) or raise
 
-          comment =
-            case class_entry
-            when RBS::Environment::ClassEntry, RBS::Environment::ModuleEntry
-              class_entry.decls.flat_map {|decl| [decl.decl.comment] }.first
-            when RBS::Environment::ClassAliasEntry, RBS::Environment::ModuleAliasEntry
-              class_entry.decl.comment
-            end
+          case class_entry
+          when RBS::Environment::ClassEntry, RBS::Environment::ModuleEntry
+            comments = class_entry.decls.map {|decl| decl.decl.comment }.compact
+            decl = class_entry.primary.decl
+          when RBS::Environment::ClassAliasEntry, RBS::Environment::ModuleAliasEntry
+            comments = [class_entry.decl.comment].compact
+            decl = class_entry.decl
+          end
 
-          LanguageServer::Protocol::Interface::CompletionItem.new(
+          LSP::Interface::CompletionItem.new(
             label: complete_text,
-            detail: type_name.to_s,
-            documentation:  format_comment(comment),
-            text_edit: LanguageServer::Protocol::Interface::TextEdit.new(
+            label_details: LSP::Interface::CompletionItemLabelDetails.new(description: LSPFormatter.declaration_summary(decl)),
+            documentation: LSPFormatter.markup_content { LSPFormatter.format_rbs_completion_docs(type_name, decl, comments) },
+            text_edit: LSP::Interface::TextEdit.new(
               range: range,
               new_text: complete_text
             ),
-            kind: LSP::Constant::CompletionItemKind::CLASS,
-            insert_text_format: LSP::Constant::InsertTextFormat::SNIPPET,
-            sort_text: complete_text,
-            filter_text: complete_text
+            kind: LSP::Constant::CompletionItemKind::CLASS
           )
         when :alias
           alias_decl = sig_service.latest_env.type_alias_decls[type_name]&.decl or raise
 
-          LanguageServer::Protocol::Interface::CompletionItem.new(
+          LSP::Interface::CompletionItem.new(
             label: complete_text,
-            detail: type_name.to_s,
-            text_edit: LanguageServer::Protocol::Interface::TextEdit.new(
+            label_details: LSP::Interface::CompletionItemLabelDetails.new(description: LSPFormatter.declaration_summary(alias_decl)),
+            text_edit: LSP::Interface::TextEdit.new(
               range: range,
               new_text: complete_text
             ),
-            documentation: format_comment(alias_decl.comment),
-            # https://github.com/microsoft/vscode-languageserver-node/blob/6d78fc4d25719b231aba64a721a606f58b9e0a5f/client/src/common/client.ts#L624-L650
-            kind: LSP::Constant::CompletionItemKind::FIELD,
-            insert_text_format: LSP::Constant::InsertTextFormat::SNIPPET,
-            sort_text: complete_text,
-            filter_text: complete_text
+            documentation: LSPFormatter.markup_content { LSPFormatter.format_rbs_completion_docs(type_name, alias_decl, [alias_decl.comment].compact) },
+            kind: LSP::Constant::CompletionItemKind::FIELD
           )
         when :interface
           interface_decl = sig_service.latest_env.interface_decls[type_name]&.decl or raise
 
-          LanguageServer::Protocol::Interface::CompletionItem.new(
+          LSP::Interface::CompletionItem.new(
             label: complete_text,
-            detail: type_name.to_s,
-            text_edit: LanguageServer::Protocol::Interface::TextEdit.new(
+            label_details: LSP::Interface::CompletionItemLabelDetails.new(description: LSPFormatter.declaration_summary(interface_decl)),
+            text_edit: LSP::Interface::TextEdit.new(
               range: range,
               new_text: complete_text
             ),
-            documentation: format_comment(interface_decl.comment),
-            kind: LanguageServer::Protocol::Constant::CompletionItemKind::INTERFACE,
-            insert_text_format: LanguageServer::Protocol::Constant::InsertTextFormat::SNIPPET,
-            sort_text: complete_text,
-            filter_text: complete_text
-          )
-        end
-      end
-
-      def format_comment(comment)
-        if comment
-          LSP::Interface::MarkupContent.new(
-            kind: LSP::Constant::MarkupKind::MARKDOWN,
-            value: comment.string.gsub(/<!--(?~-->)-->/, "")
-          )
-        end
-      end
-
-      def format_comments(comments)
-        unless comments.empty?
-          LSP::Interface::MarkupContent.new(
-            kind: LSP::Constant::MarkupKind::MARKDOWN,
-            value: comments.map(&:string).join("\n----\n").gsub(/<!--(?~-->)-->/, "")
+            documentation: LSPFormatter.markup_content { LSPFormatter.format_rbs_completion_docs(type_name, interface_decl, [interface_decl.comment].compact) },
+            kind: LSP::Constant::CompletionItemKind::INTERFACE
           )
+        else
+          raise
         end
       end
 
       def format_completion_item(item)
-        range = LanguageServer::Protocol::Interface::Range.new(
-          start: LanguageServer::Protocol::Interface::Position.new(
+        range = LSP::Interface::Range.new(
+          start: LSP::Interface::Position.new(
             line: item.range.start.line-1,
             character: item.range.start.column
           ),
-          end: LanguageServer::Protocol::Interface::Position.new(
+          end: LSP::Interface::Position.new(
             line: item.range.end.line-1,
             character: item.range.end.column
           )
@@ -316,130 +297,103 @@ module Steep
 
         case item
         when Services::CompletionProvider::LocalVariableItem
-          LanguageServer::Protocol::Interface::CompletionItem.new(
-            label: item.identifier,
-            kind: LanguageServer::Protocol::Constant::CompletionItemKind::VARIABLE,
-            detail: item.type.to_s,
-            text_edit: LanguageServer::Protocol::Interface::TextEdit.new(
-              range: range,
-              new_text: item.identifier
-            )
+          LSP::Interface::CompletionItem.new(
+            label: item.identifier.to_s,
+            kind: LSP::Constant::CompletionItemKind::VARIABLE,
+            label_details: LSP::Interface::CompletionItemLabelDetails.new(description: item.type.to_s),
+            documentation: LSPFormatter.markup_content { LSPFormatter.format_completion_docs(item) },
+            insert_text: item.identifier.to_s,
+            sort_text: item.identifier.to_s
           )
         when Services::CompletionProvider::ConstantItem
           case
           when item.class? || item.module?
-            kind = LanguageServer::Protocol::Constant::CompletionItemKind::CLASS
-            detail = item.full_name.to_s
+            kind = LSP::Constant::CompletionItemKind::CLASS
           else
-            kind = LanguageServer::Protocol::Constant::CompletionItemKind::CONSTANT
-            detail = item.type.to_s
+            kind = LSP::Constant::CompletionItemKind::CONSTANT
           end
-          LanguageServer::Protocol::Interface::CompletionItem.new(
-            label: item.identifier,
+
+          detail = LSPFormatter.declaration_summary(item.decl)
+
+          LSP::Interface::CompletionItem.new(
+            label: item.identifier.to_s,
             kind: kind,
-            detail: detail,
-            documentation: format_comments(item.comments),
-            text_edit: LanguageServer::Protocol::Interface::TextEdit.new(
+            label_details: LSP::Interface::CompletionItemLabelDetails.new(description: detail),
+            documentation: LSPFormatter.markup_content { LSPFormatter.format_completion_docs(item) },
+            text_edit: LSP::Interface::TextEdit.new(
               range: range,
-              new_text: item.identifier
+              new_text: item.identifier.to_s
             )
           )
-        when Services::CompletionProvider::MethodNameItem
-          method_type_snippet = method_type_to_snippet(item.method_type)
-          LanguageServer::Protocol::Interface::CompletionItem.new(
-            label: item.identifier,
-            kind: LanguageServer::Protocol::Constant::CompletionItemKind::METHOD,
-            detail: item.method_type.to_s,
-            text_edit: LanguageServer::Protocol::Interface::TextEdit.new(
-              new_text: "#{item.identifier}#{method_type_snippet}",
-              range: range
-            ),
-            documentation: format_comment(item.comment),
-            insert_text_format: LanguageServer::Protocol::Constant::InsertTextFormat::SNIPPET,
-            sort_text: item.inherited? ? 'z' : 'a' # Ensure language server puts non-inherited methods before inherited methods
+        when Services::CompletionProvider::SimpleMethodNameItem
+          LSP::Interface::CompletionItem.new(
+            label: item.identifier.to_s,
+            kind: LSP::Constant::CompletionItemKind::FUNCTION,
+            label_details: LSP::Interface::CompletionItemLabelDetails.new(description: item.method_name.relative.to_s),
+            insert_text: item.identifier.to_s,
+            documentation: LSPFormatter.markup_content { LSPFormatter.format_completion_docs(item) }
+          )
+        when Services::CompletionProvider::ComplexMethodNameItem
+          method_names = item.method_names.map(&:relative).uniq
+
+          LSP::Interface::CompletionItem.new(
+            label: item.identifier.to_s,
+            kind: LSP::Constant::CompletionItemKind::FUNCTION,
+            label_details: LSP::Interface::CompletionItemLabelDetails.new(description: method_names.join(", ")),
+            insert_text: item.identifier.to_s,
+            documentation: LSPFormatter.markup_content { LSPFormatter.format_completion_docs(item) }
+          )
+        when Services::CompletionProvider::GeneratedMethodNameItem
+          LSP::Interface::CompletionItem.new(
+            label: item.identifier.to_s,
+            kind: LSP::Constant::CompletionItemKind::FUNCTION,
+            label_details: LSP::Interface::CompletionItemLabelDetails.new(description: "(Generated)"),
+            insert_text: item.identifier.to_s,
+            documentation: LSPFormatter.markup_content { LSPFormatter.format_completion_docs(item) }
           )
         when Services::CompletionProvider::InstanceVariableItem
-          LanguageServer::Protocol::Interface::CompletionItem.new(
-            label: item.identifier,
-            kind: LanguageServer::Protocol::Constant::CompletionItemKind::FIELD,
-            detail: item.type.to_s,
-            text_edit: LanguageServer::Protocol::Interface::TextEdit.new(
+          LSP::Interface::CompletionItem.new(
+            label: item.identifier.to_s,
+            kind: LSP::Constant::CompletionItemKind::FIELD,
+            label_details: LSP::Interface::CompletionItemLabelDetails.new(description: item.type.to_s),
+            documentation: LSPFormatter.markup_content { LSPFormatter.format_completion_docs(item) },
+            text_edit: LSP::Interface::TextEdit.new(
               range: range,
-              new_text: item.identifier,
-            ),
-            insert_text_format: LanguageServer::Protocol::Constant::InsertTextFormat::SNIPPET
+              new_text: item.identifier.to_s
+            )
           )
         end
       end
 
-      def method_type_to_snippet(method_type)
-        params = if method_type.type.each_param.count == 0
-                   ""
-                 else
-                   "(#{params_to_snippet(method_type.type)})"
-                 end
-
-
-        block = if method_type.block
-                  open, space, close = if method_type.block.type.return_type.is_a?(RBS::Types::Bases::Void)
-                                         ["do", " ", "end"]
-                                       else
-                                         ["{", "", "}"]
-                                       end
-
-                  if method_type.block.type.each_param.count == 0
-                    " #{open} $0 #{close}"
-                  else
-                    " #{open}#{space}|#{params_to_snippet(method_type.block.type)}| $0 #{close}"
+      def process_signature_help(job)
+        Steep.logger.tagged("##{__method__}") do
+          if target = project.target_for_source_path(job.path)
+            file = service.source_files[job.path] or return
+            subtyping = service.signature_services[target.name].current_subtyping or return
+            source = Source.parse(file.content, path: file.path, factory: subtyping.factory)
+
+            provider = Services::SignatureHelpProvider.new(source: source, subtyping: subtyping)
+
+            if (items, index = provider.run(line: job.line, column: job.column))
+              signatures = items.map do |item|
+                LSP::Interface::SignatureInformation.new(
+                  label: "(#{item.method_type.type.param_to_s})",
+                  documentation: item.comment&.yield_self do |comment|
+                    LSP::Interface::MarkupContent.new(
+                      kind: LSP::Constant::MarkupKind::MARKDOWN,
+                      value: comment.string.gsub(/<!--(?~-->)-->/, "")
+                    )
                   end
-                else
-                  ""
-                end
-
-        "#{params}#{block}"
-      end
-
-      def params_to_snippet(fun)
-        params = []
-
-        index = 1
-
-        fun.required_positionals.each do |param|
-          if name = param.name
-            params << "${#{index}:#{param.type}}"
-          else
-            params << "${#{index}:#{param.type}}"
-          end
-
-          index += 1
-        end
-
-        if fun.rest_positionals
-          params << "${#{index}:*#{fun.rest_positionals.type}}"
-          index += 1
-        end
-
-        fun.trailing_positionals.each do |param|
-          if name = param.name
-            params << "${#{index}:#{param.type}}"
-          else
-            params << "${#{index}:#{param.type}}"
-          end
-
-          index += 1
-        end
+                )
+              end
 
-        fun.required_keywords.each do |keyword, param|
-          if name = param.name
-            params << "#{keyword}: ${#{index}:#{name}_}"
-          else
-            params << "#{keyword}: ${#{index}:#{param.type}_}"
+              LSP::Interface::SignatureHelp.new(
+                signatures: signatures,
+                active_signature: index
+              )
+            end
           end
-
-          index += 1
         end
-
-        params.join(", ")
       end
     end
   end