steep 0.49.0 → 0.51.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0273968ec727f3b7c5c1007f9e27966c50ad7bc3128217a4ef30be4f97321037'
-  data.tar.gz: 195eb670673894e36af5e00ef911654f2a543c71e8de1d46c15e23035bef19c8
+  metadata.gz: 502d495f9b623c5d90a041a1e0bb7854be76251a8ac0f3567c1c91911eb641ee
+  data.tar.gz: 7845d6d26f38ceae87407d507f3f67b8d35bae18ecdd5f4ee9fdb841d434a4ad
 SHA512:
-  metadata.gz: '0908edc4a3221256f450c9fd945d7127bd9ece3fa0359b7da88be8cebea30f7c766e023b84527e89e8f0c7956752310a3b0e98343b8c4808bfde518a89284456'
-  data.tar.gz: 4004adb0d0e8f2e0cd2629cd7e0c2bd6513a3a48bbd96d1d77621bbe0979b73686ab9c8ad718e3243081fdf492ff9728b5bf6df8e7357e1b1cf810393dad264c
+  metadata.gz: e2e61987da5ef5d78381affeb2f4fbb8b84dd2a6fede0baa60c68f54a3464e3cb7eea0e2822f22a66d62f1de3b9f8b223cd6399dceb927397a3dab0bed3fea5d
+  data.tar.gz: ee91ba6b1a4d8f35ec1fbc157efd2fb54f27b11e398af09a7ef3d4f403ae0ae2fab3258404316c6ded646f688b61ff38b47a514fec83cd9fe1b4fcf136fdc441

data/CHANGELOG.md

@@ -2,6 +2,29 @@
 
 ## master
 
+## 0.51.0 (2022-04-01)
+
+* Completion for constant ([\#524](https://github.com/soutaro/steep/pull/524))
+* Better hover/completion message ([\#525](https://github.com/soutaro/steep/pull/525))
+* Show available commands when using `--help` ([\#523](https://github.com/soutaro/steep/pull/523))
+
+## 0.50.0 (2022-03-22)
+
+* CLI option for override steep command at spawn worker ([\#511](https://github.com/soutaro/steep/pull/511))
+* LSP related improvements for Sublime LSP ([\#513](https://github.com/soutaro/steep/pull/513))
+* Support Windows environment ([\#514](https://github.com/soutaro/steep/pull/514))
+* Let `&:foo` proc work with methods with optional parameters ([\#516](https://github.com/soutaro/steep/pull/516))
+* Fix unexpected error when or-asgn/and-asgn ([\#517](https://github.com/soutaro/steep/pull/517))
+* Fix goto-definition from method call inside block ([\#518](https://github.com/soutaro/steep/pull/518))
+* Better splat in array typing ([\#519](https://github.com/soutaro/steep/pull/519))
+
+## 0.49.1 (2022-03-11)
+
+* Fix lambda typing ([\#506](https://github.com/soutaro/steep/pull/506))
+* Validate type descendants ([\#507](https://github.com/soutaro/steep/pull/507))
+* Fix print error with absolute path ([\#508](https://github.com/soutaro/steep/pull/508))
+* Skip non-target ruby code on `steep stats` ([\#509](https://github.com/soutaro/steep/pull/509))
+
 ## 0.49.0 (2022-03-08)
 
 * Better typing for `#flat_map` ([\#504](https://github.com/soutaro/steep/pull/504))

data/Gemfile

@@ -9,4 +9,7 @@ gem "without_steep_types", path: "test/gems/without_steep_types"
 gem "rake"
 gem "minitest", "~> 5.15"
 gem "minitest-hooks"
-gem "stackprof"
+group :stackprof, optional: true do
+  gem "stackprof"
+end
+gem 'minitest-slow_test'

data/Gemfile.lock

@@ -1,14 +1,14 @@
 PATH
   remote: .
   specs:
-    steep (0.49.0)
+    steep (0.51.0)
       activesupport (>= 5.1)
       language_server-protocol (>= 3.15, < 4.0)
       listen (~> 3.0)
       parallel (>= 1.0.0)
       parser (>= 3.0)
       rainbow (>= 2.2.2, < 4.0)
-      rbs (>= 2.2.0)
+      rbs (>= 2.3.0)
       terminal-table (>= 2, < 4)
 
 PATH
@@ -24,13 +24,13 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.2.2)
+    activesupport (7.0.2.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
     ast (2.4.2)
-    concurrent-ruby (1.1.9)
+    concurrent-ruby (1.1.10)
     ffi (1.15.5)
     i18n (1.10.0)
       concurrent-ruby (~> 1.0)
@@ -41,7 +41,9 @@ GEM
     minitest (5.15.0)
     minitest-hooks (1.5.0)
       minitest (> 5.3)
-    parallel (1.21.0)
+    minitest-slow_test (0.2.0)
+      minitest (>= 5.0)
+    parallel (1.22.1)
     parser (3.1.1.0)
       ast (~> 2.4.1)
     rainbow (3.1.1)
@@ -49,7 +51,7 @@ GEM
     rb-fsevent (0.11.1)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
-    rbs (2.2.2)
+    rbs (2.3.0)
     stackprof (0.2.19)
     terminal-table (3.0.2)
       unicode-display_width (>= 1.1.1, < 3)
@@ -63,6 +65,7 @@ PLATFORMS
 DEPENDENCIES
   minitest (~> 5.15)
   minitest-hooks
+  minitest-slow_test
   rake
   stackprof
   steep!

data/lib/steep/ast/annotation/collection.rb

@@ -4,7 +4,7 @@ module Steep
       class Collection
         attr_reader :annotations
         attr_reader :factory
-        attr_reader :current_module
+        attr_reader :context
 
         attr_reader :var_type_annotations
         attr_reader :const_type_annotations
@@ -19,10 +19,10 @@ module Steep
         attr_reader :dynamic_annotations
         attr_reader :break_type_annotation
 
-        def initialize(annotations:, factory:, current_module:)
+        def initialize(annotations:, factory:, context:)
           @annotations = annotations
           @factory = factory
-          @current_module = current_module
+          @context = context
 
           @var_type_annotations = {}
           @method_type_annotations = {}
@@ -64,7 +64,7 @@ module Steep
 
         def absolute_type(type)
           if type
-            factory.absolute_type(type, namespace: current_module)
+            factory.absolute_type(type, context: context)
           end
         end
 
@@ -140,7 +140,7 @@ module Steep
         end
 
         def merge_block_annotations(annotations)
-          if annotations.current_module != current_module || annotations.factory != factory
+          if annotations.context != context || annotations.factory != factory
             raise "Cannot merge another annotation: self=#{self}, other=#{annotations}"
           end
 
@@ -148,9 +148,11 @@ module Steep
             annotation.is_a?(BlockType) || annotation.is_a?(BreakType)
           end
 
-          self.class.new(annotations: retained_annotations + annotations.annotations,
-                         factory: factory,
-                         current_module: current_module)
+          self.class.new(
+            annotations: retained_annotations + annotations.annotations,
+            factory: factory,
+            context: context
+          )
         end
 
         def any?(&block)

data/lib/steep/ast/types/factory.rb

@@ -18,7 +18,7 @@ module Steep
         end
 
         def type_name_resolver
-          @type_name_resolver ||= RBS::TypeNameResolver.from_env(definition_builder.env)
+          @type_name_resolver ||= RBS::Resolver::TypeNameResolver.new(definition_builder.env)
         end
 
         def type_opt(type)
@@ -810,15 +810,15 @@ module Steep
           @env ||= definition_builder.env
         end
 
-        def absolute_type(type, namespace:)
+        def absolute_type(type, context:)
           absolute_type = type_1(type).map_type_name do |name|
-            absolute_type_name(name, namespace: namespace) || name.absolute!
+            absolute_type_name(name, context: context) || name.absolute!
           end
           type(absolute_type)
         end
 
-        def absolute_type_name(type_name, namespace:)
-          type_name_resolver.resolve(type_name, context: namespace.ascend)
+        def absolute_type_name(type_name, context:)
+          type_name_resolver.resolve(type_name, context: context)
         end
 
         def instance_type(type_name, args: nil, location: nil)

data/lib/steep/cli.rb

@@ -23,6 +23,14 @@ module Steep
 
     def process_global_options
       OptionParser.new do |opts|
+        opts.banner = <<~USAGE
+          Usage: steep [options]
+
+          available commands: #{CLI.available_commands.join(', ')}
+
+          Options:
+        USAGE
+
         opts.on("--version") do
           process_version
           exit 0
@@ -72,6 +80,11 @@ module Steep
       opts.on("-j N", "--jobs=N", "Specify the number of type check workers (defaults: #{default})") do |count|
         command.jobs_count = Integer(count) if Integer(count) > 0
       end
+
+      command.steep_command = "steep"
+      opts.on("--steep-command=COMMAND", "Specify command to exec Steep CLI for worker (defaults: steep)") do |cmd|
+        command.steep_command = cmd
+      end
     end
 
     def process_init

data/lib/steep/diagnostic/deprecated/unknown_constant_assigned.rb

@@ -0,0 +1,28 @@
+Steep.logger.error "Diagnostic `Ruby::UnknownConstantAssigned` is deprecated. Use `Ruby::UnknownConstant` instead."
+
+module Steep
+  module Diagnostic
+    module Ruby
+      class UnknownConstantAssigned < Base
+        attr_reader :context
+        attr_reader :name
+
+        def initialize(node:, context:, name:)
+          const = node.children[0]
+          loc = if const
+                  const.loc.expression.join(node.loc.name)
+                else
+                  node.loc.name
+                end
+          super(node: node, location: loc)
+          @context = context
+          @name = name
+        end
+
+        def header_line
+          "Cannot find the declaration of constant `#{name}`"
+        end
+      end
+    end
+  end
+end

data/lib/steep/diagnostic/ruby.rb

@@ -551,27 +551,33 @@ module Steep
         end
       end
 
-      class UnknownConstantAssigned < Base
-        attr_reader :context
+      class UnknownConstant < Base
         attr_reader :name
+        attr_reader :kind
 
-        def initialize(node:, context:, name:)
-          const = node.children[0]
-          loc = if const
-                  const.loc.expression.join(node.loc.name)
-                else
-                  node.loc.name
-                end
-          super(node: node, location: loc)
-          @context = context
+        def initialize(node:, name:)
+          super(node: node, location: node.loc.name)
           @name = name
+          @kind = :constant
+        end
+
+        def class!
+          @kind = :class
+          self
+        end
+
+        def module!
+          @kind = :module
+          self
         end
 
         def header_line
-          "Cannot find the declaration of constant `#{name}`"
+          "Cannot find the declaration of #{kind}: `#{name}`"
         end
       end
 
+      autoload :UnknownConstantAssigned, "steep/diagnostic/deprecated/unknown_constant_assigned"
+
       class FallbackAny < Base
         def initialize(node:)
           super(node: node)
@@ -669,6 +675,19 @@ module Steep
         end
       end
 
+      class ProcTypeExpected < Base
+        attr_reader :type
+
+        def initialize(node:, type:)
+          super(node: node)
+          @type = type
+        end
+
+        def header_line
+          "Proc type is expected but `#{type.to_s}` is specified"
+        end
+      end
+
       class UnsupportedSyntax < Base
         attr_reader :message
 
@@ -731,7 +750,7 @@ module Steep
             ImplicitBreakValueMismatch => :warning,
             FallbackAny => :information,
             ElseOnExhaustiveCase => :warning,
-            UnknownConstantAssigned => :warning,
+            UnknownConstant => :warning,
             MethodDefinitionMissing => :information
           }
         ).freeze
@@ -744,7 +763,7 @@ module Steep
             ImplicitBreakValueMismatch => nil,
             FallbackAny => nil,
             ElseOnExhaustiveCase => nil,
-            UnknownConstantAssigned => nil,
+            UnknownConstant => nil,
             MethodDefinitionMissing => nil
           }
         ).freeze
@@ -757,7 +776,7 @@ module Steep
             ImplicitBreakValueMismatch => nil,
             FallbackAny => nil,
             ElseOnExhaustiveCase => nil,
-            UnknownConstantAssigned => nil,
+            UnknownConstant => nil,
             MethodDefinitionMissing => nil,
             UnexpectedJump => nil
           }

data/lib/steep/drivers/check.rb

@@ -39,6 +39,7 @@ module Steep
           steepfile: project.steepfile_path,
           args: command_line_patterns,
           delay_shutdown: true,
+          steep_command: steep_command,
           count: jobs_count
         )
 
@@ -214,8 +215,8 @@ module Steep
           total = errors.sum {|notification| notification[:diagnostics].size }
 
           errors.each do |notification|
-            path = project.relative_path(Pathname(URI.parse(notification[:uri]).path))
-            buffer = RBS::Buffer.new(name: path, content: path.read)
+            path = Pathname(URI.parse(notification[:uri]).path)
+            buffer = RBS::Buffer.new(name: project.relative_path(path), content: path.read)
             printer = DiagnosticPrinter.new(buffer: buffer, stdout: stdout)
 
             notification[:diagnostics].each do |diag|

data/lib/steep/drivers/langserver.rb

@@ -37,8 +37,8 @@ module Steep
       def run
         @project = load_config()
 
-        interaction_worker = Server::WorkerProcess.spawn_worker(:interaction, name: "interaction", steepfile: project.steepfile_path)
-        typecheck_workers = Server::WorkerProcess.spawn_typecheck_workers(steepfile: project.steepfile_path, args: [], count: jobs_count)
+        interaction_worker = Server::WorkerProcess.spawn_worker(:interaction, name: "interaction", steepfile: project.steepfile_path, steep_command: steep_command)
+        typecheck_workers = Server::WorkerProcess.spawn_typecheck_workers(steepfile: project.steepfile_path, args: [], steep_command: steep_command, count: jobs_count)
 
         master = Server::Master.new(
           project: project,

data/lib/steep/drivers/stats.rb

@@ -129,6 +129,7 @@ module Steep
           steepfile: project.steepfile_path,
           delay_shutdown: true,
           args: command_line_patterns,
+          steep_command: steep_command,
           count: jobs_count
         )
 

data/lib/steep/drivers/utils/jobs_count.rb

@@ -2,7 +2,7 @@ module Steep
   module Drivers
     module Utils
       module JobsCount
-        attr_accessor :jobs_count
+        attr_accessor :jobs_count, :steep_command
       end
     end
   end

data/lib/steep/drivers/watch.rb

@@ -41,7 +41,7 @@ module Steep
         server_reader = LanguageServer::Protocol::Transport::Io::Reader.new(server_read)
         server_writer = LanguageServer::Protocol::Transport::Io::Writer.new(server_write)
 
-        typecheck_workers = Server::WorkerProcess.spawn_typecheck_workers(steepfile: project.steepfile_path, args: dirs.map(&:to_s), count: jobs_count)
+        typecheck_workers = Server::WorkerProcess.spawn_typecheck_workers(steepfile: project.steepfile_path, args: dirs.map(&:to_s), steep_command: steep_command, count: jobs_count)
 
         master = Server::Master.new(
           project: project,

data/lib/steep/index/source_index.rb

@@ -16,7 +16,7 @@ module Steep
 
         def add_definition(node)
           case node.type
-          when :casgn, :class, :module
+          when :casgn, :const
             @definitions << node
           else
             raise "Unexpected constant definition: #{node.type}"
@@ -145,6 +145,23 @@ module Steep
           raise
         end
       end
+
+      def reference(constant_node: nil)
+        case
+        when constant_node
+          constant_index.each do |name, entry|
+            if entry.references.include?(constant_node)
+              return name
+            end
+
+            if entry.definitions.include?(constant_node)
+              return name
+            end
+          end
+
+          nil
+        end
+      end
     end
   end
 end

data/lib/steep/interface/function.rb

@@ -879,6 +879,11 @@ module Steep
           !has_positional? && !has_keywords?
         end
 
+        # Returns true if all arguments are non-required.
+        def optional?
+          required.empty? && required_keywords.empty?
+        end
+
         # self + params returns a new params for overloading.
         #
         def +(other)

data/lib/steep/module_helper.rb

@@ -1,12 +1,9 @@
 module Steep
   module ModuleHelper
-    def module_name_from_node(node)
-      case node.type
-      when :const, :casgn
-        namespace = namespace_from_node(node.children[0]) or return
-        name = node.children[1]
-        RBS::TypeName.new(name: name, namespace: namespace)
-      end
+    def module_name_from_node(parent_node, constant_name)
+      namespace = namespace_from_node(parent_node) or return
+      name = constant_name
+      RBS::TypeName.new(name: name, namespace: namespace)
     end
 
     def namespace_from_node(node)

data/lib/steep/project.rb

@@ -16,7 +16,21 @@ module Steep
       steepfile_path.parent
     end
 
-    def relative_path(path)
+    def relative_path(orig_path)
+      path = if Gem.win_platform?
+               path_str = URI.decode_www_form_component(
+                 orig_path.to_s.delete_prefix("/")
+               )
+               unless path_str.start_with?(%r{[a-z]:/}i)
+                 # FIXME: Sometimes drive letter is missing, taking from base_dir
+                 path_str = base_dir.to_s.split("/")[0] + "/" + path_str
+               end
+               Pathname.new(
+                 path_str
+               )
+             else
+               orig_path
+             end
       path.relative_path_from(base_dir)
     end
 

data/lib/steep/server/interaction_worker.rb

@@ -89,7 +89,7 @@ module Steep
               end
 
               LSP::Interface::Hover.new(
-                contents: { kind: "markdown", value: format_hover(content) },
+                contents: { kind: "markdown", value: format_hover(content)&.gsub(/<!--(?~-->)-->/, "") },
                 range: range
               )
             end
@@ -175,6 +175,21 @@ HOVER
           end
 
           string
+        when Services::HoverContent::ConstantContent
+          ss = []
+          if content.class_or_module?
+            ss << ["```rbs", retrieve_decl_information(content.decl.primary.decl), "```"].join("\n")
+          end
+
+          if content.constant?
+            ss << ["```rbs", "#{content.full_name}: #{content.type}", "```"].join("\n")
+          end
+
+          if s = content.comment_string
+            ss << s
+          end
+
+          ss.join("\n\n----\n\n")
         when Services::HoverContent::TypeContent
           "`#{content.type}`"
         end
@@ -271,7 +286,7 @@ HOVER
           ),
           end: LanguageServer::Protocol::Interface::Position.new(
             line: job.line - 1,
-            character: job.column - prefix.size
+            character: job.column
           )
         )
 
@@ -327,7 +342,16 @@ HOVER
         if comment
           LSP::Interface::MarkupContent.new(
             kind: LSP::Constant::MarkupKind::MARKDOWN,
-            value: comment.string
+            value: comment.string.gsub(/<!--(?~-->)-->/, "")
+          )
+        end
+      end
+
+      def format_comments(comments)
+        unless comments.empty?
+          LSP::Interface::MarkupContent.new(
+            kind: LSP::Constant::MarkupKind::MARKDOWN,
+            value: comments.map(&:string).join("\n----\n").gsub(/<!--(?~-->)-->/, "")
           )
         end
       end
@@ -408,6 +432,25 @@ HOVER
               new_text: item.identifier
             )
           )
+        when Services::CompletionProvider::ConstantItem
+          case
+          when item.class? || item.module?
+            kind = LanguageServer::Protocol::Constant::CompletionItemKind::CLASS
+            detail = item.full_name.to_s
+          else
+            kind = LanguageServer::Protocol::Constant::CompletionItemKind::CONSTANT
+            detail = item.type.to_s
+          end
+          LanguageServer::Protocol::Interface::CompletionItem.new(
+            label: item.identifier,
+            kind: kind,
+            detail: detail,
+            documentation: format_comments(item.comments),
+            text_edit: LanguageServer::Protocol::Interface::TextEdit.new(
+              range: range,
+              new_text: item.identifier
+            )
+          )
         when Services::CompletionProvider::MethodNameItem
           method_type_snippet = method_type_to_snippet(item.method_type)
           LanguageServer::Protocol::Interface::CompletionItem.new(
@@ -418,7 +461,7 @@ HOVER
               new_text: "#{item.identifier}#{method_type_snippet}",
               range: range
             ),
-            documentation: item.comment&.string,
+            documentation: format_comment(item.comment),
             insert_text_format: LanguageServer::Protocol::Constant::InsertTextFormat::SNIPPET,
             sort_text: item.inherited? ? 'z' : 'a' # Ensure language server puts non-inherited methods before inherited methods
           )

data/lib/steep/server/master.rb

@@ -49,9 +49,14 @@ module Steep
         end
 
         def checking_path?(path)
-          library_paths.include?(path) ||
-            signature_paths.include?(path) ||
-            code_paths.include?(path)
+          [library_paths, signature_paths, code_paths].any? do |paths|
+            if Gem.win_platform?
+              # FIXME: Sometimes drive letter is missing, so comparing without drive letter.
+              paths.any? {|p| p.to_s.split("/", 2)[1] == path.to_s.split("/", 2)[1]}
+            else
+              paths.include?(path)
+            end
+          end
         end
 
         def checked(path)
@@ -496,7 +501,7 @@ module Steep
                         partialResult: true
                       },
                       completion_provider: LSP::Interface::CompletionOptions.new(
-                        trigger_characters: [".", "@"],
+                        trigger_characters: [".", "@", ":"],
                         work_done_progress: true
                       ),
                       workspace_symbol_provider: true,
@@ -739,7 +744,7 @@ module Steep
                       { kind: "end" }
                     else
                       progress_string = ("▮"*(percentage/5)) + ("▯"*(20 - percentage/5))
-                      { kind: "report", percentage: percentage, message: "#{progress_string} (#{percentage}%)" }
+                      { kind: "report", percentage: percentage, message: "#{progress_string}" }
                     end
 
             job_queue << SendMessageJob.to_client(