steep 0.46.0 → 0.48.0

data/lib/steep/type_inference/block_params.rb

@@ -131,7 +131,7 @@ module Steep
         else
           leadings = leading_params.map {|param| param.type || AST::Types::Any.new }
           optionals = optional_params.map {|param| param.type || AST::Types::Any.new }
-          rest = rest_param&.yield_self {|param| param.type.args[0] }
+          rest = rest_param&.yield_self {|param| param.type&.args&.[](0) || AST::Types::Any.new }
         end
 
         Interface::Function::Params.build(

data/lib/steep/type_inference/context.rb

@@ -102,6 +102,36 @@ module Steep
         end
       end
 
+      class TypeVariableContext
+        attr_reader :table
+        attr_reader :type_params
+
+        def initialize(type_params, parent_context: nil)
+          @type_params = type_params
+
+          @table = {}
+          table.merge!(parent_context.table) if parent_context
+
+          type_params.each do |param|
+            table[param.name] = param
+          end
+        end
+
+        def [](name)
+          table[name].upper_bound
+        end
+
+        def upper_bounds
+          table.each_value.with_object({}) do |type_param, bounds|
+            bounds[type_param.name] = type_param.upper_bound
+          end
+        end
+
+        def self.empty
+          new([])
+        end
+      end
+
       attr_reader :call_context
       attr_reader :method_context
       attr_reader :block_context
@@ -110,8 +140,9 @@ module Steep
       attr_reader :self_type
       attr_reader :type_env
       attr_reader :lvar_env
+      attr_reader :variable_context
 
-      def initialize(method_context:, block_context:, break_context:, module_context:, self_type:, type_env:, lvar_env:, call_context:)
+      def initialize(method_context:, block_context:, break_context:, module_context:, self_type:, type_env:, lvar_env:, call_context:, variable_context:)
         @method_context = method_context
         @block_context = block_context
         @break_context = break_context
@@ -120,6 +151,7 @@ module Steep
         @type_env = type_env
         @lvar_env = lvar_env
         @call_context = call_context
+        @variable_context = variable_context
       end
 
       def with(method_context: self.method_context,
@@ -129,7 +161,8 @@ module Steep
                self_type: self.self_type,
                type_env: self.type_env,
                lvar_env: self.lvar_env,
-               call_context: self.call_context)
+               call_context: self.call_context,
+               variable_context: self.variable_context)
         self.class.new(
           method_context: method_context,
           block_context: block_context,
@@ -138,7 +171,8 @@ module Steep
           self_type: self_type,
           type_env: type_env,
           lvar_env: lvar_env,
-          call_context: call_context
+          call_context: call_context,
+          variable_context: variable_context
         )
       end
     end

data/lib/steep/type_inference/send_args.rb

@@ -99,19 +99,7 @@ module Steep
           PositionalArgs.new(args: args, index: index, positional_params: positional_params, uniform: uniform)
         end
 
-        def uniform!
-          update(uniform: true)
-        end
-
         def next()
-          if uniform
-            if node
-              return [node, uniform_type, update(index: index+1)]
-            else
-              return
-            end
-          end
-
           case
           when !node && param.is_a?(Interface::Function::Params::PositionalParams::Required)
             [
@@ -153,6 +141,7 @@ module Steep
         end
 
         def uniform_type
+          return nil unless positional_params
           if positional_params.each.any? {|param| param.is_a?(Interface::Function::Params::PositionalParams::Rest) }
             AST::Types::Intersection.build(types: positional_params.each.map(&:type))
           end

data/lib/steep/version.rb

@@ -1,3 +1,3 @@
 module Steep
-  VERSION = "0.46.0"
+  VERSION = "0.48.0"
 end

data/lib/steep.rb

@@ -2,10 +2,10 @@ require "steep/version"
 
 require "pathname"
 require "parser/ruby30"
+require "active_support"
 require "active_support/core_ext/object/try"
 require "active_support/core_ext/string/inflections"
 require "logger"
-require "active_support/tagged_logging"
 require "rainbow"
 require "listen"
 require 'language_server-protocol'
@@ -50,16 +50,17 @@ require "steep/ast/types/factory"
 
 require "steep/range_extension"
 
+require "steep/interface/type_param"
 require "steep/interface/function"
 require "steep/interface/block"
 require "steep/interface/method_type"
 require "steep/interface/substitution"
 require "steep/interface/interface"
 
-require "steep/subtyping/check"
 require "steep/subtyping/result"
+require "steep/subtyping/check"
+require "steep/subtyping/cache"
 require "steep/subtyping/relation"
-require "steep/subtyping/trace"
 require "steep/subtyping/constraints"
 require "steep/subtyping/variable_variance"
 require "steep/subtyping/variable_occurrence"
@@ -123,7 +124,6 @@ require "steep/drivers/validate"
 require "steep/drivers/annotations"
 require "steep/drivers/watch"
 require "steep/drivers/langserver"
-require "steep/drivers/trace_printer"
 require "steep/drivers/print_project"
 require "steep/drivers/init"
 require "steep/drivers/vendor"
@@ -213,7 +213,7 @@ module Steep
     end
 
     def percentile(p)
-      slowests(count - count * p / 100r).last&.last || 0
+      slowests([count * p / 100r, 1].max).last&.last || 0
     end
   end
 

data/sample/lib/length.rb

@@ -0,0 +1,35 @@
+class LengthCalculator
+  def max0(x, y)
+    if x.size > y.size
+      x
+    else
+      y
+    end
+  end
+
+  def max1(x, y)
+    if x.size > y.size
+      x
+    else
+      y
+    end
+  end
+
+  def max2(x, y)
+    if x.size > y.size
+      x
+    else
+      y
+    end
+  end
+end
+
+calc = LengthCalculator.new()
+
+calc.max0("foo", "bar")
+calc.max1("foo", "bar")
+calc.max2("foo", "bar")
+
+calc.max0(true, false)
+calc.max1(true, false)
+calc.max2(true, false)

data/sample/sig/length.rbs

@@ -0,0 +1,34 @@
+# LengthCalculator shows three different method types having the same implementation.
+#
+# * It receives two objects.
+# * It calls the `#size` method of the objects, and compare the return values.
+# * It returns one of the objects which has bigger `#size` value.
+#
+class LengthCalculator
+  interface _Sized
+    def size: () -> Integer
+  end
+
+  # *Untyped* version -- all (static) type information is lost.
+  #
+  # You can pass any object, even if the object doesn't have `#size` method.
+  #
+  def max0: (untyped, untyped) -> untyped
+
+  # *Subtyping* version -- with constraints on arguments, but the return type is inaccurate.
+  #
+  # You can type check if the object has `#size` method of the expected type.
+  # However, the return type also has `_Sized` type, which drops other methods than `#size`.
+  #
+  def max1: (_Sized, _Sized) -> _Sized
+
+  # *Generics* version -- the most advanced one in Steep/RBS
+  #
+  # You can type check if the object has `#size` method of the expected type.
+  # And the return type is the one given as arguments.
+  #
+  # Note that the type system of Steep cannot ensure the given two objects have the same type.
+  # Passing `String` and `Array[String]` will infer the return type `String | Array[String]`.
+  #
+  def max2: [T < _Sized] (T, T) -> T
+end

data/smoke/diagnostics/test_expectations.yml

@@ -95,8 +95,8 @@
         line: 7
         character: 21
     severity: ERROR
-    message: 'The method parameter has different kind from the declaration `(size:
-      ::Integer, name: ::String) -> void`'
+    message: 'The method parameter has different kind from the declaration `(name:
+      ::String, size: ::Integer) -> void`'
     code: Ruby::DifferentMethodParameterKind
   - range:
       start:
@@ -106,8 +106,8 @@
         line: 7
         character: 29
     severity: ERROR
-    message: 'The method parameter has different kind from the declaration `(size:
-      ::Integer, name: ::String) -> void`'
+    message: 'The method parameter has different kind from the declaration `(name:
+      ::String, size: ::Integer) -> void`'
     code: Ruby::DifferentMethodParameterKind
 - file: else_on_exhaustive_case.rb
   diagnostics:

data/smoke/diagnostics-rbs/nonregular-type-alias.rbs

@@ -0,0 +1,3 @@
+module NonregularTypeAlias
+  type t[T, S] = ^() -> t[String, Integer]
+end

data/smoke/diagnostics-rbs/recursive-type-alias.rbs

@@ -0,0 +1,3 @@
+type foo = bar
+type bar = baz
+type baz = foo

data/smoke/diagnostics-rbs/test_expectations.yml

@@ -103,6 +103,31 @@
     message: The variance of type parameter `A` is covariant, but used in incompatible
       position here
     code: RBS::InvalidVarianceAnnotation
+- file: mixin-class-error.rbs
+  diagnostics:
+  - range:
+      start:
+        line: 5
+        character: 2
+      end:
+        line: 5
+        character: 13
+    severity: ERROR
+    message: Cannot include a class `::Foo` in the definition of `::Bar`
+    code: RBS::MixinClassError
+- file: nonregular-type-alias.rbs
+  diagnostics:
+  - range:
+      start:
+        line: 2
+        character: 2
+      end:
+        line: 2
+        character: 42
+    severity: ERROR
+    message: 'Type alias ::NonregularTypeAlias::t is defined *non-regular*: ::NonregularTypeAlias::t[::String,
+      ::Integer]'
+    code: RBS::NonregularTypeAlias
 - file: recursive-alias.rbs
   diagnostics:
   - range:
@@ -151,6 +176,38 @@
     message: 'Circular inheritance/mix-in is detected: ::Baz <: ::Foo <: ::Bar <:
       ::Baz'
     code: RBS::RecursiveAncestor
+- file: recursive-type-alias.rbs
+  diagnostics:
+  - range:
+      start:
+        line: 1
+        character: 0
+      end:
+        line: 1
+        character: 14
+    severity: ERROR
+    message: 'Type aliases cannot be *directly recursive*: ::foo'
+    code: RBS::RecursiveTypeAlias
+  - range:
+      start:
+        line: 2
+        character: 0
+      end:
+        line: 2
+        character: 14
+    severity: ERROR
+    message: 'Type aliases cannot be *directly recursive*: ::bar'
+    code: RBS::RecursiveTypeAlias
+  - range:
+      start:
+        line: 3
+        character: 0
+      end:
+        line: 3
+        character: 14
+    severity: ERROR
+    message: 'Type aliases cannot be *directly recursive*: ::baz'
+    code: RBS::RecursiveTypeAlias
 - file: superclass-mismatch.rbs
   diagnostics:
   - range:
@@ -229,15 +286,3 @@
     severity: ERROR
     message: Cannot find type `ZZZ`
     code: RBS::UnknownTypeName
-- file: mixin-class-error.rbs
-  diagnostics:
-  - range:
-      start:
-        line: 5
-        character: 2
-      end:
-        line: 5
-        character: 13
-    severity: ERROR
-    message: Cannot include a class `::Foo` in the definition of `::Bar`
-    code: RBS::MixinClassError

data/smoke/extension/e.rbs

@@ -3,5 +3,5 @@ class NumberLike
 end
 
 class Integer
-  overload def `+`: (NumberLike) -> NumberLike
+  def `+`: (NumberLike) -> NumberLike | ...
 end

data/steep.gemspec

@@ -33,7 +33,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency "rainbow", ">= 2.2.2", "< 4.0"
   spec.add_runtime_dependency "listen", "~> 3.0"
   spec.add_runtime_dependency "language_server-protocol", ">= 3.15", "< 4.0"
-  spec.add_runtime_dependency "rbs", ">= 1.2.0"
+  spec.add_runtime_dependency "rbs", ">= 2.2.0"
   spec.add_runtime_dependency "parallel", ">= 1.0.0"
   spec.add_runtime_dependency "terminal-table", ">= 2", "< 4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: steep
 version: !ruby/object:Gem::Version
-  version: 0.46.0
+  version: 0.48.0
 platform: ruby
 authors:
 - Soutaro Matsumoto
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-08-30 00:00:00.000000000 Z
+date: 2022-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -98,14 +98,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: 2.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: 2.2.0
 - !ruby/object:Gem::Dependency
   name: parallel
   requirement: !ruby/object:Gem::Requirement
@@ -204,7 +204,6 @@ files:
 - lib/steep/drivers/langserver.rb
 - lib/steep/drivers/print_project.rb
 - lib/steep/drivers/stats.rb
-- lib/steep/drivers/trace_printer.rb
 - lib/steep/drivers/utils/driver_helper.rb
 - lib/steep/drivers/utils/jobs_count.rb
 - lib/steep/drivers/validate.rb
@@ -219,9 +218,9 @@ files:
 - lib/steep/interface/block.rb
 - lib/steep/interface/function.rb
 - lib/steep/interface/interface.rb
-- lib/steep/interface/method.rb
 - lib/steep/interface/method_type.rb
 - lib/steep/interface/substitution.rb
+- lib/steep/interface/type_param.rb
 - lib/steep/method_name.rb
 - lib/steep/module_helper.rb
 - lib/steep/project.rb
@@ -247,11 +246,11 @@ files:
 - lib/steep/services/type_check_service.rb
 - lib/steep/signature/validator.rb
 - lib/steep/source.rb
+- lib/steep/subtyping/cache.rb
 - lib/steep/subtyping/check.rb
 - lib/steep/subtyping/constraints.rb
 - lib/steep/subtyping/relation.rb
 - lib/steep/subtyping/result.rb
-- lib/steep/subtyping/trace.rb
 - lib/steep/subtyping/variable_occurrence.rb
 - lib/steep/subtyping/variable_variance.rb
 - lib/steep/type_construction.rb
@@ -271,9 +270,9 @@ files:
 - manual/annotations.md
 - sample/Steepfile
 - sample/lib/conference.rb
+- sample/lib/length.rb
 - sample/sig/conference.rbs
-- sig/project.rbi
-- sig/steep/type_inference/send_args.rbs
+- sample/sig/length.rbs
 - smoke/alias/Steepfile
 - smoke/alias/a.rb
 - smoke/alias/a.rbs
@@ -326,8 +325,10 @@ files:
 - smoke/diagnostics-rbs/invalid-type-application.rbs
 - smoke/diagnostics-rbs/invalid_variance_annotation.rbs
 - smoke/diagnostics-rbs/mixin-class-error.rbs
+- smoke/diagnostics-rbs/nonregular-type-alias.rbs
 - smoke/diagnostics-rbs/recursive-alias.rbs
 - smoke/diagnostics-rbs/recursive-class.rbs
+- smoke/diagnostics-rbs/recursive-type-alias.rbs
 - smoke/diagnostics-rbs/superclass-mismatch.rbs
 - smoke/diagnostics-rbs/test_expectations.yml
 - smoke/diagnostics-rbs/unknown-method-alias.rbs
@@ -535,7 +536,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Gradual Typing for Ruby

data/lib/steep/drivers/trace_printer.rb

@@ -1,29 +0,0 @@
-module Steep
-  module Drivers
-    class TracePrinter
-      attr_reader :io
-
-      def initialize(io)
-        @io = io
-      end
-
-      def print(trace, level: 0)
-        trace.each.with_index do |t, i|
-          prefix = "  " * (i + level)
-          case t[0]
-          when :type
-            io.puts "#{prefix}#{t[1]} <: #{t[2]}"
-          when :method
-            io.puts "#{prefix}(#{t[3]}) #{t[1]} <: #{t[2]}"
-          when :method_type
-            io.puts "#{prefix}#{t[1]} <: #{t[2]}"
-          when :interface
-            # nop
-          else
-            Steep.logger.error { "Unexpected trace item: #{t[0]}" }
-          end
-        end
-      end
-    end
-  end
-end

data/lib/steep/interface/method.rb

@@ -1,78 +0,0 @@
-module Steep
-  module Interface
-    class Method
-      attr_reader :type_name
-      attr_reader :name
-      attr_reader :super_method
-      attr_reader :types
-      attr_reader :attributes
-
-      def initialize(type_name:, name:, types:, super_method:, attributes:)
-        @type_name = type_name
-        @name = name
-        @types = types
-        @super_method = super_method
-        @attributes = attributes
-      end
-
-      def ==(other)
-        other.is_a?(Method) &&
-          other.type_name == type_name &&
-          other.name == name &&
-          other.types == types &&
-          other.super_method == super_method &&
-          other.attributes == attributes
-      end
-
-      def private?
-        attributes.include?(:private)
-      end
-
-      def closed?
-        types.all?(&:closed?)
-      end
-
-      def subst(s)
-        self.class.new(
-          type_name: type_name,
-          name: name,
-          types: types.map {|type| type.subst(s) },
-          super_method: super_method&.subst(s),
-          attributes: attributes
-        )
-      end
-
-      def with_super(super_method)
-        self.class.new(
-          type_name: type_name,
-          name: name,
-          types: types,
-          super_method: super_method,
-          attributes: attributes
-        )
-      end
-
-      def with_types(types)
-        self.class.new(
-          type_name: type_name,
-          name: name,
-          types: types,
-          super_method: super_method,
-          attributes: attributes
-        )
-      end
-
-      def map_types
-        with_types(types.map {|type| yield type })
-      end
-
-      def include_in_chain?(method)
-        (method.type_name == type_name &&
-          method.name == name &&
-          method.types == types &&
-          method.attributes == attributes) ||
-          super_method&.include_in_chain?(method)
-      end
-    end
-  end
-end

data/lib/steep/subtyping/trace.rb

@@ -1,71 +0,0 @@
-module Steep
-  module Subtyping
-    class Trace
-      attr_reader :array
-
-      def initialize(array: [])
-        @array = array
-      end
-
-      def interface(sub, sup, &block)
-        push :interface, sub, sup, &block
-      end
-
-      def method(name, sub, sup, &block)
-        push :method, sub, sup, name, &block
-      end
-
-      def method_type(name, sub, sup, &block)
-        push :method_type, sub, sup, name, &block
-      end
-
-      def type(sub, sup, &block)
-        push :type, sub, sup, &block
-      end
-
-      def push(*xs)
-        array << xs
-        yield
-      ensure
-        array.pop
-      end
-
-      def add(sup, sub)
-        array << [sup, sub]
-        yield
-      ensure
-        array.pop
-      end
-
-      def empty?
-        array.empty?
-      end
-
-      def drop(n)
-        self.class.new(array: array.drop(n))
-      end
-
-      def size
-        array.size
-      end
-
-      def +(other)
-        self.class.new(array: array + other.array)
-      end
-
-      def initialize_copy(source)
-        @array = source.array.dup
-      end
-
-      def each
-        if block_given?
-          array.each do |pair|
-            yield(*pair)
-          end
-        else
-          enum_for :each
-        end
-      end
-    end
-  end
-end