steep 0.44.0 → 0.47.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9f5bbaa95e53fda280f5b1c239c0c72093d51cbb6ca0699dbc5c580bcd857989
-  data.tar.gz: c9d4c6e70696e7f85d17b872ca6cec7088f9ee44d9768e9341564fc48e0b8f65
+  metadata.gz: dcd473b07b749d136220c73d4434747c909fc516b5d14332590a5e46abed65f9
+  data.tar.gz: c652c1608f635556d3c6704746c901b97047b5f2fc670ea563f50aa30d198210
 SHA512:
-  metadata.gz: 21fb7999c14382b1e6f3d2ad6dba6ec1db2c9169c4620ee66c76ecff8bee8d198b4f972e2afc181405ba8f8f378ae16d07c070a3886135e92e3d788257c93d94
-  data.tar.gz: e06a0f4d2d5e726a749c79c8828d86f0de2c5494126d208ddaddc320fa7911b89eb5e051a231db0c97078d0f844b35a04552d47cbd3c8fe001c7213bea90f0ac
+  metadata.gz: 9a540a74cb3d514500a5d57d7111ce45b16cafde7855aa182d0a6a188edf74d7203b17368cc275aa574aaa16f5a7f265eb0a95c1fa9c0a524e42fb78b67bffdc
+  data.tar.gz: eac07db23cad1f7eeb697d4f27e4548c45174e23d7552e7bd4246494efb25d8a967c10d6f00c112a1b3070b1a86e0131a4e3f0b95af8bf66f65747ba4e57f16b

data/.github/dependabot.yml

@@ -0,0 +1,8 @@
+version: 2
+updates:
+- package-ecosystem: bundler
+  directory: "/"
+  schedule:
+    interval: daily
+    time: "20:00"
+  open-pull-requests-limit: 10

data/.github/workflows/ruby.yml

@@ -12,8 +12,9 @@ jobs:
     strategy:
       matrix:
         container_tag:
-        - 2.6.5-bionic
-        - 2.7.0-bionic
+        - "2.7"
+        - "3.0"
+        - "master-nightly-focal"
         task:
         - test
         - test:output

data/.gitignore

@@ -1,6 +1,5 @@
 /.bundle/
 /.yardoc
-/Gemfile.lock
 /_yardoc/
 /coverage/
 /doc/

data/CHANGELOG.md

@@ -2,6 +2,48 @@
 
 ## master
 
+## 0.47.0 (2021-11-30)
+
+This update contains update for RBS 1.7.
+
+* RBS 1.7 ([#455](https://github.com/soutaro/steep/pull/455))
+* Bug fixes related to `SendArgs` ([#444](https://github.com/soutaro/steep/pull/444), [#449](https://github.com/soutaro/steep/pull/449), [#451](https://github.com/soutaro/steep/pull/451))
+* LSP completion item formatting improvement ([#442](https://github.com/soutaro/steep/pull/442))
+
+## 0.46.0 (2021-08-30)
+
+This release updates Steepfile DSL syntax, introducing `stdlib_path` and `configure_code_diagnostics` syntax (methods).
+
+* `stdlib_path` allows configuring core/stdlib RBS file locations.
+* `configure_code_diagnostics` allows configuring _severity_ of each type errors.
+
+See the PRs for the explanation of these methods.
+You can try `steep init` to generate updated `Steepfile` template.
+
+* Flexible diagnostics configuration ([\#422](https://github.com/soutaro/steep/pull/422), [\#423](https://github.com/soutaro/steep/pull/423))
+* Revise Steepfile _path_ DSL ([\#421](https://github.com/soutaro/steep/pull/421))
+* Avoid to stop process by invalid jobs_count ([\#419](https://github.com/soutaro/steep/pull/419))
+* Fix `Steep::Typing::UnknownNodeError` when hover method with numblock ([\#415](https://github.com/soutaro/steep/pull/415))
+
+## 0.45.0 (2021-08-22)
+
+* Fix error reporting on `RBS::MixinClassError` ([\#411](https://github.com/soutaro/steep/pull/411))
+* Compact error reporting for method body type mismatch ([\#414](https://github.com/soutaro/steep/pull/414))
+* Fix NoMethodError with csend/numblock ([\#412](https://github.com/soutaro/steep/pull/412))
+* LSP completion for RBS files ([\#404](https://github.com/soutaro/steep/pull/404))
+* Allow break without value from bot methods ([\#398](https://github.com/soutaro/steep/pull/398))
+* Type check on lvar assignments ([\#390](https://github.com/soutaro/steep/pull/390))
+* Assign different error code to break without value ([\#387](https://github.com/soutaro/steep/pull/387))
+* Support Ruby3 Keyword Arguments ([\#386](https://github.com/soutaro/steep/pull/386))
+* LSP hover for RBS files ([\#385](https://github.com/soutaro/steep/pull/385), [\#397](https://github.com/soutaro/steep/pull/397))
+* Fix FileLoader to skip files not matching to the given pattern ([\#382](https://github.com/soutaro/steep/pull/382))
+* Ruby3 support for numbered block parameters and end-less def ([\#381](https://github.com/soutaro/steep/pull/381))
+
+## 0.44.1 (2021-04-23)
+
+* Disable goto declaration and goto type declaration (because they are not implemented) ([#377](https://github.com/soutaro/steep/pull/377))
+* Fix goto from block calls ([#378](https://github.com/soutaro/steep/pull/378))
+
 ## 0.44.0 (2021-04-22)
 
 * Implement LSP go to definition/implementation ([#371](https://github.com/soutaro/steep/pull/371), [#375](https://github.com/soutaro/steep/pull/375))

data/Gemfile

@@ -8,8 +8,5 @@ gem "without_steep_types", path: "test/gems/without_steep_types"
 
 gem "rake"
 gem "minitest", "~> 5.0"
-gem "racc", "~> 1.4"
-gem "minitest-reporters"
 gem "minitest-hooks"
 gem "stackprof"
-gem "rbs", git: "https://github.com/ruby/rbs.git"

data/Gemfile.lock

@@ -0,0 +1,75 @@
+PATH
+  remote: .
+  specs:
+    steep (0.47.0)
+      activesupport (>= 5.1)
+      language_server-protocol (>= 3.15, < 4.0)
+      listen (~> 3.0)
+      parallel (>= 1.0.0)
+      parser (>= 3.0)
+      rainbow (>= 2.2.2, < 4.0)
+      rbs (~> 1.7.0)
+      terminal-table (>= 2, < 4)
+
+PATH
+  remote: test/gems/with_steep_types
+  specs:
+    with_steep_types (1.0.0)
+
+PATH
+  remote: test/gems/without_steep_types
+  specs:
+    without_steep_types (1.0.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (6.1.4.1)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+      zeitwerk (~> 2.3)
+    ast (2.4.2)
+    concurrent-ruby (1.1.9)
+    ffi (1.15.4)
+    i18n (1.8.11)
+      concurrent-ruby (~> 1.0)
+    language_server-protocol (3.16.0.3)
+    listen (3.7.0)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    minitest (5.14.4)
+    minitest-hooks (1.5.0)
+      minitest (> 5.3)
+    parallel (1.21.0)
+    parser (3.0.3.1)
+      ast (~> 2.4.1)
+    rainbow (3.0.0)
+    rake (13.0.6)
+    rb-fsevent (0.11.0)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    rbs (1.7.1)
+    stackprof (0.2.17)
+    terminal-table (3.0.2)
+      unicode-display_width (>= 1.1.1, < 3)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (2.1.0)
+    zeitwerk (2.5.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  minitest (~> 5.0)
+  minitest-hooks
+  rake
+  stackprof
+  steep!
+  with_steep_types!
+  without_steep_types!
+
+BUNDLED WITH
+   2.2.27

data/README.md

@@ -8,7 +8,7 @@ Install via RubyGems.
 
 ### Requirements
 
-Steep requires Ruby 2.6.
+Steep requires Ruby 2.6 or later.
 
 ## Usage
 
@@ -126,6 +126,7 @@ end
 
 class Phone
   # @dynamic country, number
+  attr_reader :country, :number
 
   def initialize(country:, number:)
     @country = country

data/lib/steep/annotation_parser.rb

@@ -25,7 +25,7 @@ module Steep
         @location = location
 
         message = case exn
-                  when RBS::Parser::SyntaxError
+                  when RBS::ParsingError
                     Diagnostic::Signature::SyntaxError.parser_syntax_error_message(exn)
                   else
                     exn.message

data/lib/steep/ast/builtin.rb

@@ -10,8 +10,14 @@ module Steep
           @arity = arity
         end
 
-        def instance_type(*args)
+        def instance_type(*args, fill_untyped: false)
+          if fill_untyped
+            (arity - args.size).times do
+              args << Builtin.any_type
+            end
+          end
           arity == args.size or raise "Mulformed instance type: name=#{module_name}, args=#{args}"
+
           Types::Name::Instance.new(name: module_name, args: args)
         end
 

data/lib/steep/ast/types/factory.rb

@@ -194,7 +194,7 @@ module Steep
         end
 
         def params(type)
-          Interface::Function::Params.new(
+          Interface::Function::Params.build(
             required: type.required_positionals.map {|param| type(param.type) },
             optional: type.optional_positionals.map {|param| type(param.type) },
             rest: type.rest_positionals&.yield_self {|param| type(param.type) },
@@ -621,12 +621,7 @@ module Steep
                       Interface::MethodType.new(
                         type_params: [],
                         type: Interface::Function.new(
-                          params: Interface::Function::Params.new(required: [AST::Types::Literal.new(value: index)],
-                                                                  optional: [],
-                                                                  rest: nil,
-                                                                  required_keywords: {},
-                                                                  optional_keywords: {},
-                                                                  rest_keywords: nil),
+                          params: Interface::Function::Params.build(required: [AST::Types::Literal.new(value: index)]),
                           return_type: elem_type,
                           location: nil
                         ),
@@ -643,12 +638,7 @@ module Steep
                       Interface::MethodType.new(
                         type_params: [],
                         type: Interface::Function.new(
-                          params: Interface::Function::Params.new(required: [AST::Types::Literal.new(value: index), elem_type],
-                                                                  optional: [],
-                                                                  rest: nil,
-                                                                  required_keywords: {},
-                                                                  optional_keywords: {},
-                                                                  rest_keywords: nil),
+                          params: Interface::Function::Params.build(required: [AST::Types::Literal.new(value: index), elem_type]),
                           return_type: elem_type,
                           location: nil
                         ),
@@ -712,12 +702,14 @@ module Steep
                       Interface::MethodType.new(
                         type_params: [],
                         type: Interface::Function.new(
-                          params: Interface::Function::Params.new(required: [key_type],
-                                                                  optional: [],
-                                                                  rest: nil,
-                                                                  required_keywords: {},
-                                                                  optional_keywords: {},
-                                                                  rest_keywords: nil),
+                          params: Interface::Function::Params.build(
+                            required: [key_type],
+                            optional: [],
+                            rest: nil,
+                            required_keywords: {},
+                            optional_keywords: {},
+                            rest_keywords: nil
+                          ),
                           return_type: value_type,
                           location: nil
                         ),
@@ -735,12 +727,14 @@ module Steep
                       Interface::MethodType.new(
                         type_params: [],
                         type: Interface::Function.new(
-                          params: Interface::Function::Params.new(required: [key_type, value_type],
-                                                                  optional: [],
-                                                                  rest: nil,
-                                                                  required_keywords: {},
-                                                                  optional_keywords: {},
-                                                                  rest_keywords: nil),
+                          params: Interface::Function::Params.build(
+                            required: [key_type, value_type],
+                            optional: [],
+                            rest: nil,
+                            required_keywords: {},
+                            optional_keywords: {},
+                            rest_keywords: nil
+                          ),
                           return_type: value_type,
                           location: nil),
                         block: nil,

data/lib/steep/cli.rb

@@ -70,7 +70,7 @@ module Steep
       default = physical_processor_count + modifier
       command.jobs_count = default
       opts.on("-j N", "--jobs=N", "Specify the number of type check workers (defaults: #{default})") do |count|
-        command.jobs_count = Integer(count)
+        command.jobs_count = Integer(count) if Integer(count) > 0
       end
     end
 
@@ -99,6 +99,9 @@ module Steep
           opts.on("--save-expectations[=PATH]", "Save expectations with current type check result to PATH (or steep_expectations.yml)") do |path|
             check.save_expectations_path = Pathname(path || "steep_expectations.yml")
           end
+          opts.on("--severity-level=LEVEL", /^error|warning|information|hint$/, "Specify the minimum diagnostic severity to be recognized as an error (defaults: warning): error, warning, information, or hint") do |level|
+            check.severity_level = level.to_sym
+          end
           handle_jobs_option check, opts
           handle_logging_options opts
         end.parse!(argv)
@@ -155,6 +158,9 @@ module Steep
       Drivers::Watch.new(stdout: stdout, stderr: stderr).tap do |command|
         OptionParser.new do |opts|
           opts.banner = "Usage: steep watch [options] [dirs]"
+          opts.on("--severity-level=LEVEL", /^error|warning|information|hint$/, "Specify the minimum diagnostic severity to be recognized as an error (defaults: warning): error, warning, information, or hint") do |level|
+            command.severity_level = level.to_sym
+          end
           handle_jobs_option command, opts
           handle_logging_options opts
         end.parse!(argv)

data/lib/steep/diagnostic/lsp_formatter.rb

@@ -3,13 +3,66 @@ module Steep
     class LSPFormatter
       LSP = LanguageServer::Protocol
 
+      attr_reader :config
+      attr_reader :default_severity
+
+      ERROR = :error
+      WARNING = :warning
+      INFORMATION = :information
+      HINT = :hint
+
+      def initialize(config = {}, default_severity: ERROR)
+        @config = config
+        @default_severity = default_severity
+
+        config.each do |klass, severity|
+          validate_severity(klass, severity)
+          validate_class(klass)
+        end
+        validate_severity(:default, default_severity)
+      end
+
+      def validate_class(klass)
+        unless klass < Diagnostic::Ruby::Base
+          raise "Unexpected diagnostics class `#{klass}` given"
+        end
+      end
+
+      def validate_severity(klass, severity)
+        case severity
+        when ERROR, WARNING, INFORMATION, HINT, nil
+          # ok
+        else
+          raise "Unexpected severity `#{severity}` is specified for #{klass}"
+        end
+      end
+
       def format(diagnostic)
-        LSP::Interface::Diagnostic.new(
-          message: diagnostic.full_message,
-          code: diagnostic.diagnostic_code,
-          severity: LSP::Constant::DiagnosticSeverity::ERROR,
-          range: diagnostic.location.as_lsp_range
-        ).to_hash
+        severity = severity_for(diagnostic)
+
+        if severity
+          LSP::Interface::Diagnostic.new(
+            message: diagnostic.full_message,
+            code: diagnostic.diagnostic_code,
+            severity: severity,
+            range: diagnostic.location.as_lsp_range
+          ).to_hash
+        end
+      end
+
+      def severity_for(diagnostic)
+        case config.fetch(diagnostic.class, default_severity)
+        when ERROR
+          LSP::Constant::DiagnosticSeverity::ERROR
+        when WARNING
+          LSP::Constant::DiagnosticSeverity::WARNING
+        when INFORMATION
+          LSP::Constant::DiagnosticSeverity::INFORMATION
+        when HINT
+          LSP::Constant::DiagnosticSeverity::HINT
+        when nil
+          nil
+        end
       end
     end
   end