steep 0.40.0 → 0.44.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 725a6432404ca94fa643ba89ed2028d7b3923ece4031512ebea88ebbdc4fd01e
-  data.tar.gz: 957a95acbda38474f1a796f829f8cf098b69484a8ddf42bd39e2c2be935a961e
+  metadata.gz: 9f5bbaa95e53fda280f5b1c239c0c72093d51cbb6ca0699dbc5c580bcd857989
+  data.tar.gz: c9d4c6e70696e7f85d17b872ca6cec7088f9ee44d9768e9341564fc48e0b8f65
 SHA512:
-  metadata.gz: 363a04610a81d4652541c9e5856705f7317a8b4e92a2074dc460b5f34e19f8eb5bfd080826c3a61a41414668d22d0352e4b300d1ce09c659243ef8c06492fc22
-  data.tar.gz: 33b8d47d5290acea68f1f07ee74a6129ad0a2568fff2ddc783b7910f2ed55ae2d6d6b6f0b1b90b8dea773bfab0c9cc7ccc70723ab5aee75db3e3a0f997b93fe9
+  metadata.gz: 21fb7999c14382b1e6f3d2ad6dba6ec1db2c9169c4620ee66c76ecff8bee8d198b4f972e2afc181405ba8f8f378ae16d07c070a3886135e92e3d788257c93d94
+  data.tar.gz: e06a0f4d2d5e726a749c79c8828d86f0de2c5494126d208ddaddc320fa7911b89eb5e051a231db0c97078d0f844b35a04552d47cbd3c8fe001c7213bea90f0ac

data/CHANGELOG.md

@@ -2,6 +2,44 @@
 
 ## master
 
+## 0.44.0 (2021-04-22)
+
+* Implement LSP go to definition/implementation ([#371](https://github.com/soutaro/steep/pull/371), [#375](https://github.com/soutaro/steep/pull/375))
+* Fix typing on passing optional block ([#373](https://github.com/soutaro/steep/pull/373))
+* Do not crash when completion request `context` is missing ([#370](https://github.com/soutaro/steep/pull/370))
+* Update RBS ([#376](https://github.com/soutaro/steep/pull/376))
+
+## 0.43.1 (2021-04-01)
+
+* Fix LSP `textDocument/didSave` notification handling ([#368](https://github.com/soutaro/steep/issues/368))
+
+## 0.43.0 (2021-03-30)
+
+* LSP responsiveness improvements ([\#352](https://github.com/soutaro/steep/issues/352))
+* `@implements` annotation in blocks ([#338](https://github.com/soutaro/steep/issues/338))
+* Better `steep stats` table formatting ([\#300](https://github.com/soutaro/steep/issues/300))
+* Fix retry type checking ([\#293](https://github.com/soutaro/steep/issues/293))
+* Better tuple type checking ([\#328](https://github.com/soutaro/steep/issues/328))
+* Fix unexpected `add_call` error ([\#358](https://github.com/soutaro/steep/pull/358))
+* Ignore passing nil as a block `&nil` ([\#356](https://github.com/soutaro/steep/pull/356))
+* Better type checking for non-trivial block parameters ([\#354](https://github.com/soutaro/steep/pull/354))
+* Avoid unexpected error on splat assignments ([\#330](https://github.com/soutaro/steep/pull/330))
+* Fix constraint solver ([\#343](https://github.com/soutaro/steep/pull/343))
+* Ruby 2.7 compatible private method call typing ([\#344](https://github.com/soutaro/steep/pull/344))
+
+## 0.42.0 (2021-03-08)
+
+* Type checking performance improvement ([\#309](https://github.com/soutaro/steep/pull/309), [\#311](https://github.com/soutaro/steep/pull/311), [\#312](https://github.com/soutaro/steep/pull/312), [\#313](https://github.com/soutaro/steep/pull/313), [\#314](https://github.com/soutaro/steep/pull/314), [\#315](https://github.com/soutaro/steep/pull/315), [\#316](https://github.com/soutaro/steep/pull/316), [\#320](https://github.com/soutaro/steep/pull/320), [\#322](https://github.com/soutaro/steep/pull/322))
+* Let `watch` command support files ([\#323](https://github.com/soutaro/steep/pull/323))
+* Validate _module-self-type_ constraints ([\#308](https://github.com/soutaro/steep/pull/308))
+* Add `-j` option to specify number of worker processes ([\#318](https://github.com/soutaro/steep/pull/318), [\#325](https://github.com/soutaro/steep/pull/325))
+* Fix `code` of RBS diagnostics ([\#306](https://github.com/soutaro/steep/pull/306))
+* Skip printing source code from out of date _expectations_ file ([\#305](https://github.com/soutaro/steep/pull/305))
+
+## 0.41.0 (2021-02-07)
+
+* Add `--with-expectations` and `--save-expectations` option ([#303](https://github.com/soutaro/steep/pull/303))
+
 ## 0.40.0 (2021-01-31)
 
 * Report progress with dots ([#287](https://github.com/soutaro/steep/pull/287))

data/Gemfile

@@ -12,3 +12,4 @@ gem "racc", "~> 1.4"
 gem "minitest-reporters"
 gem "minitest-hooks"
 gem "stackprof"
+gem "rbs", git: "https://github.com/ruby/rbs.git"

data/bin/output_rebaseline.rb

@@ -9,41 +9,26 @@ else
   test_dirs = ARGV.map {|p| Pathname.pwd + p }
 end
 
-test_dirs.each do |dir|
-  test = dir + "test.yaml"
-
-  if test.file?
-    content = YAML.load_file(test)
-  else
-    content = { "test" => {} }
-  end
+failed_tests = []
 
+test_dirs.each do |dir|
   puts "Rebaselining #{dir}..."
 
-  command = content["command"] || "steep check"
-  puts "  command: #{command}"
-
-  output, _ = Open3.capture2(command, chdir: dir.to_s)
+  command = %w(steep check --save-expectations=test_expectations.yml)
+  puts "  command: #{command.join(" ")}"
 
-  diagnostics = output.split(/\n\n/).each.with_object({}) do |message, hash|
-    if message =~ /\A([^:]+):\d+:\d+:/
-      path = $1
-      hash[path] ||= { "diagnostics" => [] }
-      hash[path]["diagnostics"] << message.chomp + "\n"
-    end
-  end
+  output, status = Open3.capture2(*command, chdir: dir.to_s)
 
-  content["test"].each_key do |path|
-    unless diagnostics.key?(path)
-      diagnostics[path] = { "diagnostics" => [] }
-    end
-  end
-
-  content["test"] = diagnostics.keys.sort.each.with_object({}) do |key, hash|
-    hash[key] = diagnostics[key]
+  unless status.success?
+    puts "Error!!! 👺"
+    failed_tests << dir.basename
   end
+end
 
-  test.open("w") do |io|
-    YAML.dump(content, io, header: false)
-  end
+if failed_tests.empty?
+  puts "Successfully updated output expectations! 🤡"
+else
+  puts "Failed to update the following tests! 💀"
+  puts "  #{failed_tests.join(", ")}"
+  exit 1
 end

data/bin/output_test.rb

@@ -14,21 +14,33 @@ else
   test_dirs = ARGV.map {|p| Pathname.pwd + p }
 end
 
-success = true
+failed_tests = []
 
-test_dirs.each do |dir|
-  test = dir + "test.yaml"
-
-  next unless test.file?
+ALLOW_FAILURE = ["diagnostics-ruby-unsat"]
 
+test_dirs.each do |dir|
   puts "Running test #{dir}..."
 
-  content = YAML.load_file(test)
+  unless (dir + "test_expectations.yml").file?
+    puts "Skipped ⛹️‍♀️"
+    next
+  end
+
+  command = %w(steep check --with-expectations=test_expectations.yml)
+  puts "  command: #{command.join(" ")}"
 
-  command = content["command"] || "steep check"
-  puts "  command: #{command}"
+  output, status = Open3.capture2(*command, chdir: dir.to_s)
 
-  output, _ = Open3.capture2(command, chdir: dir.to_s)
+  unless status.success?
+    unless ALLOW_FAILURE.include?(dir.basename.to_s)
+      failed_tests << dir.basename
+      puts "  Failed! 🤕"
+    else
+      puts "  Failed! 🤕 (ALLOW_FAILURE)"
+    end
+  else
+    puts "  Succeed! 👍"
+  end
 
   if @verbose
     puts "  Raw output:"
@@ -36,58 +48,12 @@ test_dirs.each do |dir|
       puts "  > #{line.chomp}"
     end
   end
-
-  diagnostics = output.split(/\n\n/).each.with_object({}) do |d, hash|
-    if d =~ /\A([^:]+):\d+:\d+:/
-      path = $1
-      hash[path] ||= []
-      hash[path] << (d.chomp + "\n")
-    end
-  end
-
-  content["test"].each do |path, test|
-    puts "  Checking: #{path}..."
-
-    fail_expected = test["fail"] || false
-
-    expected_diagnostics = test["diagnostics"]
-    reported_diagnostics = (diagnostics[path] || [])
-
-    puts "    # of expected: #{expected_diagnostics.size}, # of reported: #{reported_diagnostics.size}"
-
-    unexpected_diagnostics = reported_diagnostics.reject {|d| expected_diagnostics.include?(d) }
-    missing_diagnostics = expected_diagnostics.reject {|d| reported_diagnostics.include?(d) }
-
-    unexpected_diagnostics.each do |d|
-      puts "    Unexpected diagnostics:"
-      d.split(/\n/).each do |line|
-        puts "      + #{line.chomp}"
-      end
-    end
-
-    missing_diagnostics.each do |d|
-      puts "    Missing diagnostics:"
-      d.split(/\n/).each do |line|
-        puts "      - #{line.chomp}"
-      end
-    end
-
-    if unexpected_diagnostics.empty? && missing_diagnostics.empty?
-      puts "    👍"
-    else
-      if fail_expected
-        puts "    🚨 (expected failure)"
-      else
-        puts "    🚨"
-        success = false
-      end
-    end
-  end
 end
 
-if success
+if failed_tests.empty?
   puts "All tests ok! 👏"
 else
   puts "Errors detected! 🤮"
+  puts "  #{failed_tests.join(", ")}"
   exit 1
 end

data/lib/steep.rb

@@ -2,8 +2,8 @@ require "steep/version"
 
 require "pathname"
 require "parser/ruby27"
-require "ast_utils"
 require "active_support/core_ext/object/try"
+require "active_support/core_ext/string/inflections"
 require "logger"
 require "active_support/tagged_logging"
 require "rainbow"
@@ -13,6 +13,11 @@ require "etc"
 require "open3"
 require "stringio"
 require 'uri'
+require "yaml"
+require "securerandom"
+
+require "parallel/processor_count"
+require "terminal-table"
 
 require "rbs"
 
@@ -84,25 +89,32 @@ require "steep/index/rbs_index"
 require "steep/index/signature_symbol_provider"
 require "steep/index/source_index"
 
-require "steep/server/utils"
+require "steep/server/change_buffer"
 require "steep/server/base_worker"
-require "steep/server/code_worker"
-require "steep/server/signature_worker"
 require "steep/server/worker_process"
 require "steep/server/interaction_worker"
+require "steep/server/type_check_worker"
 require "steep/server/master"
 
+require "steep/services/content_change"
+require "steep/services/path_assignment"
+require "steep/services/signature_service"
+require "steep/services/type_check_service"
+require "steep/services/hover_content"
+require "steep/services/completion_provider"
+require "steep/services/stats_calculator"
+require "steep/services/file_loader"
+require "steep/services/goto_service"
+
 require "steep/project"
-require "steep/project/signature_file"
-require "steep/project/source_file"
+require "steep/project/pattern"
 require "steep/project/options"
 require "steep/project/target"
 require "steep/project/dsl"
-require "steep/project/file_loader"
-require "steep/project/hover_content"
-require "steep/project/completion_provider"
-require "steep/project/stats_calculator"
+
+require "steep/expectations"
 require "steep/drivers/utils/driver_helper"
+require "steep/drivers/utils/jobs_count"
 require "steep/drivers/check"
 require "steep/drivers/stats"
 require "steep/drivers/validate"
@@ -130,7 +142,7 @@ module Steep
   def self.new_logger(output, prev_level)
     ActiveSupport::TaggedLogging.new(Logger.new(output)).tap do |logger|
       logger.push_tags "Steep #{VERSION}"
-      logger.level = prev_level || Logger::WARN
+      logger.level = prev_level || Logger::ERROR
     end
   end
 
@@ -147,18 +159,80 @@ module Steep
   @logger = nil
   self.log_output = STDERR
 
-  def self.measure(message)
+  def self.measure(message, level: :warn)
     start = Time.now
     yield.tap do
       time = Time.now - start
-      self.logger.info "#{message} took #{time} seconds"
+      if level.is_a?(Symbol)
+        level = Logger.const_get(level.to_s.upcase)
+      end
+      self.logger.log(level) { "#{message} took #{time} seconds" }
     end
   end
 
   def self.log_error(exn, message: "Unexpected error: #{exn.inspect}")
-    Steep.logger.error message
+    Steep.logger.fatal message
     exn.backtrace.each do |loc|
-      Steep.logger.warn "  #{loc}"
+      Steep.logger.error "  #{loc}"
+    end
+  end
+
+  class Sampler
+    def initialize()
+      @samples = []
+    end
+
+    def sample(message)
+      start = Time.now
+      yield.tap do
+        time = Time.now - start
+        @samples << [message, time]
+      end
+    end
+
+    def count
+      @samples.count
+    end
+
+    def total
+      @samples.sum(&:last)
     end
+
+    def slowests(num)
+      @samples.sort_by(&:last).reverse.take(num)
+    end
+
+    def average
+      if count > 0
+        total/count
+      else
+        0
+      end
+    end
+
+    def percentile(p)
+      slowests(count - count * p / 100r).last&.last || 0
+    end
+  end
+
+  def self.measure2(message, level: :warn)
+    sampler = Sampler.new
+    result = yield(sampler)
+
+    if level.is_a?(Symbol)
+      level = Logger.const_get(level.to_s.upcase)
+    end
+    logger.log(level) { "#{sampler.total}secs for \"#{message}\"" }
+    logger.log(level) { "  Average: #{sampler.average}secs"}
+    logger.log(level) { "  Median: #{sampler.percentile(50)}secs"}
+    logger.log(level) { "  Samples: #{sampler.count}"}
+    logger.log(level) { "  99 percentile: #{sampler.percentile(99)}secs"}
+    logger.log(level) { "  90 percentile: #{sampler.percentile(90)}secs"}
+    logger.log(level) { "  10 Slowests:"}
+    sampler.slowests(10).each do |message, time|
+      logger.log(level) { "    #{message} (#{time}secs)"}
+    end
+
+    result
   end
 end

data/lib/steep/annotation_parser.rb

@@ -23,7 +23,15 @@ module Steep
       def initialize(source:, location:, exn: nil)
         @source = source
         @location = location
-        super "Syntax error on annotation: `#{source}`, cause=#{exn.inspect}"
+
+        message = case exn
+                  when RBS::Parser::SyntaxError
+                    Diagnostic::Signature::SyntaxError.parser_syntax_error_message(exn)
+                  else
+                    exn.message
+                  end
+
+        super message
       end
     end
 
@@ -158,7 +166,7 @@ module Steep
         end
       end
 
-    rescue RBS::Parser::SyntaxError, RBS::Parser::SemanticsError => exn
+    rescue RBS::ParsingError => exn
       raise SyntaxError.new(source: src, location: location, exn: exn)
     end
   end

data/lib/steep/ast/types/class.rb

@@ -8,6 +8,10 @@ module Steep
           @location = location
         end
 
+        def to_s
+          "class"
+        end
+
         def ==(other)
           other.is_a?(Class)
         end

data/lib/steep/cli.rb

@@ -8,6 +8,8 @@ module Steep
     attr_reader :stderr
     attr_reader :command
 
+    include Parallel::ProcessorCount
+
     def initialize(stdout:, stdin:, stderr:, argv:)
       @stdout = stdout
       @stdin = stdin
@@ -51,19 +53,27 @@ module Steep
     end
 
     def handle_logging_options(opts)
-      opts.on("--log-level=[debug,info,warn,error,fatal]") do |level|
+      opts.on("--log-level=LEVEL", "Specify log level: debug, info, warn, error, fatal") do |level|
         Steep.logger.level = level
       end
 
-      opts.on("--log-output=[PATH]") do |file|
+      opts.on("--log-output=PATH", "Print logs to given path") do |file|
         Steep.log_output = file
       end
 
-      opts.on("--verbose") do
+      opts.on("--verbose", "Set log level to debug") do
         Steep.logger.level = Logger::DEBUG
       end
     end
 
+    def handle_jobs_option(command, opts, modifier = 0)
+      default = physical_processor_count + modifier
+      command.jobs_count = default
+      opts.on("-j N", "--jobs=N", "Specify the number of type check workers (defaults: #{default})") do |count|
+        command.jobs_count = Integer(count)
+      end
+    end
+
     def process_init
       Drivers::Init.new(stdout: stdout, stderr: stderr).tap do |command|
         OptionParser.new do |opts|
@@ -83,6 +93,13 @@ module Steep
           opts.banner = "Usage: steep check [options] [sources]"
 
           opts.on("--steepfile=PATH") {|path| check.steepfile = Pathname(path) }
+          opts.on("--with-expectations[=PATH]", "Type check with expectations saved in PATH (or steep_expectations.yml)") do |path|
+            check.with_expectations_path = Pathname(path || "steep_expectations.yml")
+          end
+          opts.on("--save-expectations[=PATH]", "Save expectations with current type check result to PATH (or steep_expectations.yml)") do |path|
+            check.save_expectations_path = Pathname(path || "steep_expectations.yml")
+          end
+          handle_jobs_option check, opts
           handle_logging_options opts
         end.parse!(argv)
 
@@ -96,6 +113,8 @@ module Steep
           opts.banner = "Usage: steep stats [options] [sources]"
 
           opts.on("--steepfile=PATH") {|path| check.steepfile = Pathname(path) }
+          opts.on("--format=FORMAT", "Specify output format: csv, table") {|format| check.format = format }
+          handle_jobs_option check, opts
           handle_logging_options opts
         end.parse!(argv)
 
@@ -136,10 +155,12 @@ module Steep
       Drivers::Watch.new(stdout: stdout, stderr: stderr).tap do |command|
         OptionParser.new do |opts|
           opts.banner = "Usage: steep watch [options] [dirs]"
+          handle_jobs_option command, opts
           handle_logging_options opts
         end.parse!(argv)
 
-        command.dirs.push *argv
+        dirs = argv.map {|dir| Pathname(dir) }
+        command.dirs.push(*dirs)
       end.run
     end
 
@@ -147,6 +168,7 @@ module Steep
       Drivers::Langserver.new(stdout: stdout, stderr: stderr, stdin: stdin).tap do |command|
         OptionParser.new do |opts|
           opts.on("--steepfile=PATH") {|path| command.steepfile = Pathname(path) }
+          handle_jobs_option command, opts, -1
           handle_logging_options opts
         end.parse!(argv)
       end.run
@@ -179,12 +201,15 @@ module Steep
           handle_logging_options opts
 
           opts.on("--interaction") { command.worker_type = :interaction }
-          opts.on("--code") { command.worker_type = :code }
-          opts.on("--signature") { command.worker_type = :signature }
+          opts.on("--typecheck") { command.worker_type = :typecheck }
           opts.on("--steepfile=PATH") {|path| command.steepfile = Pathname(path) }
           opts.on("--name=NAME") {|name| command.worker_name = name }
           opts.on("--delay-shutdown") { command.delay_shutdown = true }
+          opts.on("--max-index=COUNT") {|count| command.max_index = Integer(count) }
+          opts.on("--index=INDEX") {|index| command.index = Integer(index) }
         end.parse!(argv)
+
+        command.commandline_args.push(*argv)
       end.run
     end
   end