stbaldricks 6.13.0 → 6.13.1.alpha.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e41bd59dba8f3a1d54f3b85f4f972ac5787e84798f7df480e06478590c9f43d8
-  data.tar.gz: cedf05e63ca11292a9c32b842c36db04498794f9ffdd5a3e60de4631fb67edfe
+  metadata.gz: f160e1af1de76369152c9dbf97bcbdacfd37ccf464ba6f5d3cd9aa59bf5c5551
+  data.tar.gz: 42e01f776af7d02f1399d55b5d24c351b1cc895b0ac027bb45a684160a16ad5a
 SHA512:
-  metadata.gz: 5439676617f24fc6670c5e02f3795efee84aaba9f0119273824631529fc9dd0dfd18a21b55bbd13a6ca667e4fe5f5988b967f39969a114d6b02c92eb504de425
-  data.tar.gz: f05fe0663d23ade5387c6b3e29ff439701f0701eaa2e6d018a55ae0a1de9278f28580b2c3b72a966bbef6f18b94080bebe13e4e667684f62a874264461fd2146
+  metadata.gz: f27bf1e1e37bcb2c8578797d30009c9a2209f9c2b564f3566d2c9bbd70036c538e681d018346276ccbc1ef30518de977b92d33fac47a3693b1b3dbcbd5619a36
+  data.tar.gz: 0b2d540ae40eccf875d621e6a4b149cafdbe719ccec44f0318108e534d412ccbc515b23ff922c98d17abc046057aabff0fb999e28a91215880c85e03ad92c1ed

data/lib/stbaldricks/configuration.rb

@@ -28,8 +28,9 @@ module SBF
       end
 
       def self.logger=(new_logger)
-        missing_methods = SBF::Client::LOG::REQUIRED_METHODS.select { |method| !new_logger.respond_to?(method) }
+        missing_methods = SBF::Client::LOG::REQUIRED_METHODS.reject { |method| new_logger.respond_to?(method) }
         raise SBF::Client::Configuration::Error.new('logger', "must respond to: #{missing_methods.join(', ')}") unless missing_methods.empty?
+
         @_logger = new_logger
       end
 

data/lib/stbaldricks/endpoints/event.rb

@@ -10,10 +10,12 @@ module SBF
       def save(entity_or_hash, with = {})
         if entity_or_hash.is_a?(SBF::Client::BaseEntity)
           return create(entity_or_hash, with) if entity_or_hash.id.nil?
-          return update(entity_or_hash.id, entity_or_hash.year, entity_or_hash.dirty_data, with)
+
+          update(entity_or_hash.id, entity_or_hash.year, entity_or_hash.dirty_data, with)
         else
           return create(entity_or_hash, with) if entity_or_hash[:id].nil?
-          return update(entity_or_hash[:id], entity_or_hash[:year], entity_or_hash, with)
+
+          update(entity_or_hash[:id], entity_or_hash[:year], entity_or_hash, with)
         end
       end
 

data/lib/stbaldricks/endpoints/facebook/user.rb

@@ -14,9 +14,9 @@ module SBF
         # @return [string]
         def login!(authorization_code, redirect_uri)
           response = SBF::Client::Api::Request.post_request(
-              "/#{SBF::Client::Api::VERSION}/security/facebook/login",
-              authorization_code: authorization_code,
-              redirect_uri: redirect_uri
+            "/#{SBF::Client::Api::VERSION}/security/facebook/login",
+            authorization_code: authorization_code,
+            redirect_uri: redirect_uri
           )
           parsed_response = JSON.parse(response.body).symbolize!
 

data/lib/stbaldricks/endpoints/kid_honor.rb

@@ -6,9 +6,7 @@ module SBF
       def delete(params)
         response = SBF::Client::Api::Request.post_request("#{base_uri}/delete", params)
 
-        unless ok?(response)
-          error = SBF::Client::ErrorEntity.new(JSON.parse(response.body).symbolize!)
-        end
+        error = SBF::Client::ErrorEntity.new(JSON.parse(response.body).symbolize!) unless ok?(response)
 
         SBF::Client::Api::Response.new(http_code: response.code, data: nil, error: error)
       end

data/lib/stbaldricks/endpoints/kid_institution.rb

@@ -6,9 +6,7 @@ module SBF
       def delete(params)
         response = SBF::Client::Api::Request.post_request("#{base_uri}/delete", params)
 
-        unless ok?(response)
-          error = SBF::Client::ErrorEntity.new(JSON.parse(response.body).symbolize!)
-        end
+        error = SBF::Client::ErrorEntity.new(JSON.parse(response.body).symbolize!) unless ok?(response)
 
         SBF::Client::Api::Response.new(http_code: response.code, data: nil, error: error)
       end

data/lib/stbaldricks/endpoints/lib/entity.rb

@@ -21,10 +21,12 @@ module SBF
       def save(entity_or_hash, with = {})
         if entity_or_hash.is_a?(SBF::Client::BaseEntity)
           return create(entity_or_hash, with) if entity_or_hash.id.nil?
-          return update(entity_or_hash.id, entity_or_hash, with)
+
+          update(entity_or_hash.id, entity_or_hash, with)
         else
           return create(entity_or_hash, with) if entity_or_hash[:id].nil?
-          return update(entity_or_hash[:id], entity_or_hash, with)
+
+          update(entity_or_hash[:id], entity_or_hash, with)
         end
       end
 
@@ -77,7 +79,7 @@ module SBF
 
         if ok?(response)
           hydrated_entity(response, {}, nil)
-        elsif (response.code == 404)
+        elsif response.code == 404
           nil
         else
           parsed_response_body = JSON.parse(response.body).symbolize!
@@ -139,9 +141,7 @@ module SBF
       def delete(id)
         response = SBF::Client::Api::Request.post_request("#{base_uri}/delete/#{id}")
 
-        unless ok?(response)
-          error = SBF::Client::ErrorEntity.new(JSON.parse(response.body).symbolize!)
-        end
+        error = SBF::Client::ErrorEntity.new(JSON.parse(response.body).symbolize!) unless ok?(response)
 
         SBF::Client::Api::Response.new(http_code: response.code, data: nil, error: error)
       end
@@ -193,6 +193,7 @@ module SBF
         entity_class = klass.send(entity_class_selector_method, value)
 
         return nil if entity_class == NilClass
+
         entity_class.nil? ? value : sanitize(value, entity_class)
       end
       private :sanitize_entity
@@ -223,6 +224,7 @@ module SBF
       end
       private :normalize_with
 
+      # rubocop:disable IdenticalConditionalBranches
       def hydrated_entity(response, data, entity_or_hash)
         parsed_response_body = JSON.parse(response.body).symbolize!
 
@@ -256,6 +258,7 @@ module SBF
         end
       end
       private :hydrated_entity
+      # rubocop:enable IdenticalConditionalBranches
     end
   end
 end

data/lib/stbaldricks/endpoints/participant.rb

@@ -22,7 +22,8 @@ module SBF
           new_team_id: 0,
           team_name: team_name,
           goal: fundraising_goal,
-          how_created: SBF::Client::Team::HowCreated::WEBSITE)
+          how_created: SBF::Client::Team::HowCreated::WEBSITE
+        )
 
         if ok?(response)
           data =  SBF::Client::FullParticipant.new(JSON.parse(response.body).symbolize!)

data/lib/stbaldricks/endpoints/photo.rb

@@ -23,8 +23,8 @@ module SBF
         if entity_or_hash.is_a?(SBF::Client::BaseEntity)
           # If someone has passed in an entity, just convert it to a hash
           data = entity_or_hash.dirty_data
-          data.merge!(id: id) unless id.nil?
-          data.merge!(id: entity_or_hash.id) if id.nil? && !entity_or_hash.id.nil?
+          data[:id] = id unless id.nil?
+          data[:id] = entity_or_hash.id if id.nil? && !entity_or_hash.id.nil?
         elsif entity_or_hash.is_a?(Hash)
           # If someone has passed in a hash, make sure all of it's values match fields in the entity class
           data = sanitize(entity_or_hash)
@@ -48,7 +48,7 @@ module SBF
 
       def upload(image_data_url, data = {}, with = {})
         # support image formats: png, jpeg, gif
-        image_data_url.slice!(/data:image\/(png|jpeg|gif);base64,/)
+        image_data_url.slice!(%r{data:image/(png|jpeg|gif);base64,})
         image_data = Base64.decode64(image_data_url)
 
         Tempfile.create('photo_upload') do |file|
@@ -66,11 +66,11 @@ module SBF
       def photo_for_upload(file, data)
         if data.is_a?(SBF::Client::Photo)
           data.file = file
-          return data
+          data
         else
           photo = SBF::Client::Photo.new(data.is_a?(Hash) && data.any? ? data : {})
           photo.file = file
-          return photo
+          photo
         end
       end
     end

data/lib/stbaldricks/endpoints/search.rb

@@ -28,7 +28,8 @@ module SBF
         geo_location = geo_location.to_json unless geo_location.empty?
 
         # Build the parameter list for search
-        params, response_data = {}, {}
+        params = {}
+        response_data = {}
         {model_type: model_type, search_text: search_text, filters: filters, geo_location: geo_location}.each do |k, v|
           params[k.to_sym] = v unless v.empty?
         end

data/lib/stbaldricks/endpoints/user.rb

@@ -59,7 +59,7 @@ module SBF
       #
       # @raise [SBFClientError]
       def change_password(profile_id, password)
-        raise SBF::Client::Error, 'User not logged in' if  SBF::Client::Configuration.user_token.nil?
+        raise SBF::Client::Error, 'User not logged in' if SBF::Client::Configuration.user_token.nil?
 
         response = SBF::Client::Api::Request.post_request(
           "/#{SBF::Client::Api::VERSION}/security/change_password",
@@ -81,17 +81,16 @@ module SBF
       #
       # @raise [SBFClientError]
       def disconnect_facebook(profile_id)
-        raise SBF::Client::Error, 'User not logged in' if  SBF::Client::Configuration.user_token.nil?
+        raise SBF::Client::Error, 'User not logged in' if SBF::Client::Configuration.user_token.nil?
 
         response = SBF::Client::Api::Request.post_request(
           "/#{SBF::Client::Api::VERSION}/user/disconnect_facebook",
           profile_id: profile_id
         )
 
-        if ok?(response)
-          SBF::Client::Configuration.user_token = nil
-        else
-          SBF::Client::Configuration.user_token = nil
+        SBF::Client::Configuration.user_token = nil
+
+        unless ok?(response)
           parsed_response = JSON.parse(response.body).symbolize!
           error = SBF::Client::ErrorEntity.new(parsed_response)
         end

data/lib/stbaldricks/entities/concerns/entity_response_concern.rb

@@ -16,7 +16,7 @@ module EntityResponseConcern
     end
     errors.instance_variable_set(:@code, error.code)
     errors.instance_variable_set(:@type, error.type)
-    errors.add(:base, "#{error.type}: #{error.details}") if count == 0
+    errors.add(:base, "#{error.type}: #{error.details}") if count&.zero?
   end
 
   def errors_http_code=(http_code)
@@ -32,7 +32,7 @@ module EntityResponseConcern
   end
 
   def errors?
-    errors.count > 0
+    errors.count.positive?
   end
 
   ############ Deprecated Methods ############
@@ -52,6 +52,7 @@ module EntityResponseConcern
   def single_active_model_error
     return if errors.empty?
     return [:base, errors[:base].first] if errors[:base].any?
+
     errors.first
   end
 

data/lib/stbaldricks/entities/concerns/event_year_concern.rb

@@ -5,6 +5,7 @@ module EventYearConcern
 
   def event_year
     return year if is_a?(SBF::Client::Event)
+
     event.year
   end
 end

data/lib/stbaldricks/entities/concerns/venue_concern.rb

@@ -4,6 +4,6 @@ module VenueConcern
   extend ActiveSupport::Concern
 
   def venue_address
-    venue && venue.location && venue.location.address
+    venue&.location&.address
   end
 end

data/lib/stbaldricks/entities/config.rb

@@ -21,6 +21,7 @@ module SBF
       #NOTE: If you add another attribute, be sure to mock it out in `configure :test` of app.rb
 
       # Attempts to call the method on the cached configuration object
+      # rubocop:disable Style/MethodMissingSuper, Style/MissingRespondToMissing
       def self.method_missing(method_name, *arguments, &block)
         # The first time a missing method is called, call reload to make sure the instance has been populated
         unless @_loaded
@@ -29,12 +30,11 @@ module SBF
         end
 
         # If the method being called exists on the instance, call it. Otherwise forward the request on to 'super'.
-        if instance.respond_to?(method_name)
-          return instance.send(method_name)
-        else
-          super(method_name, *arguments, &block)
-        end
+        return instance.send(method_name) if instance.respond_to?(method_name)
+
+        super(method_name, *arguments, &block)
       end
+      # rubocop:enable Style/MethodMissingSuper, Style/MissingRespondToMissing
     end
   end
 end

data/lib/stbaldricks/entities/donation.rb

@@ -214,20 +214,16 @@ module SBF
             state_value = state.to_s.upcase.to_sym
             if !state_value.empty? && SBF::Client::Donation::SpecialDonationType.const_defined?(state_value)
               return SBF::Client::Donation::SpecialDonationType.const_get(state_value)
-
-            else
-              return SBF::Client::Donation::SpecialDonationType::NO_STATE
             end
 
+            return SBF::Client::Donation::SpecialDonationType::NO_STATE
           else
             international_value = "INT_#{country}".upcase.to_sym
             if SBF::Client::Donation::SpecialDonationType.const_defined?(international_value)
               return SBF::Client::Donation::SpecialDonationType.const_get(international_value)
-
-            else
-              return SBF::Client::Donation::SpecialDonationType::INTERNATIONAL
-
             end
+
+            return SBF::Client::Donation::SpecialDonationType::INTERNATIONAL
           end
         end
 
@@ -256,16 +252,16 @@ module SBF
           return [country, state]
 
         when SBF::Client::Participant
-          return get_event_country_and_state_for_special_donation_type(entity.event, entity.person)
+          get_event_country_and_state_for_special_donation_type(entity.event, entity.person)
 
         when SBF::Client::Fundraiser
-          return [entity.venue.location.address.country, entity.venue.location.address.state]
+          [entity.venue.location.address.country, entity.venue.location.address.state]
 
         when SBF::Client::Team
-          return get_event_country_and_state_for_special_donation_type(entity.event)
+          get_event_country_and_state_for_special_donation_type(entity.event)
 
         when SBF::Client::Event
-          return get_event_country_and_state_for_special_donation_type(entity)
+          get_event_country_and_state_for_special_donation_type(entity)
 
         end
       end

data/lib/stbaldricks/entities/fund.rb

@@ -75,12 +75,15 @@ module SBF
       attr_accessor :offline_donation_uuid, :offline_donation_form
 
       def totals_by_year=(value)
-        return [] if value.nil? || value.empty?
+        if value.nil? || value.empty?
+          @totals_by_year = []
+          return
+        end
 
         totals_by_year_will_change!
-        @totals_by_year = value.map { |k, v|
+        @totals_by_year = value.map do |k, v|
           SBF::Client::Fund::YearlyTotals.new(v.merge(year: k.to_s.to_i))
-        }
+        end
       end
 
       def to_hash

data/lib/stbaldricks/entities/fundraiser.rb

@@ -145,6 +145,7 @@ module SBF
 
       def past?
         return Date.today > Date.parse(end_date) if end_date
+
         Date.today > Date.parse(start_date) if start_date
       rescue
         nil

data/lib/stbaldricks/entities/lib/base.rb

@@ -1,5 +1,5 @@
 # Require all monkey patches
-patch_dir = File.expand_path('../../../patches', __FILE__)
+patch_dir = File.expand_path('../../patches', __dir__)
 Dir["#{patch_dir}/*.rb"].each { |file| require file }
 
 require 'set'
@@ -79,17 +79,19 @@ module SBF
         changes.each { |k, arr| data[k.to_sym] = arr[1] }
 
         instance_variables.each do |var|
-          attribute_symbol = var.to_s.gsub('@', '').to_sym
+          attribute_symbol = var.to_s.delete('@').to_sym
           attribute = instance_variable_get(var)
           if attribute.is_a?(BaseEntity)
             if attribute.dirty_data(true).empty?
               next unless changed.map(&:to_sym).include?(attribute_symbol)
+
               data.merge!(attribute_symbol => attribute.keys_hash)
             else
               data.merge!(attribute_symbol => attribute.dirty_data(true))
             end
           elsif attribute.is_a?(Array)
             next unless attribute.all? { |e| e.is_a?(BaseEntity) } && attribute.any? { |e| !e.dirty_data(true).empty? }
+
             data.merge!(attribute_symbol => attribute)
           end
         end
@@ -114,11 +116,9 @@ module SBF
           if respond_to?(setter, true)
             send(setter, value)
 
-          else
-            if respond_to?(key.to_sym)
-              instance_variable_set("@#{key}".to_sym, value)
-              attribute_will_change!(key.to_sym)
-            end
+          elsif respond_to?(key.to_sym)
+            instance_variable_set("@#{key}".to_sym, value)
+            attribute_will_change!(key.to_sym)
           end
         end
 
@@ -364,6 +364,7 @@ module SBF
         vars.each do |attribute|
           split_attribute = attribute.to_s.split('is_')
           next if split_attribute.length <= 1
+
           define_method(:"#{split_attribute.last}?") { send(attribute) }
           define_changing_attr_methods(attribute, true) if setter
         end
@@ -371,9 +372,11 @@ module SBF
       private_class_method :add_boolean_methods
 
       def self.define_changing_attr_methods(attribute, is_boolean = false, define_reader = false)
-        define_method(:"#{attribute}") do
-          instance_variable_get("@#{attribute}".to_sym)
-        end if define_reader
+        if define_reader
+          define_method(:"#{attribute}") do
+            instance_variable_get("@#{attribute}".to_sym)
+          end
+        end
 
         define_method(:"#{attribute}=") do |val|
           send(:"#{attribute}_will_change!") unless val == instance_variable_get("@#{attribute}".to_sym) && !val.nil?
@@ -451,9 +454,7 @@ module SBF
       def self.get_mappings(attribute, class_mappings)
         # Parse the mappings information and save it off
         mapping_var = :"@#{attribute}_class_mappings"
-        unless instance_variable_defined?(mapping_var)
-          instance_variable_set(mapping_var, parse_class_mappings(class_mappings))
-        end
+        instance_variable_set(mapping_var, parse_class_mappings(class_mappings)) unless instance_variable_defined?(mapping_var)
 
         instance_variable_get(mapping_var)
       end
@@ -523,6 +524,7 @@ module SBF
         define_method(:"#{attribute}=") do |values|
           values ||= []
           raise SBF::Client::Error, "#{attribute} must be an array" unless values.is_a?(Array)
+
           converted_collection = values.map { |value| convert_value(attribute, value) }
           instance_variable_set(:"@#{attribute}", converted_collection)
           send(:"#{attribute}_will_change!") if respond_to?(:"#{attribute}_will_change!")
@@ -544,28 +546,26 @@ module SBF
           value = send(key)
 
           # If the value is an Entity, call to_hash on it (recursively)
-          if value.is_a?(BaseEntity)
-            entity_hash[key] = value.to_hash
-
-          # If the value is an Array, need to try to call to_hash on each item
-          elsif value.is_a?(Array)
-            entity_hash[key] = value.map { |element|
-              if element.is_a?(BaseEntity)
-                next element.to_hash
-              else
-                next element
-              end
-            }
+          entity_hash[key] = if value.is_a?(BaseEntity)
+                               value.to_hash
 
-          # Collections should return empty array rather than nil
-          elsif value.nil? && self.class.collection_attributes.include?(key)
-            entity_hash[key] = []
+                             # If the value is an Array, need to try to call to_hash on each item
+                             elsif value.is_a?(Array)
+                               value.map { |element|
+                                 next element.to_hash if element.is_a?(BaseEntity)
 
-          # Just set the value
-          else
-            entity_hash[key] = value
+                                 next element
+                               }
 
-          end
+                             # Collections should return empty array rather than nil
+                             elsif value.nil? && self.class.collection_attributes.include?(key)
+                               []
+
+                             # Just set the value
+                             else
+                               value
+
+                             end
         }
 
         # Return the hash
@@ -590,6 +590,7 @@ module SBF
       def error
         log_deprecated('error', caller)
         return nil if single_active_model_error.nil?
+
         details = single_active_model_error.find { |x| x.is_a?(String) } if single_active_model_error.is_a?(Array)
         details ||= single_active_model_error.is_a?(String) ? single_active_model_error : nil
         field = single_active_model_error.is_a?(Array) ? single_active_model_error.find { |x| x.is_a?(Symbol) && x != :base } : nil

data/lib/stbaldricks/entities/lib/cacheable.rb

@@ -27,6 +27,7 @@ module SBF
             id = @cache_id_proc.call(proc_or_hash || {}) if @cache_id_proc
             id ||= superclass.cache_id_from_hash(proc_or_hash || {}) if superclass.respond_to?(:cache_id_from_hash)
             raise CacheableInvalidDataError, "Data missing id. Data: #{proc_or_hash.to_json}" unless id
+
             id
           end
 
@@ -34,6 +35,7 @@ module SBF
 
           def cache_id_from_hash_func(proc)
             raise ArgumentError, "Unable to re-set cache_id_from_hash on #{name}" if @cache_id_proc
+
             @cache_id_proc = proc
           end
         end

data/lib/stbaldricks/entities/lib/collection.rb

@@ -19,6 +19,7 @@ module SBF
       def error
         log_deprecated('error', caller)
         return nil if single_active_model_error.nil?
+
         details = single_active_model_error.find { |x| x.is_a?(String) } if single_active_model_error.is_a?(Array)
         details ||= single_active_model_error.is_a?(String) ? single_active_model_error : ''
         details = details["#{errors.type}: ".length..(details.length - 1)] if details.start_with?("#{errors.type}: ")
@@ -26,13 +27,16 @@ module SBF
         SBF::Client::ErrorEntity.new(code: errors.code, type: errors.type, details: details)
       end
 
+      # rubocop:disable MultipleComparison
       def [](*args)
         log_deprecated('[]', caller) if args == [:results] || args == [:total_count]
         return self if args == [:results]
         return @total_count if args == [:total_count]
+
         result = super
         result.is_a?(Array) ? self.class.new(result, total_count) : result
       end
+      # rubocop:enable MultipleComparison
     end
   end
 end

data/lib/stbaldricks/entities/lib/not_implemented_object.rb

@@ -16,10 +16,13 @@ module SBF
         super
       end
 
+      # rubocop:disable Style/MissingRespondToMissing
       def method_missing(name)
         return @props[name.to_sym] if @props.key?(name.to_sym)
+
         super.method_missing(name)
       end
+      # rubocop:enable Style/MissingRespondToMissing
 
       def to_hash
         {}.tap do |hsh|

data/lib/stbaldricks/entities/lib/permissions.rb

@@ -8,6 +8,7 @@ module SBF
       attr_accessor :is_owner
       attr_accessor :permission_ids
 
+      # rubocop:disable Style/MissingRespondToMissing
       def method_missing(method, *arguments, &block)
         # If the method starts with 'can', assume they are trying to determine if the user has the permission
         # in their list of permission ids and return the result
@@ -23,6 +24,7 @@ module SBF
 
         super
       end
+      # rubocop:enable Style/MissingRespondToMissing
     end
 
     class PermissionsAtEvent < SBF::Client::BaseEntity

data/lib/stbaldricks/entities/lib/phone.rb

@@ -15,6 +15,7 @@ module SBF
       # (402)555-5555 --> tel:4025555555
       def format_href
         return 'tel:' + number.gsub(/\D/, '') unless number.nil?
+
         number
       end
 
@@ -22,6 +23,7 @@ module SBF
       # (402)555-5555 ext. 5555 --> 402.555.555 x5555
       def format_number
         return number.gsub(/\D/, '').gsub(/(\d{3})(\d{3})(\d{4})(\d*)/, '\1.\2.\3 x\4').gsub(/x$/, '').rstrip unless number.nil?
+
         number
       end
     end

data/lib/stbaldricks/entities/lib/top_level.rb

@@ -21,6 +21,7 @@ module SBF
 
         def endpoint(mod = nil, options = {})
           return define_endpoint(mod, options) if mod
+
           _endpoint
         end
 

data/lib/stbaldricks/entities/person.rb

@@ -100,7 +100,8 @@ module SBF
           check_date = DateTime.parse(check_date) if check_date.is_a?(String)
           check_date = DateTime.parse(check_date.to_s) if check_date.is_a?(Date)
           check_date = DateTime.parse(check_date.strftime('%d/%m/%Y %H:%M:%S')) if check_date.is_a?(Time)
-          background_check_date && check_date.is_a?(DateTime) && background_check_date > check_date.prev_year(SBF::Client::Person::Policies::BACKGROUND_CHECK_YEARS_VALID)
+          background_check_date && check_date.is_a?(DateTime) \
+                                && background_check_date > check_date.prev_year(SBF::Client::Person::Policies::BACKGROUND_CHECK_YEARS_VALID)
         end
       end
 
@@ -373,6 +374,7 @@ module SBF
         when SBF::Client::LeagueStatus::BARON
           'Baron of the Brave'
         when SBF::Client::LeagueStatus::NOT_APPLICABLE
+          ''
         end
       end
     end

data/lib/stbaldricks/entities/photo.rb

@@ -34,55 +34,55 @@ module SBF
       attr_accessor :file
       attr_accessor :filename
       multitype_attr_accessor(
-          :model,
+        :model,
+        [
           [
-            [
-              ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::PARTICIPANT },
-              'SBF::Client::Photo::FullParticipant',
-              'SBF::Client::Photo::PartialParticipant'
-            ],
-            [
-              ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::FUNDRAISER },
-              'SBF::Client::Photo::FullFundraiser',
-              'SBF::Client::Photo::PartialFundraiser'
-            ],
-            [
-              ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::FUND },
-              'SBF::Client::Photo::FullFund',
-              'SBF::Client::Photo::PartialFund'
-            ],
-            [
-              ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::CAMPAIGN },
-              'SBF::Client::Photo::FullCampaign',
-              'SBF::Client::Photo::PartialCampaign'
-            ],
-            [
-              ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::TEAM },
-              'SBF::Client::Photo::FullTeam',
-              'SBF::Client::Photo::PartialTeam'
-            ],
-            [
-              ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::EVENT },
-              'SBF::Client::Photo::FullEvent',
-              'SBF::Client::Photo::PartialEvent'
-            ],
-            [
-              ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::KID },
-              'SBF::Client::Photo::FullKid',
-              'SBF::Client::Photo::PartialKid'
-            ],
-            [
-              ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::EVENT_SUPPORTER },
-              'SBF::Client::Photo::FullEventSupporter',
-              'SBF::Client::Photo::PartialEventSupporter'
-            ],
-            [
-              ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::MEMORIAL },
-              'SBF::Client::Photo::FullMemorial',
-              'SBF::Client::Photo::PartialMemorial'
-            ]
+            ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::PARTICIPANT },
+            'SBF::Client::Photo::FullParticipant',
+            'SBF::Client::Photo::PartialParticipant'
           ],
-          optional: false
+          [
+            ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::FUNDRAISER },
+            'SBF::Client::Photo::FullFundraiser',
+            'SBF::Client::Photo::PartialFundraiser'
+          ],
+          [
+            ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::FUND },
+            'SBF::Client::Photo::FullFund',
+            'SBF::Client::Photo::PartialFund'
+          ],
+          [
+            ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::CAMPAIGN },
+            'SBF::Client::Photo::FullCampaign',
+            'SBF::Client::Photo::PartialCampaign'
+          ],
+          [
+            ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::TEAM },
+            'SBF::Client::Photo::FullTeam',
+            'SBF::Client::Photo::PartialTeam'
+          ],
+          [
+            ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::EVENT },
+            'SBF::Client::Photo::FullEvent',
+            'SBF::Client::Photo::PartialEvent'
+          ],
+          [
+            ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::KID },
+            'SBF::Client::Photo::FullKid',
+            'SBF::Client::Photo::PartialKid'
+          ],
+          [
+            ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::EVENT_SUPPORTER },
+            'SBF::Client::Photo::FullEventSupporter',
+            'SBF::Client::Photo::PartialEventSupporter'
+          ],
+          [
+            ->(v) { v[:model_type] == SBF::Client::Photo::ModelType::MEMORIAL },
+            'SBF::Client::Photo::FullMemorial',
+            'SBF::Client::Photo::PartialMemorial'
+          ]
+        ],
+        optional: false
       )
       attr_accessor :base_photo_url
       attr_reader :original_file_id

data/lib/stbaldricks/entities/team.rb

@@ -11,7 +11,7 @@ require 'stbaldricks/entities/concerns/fundraising_page_concern'
 
 module SBF
   module Client
-    class Team  < SBF::Client::TopLevelEntity
+    class Team < SBF::Client::TopLevelEntity
       include Entities::DefaultCacheable
       include DonationRecipientConcern
       include EventYearConcern

data/lib/stbaldricks/log.rb

@@ -8,9 +8,11 @@ module SBF
 
       REQUIRED_METHODS = [:debug, :info, :warn, :error, :fatal, :unknown, :add, :level]
 
+      # rubocop:disable Style/MethodMissingSuper, Style/MissingRespondToMissing
       def self.method_missing(sym, *args, &block)
         SBF::Client::Configuration.logger.send(sym, *args, &block)
       end
+      # rubocop:enable Style/MethodMissingSuper, Style/MissingRespondToMissing
     end
   end
 end

data/lib/stbaldricks/patches/string.rb

@@ -23,9 +23,9 @@ class String
   end
 
   def snake_case
-    gsub(SNAKE_CASE_REGEX) {
+    gsub(SNAKE_CASE_REGEX) do
       (Regexp.last_match[1] ? "_#{Regexp.last_match[1]}" : Regexp.last_match[2]).downcase
-    }.sub(ID_REGEX, '_id').sub(UUID_REGEX, '_uuid').sub(URL_REGEX, '_url')
+    end.sub(ID_REGEX, '_id').sub(UUID_REGEX, '_uuid').sub(URL_REGEX, '_url')
   end
 
   def blank?
@@ -49,6 +49,7 @@ class String
   def to_b
     return false if self == 'false' || self == '0'
     return true if self == 'true' || self == '1'
+
     nil
   end
 end

data/lib/stbaldricks/version.rb

@@ -1,5 +1,5 @@
 module SBF
   module Client
-    VERSION = '6.13.0'
+    VERSION = '6.13.1.alpha.1'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stbaldricks
 version: !ruby/object:Gem::Version
-  version: 6.13.0
+  version: 6.13.1.alpha.1
 platform: ruby
 authors:
 - Firespring
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-19 00:00:00.000000000 Z
+date: 2019-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -31,19 +31,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '5.2'
 - !ruby/object:Gem::Dependency
-  name: httparty
+  name: htmlentities
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.14.0
+        version: 4.3.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.14.0
+        version: 4.3.4
 - !ruby/object:Gem::Dependency
   name: httmultiparty
   requirement: !ruby/object:Gem::Requirement
@@ -59,19 +59,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.3.16
 - !ruby/object:Gem::Dependency
-  name: htmlentities
+  name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.3.4
+        version: 0.14.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.3.4
+        version: 0.14.0
 description: Ruby library for accessing and integrating with the St. Baldrick's Foundation
   API
 email: opensource@stbaldricks.org
@@ -237,9 +237,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.0.1
 signing_key: