stbaldricks 12.15.0.alpha.1 → 12.15.0.alpha.2

data/lib/stbaldricks/entities/memorial.rb

@@ -21,11 +21,14 @@ module SBF
       end
 
       class Tribute < SBF::Client::BaseEntity
-        attr_accessor :birthday, :date_of_passing, :name
+        attr_accessor :birthday
+        attr_accessor :date_of_passing
+        attr_accessor :name
       end
 
       class Totals < SBF::Client::BaseEntity
-        attr_reader :amount_raised, :donations
+        attr_reader :amount_raised
+        attr_reader :donations
       end
 
       class Photos < SBF::Client::BaseEntity
@@ -38,18 +41,20 @@ module SBF
     end
 
     class FullMemorial < Memorial
-      attr_accessor :id, :status, :website_message, :expires_at, :offline_donation_uuid, :offline_donation_form
-      attr_reader :display_name, :created_at, :modified_at
-
+      attr_accessor :id
+      attr_accessor :status
+      attr_accessor :website_message
+      attr_reader :display_name
       entity_attr_accessor :address, 'SBF::Client::Address'
       entity_attr_accessor :tribute, 'SBF::Client::Memorial::Tribute'
       entity_attr_reader :totals, 'SBF::Client::Memorial::Totals'
       entity_collection_attr_accessor :donations, 'SBF::Client::FullDonation', 'SBF::Client::PartialDonation'
-
+      attr_reader :created_at, :modified_at
+      attr_accessor :expires_at
       entity_attr_accessor :photos, 'SBF::Client::Memorial::Photos'
-      entity_attr_accessor :third_party_media, 'SBF::Client::ThirdPartyMedia', nil, optional: true
-
-      entity_attr_accessor :fundraising_page, 'SBF::Client::FundraisingPage', nil, optional: true
+      entity_attr_accessor :third_party_media, 'SBF::Client::ThirdPartyMedia', nil, true
+      attr_accessor :offline_donation_uuid, :offline_donation_form
+      entity_attr_accessor :fundraising_page, 'SBF::Client::FundraisingPage', nil, true
 
       def active?
         status == SBF::Client::Memorial::Status::ACTIVE

data/lib/stbaldricks/entities/message.rb

@@ -33,19 +33,30 @@ module SBF
           DELETED = 'deleted'.freeze
         end
 
-        attr_accessor :id, :status, :message_id, :display_name, :email
+        attr_accessor :id
+        attr_accessor :status
 
+        attr_accessor :message_id
         entity_attr_reader :person, 'SBF::Client::FullPerson', 'SBF::Client::PartialPerson'
+        attr_accessor :display_name
+        attr_accessor :email
 
         attr_reader :modified_at
       end
 
-      attr_accessor :id, :type, :status, :subject, :body
+      attr_accessor :id
+      attr_accessor :type
+      attr_accessor :status
 
       entity_collection_attr_accessor :to, 'SBF::Client::Message::Recipient'
-      attr_reader :from_ip, :from_email, :display_name, :created_at, :modified_at, :sent_at
-
+      attr_reader :from_ip
       entity_attr_reader :from_person, 'SBF::Client::FullPerson', 'SBF::Client::PartialPerson'
+      attr_reader :from_email
+      attr_reader :display_name
+      attr_accessor :subject
+      attr_accessor :body
+
+      attr_reader :created_at, :modified_at, :sent_at
     end
   end
 end

data/lib/stbaldricks/entities/organization.rb

@@ -67,7 +67,8 @@ module SBF
       end
 
       class Totals < SBF::Client::BaseEntity
-        attr_reader :amount_raised, :donations
+        attr_reader :amount_raised
+        attr_reader :donations
       end
     end
 
@@ -78,23 +79,28 @@ module SBF
     class FullOrganization < SBF::Client::Organization
       class ContactName < SBF::Client::BaseEntity
         attr_reader :name
-
         entity_attr_accessor :name_pieces, 'SBF::Client::NamePieces'
       end
 
-      attr_accessor :id, :salesforce_id, :salesforce_account_id, :type, :status, :display_name_override, :name,
-                    :selected_shipping_method, :modified_by, :how_created
-      attr_reader :display_name, :created_at, :modified_at
-
+      attr_accessor :id
+      attr_accessor :salesforce_id
+      attr_accessor :salesforce_account_id
+      attr_accessor :type
+      attr_accessor :status
+      attr_reader :display_name
+      attr_accessor :display_name_override
+      attr_accessor :name
       entity_attr_accessor :contact, 'SBF::Client::FullOrganization::ContactName'
       entity_attr_accessor :addresses, 'SBF::Client::Organization::Addresses'
       entity_attr_accessor :phone_numbers, 'SBF::Client::Organization::PhoneNumbers'
       entity_attr_accessor :email_addresses, 'SBF::Client::Organization::EmailAddresses'
-      entity_attr_accessor :opt_out_settings, 'SBF::Client::OptOutSettings', nil, optional: true
-
-      entity_attr_accessor :alternate_shipping_address, 'SBF::Client::AlternateShippingAddress', nil, optional: true
-
-      entity_attr_reader :totals, 'SBF::Client::Organization::Totals', nil, optional: true
+      entity_attr_accessor :opt_out_settings, 'SBF::Client::OptOutSettings', nil, true
+      attr_accessor :selected_shipping_method
+      entity_attr_accessor :alternate_shipping_address, 'SBF::Client::AlternateShippingAddress', nil, true
+      attr_reader :created_at, :modified_at
+      attr_accessor :modified_by
+      attr_accessor :how_created
+      entity_attr_reader :totals, 'SBF::Client::Organization::Totals', nil, true
 
       def active?
         status == SBF::Client::Organization::Status::ACTIVE

data/lib/stbaldricks/entities/page.rb

@@ -9,8 +9,13 @@ module SBF
       actions DEFAULT_CRUD_ACTIONS
 
       class Content < SBF::Client::BaseEntity
-        attr_reader :id, :date_modified
-        attr_accessor :is_draft, :type, :title, :text, :sort_order
+        attr_reader :id
+        attr_accessor :is_draft
+        attr_accessor :type
+        attr_accessor :title
+        attr_accessor :text
+        attr_accessor :sort_order
+        attr_reader :date_modified
 
         module Type
           TEXT = 'text'.freeze
@@ -18,8 +23,15 @@ module SBF
         end
       end
 
-      attr_reader :id, :may_edit
-      attr_accessor :title, :lookup, :title_tag, :locked_by_profile_id, :locked_at, :modified_by_profile_id, :date_modified
+      attr_reader :id
+      attr_accessor :title
+      attr_accessor :lookup
+      attr_accessor :title_tag
+      attr_accessor :locked_by_profile_id
+      attr_accessor :locked_at
+      attr_accessor :modified_by_profile_id
+      attr_accessor :date_modified
+      attr_reader :may_edit
       entity_collection_attr_accessor :content, 'SBF::Client::Page::Content'
 
       def meta_content
@@ -63,10 +75,7 @@ module SBF
         # update or create draft version of content
         draft = draft_content.find { |d| d.id == cid }
         if draft.nil?
-          self.content << SBF::Client::Page::Content.new(
-            content.to_hash.merge(is_draft: true, title: data[:title], text: data[:text]),
-            clear_changes: false
-          )
+          self.content << SBF::Client::Page::Content.new(content.to_hash.merge(is_draft: true, title: data[:title], text: data[:text]))
         else
           draft.title = data[:title]
           draft.text = data[:text]

data/lib/stbaldricks/entities/participant.rb

@@ -138,8 +138,8 @@ module SBF
 
         class Organizer < SBF::Client::Participant::Roles::LeadRole
           class Policies < SBF::Client::BaseEntity
-            attr_accessor :agreement_received_date, :coaches_questionnaire_received_date, :is_revenue_waiver_accepted,
-                          :is_host_agreement_waiver_accepted
+            attr_accessor :agreement_received_date, :coaches_questionnaire_received_date
+            attr_accessor :is_revenue_waiver_accepted, :is_host_agreement_waiver_accepted
           end
 
           class PreviousOrganization < SBF::Client::BaseEntity
@@ -147,7 +147,6 @@ module SBF
           end
 
           attr_accessor :is_lead, :status
-
           entity_attr_accessor :policies, 'SBF::Client::Participant::Roles::Organizer::Policies'
           entity_attr_accessor :previous_organization, 'SBF::Client::Participant::Roles::Organizer::PreviousOrganization'
         end
@@ -159,7 +158,6 @@ module SBF
 
           class Salon < SBF::Client::BaseEntity
             attr_accessor :name
-
             entity_attr_accessor :phone, 'SBF::Client::Phone'
           end
 
@@ -211,28 +209,40 @@ module SBF
       extend Forwardable
       def_delegator :@photos, :avatar, :avatar_photo_url
 
-      attr_accessor :id, :display_name_override, :facebook_fundraiser_id, :fund_relationship_type, :fundraising_goal, :fundraising_message,
-                    :how_created, :is_virtual, :modified_by, :offline_donation_uuid, :offline_donation_form, :shirt_size, :status
-
-      attr_reader :created_at, :modified_at, :display_name, :is_website_allowed
+      attr_accessor :id
 
-      entity_attr_reader :permissions, 'SBF::Client::Permissions', nil, optional: true
-      entity_attr_reader :permissions_at_event, 'SBF::Client::PermissionsAtEvent', nil, optional: true
+      attr_reader :created_at, :modified_at
+      attr_reader :display_name
+      attr_reader :is_website_allowed
+
+      attr_accessor :display_name_override
+      attr_accessor :facebook_fundraiser_id
+      attr_accessor :fund_relationship_type
+      attr_accessor :fundraising_goal, :fundraising_message
+      attr_accessor :how_created
+      attr_accessor :is_virtual
+      attr_accessor :modified_by
+      attr_accessor :offline_donation_uuid, :offline_donation_form
+      attr_accessor :shirt_size
+      attr_accessor :status
+
+      entity_attr_reader :permissions, 'SBF::Client::Permissions', nil, true
+      entity_attr_reader :permissions_at_event, 'SBF::Client::PermissionsAtEvent', nil, true
       entity_attr_reader :photos, 'SBF::Client::Participant::Photos'
-      entity_attr_reader :rankings, 'SBF::Client::Participant::Rankings', nil, optional: true
+      entity_attr_reader :rankings, 'SBF::Client::Participant::Rankings', nil, true
       entity_attr_reader :totals, 'SBF::Client::Participant::Totals'
 
-      entity_attr_accessor :event, 'SBF::Client::FullEvent', 'SBF::Client::PartialEvent', optional: true
-      entity_attr_accessor :fund, 'SBF::Client::FullFund', 'SBF::Client::PartialFund', optional: true
-      entity_attr_accessor :fundraising_page, 'SBF::Client::FundraisingPage', nil, optional: true
+      entity_attr_accessor :event, 'SBF::Client::FullEvent', 'SBF::Client::PartialEvent', true
+      entity_attr_accessor :fund, 'SBF::Client::FullFund', 'SBF::Client::PartialFund', true
+      entity_attr_accessor :fundraising_page, 'SBF::Client::FundraisingPage', nil, true
       entity_attr_accessor :person, 'SBF::Client::FullPerson'
       entity_attr_accessor :policies, 'SBF::Client::Participant::Policies'
-      entity_attr_accessor :roles, 'SBF::Client::Participant::Roles', nil, optional: true
+      entity_attr_accessor :roles, 'SBF::Client::Participant::Roles', nil, true
       entity_attr_accessor :shave_schedule, 'SBF::Client::Participant::ShaveSchedule'
-      entity_attr_accessor :team, 'SBF::Client::FullTeam', 'SBF::Client::PartialTeam', optional: true
-      entity_attr_accessor :third_party_media, 'SBF::Client::ThirdPartyMedia', nil, optional: true
+      entity_attr_accessor :team, 'SBF::Client::FullTeam', 'SBF::Client::PartialTeam', true
+      entity_attr_accessor :third_party_media, 'SBF::Client::ThirdPartyMedia', nil, true
 
-      entity_collection_attr_accessor :milestones, 'SBF::Client::Milestone', nil, optional: true
+      entity_collection_attr_accessor :milestones, 'SBF::Client::Milestone', nil, true
 
       def active?
         status == SBF::Client::Participant::Status::ACTIVE

data/lib/stbaldricks/entities/participant_donation_summary.rb

@@ -9,9 +9,11 @@ module SBF
       blacklist_action :update
       blacklist_action :delete
 
-      attr_accessor :amount_raised, :donations, :event_year
+      attr_accessor :amount_raised
+      attr_accessor :donations
+      attr_accessor :event_year
 
-      entity_attr_reader :participant, 'SBF::Client::FullParticipant', nil, optional: true
+      entity_attr_reader :participant, 'SBF::Client::FullParticipant', nil, true
     end
   end
 end

data/lib/stbaldricks/entities/person.rb

@@ -92,16 +92,15 @@ module SBF
 
       class Policies < SBF::Client::BaseEntity
         BACKGROUND_CHECK_YEARS_VALID = 5
-        attr_accessor :is_photo_policy_accepted, :background_check_date, :background_check_url
+        attr_accessor :is_photo_policy_accepted
+        attr_accessor :background_check_date, :background_check_url
 
         def background_check_valid_at_date?(check_date)
           check_date = DateTime.parse(check_date) if check_date.is_a?(String)
           check_date = DateTime.parse(check_date.to_s) if check_date.is_a?(Date)
           check_date = DateTime.parse(check_date.strftime('%d/%m/%Y %H:%M:%S')) if check_date.is_a?(Time)
           background_check_date && check_date.is_a?(DateTime) \
-                                && DateTime.parse(background_check_date) > check_date.prev_year(
-                                  SBF::Client::Person::Policies::BACKGROUND_CHECK_YEARS_VALID
-                                )
+                                && background_check_date > check_date.prev_year(SBF::Client::Person::Policies::BACKGROUND_CHECK_YEARS_VALID)
         end
       end
 
@@ -206,7 +205,6 @@ module SBF
           end
         end
       end
-
       class Occupation < SBF::Client::BaseEntity
         module Type
           STUDENT = 'Student'.freeze
@@ -344,21 +342,21 @@ module SBF
         # able to determine what type it should be. As it is currently written, it cannot instanitate itself
         # without the information contained in the SBF::Client::Person::Occupation instance.
         attr_accessor :details
-
         def details=(value)
           details_will_change!
           if educator? || student?
-            @details = SBF::Client::Person::Occupation::EducationDetails.new(value, clear_changes: false)
+            @details = SBF::Client::Person::Occupation::EducationDetails.new(value)
           elsif military?
-            @details = SBF::Client::Person::Occupation::MilitaryDetails.new(value, clear_changes: false)
+            @details = SBF::Client::Person::Occupation::MilitaryDetails.new(value)
           elsif finance? || other?
-            @details = SBF::Client::Person::Occupation::FinanceDetails.new(value, clear_changes: false)
+            @details = SBF::Client::Person::Occupation::FinanceDetails.new(value)
           end
         end
       end
 
       class Totals < SBF::Client::BaseEntity
-        attr_reader :amount_raised, :donations
+        attr_reader :amount_raised
+        attr_reader :donations
       end
 
       def league_status_title
@@ -384,23 +382,34 @@ module SBF
     end
 
     class FullPerson < SBF::Client::Person
-      attr_accessor :id, :salesforce_id, :salesforce_account_id, :type, :status, :gender, :is_minor, :birthday,
-                    :display_name_override, :years_as_participant, :years_as_organizer, :selected_shipping_method,
-                    :modified_by, :how_created, :date_last_notified_about_new_donations
-      attr_reader :display_name, :first_and_last_name, :league_status, :name, :created_at, :modified_at
-
+      attr_accessor :id
+      attr_accessor :salesforce_id
+      attr_accessor :salesforce_account_id
+      attr_accessor :type
+      attr_accessor :status
+      attr_accessor :gender
+      attr_accessor :is_minor
+      attr_accessor :birthday
+      attr_reader :display_name, :first_and_last_name
+      attr_accessor :display_name_override
+      attr_accessor :years_as_participant, :years_as_organizer
+      attr_reader :league_status
+      attr_reader :name
       entity_attr_accessor :name_pieces, 'SBF::Client::NamePieces'
       entity_attr_accessor :addresses, 'SBF::Client::Person::Addresses'
       entity_attr_accessor :phone_numbers, 'SBF::Client::Person::PhoneNumbers'
       entity_attr_accessor :email_addresses, 'SBF::Client::Person::EmailAddresses'
-      entity_attr_accessor :occupation, 'SBF::Client::Person::Occupation', nil, optional: true
+      entity_attr_accessor :occupation, 'SBF::Client::Person::Occupation', nil, true
       entity_attr_accessor :policies, 'SBF::Client::Person::Policies'
-      entity_attr_accessor :how_affected, 'SBF::Client::Person::HowAffected', nil, optional: true
-      entity_attr_accessor :opt_out_settings, 'SBF::Client::OptOutSettings', nil, optional: true
-
-      entity_attr_accessor :alternate_shipping_address, 'SBF::Client::AlternateShippingAddress', nil, optional: true
-
-      entity_attr_reader :totals, 'SBF::Client::Person::Totals', nil, optional: true
+      entity_attr_accessor :how_affected, 'SBF::Client::Person::HowAffected', nil, true
+      entity_attr_accessor :opt_out_settings, 'SBF::Client::OptOutSettings', nil, true
+      attr_accessor :selected_shipping_method
+      entity_attr_accessor :alternate_shipping_address, 'SBF::Client::AlternateShippingAddress', nil, true
+      attr_reader :created_at, :modified_at
+      attr_accessor :modified_by
+      attr_accessor :how_created
+      entity_attr_reader :totals, 'SBF::Client::Person::Totals', nil, true
+      attr_accessor :date_last_notified_about_new_donations
 
       def active?
         status == SBF::Client::Person::Status::ACTIVE

data/lib/stbaldricks/entities/person_donation_by_year_summary.rb

@@ -9,7 +9,8 @@ module SBF
       blacklist_action :update
       blacklist_action :delete
 
-      attr_accessor :donations, :cumulative_total
+      attr_accessor :donations
+      attr_accessor :cumulative_total
       attr_reader :modified_at
 
       entity_attr_accessor :person, 'SBF::Client::FullPerson', 'SBF::Client::PartialPerson'

data/lib/stbaldricks/entities/photo.rb

@@ -26,8 +26,13 @@ module SBF
         endpoint.send(:upload, *args)
       end
 
-      attr_accessor :id, :caption, :sort_order, :year, :category, :file, :filename, :base_photo_url
-
+      attr_accessor :id
+      attr_accessor :caption
+      attr_accessor :sort_order
+      attr_accessor :year
+      attr_accessor :category
+      attr_accessor :file
+      attr_accessor :filename
       multitype_attr_accessor(
         :model,
         [
@@ -79,11 +84,12 @@ module SBF
         ],
         optional: false
       )
-      attr_reader :original_file_id, :original_filename
+      attr_accessor :base_photo_url
+      attr_reader :original_file_id
+      attr_reader :original_filename
 
       def to_json(*a)
-        names = %i(file filename)
-        to_hash.reject { |k, _v| names.include? k }.to_json(*a)
+        to_hash.reject { |k, _v| %i(file filename).include? k }.to_json(*a)
       end
 
       module Category

data/lib/stbaldricks/entities/recurring_gift.rb

@@ -168,7 +168,6 @@ module SBF
       class Tribute < SBF::Client::BaseEntity
         attr_accessor :type
         attr_reader :name
-
         entity_attr_accessor :name_pieces, 'SBF::Client::NamePieces'
 
         module Type
@@ -181,15 +180,24 @@ module SBF
     class PartialRecurringGift < SBF::Client::RecurringGift
       attr_accessor :id
     end
-
     class FullRecurringGift < SBF::Client::RecurringGift
-      attr_accessor :status, :event_year, :amount, :fee_amount, :billing_day_of_month, :last_collected_at,
-                    :last_failed_at, :display_name, :display_name_override, :is_unrecognized, :promotional_code,
-                    :funding_type, :payment_gateway, :customer_id, :subscription_id, :created_at, :modified_at,
-                    :modified_by, :how_created, :how_created_id, :past_due_at
-
+      attr_accessor :status
+      attr_accessor :event_year
+      attr_accessor :amount
+      attr_accessor :fee_amount
+      attr_accessor :billing_day_of_month
+      attr_accessor :last_collected_at
+      attr_accessor :last_failed_at
+      attr_accessor :display_name
+      attr_accessor :display_name_override
+      attr_accessor :is_unrecognized
+      attr_accessor :promotional_code
+      attr_accessor :funding_type
+      attr_accessor :payment_gateway
+      attr_accessor :customer_id
+      attr_accessor :subscription_id
       entity_collection_attr_accessor :donations, 'SBF::Client::FullDonation', 'SBF::Client::PartialDonation'
-
+      attr_accessor :created_at, :modified_at, :modified_by, :how_created, :how_created_id, :past_due_at
       entity_attr_accessor :tribute, 'SBF::Client::RecurringGift::Tribute'
 
       multitype_attr_accessor(
@@ -283,12 +291,12 @@ module SBF
 
       def amount=(value)
         amount_will_change!
-        @amount = value.to_s.gsub(/[^0-9.]/, '').to_f
+        @amount = value.to_s.gsub(/[^0-9\.]/, '').to_f
       end
 
       def fee_amount=(value)
         fee_amount_will_change!
-        @fee_amount = value.to_s.gsub(/[^0-9.]/, '').to_f
+        @fee_amount = value.to_s.gsub(/[^0-9\.]/, '').to_f
       end
     end
   end

data/lib/stbaldricks/entities/response.rb

@@ -7,7 +7,6 @@ module SBF
         attr_accessor :http_code, :data, :error
 
         def initialize(http_code: nil, data: nil, error: nil)
-          super()
           @http_code = http_code
           @data = data
           @error = error || SBF::Client::ErrorEntity.new(nil)