stbaldricks 10.4.0.alpha.2 → 10.6.1

data/lib/stbaldricks/entities/photo.rb

@@ -89,38 +89,38 @@ module SBF
       attr_reader :original_filename
 
       def to_json(*a)
-        to_hash.reject { |k, _v| [:file, :filename].include? k }.to_json(*a)
+        to_hash.reject { |k, _v| %i(file filename).include? k }.to_json(*a)
       end
 
       module Category
-        SHAVEE_AFTER = 'shavee_after'
-        SHAVEE_BEFORE = 'shavee_before'
-        KID = 'kid'
-        PARTICIPANT = 'participant'
-        TEAM_LOGO = 'team_logo'
-        VENUE_LOGO = 'venue_logo'
-        USER_AVATAR = 'user_avatar'
-        GALLERY = 'gallery'
-        DEFAULT_PHOTO = 'default_photo'
-        CAMPAIGN_LOGO = 'campaign_logo'
-        FUND_LOGO = 'fund_logo'
-        FUNDRAISER_LOGO = 'fundraiser_logo'
-        EVENT_SUPPORTER_LOGO = 'event_supporter_logo'
-        MEMORIAL = 'memorial'
-        COVER_ORIGINAL = 'cover_original'
-        COVER_DEFAULT = 'cover_default'
+        SHAVEE_AFTER = 'shavee_after'.freeze
+        SHAVEE_BEFORE = 'shavee_before'.freeze
+        KID = 'kid'.freeze
+        PARTICIPANT = 'participant'.freeze
+        TEAM_LOGO = 'team_logo'.freeze
+        VENUE_LOGO = 'venue_logo'.freeze
+        USER_AVATAR = 'user_avatar'.freeze
+        GALLERY = 'gallery'.freeze
+        DEFAULT_PHOTO = 'default_photo'.freeze
+        CAMPAIGN_LOGO = 'campaign_logo'.freeze
+        FUND_LOGO = 'fund_logo'.freeze
+        FUNDRAISER_LOGO = 'fundraiser_logo'.freeze
+        EVENT_SUPPORTER_LOGO = 'event_supporter_logo'.freeze
+        MEMORIAL = 'memorial'.freeze
+        COVER_ORIGINAL = 'cover_original'.freeze
+        COVER_DEFAULT = 'cover_default'.freeze
       end
 
       module ModelType
-        EVENT = 'event'
-        TEAM = 'team'
-        PARTICIPANT = 'participant'
-        FUNDRAISER = 'fundraiser'
-        KID = 'kid'
-        FUND = 'fund'
-        CAMPAIGN = 'campaign'
-        EVENT_SUPPORTER = 'event_supporter'
-        MEMORIAL = 'memorial'
+        EVENT = 'event'.freeze
+        TEAM = 'team'.freeze
+        PARTICIPANT = 'participant'.freeze
+        FUNDRAISER = 'fundraiser'.freeze
+        KID = 'kid'.freeze
+        FUND = 'fund'.freeze
+        CAMPAIGN = 'campaign'.freeze
+        EVENT_SUPPORTER = 'event_supporter'.freeze
+        MEMORIAL = 'memorial'.freeze
       end
 
       class FullParticipant < SBF::Client::FullParticipant

data/lib/stbaldricks/entities/recurring_gift.rb

@@ -28,31 +28,31 @@ module SBF
       attr_accessor :id
 
       module Status
-        UNKNOWN = 'unknown'
-        PAST_DUE = 'past_due'
-        ACTIVE = 'active'
-        CANCELED = 'canceled'
-        PENDING = 'pending'
+        UNKNOWN = 'unknown'.freeze
+        PAST_DUE = 'past_due'.freeze
+        ACTIVE = 'active'.freeze
+        CANCELED = 'canceled'.freeze
+        PENDING = 'pending'.freeze
       end
 
       module RecipientType
-        FUND = 'fund'
-        EVENT = 'event'
-        TEAM = 'team'
-        PARTICIPANT = 'participant'
-        FUNDRAISER = 'fundraiser'
-        MEMORIAL = 'memorial'
+        FUND = 'fund'.freeze
+        EVENT = 'event'.freeze
+        TEAM = 'team'.freeze
+        PARTICIPANT = 'participant'.freeze
+        FUNDRAISER = 'fundraiser'.freeze
+        MEMORIAL = 'memorial'.freeze
       end
 
       module DonorType
-        INDIVIDUAL = 'individual'
-        BUSINESS = 'business'
-        ORGANIZATION_FOUNDATION = 'foundation'
+        INDIVIDUAL = 'individual'.freeze
+        BUSINESS = 'business'.freeze
+        ORGANIZATION_FOUNDATION = 'foundation'.freeze
       end
 
       module FundingType
-        CREDIT_CARD = 'credit_card'
-        PAYPAL = 'paypal'
+        CREDIT_CARD = 'credit_card'.freeze
+        PAYPAL = 'paypal'.freeze
       end
 
       class FullParticipant < SBF::Client::FullParticipant
@@ -169,8 +169,8 @@ module SBF
         entity_attr_accessor :name_pieces, 'SBF::Client::NamePieces'
 
         module Type
-          HONOR = 'honor'
-          MEMORY = 'memory'
+          HONOR = 'honor'.freeze
+          MEMORY = 'memory'.freeze
         end
       end
     end

data/lib/stbaldricks/entities/search.rb

@@ -8,14 +8,14 @@ module SBF
       action :find
 
       module Type
-        FUND = 'fund'
-        CAMPAIGN = 'campaign'
-        EVENT = 'event'
-        TEAM = 'team'
-        PARTICIPANT = 'participant'
-        FUNDRAISER = 'fundraiser'
-        KID = 'kid'
-        MEMORIAL = 'memorial'
+        FUND = 'fund'.freeze
+        CAMPAIGN = 'campaign'.freeze
+        EVENT = 'event'.freeze
+        TEAM = 'team'.freeze
+        PARTICIPANT = 'participant'.freeze
+        FUNDRAISER = 'fundraiser'.freeze
+        KID = 'kid'.freeze
+        MEMORIAL = 'memorial'.freeze
       end
 
       module Status

data/lib/stbaldricks/entities/shave_schedule.rb

@@ -27,8 +27,8 @@ module SBF
 
       class ShaveScheduleAssignment < SBF::Client::BaseEntity
         module Type
-          RESERVED = 'reserved'
-          SHAVEE = 'shavee'
+          RESERVED = 'reserved'.freeze
+          SHAVEE = 'shavee'.freeze
         end
 
         attr_accessor :id

data/lib/stbaldricks/entities/team.rb

@@ -12,10 +12,7 @@ require 'stbaldricks/entities/concerns/fundraising_page_concern'
 module SBF
   module Client
     class Team < SBF::Client::TopLevelEntity
-      include Entities::DefaultCacheable
-      include DonationRecipientConcern
-      include EventYearConcern
-      include FundraisingPageConcern
+      include FundraisingPageConcern, EventYearConcern, DonationRecipientConcern, Entities::DefaultCacheable
       actions DEFAULT_CRUD_ACTIONS
 
       blacklist_action :create
@@ -23,26 +20,26 @@ module SBF
       disallow_instantiation
 
       module Status
-        ACTIVE = 'active'
-        PENDING = 'pending'
-        SUSPENDED = 'suspended'
+        ACTIVE = 'active'.freeze
+        PENDING = 'pending'.freeze
+        SUSPENDED = 'suspended'.freeze
       end
 
       module HowCreated
-        WEBSITE = 'website'
-        ADMIN_IMPORT = 'admin_import'
-        ADMIN_CONTROL_PANEL = 'admin_control_panel'
-        MOBILE = 'mobile'
-        PARTICIPANT_IMPORT = 'participant_import'
+        WEBSITE = 'website'.freeze
+        ADMIN_IMPORT = 'admin_import'.freeze
+        ADMIN_CONTROL_PANEL = 'admin_control_panel'.freeze
+        MOBILE = 'mobile'.freeze
+        PARTICIPANT_IMPORT = 'participant_import'.freeze
       end
 
       module FundRelationshipType
-        NO_ASSOCIATION = 'no_association'
-        INDIRECT_ONE = 'indirect_one'
-        INDIRECT_MULTIPLE = 'indirect_multiple'
-        DIRECT = 'direct'
-        DIRECT_BUT_LOCKED = 'direct_but_locked'
-        INHERITED_FROM_EVENT = 'inherited_from_event'
+        NO_ASSOCIATION = 'no_association'.freeze
+        INDIRECT_ONE = 'indirect_one'.freeze
+        INDIRECT_MULTIPLE = 'indirect_multiple'.freeze
+        DIRECT = 'direct'.freeze
+        DIRECT_BUT_LOCKED = 'direct_but_locked'.freeze
+        INHERITED_FROM_EVENT = 'inherited_from_event'.freeze
       end
 
       class Photos < SBF::Client::BaseEntity

data/lib/stbaldricks/entities/user.rb

@@ -20,20 +20,22 @@ module SBF
       cache_id_from_hash ->(h) { [h[:person][:id], h[:type]] }
 
       module AccessScope
-        ADMIN = 'admin'
-        MEMBER = 'member'
+        ADMIN = 'admin'.freeze
+        MEMBER = 'member'.freeze
       end
 
       module ProviderType
-        SBF = 'sbf'
-        FACEBOOK = 'facebook'
-        TWITTER = 'twitter'
+        SBF = 'sbf'.freeze
+        FACEBOOK = 'facebook'.freeze
+        TWITTER = 'twitter'.freeze
 
+        # rubocop:disable Style/MutableConstant
         IDS = {
           SBF => 1,
           FACEBOOK => 2,
           TWITTER => 3
         }
+        # rubocop:enable Style/MutableConstant
         IDS.default = 0
         IDS.freeze
 

data/lib/stbaldricks/enums/cancer_types.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SBF
   module Client
     module CancerType

data/lib/stbaldricks/enums/country.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SBF
   module Client
     module Country

data/lib/stbaldricks/enums/league_status.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SBF
   module Client
     module LeagueStatus

data/lib/stbaldricks/enums/model_type.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SBF
   module Client
     module ModelType

data/lib/stbaldricks/enums/permission.rb

@@ -18,7 +18,7 @@ module SBF
 
       MANAGE_SYSTEM = 109
 
-      #Event permissions
+      # Event permissions
       EVENT_MANAGE = 200
       EVENT_MANAGE_INFO = 201
       EVENT_MANAGE_ACTIVITIES = 202
@@ -42,7 +42,7 @@ module SBF
       EVENT_FAST_REGISTRATION = 220
       EVENT_DELETE_EVENT = 221
 
-      #text descriptions found in LookupUtility
+      # text descriptions found in LookupUtility
       EVENT_MEMBER_UPDATE_EVENT_INFORMATION = 300
       EVENT_MEMBER_ACTIVITIES = 301
       EVENT_MEMBER_PHOTO_GALLERY = 302
@@ -60,7 +60,7 @@ module SBF
       EVENT_MEMBER_COMMUNICATE = 315
       EVENT_MEMBER_FAST_DONATION = 316
 
-      #Participant Role Permissions
+      # Participant Role Permissions
       EVENT_ORGANIZER = 1905
       EVENT_BARBER_COORDINATOR = 1911
       EVENT_SHAVEE_RECRUITER = 1913
@@ -115,7 +115,7 @@ module SBF
 
       EVENT_APPLICATION_MANAGE = 2202
 
-      #Team Permissions
+      # Team Permissions
       TEAM_TEAM_CAPTAIN = 2101
 
       # Memorial Permissions
@@ -140,7 +140,7 @@ module SBF
         DELETE_GROUPS => :DELETE_GROUPS,
         EDIT_GROUPS => :EDIT_GROUPS,
         MANAGE_SYSTEM => :MANAGE_SYSTEM,
-        #Event permissions
+        # Event permissions
         EVENT_MANAGE => :EVENT_MANAGE,
         EVENT_MANAGE_INFO => :EVENT_MANAGE_INFO,
         EVENT_MANAGE_ACTIVITIES => :EVENT_MANAGE_ACTIVITIES,
@@ -179,7 +179,7 @@ module SBF
         EVENT_MEMBER_VIEW_TEAM_TOTALS_LIST => :EVENT_MEMBER_VIEW_TEAM_TOTALS_LIST,
         EVENT_MEMBER_COMMUNICATE => :EVENT_MEMBER_COMMUNICATE,
         EVENT_MEMBER_FAST_DONATION => :EVENT_MEMBER_FAST_DONATION,
-        #Participant Role Permissions
+        # Participant Role Permissions
         EVENT_ORGANIZER => :EVENT_ORGANIZER,
         EVENT_BARBER_COORDINATOR => :EVENT_BARBER_COORDINATOR,
         EVENT_SHAVEE_RECRUITER => :EVENT_SHAVEE_RECRUITER,
@@ -211,9 +211,9 @@ module SBF
         FUNDRAISER_MANAGE => :FUNDRAISER_MANAGE,
         FUNDRAISER_DELETE_FUNDRAISER => :FUNDRAISER_DELETE_FUNDRAISER,
         EVENT_APPLICATION_MANAGE => :EVENT_APPLICATION_MANAGE,
-        #Team Permissions
+        # Team Permissions
         TEAM_TEAM_CAPTAIN => :TEAM_TEAM_CAPTAIN,
-        #Memorial Permissions
+        # Memorial Permissions
         MEMORIAL_VIEW => :MEMORIAL_VIEW,
         MEMORIAL_MANAGE => :MEMORIAL_MANAGE,
         # Challenge Permissions

data/lib/stbaldricks/enums/permission_model_type.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SBF
   module Client
     module PermissionModelType

data/lib/stbaldricks/enums/province.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SBF
   module Client
     module Province

data/lib/stbaldricks/enums/state.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SBF
   module Client
     module State

data/lib/stbaldricks/enums/top_level_category_type.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SBF
   module Client
     module TopLevelCategoryType

data/lib/stbaldricks/log.rb

@@ -6,7 +6,9 @@ module SBF
     class LOG
       include Singleton
 
-      REQUIRED_METHODS = [:debug, :info, :warn, :error, :fatal, :unknown, :add, :level]
+      # rubocop:disable Style/MutableConstant
+      REQUIRED_METHODS = %i(debug info warn error fatal unknown add level)
+      # rubocop:enable Style/MutableConstant
 
       # rubocop:disable Style/MethodMissingSuper, Style/MissingRespondToMissing
       def self.method_missing(sym, *args, &block)

data/lib/stbaldricks/patches/hash.rb

@@ -3,9 +3,9 @@ class Hash
     keys.each do |key|
       unless key.is_a? Symbol
         value = delete(key)
-        # rubocop:disable RescueModifier
+        # rubocop:disable Style/RescueModifier
         self[(key.to_sym rescue key) || key] = value
-        # rubocop:enable RescueModifier
+        # rubocop:enable Style/RescueModifier
       end
 
       value.symbolize! if value.is_a?(Hash) || value.is_a?(Array)

data/lib/stbaldricks/patches/string.rb

@@ -5,7 +5,7 @@ class String
   ID_REGEX = Regexp.new('(^|_)i_d')
   UUID_REGEX = Regexp.new('(^|_)u_u_id')
   URL_REGEX = Regexp.new('(^|_)u_r_l')
-  MODULE_SEPARATOR = '::'
+  MODULE_SEPARATOR = '::'.freeze
 
   def camel_case
     x = split('_').map do |e|

data/lib/stbaldricks/request.rb

@@ -7,15 +7,15 @@ require 'uri'
 
 # Require all monkey patches
 patch_dir = File.realpath("#{File.dirname(__FILE__)}/patches/")
-Dir["#{patch_dir}/*.rb"].each { |file| require file }
+Dir["#{patch_dir}/*.rb"].sort.each { |file| require file }
 
 # Require all entities
 entity_dir = File.realpath("#{File.dirname(__FILE__)}/entities/")
-Dir["#{entity_dir}/**/*.rb"].each { |file| require file }
+Dir["#{entity_dir}/**/*.rb"].sort.each { |file| require file }
 
 # Require all enums
 enum_dir = File.realpath("#{File.dirname(__FILE__)}/enums/")
-Dir["#{enum_dir}/*.rb"].each { |file| require file }
+Dir["#{enum_dir}/*.rb"].sort.each { |file| require file }
 
 # Client library class for accessing the St. Baldrick's Foundation API
 module SBF

data/lib/stbaldricks/version.rb

@@ -1,5 +1,5 @@
 module SBF
   module Client
-    VERSION = '10.4.0.alpha.2'
+    VERSION = '10.6.1'.freeze
   end
 end

data/lib/stbaldricks_factories.rb

@@ -2,4 +2,4 @@ require 'stbaldricks'
 
 project_root = File.realpath("#{File.dirname(__FILE__)}/../")
 $LOAD_PATH.unshift(project_root)
-Dir["#{project_root}/spec/factories/**/*.rb"].each { |file| require file }
+Dir["#{project_root}/spec/factories/**/*.rb"].sort.each { |file| require file }

data/spec/factories/challenger.rb

@@ -2,9 +2,9 @@ require_relative 'lib/helpers'
 
 FactoryBot.define do
   factory :_base_challenger, class: SBF::Client::Challenger do
-    to_create { |it|
+    to_create do |it|
       raise "Failed to create #{it.class}: #{it.errors.details}" unless it.save
-    }
+    end
 
     initialize_with do
       new(attributes)

data/spec/factories/kid.rb

@@ -2,10 +2,10 @@ require_relative 'lib/helpers'
 
 FactoryBot.define do
   factory :kid, class: SBF::Client::FullKid do
-    to_create { |it|
+    to_create do |it|
       it.relationships.first.person = FactoryBot.create(:person) if it.relationships.first.person.nil?
       raise "Failed to create #{it.class}: #{it.errors.details}" unless it.save
-    }
+    end
 
     initialize_with do
       new(attributes)
@@ -19,7 +19,7 @@ FactoryBot.define do
     after :build do |kid, evaluator|
       kid.name_pieces = build(:name_pieces) if unpopulated?(evaluator, :name_pieces)
       kid.address = build(:address) if unpopulated?(evaluator, :address)
-      kid.diagnosis = build(:diagnosis) if unpopulated?(evaluator, :diagnosis)
+      kid.diagnosis = build(:diagnosis, date: Faker::Date.between(from: kid.birthday, to: DateTime.now).to_s) if unpopulated?(evaluator, :diagnosis)
       kid.treatment_status = build(:treatment_status) if unpopulated?(evaluator, :treatment_status)
       kid.web_page = build(:web_page) if unpopulated?(evaluator, :web_page)
       kid.photos = build(:photos) if unpopulated?(evaluator, :photos)