stbaldricks 10.4.0.alpha.1 → 10.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 23006a43310cb68778025d2c4d4b01ebbd8b8b5ff97537307cc80736e0767818
-  data.tar.gz: 16883adc356055802ee3508b606ac6434a414120485127a0e8d00a47ce0cffa9
+  metadata.gz: 0ea675b1d359942d0694800c9e8588275e83ef41a8e363e39a2d6aa4ef4a5a02
+  data.tar.gz: 13a1140cc333d580dd7725e6acf598a840d3b1529fb41edddf3cccc59761df7e
 SHA512:
-  metadata.gz: 26ae5dc27958518bf7022b6983f7bd054ad174ba558b57e93941adf23a93b7aad253f6732632ccc17e126d2e44de3ea42b82f77cbf05cdaca977f714dc4416e7
-  data.tar.gz: d6c39f9181c85719f98c8fe72b256c33764895351ba7d9d2a439ad219084395d7ca6a51db7cc5c33a2092497196a5deaa2ada9bfdbbbd0a76c9163df78b04e87
+  metadata.gz: c44585e4e05bd24ef4a976926995f409790707149d0298fcf3223febdf9219cf4ad774bd7213268cbe2b7d896393a4344d4f60f7cfd392cddbd1c8b895412830
+  data.tar.gz: 400493e6ff586305caf3d53bf22fd79f6838515ddfbc4266b7530f9c584e9a11e9fa70e1d35fcb2e1e3518837a9649a3499847ea11060a8f277cfe01d4c72b17

data/lib/stbaldricks/configuration.rb

@@ -8,7 +8,7 @@ module SBF
     class Configuration
       DEFAULT_API_ENDPOINT = 'https://api'
 
-      @_logger = nil
+      @logger = nil
 
       class << self
         attr_writer :base_uri, :user_token, :general_token, :request_id
@@ -31,11 +31,11 @@ module SBF
         missing_methods = SBF::Client::LOG::REQUIRED_METHODS.reject { |method| new_logger.respond_to?(method) }
         raise SBF::Client::Configuration::Error.new('logger', "must respond to: #{missing_methods.join(', ')}") unless missing_methods.empty?
 
-        @_logger = new_logger
+        @logger = new_logger
       end
 
       def self.logger
-        @_logger ||= SBF::Client::DefaultLogger.instance
+        @logger ||= SBF::Client::DefaultLogger.instance
       end
 
       class Error < ::StandardError

data/lib/stbaldricks/endpoints/donation.rb

@@ -6,10 +6,10 @@ module SBF
     class DonationEndpoint < SBF::Client::EntityEndpoint
       def create(entity_or_hash, with = {})
         unless SBF::Client::Configuration.forwarded_for
-          SBF::Client::LOG.warn {
+          SBF::Client::LOG.warn do
             "SBF::Client No forwarded_for configured for the client on the donation create route. \
               This may cause your app to be blocked from creating donations if too many errors occur."
-          }
+          end
         end
         super
       end

data/lib/stbaldricks/endpoints/lib/entity.rb

@@ -224,7 +224,7 @@ module SBF
       end
       private :normalize_with
 
-      # rubocop:disable IdenticalConditionalBranches
+      # rubocop:disable Style/IdenticalConditionalBranches
       def hydrated_entity(response, data, entity_or_hash)
         parsed_response_body = JSON.parse(response.body).symbolize!
 
@@ -258,7 +258,7 @@ module SBF
         end
       end
       private :hydrated_entity
-      # rubocop:enable IdenticalConditionalBranches
+      # rubocop:enable Style/IdenticalConditionalBranches
     end
   end
 end

data/lib/stbaldricks/endpoints/photo.rb

@@ -61,9 +61,7 @@ module SBF
         end
       end
 
-      private
-
-      def photo_for_upload(file, data)
+      private def photo_for_upload(file, data)
         if data.is_a?(SBF::Client::Photo)
           data.file = file
           data

data/lib/stbaldricks/entities/concerns/entity_response_concern.rb

@@ -47,16 +47,14 @@ module EntityResponseConcern
     self
   end
 
-  private
-
-  def single_active_model_error
+  private def single_active_model_error
     return if errors.empty?
     return [:base, errors[:base].first] if errors[:base].any?
 
     errors.first
   end
 
-  def log_deprecated(method_name, method_caller = nil)
+  private def log_deprecated(method_name, method_caller = nil)
     SBF::Client::Configuration.logger.warn do
       caller_message = method_caller.nil? ? '' : " Called from #{method_caller.first}"
 

data/lib/stbaldricks/entities/config.rb

@@ -19,7 +19,7 @@ module SBF
       attr_reader :years_for_knight_commander
       attr_reader :years_for_crusader
       attr_reader :years_for_baron
-      #NOTE: If you add another attribute, be sure to mock it out in `configure :test` of app.rb
+      # NOTE: If you add another attribute, be sure to mock it out in `configure :test` of app.rb
 
       # Attempts to call the method on the cached configuration object
       # rubocop:disable Style/MethodMissingSuper, Style/MissingRespondToMissing

data/lib/stbaldricks/entities/donation/promo_code.rb

@@ -41,13 +41,24 @@ module SBF
         BRIGADE = 'brigade'
         SCHICK = 'schick'
         BATTLE = 'battle'
-        BLANK4 = 'blank4'
-        BLANK5 = 'blank5'
-        BLANK6 = 'blank6'
-        BLANK7 = 'blank7'
-        BLANK8 = 'blank8'
+        CCQR = 'ccqr'
+        QREVENTPRINTOUT = 'qreventprintout'
+        PDASHQR = 'pdashqr'
+        APPEAL = 'appeal'
+        INSTAGRAM = 'instagram'
         BLANK9 = 'blank9'
         BLANK10 = 'blank10'
+        BLANK11 = 'blank11'
+        BLANK12 = 'blank12'
+        BLANK13 = 'blank13'
+        BLANK14 = 'blank14'
+        BLANK15 = 'blank15'
+        BLANK16 = 'blank16'
+        BLANK17 = 'blank17'
+        BLANK18 = 'blank18'
+        BLANK19 = 'blank19'
+        BLANK20 = 'blank20'
+        BLANK21 = 'blank21'
 
         def self.to_a
           # Defining the array explicitly, in order rather than const_getting since some things in website-ruby depend on the order
@@ -55,7 +66,8 @@ module SBF
            GIVING_TUESDAY, SURVIVOR, SPONSORSHIP, LAPSED_LOW, LAPSED_MID, RMMEVENTS, YEAR_END_DG, LAPSED_DG, FB_FUNDRAISER,
            MOBILE_CAUSE, INTERNATIONAL, ACS, HEAD_SHAVING, SPORT_CLIPS, TWENTIETH_ANNIVERSARY, DWYW, GRANTS, SUMMER,
            ADVOCACY, MISSION, RECURRING_GIVING, ACSEVENTS, HS_TO_DONOR, WIRELESS_VISION, BMC, DUTCH_BROS, FADO, SAP, BRIGADE,
-           SCHICK, BATTLE, BLANK4, BLANK5, BLANK6, BLANK7, BLANK8, BLANK9, BLANK10]
+           SCHICK, BATTLE, CCQR, QREVENTPRINTOUT, PDASHQR, APPEAL, INSTAGRAM, BLANK9, BLANK10, BLANK11, BLANK12, BLANK13,
+           BLANK14, BLANK15, BLANK16, BLANK17, BLANK18, BLANK19, BLANK20, BLANK21]
         end
       end
     end

data/lib/stbaldricks/entities/event.rb

@@ -22,11 +22,7 @@ require 'stbaldricks/entities/concerns/venue_concern'
 module SBF
   module Client
     class Event < SBF::Client::TopLevelEntity
-      include Entities::Cacheable
-      include DonationRecipientConcern
-      include EventYearConcern
-      include FundraisingPageConcern
-      include VenueConcern
+      include VenueConcern, FundraisingPageConcern, EventYearConcern, DonationRecipientConcern, Entities::Cacheable
       endpoint SBF::Client::EventEndpoint
       actions DEFAULT_CRUD_ACTIONS
       action :invite

data/lib/stbaldricks/entities/fund.rb

@@ -8,8 +8,7 @@ require 'stbaldricks/entities/concerns/donation_recipient_concern'
 module SBF
   module Client
     class Fund < SBF::Client::TopLevelEntity
-      include Entities::DefaultCacheable
-      include DonationRecipientConcern
+      include DonationRecipientConcern, Entities::DefaultCacheable
       endpoint SBF::Client::FundEndpoint
       action :allowed_entities
       action :get

data/lib/stbaldricks/entities/fundraiser.rb

@@ -16,11 +16,7 @@ require 'stbaldricks/entities/concerns/venue_concern'
 module SBF
   module Client
     class Fundraiser < SBF::Client::TopLevelEntity
-      include Entities::DefaultCacheable
-      include DonationRecipientConcern
-      include EventYearConcern
-      include FundraisingPageConcern
-      include VenueConcern
+      include VenueConcern, FundraisingPageConcern, EventYearConcern, DonationRecipientConcern, Entities::DefaultCacheable
       endpoint SBF::Client::FundraiserEndpoint
       actions DEFAULT_CRUD_ACTIONS
       action :join_team

data/lib/stbaldricks/entities/lib/base.rb

@@ -1,6 +1,6 @@
 # Require all monkey patches
 patch_dir = File.expand_path('../../patches', __dir__)
-Dir["#{patch_dir}/*.rb"].each { |file| require file }
+Dir["#{patch_dir}/*.rb"].sort.each { |file| require file }
 
 require 'set'
 require 'stbaldricks/client'
@@ -11,12 +11,8 @@ require 'securerandom'
 module SBF
   module Client
     class BaseEntity
-      include ActiveModel::AttributeAssignment
-      include ActiveModel::Dirty
-      extend ActiveModel::Naming
-      extend ActiveModel::Translation
-      include ActiveModel::Conversion
-      include EntityResponseConcern
+      include EntityResponseConcern, ActiveModel::Conversion, ActiveModel::Dirty, ActiveModel::AttributeAssignment
+      extend ActiveModel::Translation, ActiveModel::Naming
 
       attr_reader :errors
 
@@ -42,7 +38,7 @@ module SBF
 
       # Overridden from ActiveModel::Naming to remove namespace and Full/Partial
       def model_name
-        @_model_name ||= ActiveModel::Name.new(self, SBF::Client, self.class.name.gsub(/::(Full|Partial)/, '::'))
+        @model_name ||= ActiveModel::Name.new(self, SBF::Client, self.class.name.gsub(/::(Full|Partial)/, '::'))
       end
 
       def persisted?
@@ -113,7 +109,7 @@ module SBF
 
       # Mimic ActiveRecord::AttributeAssignment alias
       alias_method :attributes=, :assign_attributes
-
+      # rubocop:disable Naming/MemoizedInstanceVariableName
       def initialize_attributes(data)
         data ||= {}
         data.each do |key, value|
@@ -138,6 +134,7 @@ module SBF
         @collection_attributes ||= Set.new
       end
       private :initialize_attributes
+      # rubocop:enable Naming/MemoizedInstanceVariableName
 
       def mark_attribute_not_provided(name)
         return if not_provided_attributes.include?(name)
@@ -157,18 +154,18 @@ module SBF
 
         # If we set the value in a not_provided method, that means we now have requested the data and we
         # should replace the original getter/setter and set the value using the original method
-        define_singleton_method(setter) { |v|
+        define_singleton_method(setter) do |v|
           unmark_attribute_not_provided(name)
           super(v)
-        }
+        end
 
         # If we try to get the value in a not_provided method, we should raise an error
-        define_singleton_method(getter) {
+        define_singleton_method(getter) do
           raise(
             SBF::Client::DataNotProvidedError,
             "Data not provided for the #{name} attribute. This is usually due to the attribute not being requested in the 'with' declaration"
           )
-        }
+        end
       end
       private :mark_attribute_not_provided
 
@@ -392,7 +389,7 @@ module SBF
       private_class_method :define_changing_attr_methods
 
       # Creates a private method which resolves the class type based on the class mappings and the value
-      # rubocop:disable MethodLength
+      # rubocop:disable Metrics/MethodLength
       def self.add_class_selector_method(attribute, class_mappings)
         method_name = :"select_#{attribute}_class"
 
@@ -418,8 +415,8 @@ module SBF
 
           else
             # No class conversion if the value is already an entity
-            return nil if parsed_class_mappings.any? { |_, c1, c2|
-              [c1, c2].compact.any? { |allowed_class|
+            return nil if parsed_class_mappings.any? do |_, c1, c2|
+              [c1, c2].compact.any? do |allowed_class|
                 if allowed_class.instance_of?(Class)
                   # Otherwise, return true if the value is an instance of the allowed class
                   value.is_a?(allowed_class)
@@ -430,15 +427,15 @@ module SBF
                   allowed_class.constants.any? { |const_name| allowed_class.const_get(const_name) == value }
 
                 end
-              }
-            }
+              end
+            end
 
             # Convert to child class if given class is a parent of the same name
-            parsed_class_mappings.each { |_, c1, c2|
-              [c1, c2].compact.each { |allowed_class|
+            parsed_class_mappings.each do |_, c1, c2|
+              [c1, c2].compact.each do |allowed_class|
                 return allowed_class if allowed_class.ancestors.find { |a| a == value.class && a.demodulize == value.class.demodulize }
-              }
-            }
+              end
+            end
 
             # Don't know how to handle whatever the user entered. Raise an error.
             # (Nil and Hash are always valid values)
@@ -454,7 +451,7 @@ module SBF
 
         private_class_method method_name
       end
-      # rubocop:enable MethodLength
+      # rubocop:enable Metrics/MethodLength
       private_class_method :add_class_selector_method
 
       def self.get_mappings(attribute, class_mappings)
@@ -544,7 +541,7 @@ module SBF
       # Recursively converts an entity into a Hash
       def to_hash
         entity_hash = {}
-        self.class.defined_attributes.each { |key|
+        self.class.defined_attributes.each do |key|
           # If the method was not retrieved, do not include it in the hash
           next if not_provided_attributes.include?(key)
 
@@ -557,11 +554,11 @@ module SBF
 
                              # If the value is an Array, need to try to call to_hash on each item
                              elsif value.is_a?(Array)
-                               value.map { |element|
+                               value.map do |element|
                                  next element.to_hash if element.is_a?(BaseEntity)
 
                                  next element
-                               }
+                               end
 
                              # Collections should return empty array rather than nil
                              elsif value.nil? && self.class.collection_attributes.include?(key)
@@ -572,7 +569,7 @@ module SBF
                                value
 
                              end
-        }
+        end
 
         # Return the hash
         entity_hash

data/lib/stbaldricks/entities/lib/cacheable.rb

@@ -31,9 +31,7 @@ module SBF
             id
           end
 
-          private
-
-          def cache_id_from_hash_func(proc)
+          private def cache_id_from_hash_func(proc)
             raise ArgumentError, "Unable to re-set cache_id_from_hash on #{name}" if @cache_id_proc
 
             @cache_id_proc = proc

data/lib/stbaldricks/entities/lib/collection.rb

@@ -27,7 +27,7 @@ module SBF
         SBF::Client::ErrorEntity.new(code: errors.code, type: errors.type, details: details)
       end
 
-      # rubocop:disable MultipleComparison
+      # rubocop:disable Style/MultipleComparison
       def [](*args)
         log_deprecated('[]', caller) if args == [:results] || args == [:total_count]
         return self if args == [:results]
@@ -36,7 +36,7 @@ module SBF
         result = super
         result.is_a?(Array) ? self.class.new(result, total_count) : result
       end
-      # rubocop:enable MultipleComparison
+      # rubocop:enable Style/MultipleComparison
     end
   end
 end

data/lib/stbaldricks/entities/lib/not_implemented_object.rb

@@ -7,11 +7,11 @@ module SBF
       attr_accessor :props
 
       def initialize(attributes = {})
-        @props = {}.tap { |hsh|
-          attributes.each { |k, v|
+        @props = {}.tap do |hsh|
+          attributes.each do |k, v|
             hsh[k.to_sym] = v
-          }
-        }
+          end
+        end
 
         super
       end

data/lib/stbaldricks/entities/lib/top_level.rb

@@ -8,8 +8,8 @@ module SBF
       include Entities::Cacheable
 
       DEFAULT_ENDPOINT = SBF::Client::EntityEndpoint
-      DEFAULT_INSTANCE_ACTIONS = [:save, :create, :update, :delete]
-      DEFAULT_CLASS_ACTIONS = [:get, :find, :find_first, :aggregate, :update, :delete]
+      DEFAULT_INSTANCE_ACTIONS = %i(save create update delete)
+      DEFAULT_CLASS_ACTIONS = %i(get find find_first aggregate update delete)
       DEFAULT_CRUD_ACTIONS = DEFAULT_INSTANCE_ACTIONS + DEFAULT_CLASS_ACTIONS
 
       class << self
@@ -45,7 +45,7 @@ module SBF
           define_method(name) do |*args|
             result = endpoint.send(name, self, *args)
             result unless result.is_a?(SBF::Client::TopLevelEntity)
-            [:save, :create].include?(name) && result.errors? ? false : result
+            %i(save create).include?(name) && result.errors? ? false : result
           end
         end
 
@@ -58,7 +58,7 @@ module SBF
         end
 
         def action(name)
-          instance_action(name) if [:save, :create].include?(name)
+          instance_action(name) if %i(save create).include?(name)
 
           if name == :update
             define_method(name) do |*args|

data/lib/stbaldricks/entities/memorial.rb

@@ -7,8 +7,7 @@ require 'stbaldricks/entities/concerns/donation_recipient_concern'
 module SBF
   module Client
     class Memorial < SBF::Client::TopLevelEntity
-      include Entities::DefaultCacheable
-      include DonationRecipientConcern
+      include DonationRecipientConcern, Entities::DefaultCacheable
       actions DEFAULT_CRUD_ACTIONS
       blacklist_action :save
       blacklist_action :create

data/lib/stbaldricks/entities/page.rb

@@ -61,7 +61,7 @@ module SBF
 
       def add_draft_sections(sections)
         sections.each do |cid, data|
-          #convert symbol to integer
+          # convert symbol to integer
           cid = cid.to_s.to_i
 
           content = published_content.find { |c| c.id == cid }
@@ -69,9 +69,7 @@ module SBF
         end
       end
 
-      private
-
-      def update_draft_content_section(content, data, cid)
+      private def update_draft_content_section(content, data, cid)
         # update or create draft version of content
         draft = draft_content.find { |d| d.id == cid }
         if draft.nil?

data/lib/stbaldricks/entities/participant.rb

@@ -18,10 +18,7 @@ require 'stbaldricks/entities/concerns/fundraising_page_concern'
 module SBF
   module Client
     class Participant < SBF::Client::TopLevelEntity
-      include Entities::DefaultCacheable
-      include DonationRecipientConcern
-      include EventYearConcern
-      include FundraisingPageConcern
+      include FundraisingPageConcern, EventYearConcern, DonationRecipientConcern, Entities::DefaultCacheable
       endpoint SBF::Client::ParticipantEndpoint
       actions DEFAULT_CRUD_ACTIONS
       action :join_team
@@ -54,21 +51,21 @@ module SBF
         XXXXXL = '5x'
 
         def self.list
-          [
-            :FAST_REG_UNSPECIFIED,
-            :YOUTH_SMALL,
-            :YOUTH_MEDIUM,
-            :YOUTH_LARGE,
-            :XS,
-            :SMALL,
-            :MEDIUM,
-            :LARGE,
-            :XL,
-            :XXL,
-            :XXXL,
-            :XXXXL,
-            :XXXXXL
-          ]
+          %i(
+            FAST_REG_UNSPECIFIED
+            YOUTH_SMALL
+            YOUTH_MEDIUM
+            YOUTH_LARGE
+            XS
+            SMALL
+            MEDIUM
+            LARGE
+            XL
+            XXL
+            XXXL
+            XXXXL
+            XXXXXL
+          )
         end
       end
 

data/lib/stbaldricks/entities/person.rb

@@ -13,17 +13,16 @@ require 'stbaldricks/entities/concerns/type_concern'
 module SBF
   module Client
     class Person < SBF::Client::TopLevelEntity
-      include Entities::DefaultCacheable
-      include TypeConcern
+      include TypeConcern, Entities::DefaultCacheable
       disallow_instantiation
 
       actions DEFAULT_CRUD_ACTIONS
       blacklist_action :delete
 
       module Status
-        PENDING = 'pending' #1
-        ACTIVE = 'active' #2
-        DECEASED = 'deceased' #7 (may be deprecated: working on this with SBF)
+        PENDING = 'pending' # 1
+        ACTIVE = 'active' # 2
+        DECEASED = 'deceased' # 7 (may be deprecated: working on this with SBF)
       end
 
       module Type

data/lib/stbaldricks/entities/photo.rb

@@ -89,7 +89,7 @@ module SBF
       attr_reader :original_filename
 
       def to_json(*a)
-        to_hash.reject { |k, _v| [:file, :filename].include? k }.to_json(*a)
+        to_hash.reject { |k, _v| %i(file filename).include? k }.to_json(*a)
       end
 
       module Category

data/lib/stbaldricks/entities/team.rb

@@ -12,10 +12,7 @@ require 'stbaldricks/entities/concerns/fundraising_page_concern'
 module SBF
   module Client
     class Team < SBF::Client::TopLevelEntity
-      include Entities::DefaultCacheable
-      include DonationRecipientConcern
-      include EventYearConcern
-      include FundraisingPageConcern
+      include FundraisingPageConcern, EventYearConcern, DonationRecipientConcern, Entities::DefaultCacheable
       actions DEFAULT_CRUD_ACTIONS
 
       blacklist_action :create

data/lib/stbaldricks/enums/permission.rb

@@ -18,7 +18,7 @@ module SBF
 
       MANAGE_SYSTEM = 109
 
-      #Event permissions
+      # Event permissions
       EVENT_MANAGE = 200
       EVENT_MANAGE_INFO = 201
       EVENT_MANAGE_ACTIVITIES = 202
@@ -42,7 +42,7 @@ module SBF
       EVENT_FAST_REGISTRATION = 220
       EVENT_DELETE_EVENT = 221
 
-      #text descriptions found in LookupUtility
+      # text descriptions found in LookupUtility
       EVENT_MEMBER_UPDATE_EVENT_INFORMATION = 300
       EVENT_MEMBER_ACTIVITIES = 301
       EVENT_MEMBER_PHOTO_GALLERY = 302
@@ -60,7 +60,7 @@ module SBF
       EVENT_MEMBER_COMMUNICATE = 315
       EVENT_MEMBER_FAST_DONATION = 316
 
-      #Participant Role Permissions
+      # Participant Role Permissions
       EVENT_ORGANIZER = 1905
       EVENT_BARBER_COORDINATOR = 1911
       EVENT_SHAVEE_RECRUITER = 1913
@@ -115,7 +115,7 @@ module SBF
 
       EVENT_APPLICATION_MANAGE = 2202
 
-      #Team Permissions
+      # Team Permissions
       TEAM_TEAM_CAPTAIN = 2101
 
       # Memorial Permissions
@@ -140,7 +140,7 @@ module SBF
         DELETE_GROUPS => :DELETE_GROUPS,
         EDIT_GROUPS => :EDIT_GROUPS,
         MANAGE_SYSTEM => :MANAGE_SYSTEM,
-        #Event permissions
+        # Event permissions
         EVENT_MANAGE => :EVENT_MANAGE,
         EVENT_MANAGE_INFO => :EVENT_MANAGE_INFO,
         EVENT_MANAGE_ACTIVITIES => :EVENT_MANAGE_ACTIVITIES,
@@ -179,7 +179,7 @@ module SBF
         EVENT_MEMBER_VIEW_TEAM_TOTALS_LIST => :EVENT_MEMBER_VIEW_TEAM_TOTALS_LIST,
         EVENT_MEMBER_COMMUNICATE => :EVENT_MEMBER_COMMUNICATE,
         EVENT_MEMBER_FAST_DONATION => :EVENT_MEMBER_FAST_DONATION,
-        #Participant Role Permissions
+        # Participant Role Permissions
         EVENT_ORGANIZER => :EVENT_ORGANIZER,
         EVENT_BARBER_COORDINATOR => :EVENT_BARBER_COORDINATOR,
         EVENT_SHAVEE_RECRUITER => :EVENT_SHAVEE_RECRUITER,
@@ -211,9 +211,9 @@ module SBF
         FUNDRAISER_MANAGE => :FUNDRAISER_MANAGE,
         FUNDRAISER_DELETE_FUNDRAISER => :FUNDRAISER_DELETE_FUNDRAISER,
         EVENT_APPLICATION_MANAGE => :EVENT_APPLICATION_MANAGE,
-        #Team Permissions
+        # Team Permissions
         TEAM_TEAM_CAPTAIN => :TEAM_TEAM_CAPTAIN,
-        #Memorial Permissions
+        # Memorial Permissions
         MEMORIAL_VIEW => :MEMORIAL_VIEW,
         MEMORIAL_MANAGE => :MEMORIAL_MANAGE,
         # Challenge Permissions

data/lib/stbaldricks/log.rb

@@ -6,7 +6,7 @@ module SBF
     class LOG
       include Singleton
 
-      REQUIRED_METHODS = [:debug, :info, :warn, :error, :fatal, :unknown, :add, :level]
+      REQUIRED_METHODS = %i(debug info warn error fatal unknown add level)
 
       # rubocop:disable Style/MethodMissingSuper, Style/MissingRespondToMissing
       def self.method_missing(sym, *args, &block)

data/lib/stbaldricks/patches/hash.rb

@@ -3,9 +3,9 @@ class Hash
     keys.each do |key|
       unless key.is_a? Symbol
         value = delete(key)
-        # rubocop:disable RescueModifier
+        # rubocop:disable Style/RescueModifier
         self[(key.to_sym rescue key) || key] = value
-        # rubocop:enable RescueModifier
+        # rubocop:enable Style/RescueModifier
       end
 
       value.symbolize! if value.is_a?(Hash) || value.is_a?(Array)

data/lib/stbaldricks/request.rb

@@ -7,15 +7,15 @@ require 'uri'
 
 # Require all monkey patches
 patch_dir = File.realpath("#{File.dirname(__FILE__)}/patches/")
-Dir["#{patch_dir}/*.rb"].each { |file| require file }
+Dir["#{patch_dir}/*.rb"].sort.each { |file| require file }
 
 # Require all entities
 entity_dir = File.realpath("#{File.dirname(__FILE__)}/entities/")
-Dir["#{entity_dir}/**/*.rb"].each { |file| require file }
+Dir["#{entity_dir}/**/*.rb"].sort.each { |file| require file }
 
 # Require all enums
 enum_dir = File.realpath("#{File.dirname(__FILE__)}/enums/")
-Dir["#{enum_dir}/*.rb"].each { |file| require file }
+Dir["#{enum_dir}/*.rb"].sort.each { |file| require file }
 
 # Client library class for accessing the St. Baldrick's Foundation API
 module SBF

data/lib/stbaldricks/version.rb

@@ -1,5 +1,5 @@
 module SBF
   module Client
-    VERSION = '10.4.0.alpha.1'
+    VERSION = '10.6.0'
   end
 end

data/lib/stbaldricks_factories.rb

@@ -2,4 +2,4 @@ require 'stbaldricks'
 
 project_root = File.realpath("#{File.dirname(__FILE__)}/../")
 $LOAD_PATH.unshift(project_root)
-Dir["#{project_root}/spec/factories/**/*.rb"].each { |file| require file }
+Dir["#{project_root}/spec/factories/**/*.rb"].sort.each { |file| require file }

data/spec/factories/challenger.rb

@@ -2,9 +2,9 @@ require_relative 'lib/helpers'
 
 FactoryBot.define do
   factory :_base_challenger, class: SBF::Client::Challenger do
-    to_create { |it|
+    to_create do |it|
       raise "Failed to create #{it.class}: #{it.errors.details}" unless it.save
-    }
+    end
 
     initialize_with do
       new(attributes)

data/spec/factories/kid.rb

@@ -2,10 +2,10 @@ require_relative 'lib/helpers'
 
 FactoryBot.define do
   factory :kid, class: SBF::Client::FullKid do
-    to_create { |it|
+    to_create do |it|
       it.relationships.first.person = FactoryBot.create(:person) if it.relationships.first.person.nil?
       raise "Failed to create #{it.class}: #{it.errors.details}" unless it.save
-    }
+    end
 
     initialize_with do
       new(attributes)
@@ -19,7 +19,7 @@ FactoryBot.define do
     after :build do |kid, evaluator|
       kid.name_pieces = build(:name_pieces) if unpopulated?(evaluator, :name_pieces)
       kid.address = build(:address) if unpopulated?(evaluator, :address)
-      kid.diagnosis = build(:diagnosis) if unpopulated?(evaluator, :diagnosis)
+      kid.diagnosis = build(:diagnosis, date: Faker::Date.between(from: kid.birthday, to: DateTime.now).to_s) if unpopulated?(evaluator, :diagnosis)
       kid.treatment_status = build(:treatment_status) if unpopulated?(evaluator, :treatment_status)
       kid.web_page = build(:web_page) if unpopulated?(evaluator, :web_page)
       kid.photos = build(:photos) if unpopulated?(evaluator, :photos)

data/spec/factories/kid_institution.rb

@@ -3,10 +3,10 @@ require_relative 'lib/helpers'
 FactoryBot.define do
   # This is the relationship object between the kid and system institutions
   factory :kid_institution, class: SBF::Client::KidInstitution do
-    to_create { |it|
+    to_create do |it|
       it.kid = FactoryBot.create(:kid) if it.kid.nil?
       raise "Failed to create #{it.class}: #{it.errors.details}" unless it.save(kid: {}, institution: {})
-    }
+    end
 
     initialize_with do
       new(attributes)

data/spec/factories/team.rb

@@ -2,7 +2,7 @@ require_relative 'lib/helpers'
 
 FactoryBot.define do
   factory :team, class: SBF::Client::FullTeam do
-    to_create { |it|
+    to_create do |it|
       # Really gross - we don't support team create through the api currently.
       # Instead we need to use the start_team/move_participant_to_team logic
 
@@ -25,7 +25,7 @@ FactoryBot.define do
 
       # Return the new team
       it.attributes = team_hash.merge(captain: it.captain)
-    }
+    end
 
     initialize_with do
       new(attributes)

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: stbaldricks
 version: !ruby/object:Gem::Version
-  version: 10.4.0.alpha.1
+  version: 10.6.0
 platform: ruby
 authors:
 - Firespring
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-31 00:00:00.000000000 Z
+date: 2020-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 5.2.2
+        version: 5.2.4.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 5.2.2
+        version: 5.2.4.3
 - !ruby/object:Gem::Dependency
   name: htmlentities
   requirement: !ruby/object:Gem::Requirement
@@ -224,16 +224,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.82.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.82.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -552,9 +552,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.0.3
 signing_key: 
@@ -562,98 +562,98 @@ specification_version: 4
 summary: St. Baldrick's Foundation Ruby Client Library
 test_files:
 - lib/stbaldricks_factories.rb
-- spec/factories/memorial.rb
-- spec/factories/kid_honor.rb
-- spec/factories/donor.rb
-- spec/factories/newsletter_recipient.rb
-- spec/factories/recurring_gift.rb
-- spec/factories/contact.rb
-- spec/factories/team.rb
-- spec/factories/donation/participant.rb
-- spec/factories/phone.rb
+- spec/factories/collection.rb
+- spec/factories/user.rb
+- spec/factories/organization/addresses.rb
+- spec/factories/organization/email_addresses.rb
+- spec/factories/organization/phone_numbers.rb
+- spec/factories/search_participant.rb
+- spec/factories/location.rb
+- spec/factories/email_address.rb
+- spec/factories/grant_institution.rb
 - spec/factories/response.rb
+- spec/factories/fundraising_page.rb
 - spec/factories/grant.rb
-- spec/factories/researcher.rb
-- spec/factories/payment.rb
-- spec/factories/collection.rb
-- spec/factories/fundraiser.rb
-- spec/factories/lib/helpers.rb
-- spec/factories/lib/faker_patch.rb
-- spec/factories/person/email_addresses.rb
-- spec/factories/person/phone_numbers.rb
+- spec/factories/campaign.rb
+- spec/factories/donor.rb
+- spec/factories/kid_institution.rb
+- spec/factories/shave_schedule.rb
+- spec/factories/donation/participant.rb
 - spec/factories/person/addresses.rb
+- spec/factories/person/email_addresses.rb
 - spec/factories/person/policies.rb
-- spec/factories/campaign.rb
+- spec/factories/person/phone_numbers.rb
+- spec/factories/photo.rb
+- spec/factories/event_application.rb
+- spec/factories/kid.rb
+- spec/factories/event.rb
+- spec/factories/donation.rb
+- spec/factories/kid_honor.rb
+- spec/factories/message.rb
+- spec/factories/memorial/photos.rb
+- spec/factories/memorial/tribute.rb
+- spec/factories/memorial/totals.rb
+- spec/factories/photos.rb
+- spec/factories/kid/custom_institution.rb
+- spec/factories/phone.rb
+- spec/factories/campaign/totals.rb
 - spec/factories/page.rb
-- spec/factories/kid_institution.rb
+- spec/factories/newsletter_recipient.rb
+- spec/factories/memorial.rb
+- spec/factories/institution.rb
 - spec/factories/participant.rb
-- spec/factories/donation.rb
-- spec/factories/event/venue/social.rb
-- spec/factories/event/venue/location.rb
+- spec/factories/address.rb
+- spec/factories/contact_group.rb
+- spec/factories/venue.rb
+- spec/factories/permissions.rb
+- spec/factories/participant/rankings/ranking.rb
+- spec/factories/participant/photos.rb
+- spec/factories/participant/roles.rb
+- spec/factories/participant/roles/role.rb
+- spec/factories/participant/totals.rb
+- spec/factories/participant/rankings.rb
+- spec/factories/participant/policies.rb
+- spec/factories/diagnosis.rb
+- spec/factories/researcher.rb
+- spec/factories/contact.rb
+- spec/factories/organization.rb
+- spec/factories/search_fundraiser.rb
+- spec/factories/team.rb
+- spec/factories/event_supporter.rb
+- spec/factories/challenger.rb
+- spec/factories/disease.rb
+- spec/factories/third_party_media.rb
+- spec/factories/search_kid.rb
+- spec/factories/lib/faker_patch.rb
+- spec/factories/lib/helpers.rb
+- spec/factories/treatment_status.rb
+- spec/factories/recurring_gift.rb
+- spec/factories/name_pieces.rb
+- spec/factories/shave_schedule/time_selection_permissions.rb
 - spec/factories/event/coach_tracking/coaching_interactions.rb
-- spec/factories/event/coach_tracking/plaque.rb
 - spec/factories/event/coach_tracking/proceeds.rb
-- spec/factories/event/venue.rb
+- spec/factories/event/coach_tracking/plaque.rb
+- spec/factories/event/contacts.rb
+- spec/factories/event/photos.rb
 - spec/factories/event/contacts/contact.rb
 - spec/factories/event/contacts/name_pieces.rb
-- spec/factories/event/photos.rb
+- spec/factories/event/venue.rb
 - spec/factories/event/coach_tracking.rb
-- spec/factories/event/contacts.rb
+- spec/factories/event/venue/location.rb
+- spec/factories/event/venue/social.rb
 - spec/factories/event/totals.rb
-- spec/factories/permissions.rb
-- spec/factories/location.rb
-- spec/factories/participant/rankings/ranking.rb
-- spec/factories/participant/rankings.rb
-- spec/factories/participant/photos.rb
-- spec/factories/participant/policies.rb
-- spec/factories/participant/roles/role.rb
-- spec/factories/participant/roles.rb
-- spec/factories/participant/totals.rb
-- spec/factories/event_application.rb
-- spec/factories/message.rb
-- spec/factories/user.rb
-- spec/factories/shave_schedule.rb
 - spec/factories/team/rankings/ranking.rb
-- spec/factories/team/rankings.rb
 - spec/factories/team/photos.rb
 - spec/factories/team/totals.rb
-- spec/factories/search_participant.rb
+- spec/factories/team/rankings.rb
+- spec/factories/fundraiser/photos.rb
+- spec/factories/fundraiser/totals.rb
+- spec/factories/fundraiser/policies.rb
 - spec/factories/search_event.rb
-- spec/factories/photo.rb
-- spec/factories/kid/custom_institution.rb
+- spec/factories/person.rb
 - spec/factories/search_team.rb
+- spec/factories/fundraiser.rb
 - spec/factories/error.rb
-- spec/factories/search_fundraiser.rb
-- spec/factories/campaign/totals.rb
-- spec/factories/name_pieces.rb
-- spec/factories/challenger.rb
-- spec/factories/memorial/tribute.rb
-- spec/factories/memorial/photos.rb
-- spec/factories/memorial/totals.rb
-- spec/factories/venue.rb
-- spec/factories/institution.rb
-- spec/factories/treatment_status.rb
-- spec/factories/photos.rb
-- spec/factories/fund.rb
-- spec/factories/search_kid.rb
-- spec/factories/person.rb
-- spec/factories/contact_group.rb
-- spec/factories/disease.rb
-- spec/factories/fundraising_page.rb
-- spec/factories/event_supporter.rb
-- spec/factories/event.rb
-- spec/factories/organization/email_addresses.rb
-- spec/factories/organization/phone_numbers.rb
-- spec/factories/organization/addresses.rb
-- spec/factories/address.rb
-- spec/factories/third_party_media.rb
-- spec/factories/kid.rb
-- spec/factories/shave_schedule/time_selection_permissions.rb
+- spec/factories/payment.rb
 - spec/factories/challenge.rb
-- spec/factories/fundraiser/photos.rb
-- spec/factories/fundraiser/policies.rb
-- spec/factories/fundraiser/totals.rb
-- spec/factories/organization.rb
-- spec/factories/grant_institution.rb
-- spec/factories/email_address.rb
-- spec/factories/diagnosis.rb
+- spec/factories/fund.rb