staypuft 0.3.1 → 0.3.2

data/app/lib/staypuft/seeder.rb

@@ -203,13 +203,13 @@ module Staypuft
                                            :layouts  => ALL_LAYOUTS}
     }
 
-    def get_host_format(param_name)
-      { :string => '<%%= d = @host.deployment; d.ha? ? d.vips.get(:%s) : d.ips.controller_ip %%>' % param_name }
+    def get_host_format(param_name, subnet_type_name)
+      { :string => "<%= d = @host.deployment; d.ha? ? d.network_query.get_vip(:#{param_name}) : d.network_query.controller_ip('#{subnet_type_name}') %>" }
     end
 
     # virtual ip addresses
     def vip_format(param_name)
-      { :string => '<%%= @host.deployment.vips.get(:%s) %%>' % param_name }
+      { :string => '<%%= @host.deployment.network_query.get_vip(:%s) %%>' % param_name }
     end
 
     def functional_dependencies
@@ -224,8 +224,8 @@ module Staypuft
       network_num_networks        = { :string => '<%= @host.deployment.nova.num_networks %>' }
       network_fixed_range         = { :string => '<%= @host.deployment.nova.private_fixed_range %>' }
       network_floating_range      = { :string => '<%= @host.deployment.nova.public_floating_range %>' }
-      network_private_iface       = { :string => '<%= @host.deployment.nova.private_iface %>' }
-      network_public_iface        = { :string => '<%= @host.deployment.nova.public_iface %>' }
+      network_private_iface       = { :string => "<%= @host.deployment.network_query.interface_for_host(@host, '#{Staypuft::SubnetType::TENANT}') %>" }
+      network_public_iface        = { :string => "<%= @host.deployment.network_query.interface_for_host(@host, '#{Staypuft::SubnetType::EXTERNAL}') %>" }
       network_create_networks     = true
 
       # Neutron
@@ -237,12 +237,12 @@ module Staypuft
       ml2_tunnel_id_ranges        = ['10:1000']
       ml2_vni_ranges              = ['10:1000']
       ovs_tunnel_types            = ['vxlan', 'gre']
-      ovs_tunnel_iface            = { :string => '<%= n = @host.deployment.neutron; n.enable_tunneling? ? n.networker_tenant_iface : "" %>' }
-      ovs_bridge_mappings         = { :array =>  '<%= @host.deployment.neutron.networker_ovs_bridge_mappings %>' }
-      ovs_bridge_uplinks          = { :array =>  '<%= @host.deployment.neutron.networker_ovs_bridge_uplinks %>' }
-      compute_ovs_tunnel_iface    = { :string => '<%= n = @host.deployment.neutron; n.enable_tunneling? ? n.compute_tenant_iface : "" %>' }
-      compute_ovs_bridge_mappings = { :array =>  '<%= @host.deployment.neutron.compute_ovs_bridge_mappings %>' }
-      compute_ovs_bridge_uplinks  = { :array =>  '<%= @host.deployment.neutron.compute_ovs_bridge_uplinks %>' }
+      ovs_tunnel_iface            = { :string => '<%= n = @host.deployment.neutron; n.enable_tunneling? ? n.tenant_iface(@host) : "" %>' }
+      ovs_bridge_mappings         = { :array =>  '<%= @host.deployment.neutron.networker_ovs_bridge_mappings(@host) %>' }
+      ovs_bridge_uplinks          = { :array =>  '<%= @host.deployment.neutron.networker_ovs_bridge_uplinks(@host) %>' }
+      compute_ovs_tunnel_iface    = { :string => '<%= n = @host.deployment.neutron; n.enable_tunneling? ? n.tenant_iface(@host) : "" %>' }
+      compute_ovs_bridge_mappings = { :array =>  '<%= @host.deployment.neutron.compute_ovs_bridge_mappings(@host) %>' }
+      compute_ovs_bridge_uplinks  = { :array =>  '<%= @host.deployment.neutron.compute_ovs_bridge_uplinks(@host) %>' }
       enable_tunneling            = { :string => '<%= @host.deployment.neutron.enable_tunneling?.to_s %>' }
 
       # Glance
@@ -263,7 +263,7 @@ module Staypuft
       cinder_backend_iscsi_name   = 'iscsi_backend'
       cinder_backend_nfs          = { :string => '<%= @host.deployment.cinder.nfs_backend? %>' }
       cinder_backend_nfs_name     = 'nfs_backend'
-      cinder_multiple_backends    = false
+      cinder_multiple_backends    = { :string => '<%= @host.deployment.cinder.multiple_backends? %>' }
       cinder_nfs_shares           = ['<%= @host.deployment.cinder.nfs_uri %>']
       cinder_nfs_mount_options    = 'nosharecache'
 
@@ -280,11 +280,11 @@ module Staypuft
       cinder_backend_eqlx_name      = ['eqlx_backend']
       # TODO: confirm these params and add them to model where user input is needed
       # below dynamic calls are commented out since the model does not yet have san/chap entries
-      cinder_san_ip                 = ['<%= @host.deployment.cinder.san_ip %>']
-      cinder_san_login              = ['<%= @host.deployment.cinder.san_login %>']
-      cinder_san_password           = ['<%= @host.deployment.cinder.san_password %>']
-      cinder_eqlx_group_name        = ['<%= @host.deployment.cinder.eqlx_group_name %>']
-      cinder_eqlx_pool              = ['<%= @host.deployment.cinder.eqlx_pool %>']
+      cinder_san_ip                 = { :array => '<%= @host.deployment.cinder.compute_eqlx_san_ips %>' }
+      cinder_san_login              = { :array => '<%= @host.deployment.cinder.compute_eqlx_san_logins %>' }
+      cinder_san_password           = { :array => '<%= @host.deployment.cinder.compute_eqlx_san_passwords %>' }
+      cinder_eqlx_group_name        = { :array => '<%= @host.deployment.cinder.compute_eqlx_group_names %>' }
+      cinder_eqlx_pool              = { :array => '<%= @host.deployment.cinder.compute_eqlx_pools %>'}
 
       cinder_san_thin_provision     = ['false']
       cinder_eqlx_use_chap          = ['false']
@@ -326,15 +326,20 @@ module Staypuft
       neutron_metadata_proxy_secret = { :string => '<%= @host.deployment.passwords.neutron_metadata_proxy_secret %>' }
 
 
-      private_ip   = { :string => '<%= @host.ip %>' }
-      amqp_host    = get_host_format :amqp
-      mysql_host   = get_host_format :db
-      glance_host  = get_host_format :glance
-      auth_host    = get_host_format :keystone
-      neutron_host = get_host_format :neutron
-      nova_host    = get_host_format :nova
+      private_ip   = { :string => "<%= @host.deployment.network_query.ip_for_host(@host, '#{Staypuft::SubnetType::MANAGEMENT}') %>" }
+      # private API/management
+      amqp_host    = get_host_format :amqp_vip, Staypuft::SubnetType::MANAGEMENT
+      mysql_host   = get_host_format :db_vip, Staypuft::SubnetType::MANAGEMENT
+      glance_host  = get_host_format :glance_private_vip, Staypuft::SubnetType::MANAGEMENT
+      neutron_host = get_host_format :neutron_private_vip, Staypuft::SubnetType::MANAGEMENT
+      #admin API
+      auth_host    = get_host_format :keystone_admin_vip, Staypuft::SubnetType::ADMIN_API
+      # public API
+      nova_host    = get_host_format :nova_public_vip, Staypuft::SubnetType::PUBLIC_API
 
-      controller_host = { :string => '<%= d = @host.deployment; d.ha? ? nil : d.ips.controller_ip %>'}
+      controller_admin_host = { :string => "<%= d = @host.deployment; d.ha? ? nil : d.network_query.controller_ip('#{Staypuft::SubnetType::ADMIN_API}') %>"}
+      controller_priv_host  = { :string => "<%= d = @host.deployment; d.ha? ? nil : d.network_query.controller_ip('#{Staypuft::SubnetType::MANAGEMENT}') %>"}
+      controller_pub_host   = { :string => "<%= d = @host.deployment; d.ha? ? nil : d.network_query.controller_ip('#{Staypuft::SubnetType::PUBLIC_API}') %>"}
 
       {
           'quickstack::nova_network::controller'   => {
@@ -394,11 +399,11 @@ module Staypuft
               'mysql_host'                              => mysql_host,
               'swift_shared_secret'                     => swift_shared_secret,
               'swift_ringserver_ip'                     => '',
-              'swift_storage_ips'                       => { :array => '<%= @host.deployment.ips.controller_ips %>' },
+              'swift_storage_ips'                       => { :array => "<%= @host.deployment.network_query.controller_ips('#{Staypuft::SubnetType::MANAGEMENT}') %>" },
               'cinder_gluster_shares'                   => [],
-              'controller_admin_host'                   => controller_host,
-              'controller_priv_host'                    => controller_host,
-              'controller_pub_host'                     => controller_host },
+              'controller_admin_host'                   => controller_admin_host,
+              'controller_priv_host'                    => controller_priv_host,
+              'controller_pub_host'                     => controller_pub_host },
           'quickstack::neutron::controller'        => {
               'amqp_provider'                           => amqp_provider,
               'tenant_network_type'                     => tenant_network_type,
@@ -467,11 +472,11 @@ module Staypuft
               'mysql_host'                              => mysql_host,
               'swift_shared_secret'                     => swift_shared_secret,
               'swift_ringserver_ip'                     => '',
-              'swift_storage_ips'                       => { :array => '<%= @host.deployment.ips.controller_ips %>' },
+              'swift_storage_ips'                       => { :array => "<%= @host.deployment.network_query.controller_ips('#{Staypuft::SubnetType::MANAGEMENT}') %>" },
               'cinder_gluster_shares'                   => [],
-              'controller_admin_host'                   => controller_host,
-              'controller_priv_host'                    => controller_host,
-              'controller_pub_host'                     => controller_host },
+              'controller_admin_host'                   => controller_admin_host,
+              'controller_priv_host'                    => controller_priv_host,
+              'controller_pub_host'                     => controller_pub_host },
           'quickstack::pacemaker::params'          => {
               'include_swift'                 => 'false',
               'include_neutron'               => neutron,
@@ -494,43 +499,43 @@ module Staypuft
               'amqp_password'                 => amqp_pw,
               'heat_auth_encryption_key'      => heat_auth_encrypt_key,
               'neutron_metadata_proxy_secret' => neutron_metadata_proxy_secret,
-              'ceilometer_admin_vip'          => vip_format(:ceilometer),
-              'ceilometer_private_vip'        => vip_format(:ceilometer),
-              'ceilometer_public_vip'         => vip_format(:ceilometer),
-              'cinder_admin_vip'              => vip_format(:cinder),
-              'cinder_private_vip'            => vip_format(:cinder),
-              'cinder_public_vip'             => vip_format(:cinder),
-              'db_vip'                        => vip_format(:db),
-              'glance_admin_vip'              => vip_format(:glance),
-              'glance_private_vip'            => vip_format(:glance),
-              'glance_public_vip'             => vip_format(:glance),
-              'heat_admin_vip'                => vip_format(:heat),
-              'heat_private_vip'              => vip_format(:heat),
-              'heat_public_vip'               => vip_format(:heat),
-              'heat_cfn_admin_vip'            => vip_format(:heat_cfn),
-              'heat_cfn_private_vip'          => vip_format(:heat_cfn),
-              'heat_cfn_public_vip'           => vip_format(:heat_cfn),
-              'horizon_admin_vip'             => vip_format(:horizon),
-              'horizon_private_vip'           => vip_format(:horizon),
-              'horizon_public_vip'            => vip_format(:horizon),
-              'keystone_admin_vip'            => vip_format(:keystone),
-              'keystone_private_vip'          => vip_format(:keystone),
-              'keystone_public_vip'           => vip_format(:keystone),
-              'loadbalancer_vip'              => vip_format(:loadbalancer),
-              'neutron_admin_vip'             => vip_format(:neutron),
-              'neutron_private_vip'           => vip_format(:neutron),
-              'neutron_public_vip'            => vip_format(:neutron),
-              'nova_admin_vip'                => vip_format(:nova),
-              'nova_private_vip'              => vip_format(:nova),
-              'nova_public_vip'               => vip_format(:nova),
-              'amqp_vip'                      => vip_format(:amqp),
-              'swift_public_vip'              => vip_format(:swift),
+              'ceilometer_admin_vip'          => vip_format(:ceilometer_admin_vip),
+              'ceilometer_private_vip'        => vip_format(:ceilometer_private_vip),
+              'ceilometer_public_vip'         => vip_format(:ceilometer_public_vip),
+              'cinder_admin_vip'              => vip_format(:cinder_admin_vip),
+              'cinder_private_vip'            => vip_format(:cinder_private_vip),
+              'cinder_public_vip'             => vip_format(:cinder_public_vip),
+              'db_vip'                        => vip_format(:db_vip),
+              'glance_admin_vip'              => vip_format(:glance_admin_vip),
+              'glance_private_vip'            => vip_format(:glance_private_vip),
+              'glance_public_vip'             => vip_format(:glance_public_vip),
+              'heat_admin_vip'                => vip_format(:heat_admin_vip),
+              'heat_private_vip'              => vip_format(:heat_private_vip),
+              'heat_public_vip'               => vip_format(:heat_public_vip),
+              'heat_cfn_admin_vip'            => vip_format(:heat_cfn_admin_vip),
+              'heat_cfn_private_vip'          => vip_format(:heat_cfn_private_vip),
+              'heat_cfn_public_vip'           => vip_format(:heat_cfn_public_vip),
+              'horizon_admin_vip'             => vip_format(:horizon_admin_vip),
+              'horizon_private_vip'           => vip_format(:horizon_private_vip),
+              'horizon_public_vip'            => vip_format(:horizon_public_vip),
+              'keystone_admin_vip'            => vip_format(:keystone_admin_vip),
+              'keystone_private_vip'          => vip_format(:keystone_private_vip),
+              'keystone_public_vip'           => vip_format(:keystone_public_vip),
+              'loadbalancer_vip'              => vip_format(:loadbalancer_vip),
+              'neutron_admin_vip'             => vip_format(:neutron_admin_vip),
+              'neutron_private_vip'           => vip_format(:neutron_private_vip),
+              'neutron_public_vip'            => vip_format(:neutron_public_vip),
+              'nova_admin_vip'                => vip_format(:nova_admin_vip),
+              'nova_private_vip'              => vip_format(:nova_private_vip),
+              'nova_public_vip'               => vip_format(:nova_public_vip),
+              'amqp_vip'                      => vip_format(:amqp_vip),
+              'swift_public_vip'              => vip_format(:swift_public_vip),
               'private_ip'                    => private_ip,
-              'cluster_control_ip'            => { :string => '<%= @host.deployment.ips.controller_ips.first %>' },
-              'lb_backend_server_addrs'       => { :array => '<%= @host.deployment.ips.controller_ips %>' },
-              'lb_backend_server_names'       => { :array => '<%= @host.deployment.ips.controller_fqdns %>' } },
+              'cluster_control_ip'            => { :string => "<%= @host.deployment.network_query.controller_ips('#{Staypuft::SubnetType::MANAGEMENT}').first %>" },
+              'lb_backend_server_addrs'       => { :array => "<%= @host.deployment.network_query.controller_ips('#{Staypuft::SubnetType::MANAGEMENT}') %>" },
+              'lb_backend_server_names'       => { :array => '<%= @host.deployment.network_query.controller_fqdns %>' } },
           'quickstack::pacemaker::common'          => {
-              'pacemaker_cluster_members' => { :string => '<%= @host.deployment.ips.controller_ips.join(" ") %>' } },
+              'pacemaker_cluster_members' => { :string => "<%= @host.deployment.network_query.controller_ips('#{Staypuft::SubnetType::MANAGEMENT}').join(' ') %>" } },
           'quickstack::pacemaker::neutron'         => {
               'ml2_network_vlan_ranges'  => ml2_network_vlan_ranges,
               'ml2_tenant_network_types' => ml2_tenant_network_types,
@@ -580,10 +585,9 @@ module Staypuft
               'secret_key' => horizon_secret_key },
           'quickstack::pacemaker::galera'          => {
               'mysql_root_password'   => mysql_root_pw,
-              'wsrep_cluster_members' => { :array => '<%= @host.deployment.ips.controller_ips %>' } },
+              'wsrep_cluster_members' => { :array => "<%= @host.deployment.network_query.controller_ips('#{Staypuft::SubnetType::MANAGEMENT}') %>" } },
           'quickstack::pacemaker::swift'           => {
               'swift_shared_secret' => swift_shared_secret,
-              'swift_internal_vip'  => vip_format(:swift),
               'swift_storage_ips'   => [] },
           'quickstack::pacemaker::nova'            => {
               'multi_host'                    => 'true',
@@ -605,7 +609,7 @@ module Staypuft
               'neutron_metadata_proxy_secret' => neutron_metadata_proxy_secret,
               'amqp_host'                     => amqp_host,
               'mysql_host'                    => mysql_host,
-              'controller_priv_host'          => controller_host },
+              'controller_priv_host'          => controller_priv_host },
           'quickstack::storage_backend::cinder'    => {
               'amqp_provider'        => amqp_provider,
               'cinder_db_password'   => cinder_db_pw,

data/app/models/staypuft/concerns/host_interface_management.rb

@@ -13,16 +13,39 @@ module Staypuft
 
       def interfaces_identifiers
         interfaces = [ self.primary_interface ]
-        interfaces += self.respond_to?(:interfaces) ? self.interfaces.where("type <> 'Nic::BMC'").physical.map(&:identifier) : []
+        interfaces += self.respond_to?(:interfaces) ? self.interfaces.where("type <> 'Nic::BMC'").non_vip.physical.map(&:identifier) : []
         interfaces
       end
 
       def make_all_interfaces_managed
-        self.interfaces.each do |interface|
+        self.interfaces.non_vip.each do |interface|
           interface.managed = true
           interface.save!
         end
       end
+
+      def build_vips(parameters)
+        deployment = self.hostgroup.deployment
+        typings = deployment.subnet_typings
+        types = SubnetType.where(:name => parameters.values).all
+        n = 0
+
+        parameters.each do |parameter, subnet_type|
+          type = types.find { |t| t.name == subnet_type }
+          raise "unable to find subnet type with name #{subnet_type}" if type.nil?
+
+          subnet = typings.where(:subnet_type_id => type.id).first.subnet
+          raise "unable to find subnet assigned to type #{subnet_type} in deployment #{deployment.name}" if subnet.nil?
+
+          interface = self.interfaces.build(:type => 'Nic::Managed')
+          interface.identifier = "vip#{n}"
+          interface.subnet = subnet
+          interface.managed = false
+          interface.mac = "00:00:00:00:00:#{n.to_s(16).rjust(2, '0')}"
+          interface.tag = parameter
+          n += 1
+        end
+      end
     end
   end
 end

data/app/models/staypuft/concerns/subnet_ip_management.rb

@@ -0,0 +1,17 @@
+module Staypuft
+  module Concerns
+    module SubnetIpManagement
+      extend ActiveSupport::Concern
+
+      included do
+        before_save :reserve_ip
+      end
+
+      def reserve_ip
+        if self.identifier =~ /\Avip\d+\Z/ && self.subnet.present? && self.subnet.ipam?
+          self.ip ||= self.subnet.unused_ip
+        end
+      end
+    end
+  end
+end

data/app/models/staypuft/concerns/vip_nic_scopes.rb

@@ -0,0 +1,13 @@
+module Staypuft
+  module Concerns
+    module VipNicScopes
+      extend ActiveSupport::Concern
+
+      included do
+        scope :vip, lambda { where(['identifier LIKE ?', 'vip%']) }
+        scope :non_vip, lambda { where(['identifier NOT LIKE ?', 'vip%']) }
+      end
+
+    end
+  end
+end

data/app/models/staypuft/deployment/attribute_param_storage.rb

@@ -16,7 +16,7 @@ module Staypuft
         end
 
         define_method "#{name}=" do |value|
-          instance_variable_set(ivar_name, value)
+          instance_variable_set(:"@#{name}", value)
         end
 
         after_save do
@@ -36,6 +36,64 @@ module Staypuft
         end
       end
     end
+
+    def param_attr_array(*names)
+      names.each do |item|
+        item.each do |name, type|
+          ivar_name = :"@#{name}"
+          param_base_name = "ui::#{param_scope}::#{name}"
+
+          define_method name do
+            instance_variable_get(ivar_name) or
+            begin
+              params = hostgroup.group_parameters.where(['name LIKE ?', "#{param_base_name}%"])
+              ivar = []
+              params.each do |param|
+                value = param.try(:value)
+                unless value.nil?
+                  full, index = *param.name.match(/#{param_base_name}::(\d+)/)
+                  ivar[index.to_i] ||= type.new({id: index.to_i }.merge(JSON.parse(value)))
+                end
+              end
+              instance_variable_set(ivar_name, ivar)
+            end
+          end
+
+          define_method "#{name}=" do |value|
+            if value.is_a? Hash
+              values = []
+              value.each do |k,v|
+                values << type.new(v)
+              end
+              instance_variable_set(:"@#{name}", values)
+            else
+              instance_variable_set(:"@#{name}", value)
+            end
+          end
+
+          define_method "#{name}_attributes=" do |attributes|
+            Rails.logger.error attributes
+          end
+
+          after_save do
+            values = send(name)
+            # Delete all params since array can shrink
+            params = hostgroup.group_parameters.where(['name LIKE ?', "#{param_base_name}%"])
+            params.each do |param|
+              param.try(:destroy)
+            end
+            if not values.blank?
+              values.each_with_index do |value, index|
+                param = hostgroup.
+                    group_parameters.
+                        find_or_initialize_by_name( "#{param_base_name}::#{index}")
+                param.update_attributes!(value: value.to_json(root:false))
+              end
+            end
+          end
+        end
+      end
+    end
   end
 end
 

data/app/models/staypuft/deployment/cinder_service/equallogic.rb

@@ -0,0 +1,80 @@
+#encoding: utf-8
+module Staypuft
+  class Deployment::CinderService::Equallogic
+    include ActiveModel::Serializers::JSON
+    include ActiveModel::Validations
+    extend ActiveModel::Naming
+
+    attr_accessor :id, :san_ip, :san_login, :san_password, :pool, :group_name
+    attr_reader :errors
+
+    def initialize(attrs = {})
+      @errors = ActiveModel::Errors.new(self)
+      self.attributes = attrs
+    end
+
+    def self.human_attribute_name(attr, options = {})
+      attr
+    end
+
+    def self.lookup_ancestors
+      [self]
+    end
+
+    def attributes
+      { 'san_ip' => nil, 'san_login' => nil, 'san_password' => nil, 'pool' => nil, 'group_name' => nil }
+    end
+
+    def attributes=(attrs)
+      attrs.each { |attr, value| send "#{attr}=", value } unless attrs.nil?
+    end
+
+    class SanIpValueValidator < ActiveModel::EachValidator
+      def validate_each(record, attribute, value)
+        return if value.empty?
+
+        begin
+          ip_addr = IPAddr.new(value)
+          ip_range = ip_addr.to_range
+          if ip_range.begin == ip_range.end
+            true
+          else
+            record.errors.add attribute, "Specify single IP address, not range"
+            false
+          end
+        rescue
+          # not IP addr
+          # validating as fqdn
+          if /(?=^.{1,254}$)(^(((?!-)[a-zA-Z0-9-]{1,63}(?<!-))|((?!-)[a-zA-Z0-9-]{1,63}(?<!-)\.)+[a-zA-Z]{2,63})$)/ =~ value
+            true
+          else
+            record.errors.add attribute, "Invalid IP address or FQDN supplied"
+            false
+          end
+        end
+      end
+    end
+
+    validates :san_ip,
+              presence: true,
+              san_ip_value: true
+    validates :san_login,
+              presence: true,
+              format: /\A[a-zA-Z\d][\w\.\-]*[\w\-]\z/,
+              length: { maximum: 16 }
+    validates :san_password,
+              presence: true,
+              format: /\A[!-~]+\z/,
+              length: { minimum:3, maximum: 16 }
+    validates :pool,
+              presence: true,
+              format: /\A[[^\p{Z}\p{C}!"\#$%&'\(\)\*\+,\/;<=>\?@\[\]\\\^\{\}|~\.\-:]][[^\p{Z}\p{C}!"\#$%&'\(\)\*\+,\/;<=>\?@\[\]\\\^\{\}|~]]+[[^\p{Z}\p{C}!"\#$%&'\(\)\*\+,\/;<=>\?@\[\]\\\^\{\}|~\.\-:]]\z/,
+              length: { maximum: 63,
+                             too_long: "Too long: max length is %{count} bytes. Using multibyte characters reduces the maximum number of characters allowed.",
+                             tokenizer: lambda {|str| str.bytes.to_a } }
+    validates :group_name,
+              presence: true,
+              format: /\A[a-zA-Z\d][a-zA-Z\d\-]*\z/,
+              length: { maximum: 54 }
+  end
+end