statsig 1.31.1 → 1.32.0

data/lib/feature_gate.rb

@@ -1,42 +1,19 @@
-# typed: false
-
-require 'sorbet-runtime'
-
 class FeatureGate
-  extend T::Sig
 
-  sig { returns(String) }
   attr_accessor :name
 
-  sig { returns(T::Boolean) }
   attr_accessor :value
 
-  sig { returns(String) }
   attr_accessor :rule_id
 
-  sig { returns(T.nilable(String)) }
   attr_accessor :group_name
 
-  sig { returns(String) }
   attr_accessor :id_type
 
-  sig { returns(T.nilable(Statsig::EvaluationDetails)) }
   attr_accessor :evaluation_details
 
-  sig { returns(T.nilable(T::Array[String])) }
   attr_accessor :target_app_ids
 
-  sig do
-    params(
-      name: String,
-      value: T::Boolean,
-      rule_id: String,
-      group_name: T.nilable(String),
-      id_type: String,
-      evaluation_details: T.nilable(Statsig::EvaluationDetails),
-      target_app_ids: T.nilable(T::Array[String])
-    ).void
-  end
   def initialize(
     name,
     value: false,
@@ -55,7 +32,6 @@ class FeatureGate
     @target_app_ids = target_app_ids
   end
 
-  sig { params(res: Statsig::ConfigResult).returns(FeatureGate) }
   def self.from_config_result(res)
     new(
       res.name,

data/lib/id_list.rb

@@ -1,4 +1,4 @@
-# typed: true
+
 module Statsig
   class IDList
     attr_accessor :name

data/lib/interfaces/data_store.rb

@@ -1,4 +1,4 @@
-# typed: true
+
 module Statsig
   module Interfaces
     class IDataStore

data/lib/interfaces/user_persistent_storage.rb

@@ -1,4 +1,4 @@
-# typed: true
+
 module Statsig
   module Interfaces
     class IUserPersistentStorage

data/lib/layer.rb

@@ -1,6 +1,3 @@
-# typed: false
-
-require 'sorbet-runtime'
 ##
 # Contains the current values from Statsig.
 # Will contain layer default values for all shared parameters in that layer.
@@ -9,37 +6,22 @@ require 'sorbet-runtime'
 #
 # Layers Documentation: https://docs.statsig.com/layers
 class Layer
-  extend T::Sig
 
-  sig { returns(String) }
   attr_accessor :name
 
-  sig { returns(String) }
   attr_accessor :rule_id
 
-  sig { returns(String) }
   attr_accessor :group_name
 
-  sig do
-    params(
-      name: String,
-      value: T::Hash[String, T.untyped],
-      rule_id: String,
-      group_name: T.nilable(String),
-      allocated_experiment: T.nilable(String),
-      exposure_log_func: T.any(Method, Proc, NilClass)
-    ).void
-  end
   def initialize(name, value = {}, rule_id = '', group_name = nil, allocated_experiment = nil, exposure_log_func = nil)
     @name = name
-    @value = value
+    @value = value || {}
     @rule_id = rule_id
     @group_name = group_name
     @allocated_experiment = allocated_experiment
     @exposure_log_func = exposure_log_func
   end
 
-  sig { params(index: String, default_value: T.untyped).returns(T.untyped) }
   ##
   # Get the value for the given key (index), falling back to the default_value if it cannot be found.
   #
@@ -55,7 +37,6 @@ class Layer
     @value[index]
   end
 
-  sig { params(index: String, default_value: T.untyped).returns(T.untyped) }
   ##
   # Get the value for the given key (index), falling back to the default_value if it cannot be found
   # or is found to have a different type from the default_value.

data/lib/network.rb

@@ -1,9 +1,7 @@
-# typed: true
-
 require 'http'
 require 'json'
 require 'securerandom'
-require 'sorbet-runtime'
+
 require 'uri_helper'
 require 'connection_pool'
 
@@ -20,9 +18,7 @@ module Statsig
   end
 
   class Network
-    extend T::Sig
 
-    sig { params(server_secret: String, options: StatsigOptions, backoff_mult: Integer).void }
     def initialize(server_secret, options, backoff_mult = 10)
       super()
       URIHelper.initialize(options)
@@ -54,41 +50,18 @@ module Statsig
       end
     end
 
-    sig do
-      params(since_time: Integer)
-        .returns([T.any(HTTP::Response, NilClass), T.any(StandardError, NilClass)])
-    end
     def download_config_specs(since_time)
       get("download_config_specs/#{@server_secret}.json?sinceTime=#{since_time}")
     end
 
-    class HttpMethod < T::Enum
-      enums do
-        GET = new
-        POST = new
-      end
-    end
-
-    sig do
-      params(endpoint: String, retries: Integer, backoff: Integer)
-        .returns([T.any(HTTP::Response, NilClass), T.any(StandardError, NilClass)])
-    end
     def get(endpoint, retries = 0, backoff = 1)
-      request(HttpMethod::GET, endpoint, nil, retries, backoff)
+      request(:GET, endpoint, nil, retries, backoff)
     end
 
-    sig do
-      params(endpoint: String, body: String, retries: Integer, backoff: Integer)
-        .returns([T.any(HTTP::Response, NilClass), T.any(StandardError, NilClass)])
-    end
     def post(endpoint, body, retries = 0, backoff = 1)
-      request(HttpMethod::POST, endpoint, body, retries, backoff)
+      request(:POST, endpoint, body, retries, backoff)
     end
 
-    sig do
-      params(method: HttpMethod, endpoint: String, body: T.nilable(String), retries: Integer, backoff: Integer)
-        .returns([T.any(HTTP::Response, NilClass), T.any(StandardError, NilClass)])
-    end
     def request(method, endpoint, body, retries = 0, backoff = 1)
       if @local_mode
         return nil, nil
@@ -107,9 +80,9 @@ module Statsig
         res = @connection_pool.with do |conn|
           request = conn.headers('STATSIG-CLIENT-TIME' => (Time.now.to_f * 1000).to_i.to_s)
           case method
-          when HttpMethod::GET
+          when :GET
             request.get(url)
-          when HttpMethod::POST
+          when :POST
             request.post(url, body: body)
           end
         end
@@ -133,7 +106,7 @@ module Statsig
     end
 
     def post_logs(events)
-      json_body = JSON.generate({ 'events' => events, 'statsigMetadata' => Statsig.get_statsig_metadata })
+      json_body = JSON.generate({ events: events, statsigMetadata: Statsig.get_statsig_metadata })
       post('log_event', json_body, @post_logs_retry_limit)
     rescue StandardError
 

data/lib/spec_store.rb

@@ -1,17 +1,24 @@
-# typed: false
 require 'net/http'
 require 'uri'
 require 'evaluation_details'
 require 'id_list'
 require 'concurrent-ruby'
 require 'hash_utils'
+require 'api_config'
 
 module Statsig
   class SpecStore
-
     attr_accessor :last_config_sync_time
     attr_accessor :initial_config_sync_time
     attr_accessor :init_reason
+    attr_accessor :gates
+    attr_accessor :configs
+    attr_accessor :layers
+    attr_accessor :id_lists
+    attr_accessor :experiment_to_layer
+    attr_accessor :sdk_keys_to_app_ids
+    attr_accessor :hashed_sdk_keys_to_app_ids
+    attr_accessor :unsupported_configs
 
     def initialize(network, options, error_callback, diagnostics, error_boundary, logger, secret_key)
       @init_reason = EvaluationReason::UNINITIALIZED
@@ -23,25 +30,24 @@ module Statsig
       @rulesets_sync_interval = options.rulesets_sync_interval
       @id_lists_sync_interval = options.idlists_sync_interval
       @rules_updated_callback = options.rules_updated_callback
-      @specs = {
-        :gates => {},
-        :configs => {},
-        :layers => {},
-        :id_lists => {},
-        :experiment_to_layer => {},
-        :sdk_keys_to_app_ids => {},
-        :hashed_sdk_keys_to_app_ids => {}
-      }
+      @gates = {}
+      @configs = {}
+      @layers = {}
+      @id_lists = {}
+      @experiment_to_layer = {}
+      @sdk_keys_to_app_ids = {}
+      @hashed_sdk_keys_to_app_ids = {}
       @diagnostics = diagnostics
       @error_boundary = error_boundary
       @logger = logger
       @secret_key = secret_key
+      @unsupported_configs = Set.new
 
       @id_list_thread_pool = Concurrent::FixedThreadPool.new(
         options.idlist_threadpool_size,
         name: 'statsig-idlist',
         max_queue: 100,
-        fallback_policy: :discard,
+        fallback_policy: :discard
       )
 
       unless @options.bootstrap_values.nil?
@@ -53,7 +59,7 @@ module Statsig
             if process_specs(options.bootstrap_values)
               @init_reason = EvaluationReason::BOOTSTRAP
             end
-          rescue
+          rescue StandardError
             puts 'the provided bootstrapValues is not a valid JSON string'
           ensure
             tracker.end(success: @init_reason == EvaluationReason::BOOTSTRAP)
@@ -96,70 +102,61 @@ module Statsig
     end
 
     def has_gate?(gate_name)
-      @specs[:gates].key?(gate_name)
+      @gates.key?(gate_name)
     end
 
     def has_config?(config_name)
-      @specs[:configs].key?(config_name)
+      @configs.key?(config_name)
     end
 
     def has_layer?(layer_name)
-      @specs[:layers].key?(layer_name)
+      @layers.key?(layer_name)
     end
 
     def get_gate(gate_name)
       return nil unless has_gate?(gate_name)
-      @specs[:gates][gate_name]
+
+      @gates[gate_name]
     end
 
     def get_config(config_name)
       return nil unless has_config?(config_name)
-      @specs[:configs][config_name]
+
+      @configs[config_name]
     end
 
     def get_layer(layer_name)
       return nil unless has_layer?(layer_name)
-      @specs[:layers][layer_name]
-    end
 
-    def gates
-      @specs[:gates]
-    end
-
-    def configs
-      @specs[:configs]
-    end
-
-    def layers
-      @specs[:layers]
+      @layers[layer_name]
     end
 
     def get_id_list(list_name)
-      @specs[:id_lists][list_name]
+      @id_lists[list_name]
     end
 
     def has_sdk_key?(sdk_key)
-      @specs[:sdk_keys_to_app_ids].key?(sdk_key)
+      @sdk_keys_to_app_ids.key?(sdk_key)
     end
 
     def has_hashed_sdk_key?(hashed_sdk_key)
-      @specs[:hashed_sdk_keys_to_app_ids].key?(hashed_sdk_key)
+      @hashed_sdk_keys_to_app_ids.key?(hashed_sdk_key)
     end
 
     def get_app_id_for_sdk_key(sdk_key)
       if sdk_key.nil?
         return nil
       end
-      hashed_sdk_key = Statsig::HashUtils.djb2(sdk_key)
+
+      hashed_sdk_key = Statsig::HashUtils.djb2(sdk_key).to_sym
       if has_hashed_sdk_key?(hashed_sdk_key)
-        return @specs[:hashed_sdk_keys_to_app_ids][hashed_sdk_key]
+        return @hashed_sdk_keys_to_app_ids[hashed_sdk_key]
       end
-      return nil unless has_sdk_key?(sdk_key)
-      @specs[:sdk_keys_to_app_ids][sdk_key]
-    end
 
-    def get_raw_specs
-      @specs
+      key = sdk_key.to_sym
+      return nil unless has_sdk_key?(key)
+
+      @sdk_keys_to_app_ids[key]
     end
 
     def maybe_restart_background_threads
@@ -211,6 +208,7 @@ module Statsig
       if @options.data_store.nil?
         return
       end
+
       @options.data_store.set(Interfaces::IDataStore::CONFIG_SPECS_KEY, specs_string)
     end
 
@@ -264,7 +262,10 @@ module Statsig
             end
             tracker.end(success: @init_reason == EvaluationReason::NETWORK)
 
-            @rules_updated_callback.call(response.body.to_s, @last_config_sync_time) unless response.body.nil? or @rules_updated_callback.nil?
+            unless response.body.nil? or @rules_updated_callback.nil?
+              @rules_updated_callback.call(response.body.to_s,
+                                           @last_config_sync_time)
+            end
           end
 
           nil
@@ -283,43 +284,41 @@ module Statsig
         return false
       end
 
-      specs_json = JSON.parse(specs_string)
+      specs_json = JSON.parse(specs_string, { symbolize_names: true })
       return false unless specs_json.is_a? Hash
 
-      hashed_sdk_key_used = specs_json['hashed_sdk_key_used']
+      hashed_sdk_key_used = specs_json[:hashed_sdk_key_used]
       unless hashed_sdk_key_used.nil? or hashed_sdk_key_used == Statsig::HashUtils.djb2(@secret_key)
         err_boundary.log_exception(Statsig::InvalidSDKKeyResponse.new)
         return false
       end
 
-      @last_config_sync_time = specs_json['time'] || @last_config_sync_time
-      return false unless specs_json['has_updates'] == true &&
-        !specs_json['feature_gates'].nil? &&
-        !specs_json['dynamic_configs'].nil? &&
-        !specs_json['layer_configs'].nil?
+      @last_config_sync_time = specs_json[:time] || @last_config_sync_time
+      return false unless specs_json[:has_updates] == true &&
+                          !specs_json[:feature_gates].nil? &&
+                          !specs_json[:dynamic_configs].nil? &&
+                          !specs_json[:layer_configs].nil?
 
-      new_gates = {}
-      new_configs = {}
-      new_layers = {}
-      new_exp_to_layer = {}
+      @unsupported_configs.clear()
+      new_gates = process_configs(specs_json[:feature_gates])
+      new_configs = process_configs(specs_json[:dynamic_configs])
+      new_layers = process_configs(specs_json[:layer_configs])
 
-      specs_json['feature_gates'].each { |gate| new_gates[gate['name']] = gate }
-      specs_json['dynamic_configs'].each { |config| new_configs[config['name']] = config }
-      specs_json['layer_configs'].each { |layer| new_layers[layer['name']] = layer }
-      specs_json['diagnostics']&.each { |key, value| @diagnostics.sample_rates[key] = value }
+      new_exp_to_layer = {}
+      specs_json[:diagnostics]&.each { |key, value| @diagnostics.sample_rates[key.to_s] = value }
 
-      if specs_json['layers'].is_a?(Hash)
-        specs_json['layers'].each { |layer_name, experiments|
+      if specs_json[:layers].is_a?(Hash)
+        specs_json[:layers].each do |layer_name, experiments|
           experiments.each { |experiment_name| new_exp_to_layer[experiment_name] = layer_name }
-        }
+        end
       end
 
-      @specs[:gates] = new_gates
-      @specs[:configs] = new_configs
-      @specs[:layers] = new_layers
-      @specs[:experiment_to_layer] = new_exp_to_layer
-      @specs[:sdk_keys_to_app_ids] = specs_json['sdk_keys_to_app_ids'] || {}
-      @specs[:hashed_sdk_keys_to_app_ids] = specs_json['hashed_sdk_keys_to_app_ids'] || {}
+      @gates = new_gates
+      @configs = new_configs
+      @layers = new_layers
+      @experiment_to_layer = new_exp_to_layer
+      @sdk_keys_to_app_ids = specs_json[:sdk_keys_to_app_ids] || {}
+      @hashed_sdk_keys_to_app_ids = specs_json[:hashed_sdk_keys_to_app_ids] || {}
 
       unless from_adapter
         save_config_specs_to_storage_adapter(specs_string)
@@ -327,6 +326,17 @@ module Statsig
       true
     end
 
+    def process_configs(configs)
+      configs.each_with_object({}) do |config, new_configs|
+        begin
+          new_configs[config[:name]] = APIConfig.from_json(config)
+        rescue UnsupportedConfigException => e
+          @unsupported_configs.add(config[:name])
+          nil
+        end
+      end
+    end
+
     def get_id_lists_from_adapter(context)
       tracker = @diagnostics.track(context, 'data_store_id_lists', 'fetch')
       cached_values = @options.data_store.get(Interfaces::IDataStore::ID_LISTS_KEY)
@@ -345,6 +355,7 @@ module Statsig
       if @options.data_store.nil?
         return
       end
+
       @options.data_store.set(Interfaces::IDataStore::ID_LISTS_KEY, id_lists_raw_json)
     end
 
@@ -357,7 +368,7 @@ module Statsig
       end
       success = e.nil? && !response.nil?
       tracker.end(statusCode: code, success: success, sdkRegion: response&.headers&.[]('X-Statsig-Region'))
-      if !success
+      unless success
         return
       end
 
@@ -365,16 +376,17 @@ module Statsig
         server_id_lists = JSON.parse(response)
         process_id_lists(server_id_lists, context)
         save_id_lists_to_adapter(response.body.to_s)
-      rescue
+      rescue StandardError
         # Ignored, will try again
       end
     end
 
     def process_id_lists(new_id_lists, context, from_adapter: false)
-      local_id_lists = @specs[:id_lists]
+      local_id_lists = @id_lists
       if !new_id_lists.is_a?(Hash) || !local_id_lists.is_a?(Hash)
         return
       end
+
       tasks = []
 
       tracker = @diagnostics.track(context,
@@ -389,7 +401,7 @@ module Statsig
       end
 
       delete_lists = []
-      local_id_lists.each do |list_name, list|
+      local_id_lists.each do |list_name, _list|
         unless new_id_lists.key? list_name
           delete_lists.push list_name
         end
@@ -425,7 +437,7 @@ module Statsig
           next
         end
 
-        tasks << Concurrent::Promise.execute(:executor => @id_list_thread_pool) do
+        tasks << Concurrent::Promise.execute(executor: @id_list_thread_pool) do
           if from_adapter
             get_single_id_list_from_adapter(local_list, context)
           else
@@ -468,7 +480,7 @@ module Statsig
         content = res.body.to_s
         success = process_single_id_list(list, context, content, content_length)
         save_single_id_list_to_adapter(list.name, content) unless success.nil? || !success
-      rescue
+      rescue StandardError
         tracker.end(success: false)
         nil
       end
@@ -479,7 +491,7 @@ module Statsig
       begin
         tracker = @diagnostics.track(context, from_adapter ? 'data_store_id_list' : 'get_id_list', 'process', { url: list.url })
         unless content.is_a?(String) && (content[0] == '-' || content[0] == '+')
-          @specs[:id_lists].delete(list.name)
+          @id_lists.delete(list.name)
           tracker.end(success: false)
           return false
         end
@@ -488,6 +500,7 @@ module Statsig
         lines.each do |li|
           line = li.strip
           next if line.length <= 1
+
           op = line[0]
           id = line[1..line.length]
           if op == '+'
@@ -504,11 +517,10 @@ module Statsig
                     end
         tracker.end(success: true)
         return true
-      rescue
+      rescue StandardError
         tracker.end(success: false)
         return false
       end
     end
-
   end
 end