statsig 1.24.5 → 1.25.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1565b50f9e48bfcd6c456bc8e1681a9adbd523287f656b042c3cce803063d3b6
-  data.tar.gz: 8dbf5c5879173b3c44e0e155c8e6e649af5e0cb184e1fdd18a47cc8875fb32c0
+  metadata.gz: 267f2a16a3bb05a6b046d493bfe98f00b7c083f387eba7862641801ec0579b2b
+  data.tar.gz: a20de08fe3b12bcba40795ec1ff53ce5d3c2c27aca3ab41d72541a49e730414c
 SHA512:
-  metadata.gz: f8c6e02873f9274b49a42fe94f21d67eec6d2ba720841d107d1b0b3e7f39b3a208fc4bae478337829359e25d109f5e7409dffbd143e802ab5e1f1c2b0d08fcf0
-  data.tar.gz: f75079d1ba3837d66a8386aa106d2bb4f75e78371dcc53cf09e1921610841d81a958e351e1f1a2f5786ebf0c44c43215a709edcb1e21dd45b563f8b2f4f8004d
+  metadata.gz: e7afa3f47ea19f3d759a648f12bd98c8e56c1c757f2c86bc72859ace8ca081e205af90f315cd26c08598fed408a8b4163b452e2312066120d5ead9644f1028ec
+  data.tar.gz: d671a37cf7ad21212d71ad90c8fddab13110641a278c475c6f4cec3ff922c0d6b6bceaa1367b902933db481be56601af2ab203c03768a65e9dd959fb900a2438

data/lib/evaluator.rb

@@ -6,7 +6,7 @@ require 'evaluation_helpers'
 require 'client_initialize_helpers'
 require 'spec_store'
 require 'time'
-require 'user_agent_parser'
+require 'ua_parser'
 require 'evaluation_details'
 require 'user_agent_parser/operating_system'
 
@@ -19,8 +19,8 @@ module Statsig
 
     def initialize(network, options, error_callback, init_diagnostics = nil)
       @spec_store = Statsig::SpecStore.new(network, options, error_callback, init_diagnostics)
-      @ua_parser = UserAgentParser::Parser.new
-      CountryLookup.initialize
+      UAParser.initialize_async
+      CountryLookup.initialize_async
 
       @gate_overrides = {}
       @config_overrides = {}
@@ -447,16 +447,18 @@ module Statsig
       ua = get_value_from_user(user, 'userAgent')
       return nil unless ua.is_a?(String)
 
-      parsed = @ua_parser.parse ua
-      os = parsed.os
       case field.downcase
       when 'os_name', 'osname'
+        os = UAParser.parse_os(ua)
         return os&.family
       when 'os_version', 'osversion'
+        os = UAParser.parse_os(ua)
         return os&.version unless os&.version.nil?
       when 'browser_name', 'browsername'
+        parsed = UAParser.parse_ua(ua)
         return parsed.family
       when 'browser_version', 'browserversion'
+        parsed = UAParser.parse_ua(ua)
         return parsed.version.to_s
       else
         nil

data/lib/layer.rb

@@ -1,5 +1,6 @@
 # typed: false
 
+require 'sorbet-runtime'
 ##
 # Contains the current values from Statsig.
 # Will contain layer default values for all shared parameters in that layer.

data/lib/network.rb

@@ -33,6 +33,8 @@ module Statsig
       @local_mode = options.local_mode
       @timeout = options.network_timeout
       @backoff_multiplier = backoff_mult
+      @post_logs_retry_backoff = options.post_logs_retry_backoff
+      @post_logs_retry_limit = options.post_logs_retry_limit
       @session_id = SecureRandom.uuid
     end
 
@@ -57,18 +59,26 @@ module Statsig
       if @timeout
         http = http.timeout(@timeout)
       end
+      backoff_adjusted = backoff > 10 ? backoff += Random.rand(10) : backoff # to deter overlap
+      if @post_logs_retry_backoff
+        if @post_logs_retry_backoff.is_a? Integer
+          backoff_adjusted = @post_logs_retry_backoff
+        else
+          backoff_adjusted = @post_logs_retry_backoff.call(retries)
+        end
+      end
       begin
         res = http.post(@api + endpoint, body: body)
       rescue StandardError => e
         ## network error retry
         return nil, e unless retries > 0
-        sleep backoff
+        sleep backoff_adjusted
         return post_helper(endpoint, body, retries - 1, backoff * @backoff_multiplier)
       end
       return res, nil if res.status.success?
       return nil, NetworkError.new("Got an exception when making request to #{@api + endpoint}: #{res.to_s}", res.status.to_i) unless retries > 0 && $retry_codes.include?(res.code)
       ## status code retry
-      sleep backoff
+      sleep backoff_adjusted
       post_helper(endpoint, body, retries - 1, backoff * @backoff_multiplier)
     end
 
@@ -97,7 +107,7 @@ module Statsig
     def post_logs(events)
       begin
         json_body = JSON.generate({ 'events' => events, 'statsigMetadata' => Statsig.get_statsig_metadata })
-        post_helper('log_event', json_body, 5)
+        post_helper('log_event', json_body, @post_logs_retry_limit)
       rescue
       end
     end

data/lib/spec_store.rb

@@ -32,6 +32,7 @@ module Statsig
 
       @id_list_thread_pool = Concurrent::FixedThreadPool.new(
         options.idlist_threadpool_size,
+        name: 'statsig-idlist',
         max_queue: 100,
         fallback_policy: :discard,
       )
@@ -309,6 +310,16 @@ module Statsig
 
       init_diagnostics&.mark("get_id_lists", "start", "process", new_id_lists.length)
 
+      delete_lists = []
+      local_id_lists.each do |list_name, list|
+        unless new_id_lists.key? list_name
+          delete_lists.push list_name
+        end
+      end
+      delete_lists.each do |list_name|
+        local_id_lists.delete list_name
+      end
+
       new_id_lists.each do |list_name, list|
         new_list = IDList.new(list)
         local_list = get_id_list(list_name)
@@ -346,21 +357,7 @@ module Statsig
       end
 
       result = Concurrent::Promise.all?(*tasks).execute.wait(@id_lists_sync_interval)
-      if result.state != :fulfilled
-        init_diagnostics&.mark("get_id_lists", "end", "process", false)
-        return # timed out
-      end
-
-      delete_lists = []
-      local_id_lists.each do |list_name, list|
-        unless new_id_lists.key? list_name
-          delete_lists.push list_name
-        end
-      end
-      delete_lists.each do |list_name|
-        local_id_lists.delete list_name
-      end
-      init_diagnostics&.mark("get_id_lists", "end", "process", true)
+      init_diagnostics&.mark("get_id_lists", "end", "process", result.state == :fulfilled)
     end
 
     def get_single_id_list_from_adapter(list)

data/lib/statsig.rb

@@ -148,7 +148,7 @@ module Statsig
     @shared_instance&.get_layer(user, layer_name, StatsigDriver::GetLayerOptions.new(log_exposure: false))
   end
 
-  sig { params(user: StatsigUser, layer_name: String, parameter_name: String).returns(Layer) }
+  sig { params(user: StatsigUser, layer_name: String, parameter_name: String).void }
   ##
   # Logs an exposure event for the parameter in the given layer
   #
@@ -227,7 +227,7 @@ module Statsig
   def self.get_statsig_metadata
     {
       'sdkType' => 'ruby-server',
-      'sdkVersion' => '1.24.5',
+      'sdkVersion' => '1.24.6',
     }
   end
 

data/lib/statsig_driver.rb

@@ -170,7 +170,6 @@ class StatsigDriver
       event.user = user
       event.value = value
       event.metadata = metadata
-      event.statsig_metadata = Statsig.get_statsig_metadata
       @logger.log_event(event)
     })
   end
@@ -199,6 +198,7 @@ class StatsigDriver
   # @return [Hash]
   def get_client_initialize_response(user)
     @err_boundary.capture(-> {
+      validate_user(user)
       normalize_user(user)
       @evaluator.get_client_initialize_response(user)
     }, -> { nil })

data/lib/statsig_event.rb

@@ -1,9 +1,6 @@
 # typed: true
 class StatsigEvent
-  attr_accessor :value
-  attr_accessor :metadata
-  attr_accessor :statsig_metadata
-  attr_accessor :secondary_exposures
+  attr_accessor :value, :metadata, :statsig_metadata, :secondary_exposures
   attr_reader :user
 
   def initialize(event_name)
@@ -13,6 +10,7 @@ class StatsigEvent
     @secondary_exposures = nil
     @user = nil
     @time = (Time.now.to_f * 1000).to_i
+    @statsig_metadata = Statsig.get_statsig_metadata
   end
 
   def user=(value)

data/lib/statsig_logger.rb

@@ -15,11 +15,12 @@ module Statsig
       @options = options
 
       @logging_pool = Concurrent::ThreadPoolExecutor.new(
-        min_threads: [2, Concurrent.processor_count].min,
-        max_threads: [2, Concurrent.processor_count].max,
+        name: 'statsig-logger',
+        min_threads: @options.logger_threadpool_size,
+        max_threads: @options.logger_threadpool_size,
         # max jobs pending before we start dropping
-        max_queue:   [2, Concurrent.processor_count].max * 5,
-        fallback_policy: :discard,
+        max_queue: 100,
+        fallback_policy: :discard
       )
 
       @background_flush = periodic_flush
@@ -44,7 +45,6 @@ module Statsig
       }
       return false if not is_unique_exposure(user, $gate_exposure_event, metadata)
       event.metadata = metadata
-      event.statsig_metadata = Statsig.get_statsig_metadata
 
       event.secondary_exposures = secondary_exposures.is_a?(Array) ? secondary_exposures : []
 
@@ -62,7 +62,6 @@ module Statsig
       }
       return false if not is_unique_exposure(user, $config_exposure_event, metadata)
       event.metadata = metadata
-      event.statsig_metadata = Statsig.get_statsig_metadata
       event.secondary_exposures = secondary_exposures.is_a?(Array) ? secondary_exposures : []
 
       safe_add_eval_details(eval_details, event)
@@ -90,7 +89,6 @@ module Statsig
       }
       return false if not is_unique_exposure(user, $layer_exposure_event, metadata)
       event.metadata = metadata
-      event.statsig_metadata = Statsig.get_statsig_metadata
       event.secondary_exposures = exposures.is_a?(Array) ? exposures : []
 
       safe_add_eval_details(config_evaluation.evaluation_details, event)
@@ -109,7 +107,7 @@ module Statsig
       Thread.new do
         loop do
           sleep @options.logging_interval_seconds
-          flush
+          flush_async
           @interval += 1
           @deduper.clear if @interval % 2 == 0
         end

data/lib/statsig_options.rb

@@ -64,6 +64,11 @@ class StatsigOptions
   # default: 3
   attr_accessor :idlist_threadpool_size
 
+  sig { returns(Integer) }
+  # The number of threads allocated to posting event logs.
+  # default: 3
+  attr_accessor :logger_threadpool_size
+
   sig { returns(T::Boolean) }
   # Should diagnostics be logged. These include performance metrics for initialize.
   # default: false
@@ -79,6 +84,15 @@ class StatsigOptions
   # Number of seconds before a network call is timed out
   attr_accessor :network_timeout
 
+  sig { returns(Integer) }
+  # Number of times to retry sending a batch of failed log events
+  attr_accessor :post_logs_retry_limit
+
+  sig { returns(T.any(Method, Proc, Integer, NilClass)) }
+  # The number of seconds, or a function that returns the number of seconds based on the number of retries remaining
+  # which overrides the default backoff time between retries
+  attr_accessor :post_logs_retry_backoff
+
   sig do
     params(
       environment: T.any(T::Hash[String, String], NilClass),
@@ -92,9 +106,12 @@ class StatsigOptions
       rules_updated_callback: T.any(Method, Proc, NilClass),
       data_store: T.any(Statsig::Interfaces::IDataStore, NilClass),
       idlist_threadpool_size: Integer,
+      logger_threadpool_size: Integer,
       disable_diagnostics_logging: T::Boolean,
       disable_sorbet_logging_handlers: T::Boolean,
-      network_timeout: T.any(Integer, NilClass)
+      network_timeout: T.any(Integer, NilClass),
+      post_logs_retry_limit: Integer,
+      post_logs_retry_backoff: T.any(Method, Proc, Integer, NilClass)
     ).void
   end
 
@@ -110,9 +127,12 @@ class StatsigOptions
     rules_updated_callback: nil,
     data_store: nil,
     idlist_threadpool_size: 3,
+    logger_threadpool_size: 3,
     disable_diagnostics_logging: false,
     disable_sorbet_logging_handlers: false,
-    network_timeout: nil)
+    network_timeout: nil,
+    post_logs_retry_limit: 3,
+    post_logs_retry_backoff: nil)
     @environment = environment.is_a?(Hash) ? environment : nil
     @api_url_base = api_url_base
     @rulesets_sync_interval = rulesets_sync_interval
@@ -124,8 +144,11 @@ class StatsigOptions
     @rules_updated_callback = rules_updated_callback
     @data_store = data_store
     @idlist_threadpool_size = idlist_threadpool_size
+    @logger_threadpool_size = logger_threadpool_size
     @disable_diagnostics_logging = disable_diagnostics_logging
     @disable_sorbet_logging_handlers = disable_sorbet_logging_handlers
     @network_timeout = network_timeout
+    @post_logs_retry_limit = post_logs_retry_limit
+    @post_logs_retry_backoff = post_logs_retry_backoff
   end
 end

data/lib/ua_parser.rb

@@ -0,0 +1,57 @@
+require 'user_agent_parser'
+
+module UAParser
+  class Parser
+    def initialize
+      @ua_parser = UserAgentParser::Parser.new
+    end
+
+    def parse_os(*args)
+      @ua_parser.parse_os(*args)
+    end
+
+    def parse_ua(*args)
+      @ua_parser.parse_ua(*args)
+    end
+
+    def parse_device(*args)
+      @ua_parser.parse_device(*args)
+    end
+  end
+
+  def self.initialize
+    if !@initialize_bg_thread.nil? && @initialize_bg_thread.alive?
+      @initialize_bg_thread.kill.join
+    end
+    @parser = Parser.new
+  end
+
+  def self.initialize_async
+    if !@initialize_bg_thread.nil? && @initialize_bg_thread.alive?
+      @initialize_bg_thread.kill.join
+    end
+    @initialize_bg_thread = Thread.new { @parser = Parser.new }
+    @initialize_bg_thread
+  end
+
+  def self.parse_os(*args)
+    if @parser.nil?
+      initialize
+    end
+    @parser.parse_os(*args)
+  end
+
+  def self.parse_ua(*args)
+    if @parser.nil?
+      initialize
+    end
+    @parser.parse_ua(*args)
+  end
+
+  def self.parse_device(*args)
+    if @parser.nil?
+      initialize
+    end
+    @parser.parse_device(*args)
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: statsig
 version: !ruby/object:Gem::Version
-  version: 1.24.5
+  version: 1.25.0
 platform: ruby
 authors:
 - Statsig, Inc
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-04-03 00:00:00.000000000 Z
+date: 2023-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.14'
+        version: 5.14.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.14'
+        version: 5.14.0
 - !ruby/object:Gem::Dependency
   name: spy
   requirement: !ruby/object:Gem::Requirement
@@ -123,19 +123,89 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '6.0'
 - !ruby/object:Gem::Dependency
-  name: user_agent_parser
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.28.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.28.2
+- !ruby/object:Gem::Dependency
+  name: parallel_tests
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.7'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.7'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.21'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.21'
+- !ruby/object:Gem::Dependency
+  name: simplecov-lcov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.7.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.7.0
+- !ruby/object:Gem::Dependency
+  name: simplecov-cobertura
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+- !ruby/object:Gem::Dependency
+  name: user_agent_parser
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.15.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.15.0
 - !ruby/object:Gem::Dependency
   name: http
   requirement: !ruby/object:Gem::Requirement
@@ -160,16 +230,16 @@ dependencies:
   name: ip3country
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: 0.2.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: 0.2.1
 - !ruby/object:Gem::Dependency
   name: sorbet-runtime
   requirement: !ruby/object:Gem::Requirement
@@ -224,6 +294,7 @@ files:
 - lib/statsig_logger.rb
 - lib/statsig_options.rb
 - lib/statsig_user.rb
+- lib/ua_parser.rb
 homepage: https://rubygems.org/gems/statsig
 licenses:
 - ISC