statsd-instrument 3.5.8 → 3.5.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 704d6e657601de493dc28e4a99f3d68529582693b7a74981a63a9837e99119e7
-  data.tar.gz: b801455560f15650dd460cd25cf3de3efde71ec180842016899b2d51896b4a78
+  metadata.gz: 5b849985c5072f05154d25451f6db9fc1a6c5ca658d14aca02256aab9af99295
+  data.tar.gz: e780d3a60c47a278f1862fa5b18593cfdcc87febe6504a6de9c894e1f024ce2b
 SHA512:
-  metadata.gz: 5a47689d821aeaab37d72af1021af0d1892d420bfbb3d75ded3f2318f73f16f2e36dde3706f82bf5c95b33b3669a028ceb11315f66fac6025c27da6da325ab59
-  data.tar.gz: 64388d0ec0a6a1107d455d54dc2b26d5a5caf26d7a1a6051ad117d2d4088cc1cb6527490f87bacd706a13be4d04f4146e3806fe7f5d5e2336f9f9e23ef8609ec
+  metadata.gz: 6bc432d02716529829c060a0357de9772af5da0f1a270dcaadb5f014666701888e037917b70e794c265175e807df22bbf7153b43a6a79bf3563c97b1617c038d
+  data.tar.gz: 59dceba9b5b0e35d2a96d97e13e2536134e03a8d6116b728fe32d30e80b8e38b95263e5cf853e1d485b7ae0fe94b8d2833929d30ab7513874e737ae62e1562eb

data/CHANGELOG.md

@@ -6,6 +6,10 @@ section below.
 
 ## Unreleased changes
 
+## Version 3.5.9
+
+- Fix dynamic tags being evaluated only once.
+
 ## Version 3.5.8
 
 - Allow the `tag_error_class` option for `statsd_count_success` in strict mode.

data/lib/statsd/instrument/version.rb

@@ -2,6 +2,6 @@
 
 module StatsD
   module Instrument
-    VERSION = "3.5.8"
+    VERSION = "3.5.9"
   end
 end

data/lib/statsd/instrument.rb

@@ -79,8 +79,8 @@ module StatsD
         define_method(method) do |*args, &block|
           client ||= StatsD.singleton_client
           key = StatsD::Instrument.generate_metric_name(name, self, *args)
-          tags = StatsD::Instrument.generate_tags(tags, self, *args)
-          client.measure(key, sample_rate: sample_rate, tags: tags, no_prefix: no_prefix) do
+          generated_tags = StatsD::Instrument.generate_tags(tags, self, *args)
+          client.measure(key, sample_rate: sample_rate, tags: generated_tags, no_prefix: no_prefix) do
             super(*args, &block)
           end
         end
@@ -100,8 +100,8 @@ module StatsD
         define_method(method) do |*args, &block|
           client ||= StatsD.singleton_client
           key = StatsD::Instrument.generate_metric_name(name, self, *args)
-          tags = StatsD::Instrument.generate_tags(tags, self, *args)
-          client.distribution(key, sample_rate: sample_rate, tags: tags, no_prefix: no_prefix) do
+          generated_tags = StatsD::Instrument.generate_tags(tags, self, *args)
+          client.distribution(key, sample_rate: sample_rate, tags: generated_tags, no_prefix: no_prefix) do
             super(*args, &block)
           end
         end
@@ -145,10 +145,10 @@ module StatsD
           client ||= StatsD.singleton_client
           suffix = truthiness == false ? "failure" : "success"
           key = StatsD::Instrument.generate_metric_name(name, self, *args)
-          tags = StatsD::Instrument.generate_tags(tags, self, *args)
-          tags = Helpers.add_tag(tags, :error_class, error.class.name) if tag_error_class && error
+          generated_tags = StatsD::Instrument.generate_tags(tags, self, *args)
+          generated_tags = Helpers.add_tag(generated_tags, :error_class, error.class.name) if tag_error_class && error
 
-          client.increment("#{key}.#{suffix}", sample_rate: sample_rate, tags: tags, no_prefix: no_prefix)
+          client.increment("#{key}.#{suffix}", sample_rate: sample_rate, tags: generated_tags, no_prefix: no_prefix)
         end
       end
     end
@@ -185,8 +185,8 @@ module StatsD
           if truthiness
             client ||= StatsD.singleton_client
             key = StatsD::Instrument.generate_metric_name(name, self, *args)
-            tags = StatsD::Instrument.generate_tags(tags, self, *args)
-            client.increment(key, sample_rate: sample_rate, tags: tags, no_prefix: no_prefix)
+            generated_tags = StatsD::Instrument.generate_tags(tags, self, *args)
+            client.increment(key, sample_rate: sample_rate, tags: generated_tags, no_prefix: no_prefix)
           end
         end
       end
@@ -206,8 +206,8 @@ module StatsD
         define_method(method) do |*args, &block|
           client ||= StatsD.singleton_client
           key = StatsD::Instrument.generate_metric_name(name, self, *args)
-          tags = StatsD::Instrument.generate_tags(tags, self, *args)
-          client.increment(key, sample_rate: sample_rate, tags: tags, no_prefix: no_prefix)
+          generated_tags = StatsD::Instrument.generate_tags(tags, self, *args)
+          client.increment(key, sample_rate: sample_rate, tags: generated_tags, no_prefix: no_prefix)
           super(*args, &block)
         end
       end

data/test/statsd_instrumentation_test.rb

@@ -231,6 +231,9 @@ class StatsDInstrumentationTest < Minitest::Test
     assert_statsd_increment("subgateway.foo", tags: { "key": "foo" }) do
       GatewaySubClass.new.purchase("foo")
     end
+    assert_statsd_increment("subgateway.bar", tags: { "key": "bar" }) do
+      GatewaySubClass.new.purchase("bar")
+    end
   ensure
     ActiveMerchant::Gateway.statsd_remove_count(:ssl_post, metric_namer)
   end
@@ -243,6 +246,9 @@ class StatsDInstrumentationTest < Minitest::Test
     assert_statsd_increment("subgateway.foo", tags: { "key": "foo" }) do
       GatewaySubClass.new.purchase("foo")
     end
+    assert_statsd_increment("subgateway.bar", tags: { "key": "bar" }) do
+      GatewaySubClass.new.purchase("bar")
+    end
   ensure
     ActiveMerchant::Gateway.statsd_remove_count(:ssl_post, metric_namer)
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: statsd-instrument
 version: !ruby/object:Gem::Version
-  version: 3.5.8
+  version: 3.5.9
 platform: ruby
 authors:
 - Jesse Storimer
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-04-27 00:00:00.000000000 Z
+date: 2023-05-17 00:00:00.000000000 Z
 dependencies: []
 description: A StatsD client for Ruby apps. Provides metaprogramming methods to inject
   StatsD instrumentation into your code.
@@ -122,7 +122,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.12
+rubygems_version: 3.4.13
 signing_key: 
 specification_version: 4
 summary: A StatsD client for Ruby apps