statsd-instrument 1.3.0 → 1.3.1

data/lib/statsd/instrument.rb

@@ -15,7 +15,7 @@ module StatsD
                   :prefix, :implementation
   end
   self.enabled = true
-  self.default_sample_rate = 1
+  self.default_sample_rate = 1.0
   self.implementation = :statsd
 
   TimeoutClass = defined?(::SystemTimer) ? ::SystemTimer : ::Timeout
@@ -100,13 +100,13 @@ module StatsD
   end
 
   # glork:320|ms
-  def self.measure(key, milli = nil)
+  def self.measure(key, milli = nil, sample_rate = default_sample_rate)
     result = nil
     ms = milli || Benchmark.ms do
       result = yield
     end
 
-    write(key, ms, :ms)
+    write(key, ms, :ms, sample_rate)
     result
   end
 

data/statsd-instrument.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = "statsd-instrument"
-  s.version     = '1.3.0'
+  s.version     = '1.3.1'
   s.authors     = ["Jesse Storimer"]
   s.email       = ["jesse@shopify.com"]
   s.homepage    = "http://github.com/shopify/statsd-instrument"

data/test/statsd-instrument_test.rb

@@ -139,7 +139,7 @@ class StatsDTest < Test::Unit::TestCase
   def test_statsd_measure
     ActiveMerchant::UniqueGateway.statsd_measure :ssl_post, 'ActiveMerchant.Gateway.ssl_post'
 
-    StatsD.expects(:write).with('ActiveMerchant.Gateway.ssl_post', is_a(Float), :ms).returns({:success => true})
+    StatsD.expects(:write).with('ActiveMerchant.Gateway.ssl_post', is_a(Float), :ms, is_a(Numeric)).returns({:success => true})
     ActiveMerchant::UniqueGateway.new.purchase(true)
   end
 
@@ -257,11 +257,17 @@ class StatsDTest < Test::Unit::TestCase
   end
 
   def test_statsd_measure_with_explicit_value
-    StatsD.expects(:write).with('values.foobar', 42, :ms)
+    StatsD.expects(:write).with('values.foobar', 42, :ms, is_a(Numeric))
 
     StatsD.measure('values.foobar', 42)
   end
 
+  def test_statsd_measure_with_explicit_value_and_sample_rate
+    StatsD.expects(:write).with('values.foobar', 42, :ms, 0.1)
+
+    StatsD.measure('values.foobar', 42, 0.1)
+  end
+
   def test_statsd_gauge
     StatsD.expects(:write).with('values.foobar', 12, :g, 1)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: statsd-instrument
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-07-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &2173609220 !ruby/object:Gem::Requirement
+  requirement: &2170660100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,7 +21,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2173609220
+  version_requirements: *2170660100
 description: A StatsD client for Ruby apps. Provides metaprogramming methods to inject
   StatsD instrumentation into your code.
 email: