static_collection 0.3.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c35ba8c77c61ddfaf666a7b9a0be2a0ba9580ec568e6fbc7c5269590d300607b
-  data.tar.gz: a85d58e434c5d0dc7506016376d65b93e9715c55077ca7698cf637ab5eee76d5
+  metadata.gz: 4bdcf2327cbd67bd3a580c9be6a96c96d104e04462970d8abf97139fd05f252d
+  data.tar.gz: b8a83baba3ba4eebc5019ddf6825635f0a95a77c793b02030021fe32ec0e3676
 SHA512:
-  metadata.gz: 6639c1ad20a1ab0311597e4ef172b83b42ed15e5261948090314097f3b5464c4ceed9eda7516f162915409d70eb41c7d42586a4c50585c8f8eba7aa5b81b8e23
-  data.tar.gz: 9dcbf439545dfbe7f5de03d6415ed1205dab7a221e4637400b8260b0f1b6028bf5ae44fcde78ee0e0f77abf48cda4241da07a19a6b1a8561e944b4177fe97b79
+  metadata.gz: 93f9f93d7b45466de470ccafc0b6d30272fbb9bada41598fb7e441b33ac3eb037bbeb2a81367de5f0601e947511247f0290ef2b813d75c75c0c2e5a51bf1b7bf
+  data.tar.gz: 07aaaee52c0854e04ce98ca5db1ab7dbbcf8aa81232590262343cd5a3960e85cb6190815f3a64ede2a58a8320278b8f7c5426c7a2a2490f97944ba481db160a0

data/.github/workflows/main.yml

@@ -8,12 +8,12 @@ concurrency:
 jobs:
   build:
     name: Build
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     strategy:
       matrix:
-        ruby-version: [2.7.5, 3.0.3, 3.1.0, 3.2.0]
+        ruby-version: [3.1.4, 3.2.3, 3.3.0]
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Set up Ruby ${{ matrix.ruby-version }}
         uses: ruby/setup-ruby@v1
         with:
@@ -30,9 +30,9 @@ jobs:
     name: Release
     if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master'
     needs: build
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: ruby/setup-ruby@v1
         with:
           bundler-cache: true

data/.github/workflows/stale.yml

@@ -7,7 +7,7 @@ jobs:
   stale:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/stale@v4
+      - uses: actions/stale@v8
         with:
           days-before-stale: 30
           days-before-close: 30

data/.gitignore

@@ -11,3 +11,4 @@
 .rspec_status
 
 *.gem
+vendor

data/.ruby-version

@@ -1 +1 @@
-2.7.5
+3.0.6

data/CHANGELOG.md

@@ -0,0 +1,11 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## 0.4.0
+### Breaking Change
+- All Static Collections will be now consist of frozen objects
+- Reduce initialization of objects

data/Gemfile.lock

@@ -1,79 +1,99 @@
 PATH
   remote: .
   specs:
-    static_collection (0.3.1)
+    static_collection (0.4.0)
       activesupport (>= 4)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.4.2)
+    activesupport (7.1.3)
+      base64
+      bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
+      connection_pool (>= 2.2.5)
+      drb
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
+      mutex_m
       tzinfo (~> 2.0)
     ast (2.4.2)
-    concurrent-ruby (1.2.0)
+    base64 (0.2.0)
+    bigdecimal (3.1.6)
+    concurrent-ruby (1.2.3)
+    connection_pool (2.4.1)
     diff-lcs (1.5.0)
-    i18n (1.12.0)
+    drb (2.2.0)
+      ruby2_keywords
+    i18n (1.14.1)
       concurrent-ruby (~> 1.0)
-    json (2.6.3)
-    minitest (5.17.0)
-    parallel (1.22.1)
-    parser (3.2.0.0)
+    json (2.7.1)
+    language_server-protocol (3.17.0.3)
+    minitest (5.21.2)
+    mutex_m (0.2.0)
+    parallel (1.24.0)
+    parser (3.3.0.4)
       ast (~> 2.4.1)
-    rack (3.0.4.1)
+      racc
+    racc (1.7.3)
+    rack (3.0.8)
     rainbow (3.1.1)
-    rake (10.5.0)
-    regexp_parser (2.6.2)
-    rexml (3.2.5)
+    rake (13.1.0)
+    regexp_parser (2.9.0)
+    rexml (3.2.6)
     rspec (3.12.0)
       rspec-core (~> 3.12.0)
       rspec-expectations (~> 3.12.0)
       rspec-mocks (~> 3.12.0)
-    rspec-core (3.12.0)
+    rspec-core (3.12.2)
       rspec-support (~> 3.12.0)
-    rspec-expectations (3.12.2)
+    rspec-expectations (3.12.3)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
     rspec-its (1.3.0)
       rspec-core (>= 3.0.0)
       rspec-expectations (>= 3.0.0)
-    rspec-mocks (3.12.3)
+    rspec-mocks (3.12.6)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
-    rspec-support (3.12.0)
-    rubocop (1.44.1)
+    rspec-support (3.12.1)
+    rubocop (1.60.1)
       json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.2.0.0)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.24.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.24.1)
-      parser (>= 3.1.1.0)
-    rubocop-capybara (2.17.0)
+    rubocop-ast (1.30.0)
+      parser (>= 3.2.1.0)
+    rubocop-capybara (2.20.0)
       rubocop (~> 1.41)
-    rubocop-performance (1.15.2)
-      rubocop (>= 1.7.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.17.4)
+    rubocop-factory_bot (2.25.1)
+      rubocop (~> 1.41)
+    rubocop-performance (1.20.2)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
+    rubocop-rails (2.23.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
-    rubocop-rspec (2.18.1)
-      rubocop (~> 1.33)
+      rubocop-ast (>= 1.30.0, < 2.0)
+    rubocop-rspec (2.26.1)
+      rubocop (~> 1.40)
       rubocop-capybara (~> 2.17)
-    rubocop-vendor (0.8.10)
-      rubocop (>= 0.53.0)
-    ruby-progressbar (1.11.0)
+      rubocop-factory_bot (~> 2.22)
+    rubocop-vendor (0.13.0)
+      rubocop
+    ruby-progressbar (1.13.0)
+    ruby2_keywords (0.0.5)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.4.2)
-    ws-style (6.14.4)
+    unicode-display_width (2.5.0)
+    ws-style (6.14.7)
       rubocop (>= 1.36)
       rubocop-performance (>= 1.10.2)
       rubocop-rails (>= 2.9.1)
@@ -85,7 +105,7 @@ PLATFORMS
 
 DEPENDENCIES
   bundler (~> 2.0)
-  rake (~> 10.0)
+  rake (~> 13.0)
   rspec (~> 3.0)
   rspec-its (~> 1.2)
   rubocop (~> 1.2)
@@ -93,4 +113,4 @@ DEPENDENCIES
   ws-style
 
 BUNDLED WITH
-   2.2.32
+   2.2.33

data/Rakefile

@@ -1,6 +1,14 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+begin
+  require 'bundler/setup'
+rescue LoadError
+  puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
+end
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
+RuboCop::RakeTask.new
 
-task default: :spec
+task default: %i[spec rubocop]

data/lib/static_collection/version.rb

@@ -1,3 +1,3 @@
 module StaticCollection
-  VERSION = "0.3.1".freeze
+  VERSION = "0.4.0".freeze
 end

data/lib/static_collection.rb

@@ -3,23 +3,27 @@ require "static_collection/version"
 
 module StaticCollection
   class Base
+    # rubocop:disable Metrics/MethodLength
     def self.set_source(source, defaults: {})
       raise "Source must be an array" unless source.is_a?(Array)
 
-      instance_variable_set(:@defaults, defaults.stringify_keys)
-      instance_variable_set(:@source, source.map(&:stringify_keys))
-      raise "Source must have at least one value" unless count > 0
+      defaults = defaults.stringify_keys
+      raise "Source must have at least one value" if source.count <= 0
 
-      all.first.attributes.each do |attribute_name, attribute_value|
+      values = source.map(&:stringify_keys).map { |s| new(deep_freeze(defaults.merge(s))) }
+      instance_variable_set(:@all, values)
+
+      all_attribute_names = values.flat_map { |v| v.attributes.keys }.uniq
+      all_attribute_names.each do |attribute_name|
         # Class methods
-        define_singleton_method("find_by_#{attribute_name}") do |value|
+        define_singleton_method(:"find_by_#{attribute_name}") do |value|
           ActiveSupport::Deprecation.warn(
             "find_by_#{attribute_name} is deprecated for StaticCollection, " \
             "use find_by(#{attribute_name}: [value])",
           )
           all.find { |instance| instance.send(attribute_name) == value }
         end
-        define_singleton_method("find_all_by_#{attribute_name}") do |value|
+        define_singleton_method(:"find_all_by_#{attribute_name}") do |value|
           ActiveSupport::Deprecation.warn(
             "find_all_by_#{attribute_name} is deprecated for StaticCollection, " \
             "use where(#{attribute_name}: [value])",
@@ -29,13 +33,33 @@ module StaticCollection
 
         # Instance methods
         send(:define_method, attribute_name) { attributes[attribute_name] }
-        next unless attribute_value.is_a?(TrueClass) || attribute_value.is_a?(FalseClass)
-
         send(:define_method, "#{attribute_name}?") {
-          attributes[attribute_name]
+          attributes[attribute_name] if attributes.key?(attribute_name)
         }
       end
     end
+    # rubocop:enable Metrics/MethodLength
+
+    class << self
+      private
+
+      def deep_freeze(obj)
+        case obj
+        when Hash
+          obj.each_with_object({}) do |(key, value), acc|
+            acc[deep_freeze(key)] = deep_freeze(value)
+          end.freeze
+        when Array
+          obj.map do |value|
+            deep_freeze(value)
+          end.freeze
+        when Symbol, Integer, NilClass
+          obj
+        else
+          obj.freeze
+        end
+      end
+    end
 
     def self.find_by(opts)
       all.find { |instance| opts.all? { |k, v| instance.send(k) == v } }
@@ -46,8 +70,7 @@ module StaticCollection
     end
 
     def self.all
-      defaults = instance_variable_get(:@defaults)
-      instance_variable_get(:@source).map { |s| new(defaults.merge(s)) }
+      instance_variable_get(:@all)
     end
 
     def self.count

data/static_collection.gemspec

@@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
   spec.homepage = "https://github.com/wealthsimple/static_collection"
   spec.license = "MIT"
 
-  spec.required_ruby_version = '>= 2.7.5'
+  spec.required_ruby_version = '>= 3.0'
 
   spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
@@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "activesupport", ">= 4"
 
   spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "rspec-its", "~> 1.2"
   spec.add_development_dependency "rubocop", "~> 1.2"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: static_collection
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - Peter Graham
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-02-03 00:00:00.000000000 Z
+date: 2024-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -123,6 +123,7 @@ files:
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
 - ".ruby-version"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -146,14 +147,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.7.5
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.2.33
 signing_key: 
 specification_version: 4
 summary: Run queries against static data.