static_association 0.0.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e9070d8b187c9b04c979f3f77244f5f0aff54bc9
-  data.tar.gz: 3a95140244d4d5413d29b86b517f847177a03182
+SHA256:
+  metadata.gz: 86ead7939a0117761cc96d89b8bead9dd9d6158e6266a8d068c9033b55fa727a
+  data.tar.gz: b8e8fed19948fa1c38dd7b975c083af75c1e232f89010d197ca661bb48c6a422
 SHA512:
-  metadata.gz: 11a3e13c6693ec96763180f4f1e7feff0d41bb6b8fd0ea8bac6f662c21cc23df81b1d2aa16e3107f887d44df54da0ab5be89e66d3e7b44b3f5dda73c94373d4b
-  data.tar.gz: cc67b525ced9dce9f6b56ec235b955c7a140cf98639738451f1d4ec95285db2e5e42e65e880bd3b1f717a6c9fbb8ffd1d4a00f5d90c96435c7d069ac79125af1
+  metadata.gz: a524a9345a9b43d5f6c9651e2be95cdc56095fca59a5cf7e97b032e424d122fe1769d365caed9c993ef01b49f6fa77cdcab23b1e841a731392ffe0ebd7707883
+  data.tar.gz: 5a54cf10f28c4582cd9aa9d353defc0c8fe853014be4c883563f7f7b6bbad0d856a0f5d889ec5ca8f16c04d1f1ebf56fc71506dfdd7d776e6c754bf8c74a5e02

data/.github/workflows/lint.yml

@@ -0,0 +1,15 @@
+name: Lint
+
+on: push
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.1'
+          bundler-cache: true
+      - run: bundle exec standardrb

data/.github/workflows/test.yml

@@ -0,0 +1,24 @@
+name: Test
+
+on: push
+
+jobs:
+  test:
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: ['3.2', '3.3', '3.4']
+        gemfile: ['7.1', '7.2', '8.0']
+
+    runs-on: ubuntu-latest
+
+    env:
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
+
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - run: bundle exec rspec

data/.gitignore

@@ -1,8 +1,10 @@
 *.gem
+*.gemfile.lock
 *.rbc
 .bundle
 .config
 .yardoc
+.tool-versions
 Gemfile.lock
 InstalledFiles
 _yardoc
@@ -15,3 +17,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+vendor/bundle

data/.standard.yml

@@ -0,0 +1,3 @@
+fix: false
+parallel: false
+format: progress

data/Appraisals

@@ -1,17 +1,11 @@
-appraise "3.0" do
-  gem "i18n"
-  gem "activesupport", "3.0"
+appraise "7.1" do
+  gem "activesupport", "7.1"
 end
 
-appraise "3.1" do
-  gem "i18n"
-  gem "activesupport", "3.1"
+appraise "7.2" do
+  gem "activesupport", "7.2"
 end
 
-appraise "3.2" do
-  gem "activesupport", "3.2"
-end
-
-appraise "4.0" do
-  gem "activesupport", "4.0"
+appraise "8.0" do
+  gem "activesupport", "8.0"
 end

data/CHANGELOG.md

@@ -0,0 +1,19 @@
+# Changelog
+
+## v0.2.0 (20 June 2025)
+
+### Added
+
+- `standardrb` gem for linting (#11)
+- `.where` method for finding multiple records with an array of IDs (#16)
+- `.ids` method which returns an array of all record IDs (#25)
+- `.find_by` method to return the first method matching a specific condition (#26)
+- `.find_by!` method which behaves like `find_by` but raises when a matching
+   record is not found (#28)
+
+### Changed
+- Use GitHub Actions for CI (#10)
+- Refactor specs to be more inline with thoughtbot style (#15)
+- Require `activesupport` v7.1.0 or higher (#22)
+- Coerce `.find_by_id` argument to integer (#23)
+- More descriptive exception messages (#24)

data/CODEOWNERS

@@ -0,0 +1,16 @@
+# Lines starting with '#' are comments.
+# Each line is a file pattern followed by one or more owners.
+
+# More details are here: https://help.github.com/articles/about-codeowners/
+
+# The '*' pattern is global owners.
+
+# Order is important. The last matching pattern has the most precedence.
+# The folders are ordered as follows:
+
+# In each subsection folders are ordered first by depth, then alphabetically.
+# This should make it easy to add new rules without breaking existing ones.
+
+# Global rule:
+
+* @sidane

data/Gemfile

@@ -1,4 +1,4 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in static_association.gemspec
 gemspec

data/README.md

@@ -1,14 +1,17 @@
 # StaticAssociation
 
-Adds basic ActiveRecord like associations to static data.
+![test](https://github.com/thoughtbot/static_association/actions/workflows/test.yml/badge.svg)
+![lint](https://github.com/thoughtbot/static_association/actions/workflows/lint.yml/badge.svg)
 
-This has been extracted from ProjectsDB and Hotleads, see the `BudgetCategory`, `Project` and `ArchiveReason`, `Lead` classes respectively for examples.
+Adds basic ActiveRecord-like associations to static data.
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
-    gem 'static_association'
+```ruby
+gem "static_association"
+```
 
 And then execute:
 
@@ -24,25 +27,48 @@ Or install it yourself as:
 
 Create your static association class:
 
-    class Days
-      include StaticAssociation
+```ruby
+class Day
+  include StaticAssociation
 
-      attr_accessor :name
+  attr_accessor :name
 
-      record id: 0 do |day|
-        day.name = :monday
-      end
-    end
+  record id: 0 do |day|
+    day.name = :monday
+  end
+end
+```
 
-Calling `record` will allow you to create an instance of this static model, a unique id is mandatory. The newly created object is yielded to the passed block.
+Calling `record` will allow you to create an instance of this static model,
+a unique id is mandatory. The newly created object is yielded to the passed
+block.
 
-The `Days` class will gain an `all` and `find` method.
+The `Day` class will gain the following methods:
+
+- `.all`: returns all the static records defined in the class.
+- `.ids`: returns an array of all the ids of the static records.
+- `.find`: accepts a single id and returns the matching record. If the record
+  does not exist, a `RecordNotFound` error is raised.
+- `.find_by_id`: behaves similarly to the `.find` method, except it returns
+  `nil` when a record does not exist.
+- `.find_by`: finds the first record matching the specified conditions. If no
+  record is found, returns `nil`.
+- `find_by!` behaves like `find_by` but raises a
+  `StaticAssociation::RecordNotFound` error if no record is found.
+- `.where`: accepts an array of ids and returns all records with matching ids.
 
 ### Associations
 
-Currently just a 'belongs to' association can be created. This behaviour can be mixed into an `ActiveRecord` model:
+Currently just a `belongs_to` association can be created. This behaviour can be
+mixed into an `ActiveRecord` model:
+
+```ruby
+class Event < ActiveRecord::Base
+  extend StaticAssociation::AssociationHelpers
 
-    belongs_to_static :day
+  belongs_to_static :day
+end
+```
 
 This assumes your model has a field `day_id`.
 
@@ -51,6 +77,6 @@ This assumes your model has a field `day_id`.
 1. Fork it
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Run the tests (`rake`)
+4. Run lint checks and tests (`bundle exec rake`)
 5. Push to the branch (`git push origin my-new-feature`)
 6. Create new Pull Request

data/Rakefile

@@ -1,7 +1,8 @@
 require "bundler/gem_tasks"
-require 'rspec/core/rake_task'
-require 'appraisal'
+require "rspec/core/rake_task"
+require "appraisal"
+require "standard/rake"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: [:standard, :spec]

data/gemfiles/{3.2.gemfile → 7.1.gemfile}

@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "activesupport", "3.2"
+gem "activesupport", "7.1"
 
-gemspec :path=>"../"
+gemspec path: "../"

data/gemfiles/{4.0.gemfile → 7.2.gemfile}

@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "activesupport", "4.0"
+gem "activesupport", "7.2"
 
-gemspec :path=>"../"
+gemspec path: "../"

data/gemfiles/{3.0.gemfile → 8.0.gemfile}

@@ -2,7 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "i18n"
-gem "activesupport", "3.0"
+gem "activesupport", "8.0"
 
-gemspec :path=>"../"
+gemspec path: "../"

data/lib/static_association/version.rb

@@ -1,3 +1,3 @@
 module StaticAssociation
-  VERSION = "0.0.2"
+  VERSION = "0.2.0"
 end

data/lib/static_association.rb

@@ -1,16 +1,20 @@
-require 'static_association/version'
-require 'active_support/concern'
-require 'active_support/ordered_hash'
-require 'active_support/core_ext/module/delegation'
-require 'active_support/core_ext/hash/keys'
-require 'active_support/core_ext/string/inflections'
+require "static_association/version"
+require "active_support/concern"
+require "active_support/core_ext/module/delegation"
+require "active_support/core_ext/hash/keys"
+require "active_support/core_ext/string/inflections"
 
 module StaticAssociation
   extend ActiveSupport::Concern
 
+  class ArgumentError < StandardError; end
+
   class DuplicateID < StandardError; end
+
   class RecordNotFound < StandardError; end
 
+  class UndefinedAttribute < StandardError; end
+
   attr_reader :id
 
   private
@@ -22,44 +26,86 @@ module StaticAssociation
   module ClassMethods
     include Enumerable
 
-    delegate :each, :to => :all
+    delegate :each, to: :all
 
     def index
-      @index ||= ActiveSupport::OrderedHash.new
+      @index ||= {}
     end
 
     def all
       index.values
     end
 
+    def ids
+      index.keys
+    end
+
     def find(id)
-      raise RecordNotFound unless index.has_key?(id)
-      index[id]
+      find_by_id(id) or raise RecordNotFound.new(
+        "Couldn't find DummyClass with 'id'=#{id}"
+      )
+    end
+
+    def find_by_id(id)
+      index[
+        Integer(id, exception: false) || id
+      ]
+    end
+
+    def where(id: [])
+      all.select { |record| id.include?(record.id) }
+    end
+
+    def find_by(**args)
+      args.any? or raise ArgumentError
+
+      all.find { |record| matches_attributes?(record: record, attributes: args) }
     end
 
-    def record(settings)
+    def find_by!(**args)
+      find_by(**args) or raise RecordNotFound.new(
+        "Couldn't find #{name} with " +
+        args.map { |k, v| "#{k}=#{v}" }.join(", ")
+      )
+    end
+
+    def record(settings, &block)
       settings.assert_valid_keys(:id)
       id = settings.fetch(:id)
-      raise DuplicateID if index.has_key?(id)
-      record = self.new(id)
-      yield(record) if block_given?
+
+      if index.has_key?(id)
+        raise DuplicateID.new("Duplicate record with 'id'=#{id} found")
+      end
+
+      record = new(id)
+      record.instance_exec(record, &block) if block
       index[id] = record
     end
+
+    private
+
+    def matches_attributes?(record:, attributes:)
+      attributes.all? do |attribute, value|
+        record.respond_to?(attribute) or raise UndefinedAttribute.new(
+          "Undefined attribute '#{attribute}'"
+        )
+
+        record.public_send(attribute) == value
+      end
+    end
   end
 
   module AssociationHelpers
-    def belongs_to_static(name)
-      self.send(:define_method, name) do
-        begin
-          foreign_key = self.send("#{name}_id")
-          name.to_s.camelize.constantize.find(foreign_key) if foreign_key
-        rescue RecordNotFound
-          nil
-        end
+    def belongs_to_static(name, opts = {})
+      class_name = opts.fetch(:class_name, name.to_s.camelize)
+
+      send(:define_method, name) do
+        foreign_key = send(:"#{name}_id")
+        class_name.constantize.find_by_id(foreign_key)
       end
 
-      self.send(:define_method, "#{name}=") do |assoc|
-        self.send("#{name}_id=", assoc.id)
+      send(:define_method, "#{name}=") do |assoc|
+        send(:"#{name}_id=", assoc.id)
       end
     end
   end

data/spec/spec_helper.rb

@@ -4,14 +4,10 @@
 # loaded once.
 #
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
-require 'rubygems'
-require 'bundler/setup'
+require "bundler/setup"
 
-require 'static_association'
+require "static_association"
 
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
-  config.run_all_when_everything_filtered = true
-  config.filter_run :focus
-  config.order = 'random'
+  config.order = "random"
 end

data/spec/static_association_spec.rb

@@ -1,105 +1,419 @@
-require 'spec_helper'
-require 'static_association'
+require "spec_helper"
+require "static_association"
 
-describe StaticAssociation do
+class DummyClass
+  include StaticAssociation
+  attr_accessor :name
+end
 
-  class DummyClass
-    include StaticAssociation
-    attr_accessor :name
-  end
+class AssociationClass
+  attr_accessor :dummy_class_id
+  attr_accessor :dodo_class_id
 
+  extend StaticAssociation::AssociationHelpers
+  belongs_to_static :dummy_class
+  belongs_to_static :dodo_class, class_name: "DummyClass"
+end
+
+RSpec.describe StaticAssociation do
   after do
-    DummyClass.instance_variable_set("@index", {})
+    DummyClass.instance_variable_set(:@index, {})
   end
 
   describe ".record" do
-    it "should add a record" do
-      expect {
-        DummyClass.record :id => 1 do |c|
-          c.name = 'asdf'
-        end
-      }.to change(DummyClass, :count).by(1)
+    it "adds a record" do
+      expect { DummyClass.record(id: 1) { self.name = "test" } }
+        .to change(DummyClass, :count).by(1)
     end
 
-    context "id uniqueness" do
-      it "should raise an error with a duplicate id" do
-        expect {
-          DummyClass.record :id => 1 do |c|
-            c.name = 'asdf'
+    context "when using `self`" do
+      it "assigns attributes" do
+        record = DummyClass.record(id: 1) { self.name = "test" }
+
+        expect(record.id).to eq(1)
+        expect(record.name).to eq("test")
+      end
+    end
+
+    context "when using the object" do
+      it "assigns attributes" do
+        record = DummyClass.record(id: 1) { |i| i.name = "test" }
+
+        expect(record.id).to eq(1)
+        expect(record.name).to eq("test")
+      end
+    end
+
+    context "when the id is a duplicate" do
+      it "raises an error" do
+        DummyClass.record(id: 1) { self.name = "test0" }
+
+        expect { DummyClass.record(id: 1) { self.name = "test1" } }
+          .to raise_error(
+            StaticAssociation::DuplicateID,
+            "Duplicate record with 'id'=1 found"
+          )
+      end
+    end
+
+    context "when an attribute is not defined" do
+      it "raises an error" do
+        expect { DummyClass.record(id: 1) { self.foo = "bar" } }
+          .to raise_error(NoMethodError)
+      end
+    end
+
+    context "when a key is invalid" do
+      it "raises an error" do
+        expect { DummyClass.record(id: 1, foo: "bar") }
+          .to raise_error(ArgumentError)
+      end
+    end
+
+    context "without a block" do
+      it "adds a record" do
+        expect { DummyClass.record(id: 1) }.to change(DummyClass, :count).by(1)
+      end
+    end
+  end
+
+  describe ".all" do
+    it "returns all records" do
+      record1 = DummyClass.record(id: 1)
+      record2 = DummyClass.record(id: 2)
+
+      records = DummyClass.all
+
+      expect(records).to contain_exactly(record1, record2)
+    end
+  end
+
+  describe ".ids" do
+    it "returns array of ids for all records" do
+      _record1 = DummyClass.record(id: 1)
+      _record2 = DummyClass.record(id: 2)
+
+      ids = DummyClass.ids
+
+      expect(ids).to contain_exactly(1, 2)
+    end
+  end
+
+  describe ".find" do
+    context "when the record exists" do
+      it "returns the record" do
+        record = DummyClass.record(id: 1)
+
+        found_record = DummyClass.find(1)
+
+        expect(found_record).to eq(record)
+      end
+    end
+
+    context "when the record does not exist" do
+      it "raises an error" do
+        expect { DummyClass.find(1) }
+          .to raise_error(
+            StaticAssociation::RecordNotFound,
+            "Couldn't find DummyClass with 'id'=1"
+          )
+      end
+    end
+
+    context "when argument is numeric string" do
+      it "returns the record" do
+        record = DummyClass.record(id: 1)
+
+        found_record = DummyClass.find("1")
+
+        expect(found_record).to eq(record)
+      end
+    end
+  end
+
+  describe ".find_by_id" do
+    context "when the record exists" do
+      it "returns the record" do
+        record = DummyClass.record(id: 1)
+
+        found_record = DummyClass.find_by_id(1)
+
+        expect(found_record).to eq(record)
+      end
+    end
+
+    context "when the record does not exist" do
+      it "returns nil" do
+        found_record = DummyClass.find_by_id(1)
+
+        expect(found_record).to be_nil
+      end
+    end
+
+    context "when id argument is a numeric string" do
+      it "returns the record" do
+        record = DummyClass.record(id: 1)
+
+        found_record = DummyClass.find_by_id("1")
+
+        expect(found_record).to eq(record)
+      end
+    end
+
+    context "when id argument is a non-numeric string" do
+      it "returns the record" do
+        DummyClass.record(id: 1)
+
+        found_record = DummyClass.find_by_id("foo")
+
+        expect(found_record).to be_nil
+      end
+    end
+
+    context "when record ids are strings and id argument matches a record" do
+      it "returns the record" do
+        record = DummyClass.record(id: "foo")
+
+        found_record = DummyClass.find_by_id("foo")
+
+        expect(found_record).to eq(record)
+      end
+    end
+
+    context "when record ids are strings and id argument doesn't match a record" do
+      it "returns nil" do
+        DummyClass.record(id: "foo")
+
+        found_record = DummyClass.find_by_id("bar")
+
+        expect(found_record).to be_nil
+      end
+    end
+  end
+
+  describe ".where" do
+    it "returns all records with the given ids" do
+      record1 = DummyClass.record(id: 1)
+      _record2 = DummyClass.record(id: 2)
+      record3 = DummyClass.record(id: 3)
+
+      results = DummyClass.where(id: [1, 3, 4])
+
+      expect(results).to contain_exactly(record1, record3)
+    end
+
+    describe ".find_by" do
+      context "when record exists with the specified attribute value" do
+        it "returns the record" do
+          record1 = DummyClass.record(id: 1) do |r|
+            r.name = "foo"
           end
+          _record2 = DummyClass.record(id: 2) do |r|
+            r.name = "bar"
+          end
+
+          found_record = DummyClass.find_by(name: "foo")
+
+          expect(found_record).to eq(record1)
+        end
+      end
 
-          DummyClass.record :id => 1 do |c|
-            c.name = 'asdf'
+      context "when no record exists that matches the specified attribute value" do
+        it "returns nil" do
+          DummyClass.record(id: 1) do |r|
+            r.name = "foo"
           end
-        }.to raise_error(StaticAssociation::DuplicateID)
+
+          found_record = DummyClass.find_by(name: "bar")
+
+          expect(found_record).to be_nil
+        end
+      end
+
+      context "when multiple records match the specified attribute value" do
+        it "returns the first matching record" do
+          record1 = DummyClass.record(id: 1) do |r|
+            r.name = "foo"
+          end
+          _record2 = DummyClass.record(id: 2) do |r|
+            r.name = "foo"
+          end
+
+          found_record = DummyClass.find_by(name: "foo")
+
+          expect(found_record).to eq(record1)
+        end
+      end
+
+      context "when specifying multiple attribute values" do
+        it "returns the record matching all attributes" do
+          _record1 = DummyClass.record(id: 1) do |r|
+            r.name = "foo"
+          end
+          record2 = DummyClass.record(id: 2) do |r|
+            r.name = "foo"
+          end
+
+          found_record = DummyClass.find_by(id: 2, name: "foo")
+
+          expect(found_record).to eq(record2)
+        end
+      end
+
+      context "when specifying multiple attribute values but no record " \
+              "matches all attributes" do
+        it "returns nil" do
+          _record1 = DummyClass.record(id: 1) do |r|
+            r.name = "foo"
+          end
+
+          found_record = DummyClass.find_by(id: 1, name: "bar")
+
+          expect(found_record).to be_nil
+        end
       end
-    end
 
-    context "sets up the instance" do
-      subject { 
-        DummyClass.record :id => 1 do |c|
-          c.name = 'asdf'
+      context "with undefined attributes" do
+        it "raises an error" do
+          DummyClass.record(id: 1)
+
+          expect {
+            DummyClass.find_by(undefined_attribute: 1)
+          }.to raise_error(
+            StaticAssociation::UndefinedAttribute,
+            "Undefined attribute 'undefined_attribute'"
+          )
         end
-      }
+      end
 
-      its(:id) { should == 1 }
-      its(:name) { should == 'asdf' }
+      context "with no attributes" do
+        it "raises a StaticAssociation::ArgumentError" do
+          expect {
+            DummyClass.find_by
+          }.to raise_error(StaticAssociation::ArgumentError)
+        end
+      end
     end
+  end
 
-    context "without a block" do
-      subject { DummyClass.record :id => 1 }
+  describe ".find_by!" do
+    context "when record exists with the specified attribute value" do
+      it "returns the record" do
+        record1 = DummyClass.record(id: 1) do |r|
+          r.name = "foo"
+        end
+        _record2 = DummyClass.record(id: 2) do |r|
+          r.name = "bar"
+        end
 
-      its(:id) { should == 1 }
-      its(:name) { should be_nil }
+        found_record = DummyClass.find_by!(name: "foo")
+
+        expect(found_record).to eq(record1)
+      end
     end
 
-    context "asserting valid keys" do
-      it "should raise an error" do
+    context "when no record exists that matches the specified attribute value" do
+      it "raises an error" do
+        DummyClass.record(id: 1) do |r|
+          r.name = "foo"
+        end
+
         expect {
-          DummyClass.record :id => 1, :foo => :bar
-        }.to raise_error(ArgumentError)
+          DummyClass.find_by!(name: "bar")
+        }.to raise_error(
+          StaticAssociation::RecordNotFound,
+          "Couldn't find DummyClass with name=bar"
+        )
       end
     end
-  end
 
-  describe ".find" do
-    before do
-      DummyClass.record :id => 1 do |c|
-        c.name = 'asdf'
+    context "when multiple records match the specified attribute value" do
+      it "returns the first matching record" do
+        record1 = DummyClass.record(id: 1) do |r|
+          r.name = "foo"
+        end
+        _record2 = DummyClass.record(id: 2) do |r|
+          r.name = "foo"
+        end
+
+        found_record = DummyClass.find_by!(name: "foo")
+
+        expect(found_record).to eq(record1)
       end
     end
 
-    context "record exists" do
-      subject { DummyClass.find(1) }
+    context "when specifying multiple attribute values" do
+      it "returns the record matching all attributes" do
+        _record1 = DummyClass.record(id: 1) do |r|
+          r.name = "foo"
+        end
+        record2 = DummyClass.record(id: 2) do |r|
+          r.name = "foo"
+        end
 
-      it { should be_kind_of(DummyClass) }
-      its(:id) { should == 1 }
+        found_record = DummyClass.find_by!(id: 2, name: "foo")
+
+        expect(found_record).to eq(record2)
+      end
+    end
+
+    context "when specifying multiple attribute values but no record " \
+            "matches all attributes" do
+      it "raises an error" do
+        _record1 = DummyClass.record(id: 1) do |r|
+          r.name = "foo"
+        end
+
+        expect {
+          DummyClass.find_by!(id: 1, name: "bar")
+        }.to raise_error(
+          StaticAssociation::RecordNotFound,
+          "Couldn't find DummyClass with id=1, name=bar"
+        )
+      end
     end
 
-    context "record does not exist" do
-      it "should raise a StaticAssociation::RecordNotFoundError" do
+    context "with undefined attributes" do
+      it "raises a StaticAssociation::UndefinedAttribute" do
+        DummyClass.record(id: 1)
+
         expect {
-          DummyClass.find(:not_in_the_index)
-        }.to raise_error(StaticAssociation::RecordNotFound)
+          DummyClass.find_by!(undefined_attribute: 1)
+        }.to raise_error(
+          StaticAssociation::UndefinedAttribute,
+          "Undefined attribute 'undefined_attribute'"
+        )
+      end
+    end
+
+    context "with no attributes" do
+      it "raises a StaticAssociation::ArgumentError" do
+        expect {
+          DummyClass.find_by!
+        }.to raise_error(StaticAssociation::ArgumentError)
       end
     end
   end
 
   describe ".belongs_to_static" do
-    class AssociationClass
-      attr_accessor :dummy_class_id
-      
-      extend StaticAssociation::AssociationHelpers
-      belongs_to_static :dummy_class
+    it "defines a reader method for the association" do
+      associated_class = AssociationClass.new
+      allow(DummyClass).to receive(:find_by_id)
+
+      associated_class.dummy_class
+
+      expect(DummyClass).to have_received(:find_by_id)
     end
 
-    let(:associated_class) { AssociationClass.new }
+    context "when `class_name` is specified" do
+      it "defines a reader method for the association" do
+        associated_class = AssociationClass.new
+        allow(DummyClass).to receive(:find_by_id)
 
-    it "creates reader method that uses the correct singularized class when finding static association" do
-      expect {
-        DummyClass.should_receive(:find)
-      }
-      associated_class.dummy_class
+        associated_class.dodo_class
+
+        expect(DummyClass).to have_received(:find_by_id)
+      end
     end
   end
 end

data/static_association.gemspec

@@ -1,26 +1,24 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'static_association/version'
+require "static_association/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = "static_association"
-  spec.version       = StaticAssociation::VERSION
-  spec.authors       = ["Oliver Nightingale"]
-  spec.email         = ["oliver.nightingale1@gmail.com"]
-  spec.description   = %q{StaticAssociation adds a simple enum type that can act like an ActiveRecord association for static data.}
-  spec.summary       = %q{ActiveRecord like associations for static data}
-  spec.license       = "MIT"
+  spec.name = "static_association"
+  spec.version = StaticAssociation::VERSION
+  spec.authors = ["Oliver Nightingale"]
+  spec.email = ["oliver.nightingale1@gmail.com"]
+  spec.description = "StaticAssociation adds a simple enum type that can act like an ActiveRecord association for static data."
+  spec.summary = "ActiveRecord like associations for static data"
+  spec.license = "MIT"
+  spec.homepage = "https://github.com/thoughtbot/static_association"
 
-  spec.files         = `git ls-files`.split($/)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.files = `git ls-files`.split($/)
+  spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "activesupport", ">= 3.0.0"
+  spec.add_dependency "activesupport", ">= 7.1.0"
 
-  spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rspec"
-  spec.add_development_dependency "rake"
   spec.add_development_dependency "appraisal"
+  spec.add_development_dependency "standard"
 end

metadata

@@ -1,83 +1,68 @@
 --- !ruby/object:Gem::Specification
 name: static_association
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Oliver Nightingale
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-04 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 7.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 7.1.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: appraisal
+  name: standard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: StaticAssociation adds a simple enum type that can act like an ActiveRecord
@@ -88,50 +73,44 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".github/workflows/lint.yml"
+- ".github/workflows/test.yml"
+- ".gitignore"
+- ".standard.yml"
 - Appraisals
+- CHANGELOG.md
+- CODEOWNERS
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
-- gemfiles/3.0.gemfile
-- gemfiles/3.0.gemfile.lock
-- gemfiles/3.1.gemfile
-- gemfiles/3.1.gemfile.lock
-- gemfiles/3.2.gemfile
-- gemfiles/3.2.gemfile.lock
-- gemfiles/4.0.gemfile
-- gemfiles/4.0.gemfile.lock
+- gemfiles/7.1.gemfile
+- gemfiles/7.2.gemfile
+- gemfiles/8.0.gemfile
 - lib/static_association.rb
 - lib/static_association/version.rb
 - spec/spec_helper.rb
 - spec/static_association_spec.rb
 - static_association.gemspec
-homepage: 
+homepage: https://github.com/thoughtbot/static_association
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.0.3
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: ActiveRecord like associations for static data
-test_files:
-- spec/spec_helper.rb
-- spec/static_association_spec.rb
+test_files: []

data/.travis.yml

@@ -1,20 +0,0 @@
-language: ruby
-install: bundle install
-script:
- - bundle exec rake
-rvm:
-  - 2.0.0
-  - 1.9.3
-  - 1.9.2
-  - 1.8.7
-gemfile:
-  - gemfiles/3.0.gemfile
-  - gemfiles/3.1.gemfile
-  - gemfiles/3.2.gemfile
-  - gemfiles/4.0.gemfile
-matrix:
-  exclude:
-    - rvm: 1.8.7
-      gemfile: gemfiles/4.0.gemfile
-    - rvm: 1.9.2
-      gemfile: gemfiles/4.0.gemfile

data/gemfiles/3.0.gemfile.lock

@@ -1,36 +0,0 @@
-PATH
-  remote: /Users/olivernightingale/code/static_association
-  specs:
-    static_association (0.0.1)
-      activesupport (>= 3.0.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    activesupport (3.0.0)
-    appraisal (0.5.2)
-      bundler
-      rake
-    diff-lcs (1.2.4)
-    i18n (0.6.5)
-    rake (10.1.0)
-    rspec (2.14.1)
-      rspec-core (~> 2.14.0)
-      rspec-expectations (~> 2.14.0)
-      rspec-mocks (~> 2.14.0)
-    rspec-core (2.14.5)
-    rspec-expectations (2.14.3)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.3)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activesupport (= 3.0)
-  appraisal
-  bundler (~> 1.3)
-  i18n
-  rake
-  rspec
-  static_association!

data/gemfiles/3.1.gemfile

@@ -1,8 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "i18n"
-gem "activesupport", "3.1"
-
-gemspec :path=>"../"

data/gemfiles/3.1.gemfile.lock

@@ -1,38 +0,0 @@
-PATH
-  remote: /Users/olivernightingale/code/static_association
-  specs:
-    static_association (0.0.1)
-      activesupport (>= 3.0.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    activesupport (3.1.0)
-      multi_json (~> 1.0)
-    appraisal (0.5.2)
-      bundler
-      rake
-    diff-lcs (1.2.4)
-    i18n (0.6.5)
-    multi_json (1.8.0)
-    rake (10.1.0)
-    rspec (2.14.1)
-      rspec-core (~> 2.14.0)
-      rspec-expectations (~> 2.14.0)
-      rspec-mocks (~> 2.14.0)
-    rspec-core (2.14.5)
-    rspec-expectations (2.14.3)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.3)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activesupport (= 3.1)
-  appraisal
-  bundler (~> 1.3)
-  i18n
-  rake
-  rspec
-  static_association!

data/gemfiles/3.2.gemfile.lock

@@ -1,38 +0,0 @@
-PATH
-  remote: /Users/olivernightingale/code/static_association
-  specs:
-    static_association (0.0.1)
-      activesupport (>= 3.0.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    activesupport (3.2.0)
-      i18n (~> 0.6)
-      multi_json (~> 1.0)
-    appraisal (0.5.2)
-      bundler
-      rake
-    diff-lcs (1.2.4)
-    i18n (0.6.5)
-    multi_json (1.8.0)
-    rake (10.1.0)
-    rspec (2.14.1)
-      rspec-core (~> 2.14.0)
-      rspec-expectations (~> 2.14.0)
-      rspec-mocks (~> 2.14.0)
-    rspec-core (2.14.5)
-    rspec-expectations (2.14.3)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.3)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activesupport (= 3.2)
-  appraisal
-  bundler (~> 1.3)
-  rake
-  rspec
-  static_association!

data/gemfiles/4.0.gemfile.lock

@@ -1,46 +0,0 @@
-PATH
-  remote: /Users/olivernightingale/code/static_association
-  specs:
-    static_association (0.0.1)
-      activesupport (>= 3.0.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    activesupport (4.0.0)
-      i18n (~> 0.6, >= 0.6.4)
-      minitest (~> 4.2)
-      multi_json (~> 1.3)
-      thread_safe (~> 0.1)
-      tzinfo (~> 0.3.37)
-    appraisal (0.5.2)
-      bundler
-      rake
-    atomic (1.1.13)
-    diff-lcs (1.2.4)
-    i18n (0.6.5)
-    minitest (4.7.5)
-    multi_json (1.8.0)
-    rake (10.1.0)
-    rspec (2.14.1)
-      rspec-core (~> 2.14.0)
-      rspec-expectations (~> 2.14.0)
-      rspec-mocks (~> 2.14.0)
-    rspec-core (2.14.5)
-    rspec-expectations (2.14.3)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.3)
-    thread_safe (0.1.2)
-      atomic
-    tzinfo (0.3.37)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activesupport (= 4.0)
-  appraisal
-  bundler (~> 1.3)
-  rake
-  rspec
-  static_association!