statesman 7.0.1 → 7.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4e098c0148958526a38807f1019f76735c627dcd57124bd61108c52ec5d468a1
-  data.tar.gz: 7ee21582573f6aa3887b5081e96850080ad450afeec1431365fcab492ef8fc1a
+  metadata.gz: d3c4334aeb972468799292be667b537dddf997d9fe065521cfe9454ed938b2a7
+  data.tar.gz: d78b8accf1d41e1da296d4e815c660df4889320bd2d40e85ee680061e9c2d947
 SHA512:
-  metadata.gz: bcc7845c4fe7e31640bfa956f7aae786fd3bbbc395af0a5266e1b18c67cd309265e9b6076cd6ba75c90802f48a1e95c716cd39f5303e7410063b403cc0eec3d1
-  data.tar.gz: b359e526717980326362978645a5abcd2c1fd8eeaa07ddb6ea41212100c05d4588e752791bf9592495abf6e30d06cb7ea488825266caf3440f66dbd4d22bc903
+  metadata.gz: 582292d37d4cd51742ad15894a2c1fe0b93894d1337d9631ecc7fd4ca0f6ff7e33c0ce9889729cad4d10490def304b4336ea843121bb751d89256ef0b034c647
+  data.tar.gz: 129e07afb181e19af2b89443740449b799616aaacf07e4bf3224417ae3c97cae376ba923ac979c2ada15111d54f844036e3e0ea8b9e7870e0300258736138e2a

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## v7.1.0, 10th Feb 2020
+
+- Fix `to_s` on `TransitionFailedError` & `GuardFailedError`. `.message` and
+    `.to_s` diverged when `from` and `to` accessors where added in v4.1.3
+
 ## v7.0.1, 8th Jan 2020
 
 - Fix deprecation warning with Ruby 2.7 [#386](https://github.com/gocardless/statesman/pull/386)

data/Gemfile

@@ -14,5 +14,5 @@ end
 
 group :development do
   # test/unit is no longer bundled with Ruby 2.2, but required by Rails
-  gem "test-unit", "~> 3.0" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.2.0")
+  gem "test-unit", "~> 3.3" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.2.0")
 end

data/README.md

@@ -30,7 +30,7 @@ protection.
 To get started, just add Statesman to your `Gemfile`, and then run `bundle`:
 
 ```ruby
-gem 'statesman', '~> 7.0.1'
+gem 'statesman', '~> 7.1.0'
 ```
 
 ## Usage

data/lib/statesman/exceptions.rb

@@ -4,16 +4,21 @@ module Statesman
   class InvalidStateError < StandardError; end
   class InvalidTransitionError < StandardError; end
   class InvalidCallbackError < StandardError; end
+  class TransitionConflictError < StandardError; end
+  class MissingTransitionAssociation < StandardError; end
 
   class TransitionFailedError < StandardError
     def initialize(from, to)
       @from = from
       @to = to
+      super(_message)
     end
 
     attr_reader :from, :to
 
-    def message
+    private
+
+    def _message
       "Cannot transition from '#{from}' to '#{to}'"
     end
   end
@@ -22,18 +27,18 @@ module Statesman
     def initialize(from, to)
       @from = from
       @to = to
+      super(_message)
     end
 
     attr_reader :from, :to
 
-    def message
+    private
+
+    def _message
       "Guard on transition from: '#{from}' to '#{to}' returned false"
     end
   end
 
-  class TransitionConflictError < StandardError; end
-  class MissingTransitionAssociation < StandardError; end
-
   class UnserializedMetadataError < StandardError
     def initialize(transition_class_name)
       super(_message(transition_class_name))

data/lib/statesman/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Statesman
-  VERSION = "7.0.1"
+  VERSION = "7.1.0"
 end

data/spec/statesman/exceptions_spec.rb

@@ -0,0 +1,88 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Statesman do
+  describe "InvalidStateError" do
+    subject(:error) { Statesman::InvalidStateError.new }
+
+    its(:message) { is_expected.to eq("Statesman::InvalidStateError") }
+    its "string matches its message" do
+      expect(error.to_s).to eq(error.message)
+    end
+  end
+
+  describe "InvalidTransitionError" do
+    subject(:error) { Statesman::InvalidTransitionError.new }
+
+    its(:message) { is_expected.to eq("Statesman::InvalidTransitionError") }
+    its "string matches its message" do
+      expect(error.to_s).to eq(error.message)
+    end
+  end
+
+  describe "InvalidCallbackError" do
+    subject(:error) { Statesman::InvalidTransitionError.new }
+
+    its(:message) { is_expected.to eq("Statesman::InvalidTransitionError") }
+    its "string matches its message" do
+      expect(error.to_s).to eq(error.message)
+    end
+  end
+
+  describe "TransitionConflictError" do
+    subject(:error) { Statesman::TransitionConflictError.new }
+
+    its(:message) { is_expected.to eq("Statesman::TransitionConflictError") }
+    its "string matches its message" do
+      expect(error.to_s).to eq(error.message)
+    end
+  end
+
+  describe "MissingTransitionAssociation" do
+    subject(:error) { Statesman::MissingTransitionAssociation.new }
+
+    its(:message) { is_expected.to eq("Statesman::MissingTransitionAssociation") }
+    its "string matches its message" do
+      expect(error.to_s).to eq(error.message)
+    end
+  end
+
+  describe "TransitionFailedError" do
+    subject(:error) { Statesman::TransitionFailedError.new("from", "to") }
+
+    its(:message) { is_expected.to eq("Cannot transition from 'from' to 'to'") }
+    its "string matches its message" do
+      expect(error.to_s).to eq(error.message)
+    end
+  end
+
+  describe "GuardFailedError" do
+    subject(:error) { Statesman::GuardFailedError.new("from", "to") }
+
+    its(:message) do
+      is_expected.to eq("Guard on transition from: 'from' to 'to' returned false")
+    end
+    its "string matches its message" do
+      expect(error.to_s).to eq(error.message)
+    end
+  end
+
+  describe "UnserializedMetadataError" do
+    subject(:error) { Statesman::UnserializedMetadataError.new("foo") }
+
+    its(:message) { is_expected.to match(/foo#metadata is not serialized/) }
+    its "string matches its message" do
+      expect(error.to_s).to eq(error.message)
+    end
+  end
+
+  describe "IncompatibleSerializationError" do
+    subject(:error) { Statesman::IncompatibleSerializationError.new("foo") }
+
+    its(:message) { is_expected.to match(/foo#metadata column type cannot be json/) }
+    its "string matches its message" do
+      expect(error.to_s).to eq(error.message)
+    end
+  end
+end

data/statesman.gemspec

@@ -33,6 +33,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec-its", "~> 1.1"
   spec.add_development_dependency "rspec-rails", "~> 3.1"
   spec.add_development_dependency "rspec_junit_formatter", "~> 0.4.0"
-  spec.add_development_dependency "sqlite3", "~> 1.3.6"
+  spec.add_development_dependency "sqlite3", "~> 1.4.2"
   spec.add_development_dependency "timecop", "~> 0.9.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: statesman
 version: !ruby/object:Gem::Version
-  version: 7.0.1
+  version: 7.1.0
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-08 00:00:00.000000000 Z
+date: 2020-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ammeter
@@ -190,14 +190,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.6
+        version: 1.4.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.6
+        version: 1.4.2
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
@@ -266,6 +266,7 @@ files:
 - spec/statesman/adapters/shared_examples.rb
 - spec/statesman/callback_spec.rb
 - spec/statesman/config_spec.rb
+- spec/statesman/exceptions_spec.rb
 - spec/statesman/guard_spec.rb
 - spec/statesman/machine_spec.rb
 - spec/statesman/utils_spec.rb
@@ -310,6 +311,7 @@ test_files:
 - spec/statesman/adapters/shared_examples.rb
 - spec/statesman/callback_spec.rb
 - spec/statesman/config_spec.rb
+- spec/statesman/exceptions_spec.rb
 - spec/statesman/guard_spec.rb
 - spec/statesman/machine_spec.rb
 - spec/statesman/utils_spec.rb