statesman 4.1.2 → 4.1.3

data/statesman.gemspec

@@ -26,7 +26,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "pg", "~> 0.18"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "rails", ">= 3.2"
-  spec.add_development_dependency "rake", "~> 12.3.0"
+  spec.add_development_dependency "rake", "~> 13.0.0"
   spec.add_development_dependency "rspec", "~> 3.1"
   spec.add_development_dependency "rspec-its", "~> 1.1"
   spec.add_development_dependency "rspec-rails", "~> 3.1"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: statesman
 version: !ruby/object:Gem::Version
-  version: 4.1.2
+  version: 4.1.3
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-17 00:00:00.000000000 Z
+date: 2019-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ammeter
@@ -120,14 +120,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 12.3.0
+        version: 13.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 12.3.0
+        version: 13.0.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -234,10 +234,8 @@ files:
 - lib/generators/statesman/active_record_transition_generator.rb
 - lib/generators/statesman/generator_helpers.rb
 - lib/generators/statesman/migration_generator.rb
-- lib/generators/statesman/mongoid_transition_generator.rb
 - lib/generators/statesman/templates/active_record_transition_model.rb.erb
 - lib/generators/statesman/templates/create_migration.rb.erb
-- lib/generators/statesman/templates/mongoid_transition_model.rb.erb
 - lib/generators/statesman/templates/update_migration.rb.erb
 - lib/statesman.rb
 - lib/statesman/adapters/active_record.rb
@@ -245,8 +243,6 @@ files:
 - lib/statesman/adapters/active_record_transition.rb
 - lib/statesman/adapters/memory.rb
 - lib/statesman/adapters/memory_transition.rb
-- lib/statesman/adapters/mongoid.rb
-- lib/statesman/adapters/mongoid_transition.rb
 - lib/statesman/callback.rb
 - lib/statesman/config.rb
 - lib/statesman/exceptions.rb
@@ -261,14 +257,12 @@ files:
 - spec/fixtures/add_most_recent_to_bacon_transitions.rb
 - spec/generators/statesman/active_record_transition_generator_spec.rb
 - spec/generators/statesman/migration_generator_spec.rb
-- spec/generators/statesman/mongoid_transition_generator_spec.rb
 - spec/spec_helper.rb
 - spec/statesman/adapters/active_record_queries_spec.rb
 - spec/statesman/adapters/active_record_spec.rb
 - spec/statesman/adapters/active_record_transition_spec.rb
 - spec/statesman/adapters/memory_spec.rb
 - spec/statesman/adapters/memory_transition_spec.rb
-- spec/statesman/adapters/mongoid_spec.rb
 - spec/statesman/adapters/shared_examples.rb
 - spec/statesman/callback_spec.rb
 - spec/statesman/config_spec.rb
@@ -277,7 +271,6 @@ files:
 - spec/statesman/utils_spec.rb
 - spec/support/active_record.rb
 - spec/support/generators_shared_examples.rb
-- spec/support/mongoid.rb
 - statesman.gemspec
 homepage: https://github.com/gocardless/statesman
 licenses:
@@ -299,7 +292,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2.3
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: A statesman-like state machine library
@@ -309,14 +302,12 @@ test_files:
 - spec/fixtures/add_most_recent_to_bacon_transitions.rb
 - spec/generators/statesman/active_record_transition_generator_spec.rb
 - spec/generators/statesman/migration_generator_spec.rb
-- spec/generators/statesman/mongoid_transition_generator_spec.rb
 - spec/spec_helper.rb
 - spec/statesman/adapters/active_record_queries_spec.rb
 - spec/statesman/adapters/active_record_spec.rb
 - spec/statesman/adapters/active_record_transition_spec.rb
 - spec/statesman/adapters/memory_spec.rb
 - spec/statesman/adapters/memory_transition_spec.rb
-- spec/statesman/adapters/mongoid_spec.rb
 - spec/statesman/adapters/shared_examples.rb
 - spec/statesman/callback_spec.rb
 - spec/statesman/config_spec.rb
@@ -325,4 +316,3 @@ test_files:
 - spec/statesman/utils_spec.rb
 - spec/support/active_record.rb
 - spec/support/generators_shared_examples.rb
-- spec/support/mongoid.rb

data/lib/generators/statesman/mongoid_transition_generator.rb

@@ -1,25 +0,0 @@
-require "rails/generators"
-require "generators/statesman/generator_helpers"
-
-module Statesman
-  class MongoidTransitionGenerator < Rails::Generators::Base
-    include Statesman::GeneratorHelpers
-
-    desc "Create a Mongoid-based transition model with the required attributes"
-
-    argument :parent, type: :string, desc: "Your parent model name"
-    argument :klass, type: :string, desc: "Your transition model name"
-
-    source_root File.expand_path("templates", __dir__)
-
-    def create_model_file
-      template("mongoid_transition_model.rb.erb", model_file_name)
-    end
-
-    private
-
-    def collection_name
-      klass.underscore.pluralize
-    end
-  end
-end

data/lib/generators/statesman/templates/mongoid_transition_model.rb.erb

@@ -1,14 +0,0 @@
-class <%= klass %>
-  include Mongoid::Document
-  include Mongoid::Timestamps
-
-  field :to_state, type: String
-  field :sort_key, type: Integer
-  field :statesman_metadata, type: Hash
-
-  include Statesman::Adapters::MongoidTransition
-
-  index({ sort_key: 1 })
-
-  belongs_to :<%= parent %><%= class_name_option %>, index: true
-end

data/lib/statesman/adapters/mongoid.rb

@@ -1,66 +0,0 @@
-require_relative "../exceptions"
-
-module Statesman
-  module Adapters
-    class Mongoid
-      attr_reader :transition_class
-      attr_reader :parent_model
-
-      def initialize(transition_class, parent_model, observer, _opts = {})
-        @transition_class = transition_class
-        @parent_model = parent_model
-        @observer = observer
-        unless transition_class_hash_fields.include?("statesman_metadata")
-          raise UnserializedMetadataError, metadata_field_error_message
-        end
-      end
-
-      def create(from, to, metadata = {})
-        from = from.to_s
-        to = to.to_s
-        transition = transitions_for_parent.build(to_state: to,
-                                                  sort_key: next_sort_key,
-                                                  statesman_metadata: metadata)
-
-        @observer.execute(:before, from, to, transition)
-        transition.save!
-        @last_transition = transition
-        @observer.execute(:after, from, to, transition)
-        @observer.execute(:after_commit, from, to, transition)
-        transition
-      ensure
-        @last_transition = nil
-      end
-
-      def history(*)
-        transitions_for_parent.asc(:sort_key)
-      end
-
-      def last(force_reload: false)
-        if force_reload
-          @last_transition = history.last
-        else
-          @last_transition ||= history.last
-        end
-      end
-
-      private
-
-      def transition_class_hash_fields
-        transition_class.fields.select { |_, v| v.type == Hash }.keys
-      end
-
-      def metadata_field_error_message
-        "#{transition_class.name}#statesman_metadata is not of type 'Hash'"
-      end
-
-      def transitions_for_parent
-        @parent_model.send(@transition_class.collection_name)
-      end
-
-      def next_sort_key
-        (last && last.sort_key + 10) || 10
-      end
-    end
-  end
-end

data/lib/statesman/adapters/mongoid_transition.rb

@@ -1,10 +0,0 @@
-module Statesman
-  module Adapters
-    module MongoidTransition
-      def self.included(base)
-        base.send(:alias_method, :metadata, :statesman_metadata)
-        base.send(:alias_method, :metadata=, :statesman_metadata=)
-      end
-    end
-  end
-end

data/spec/generators/statesman/mongoid_transition_generator_spec.rb

@@ -1,23 +0,0 @@
-require "spec_helper"
-require "support/generators_shared_examples"
-require "generators/statesman/mongoid_transition_generator"
-
-describe Statesman::MongoidTransitionGenerator, type: :generator do
-  describe "the model contains the correct words" do
-    subject { file("app/models/yummy/bacon_transition.rb") }
-
-    before { run_generator %w[Yummy::Bacon Yummy::BaconTransition] }
-
-    it { is_expected.to_not contain(%r{:yummy/bacon}) }
-    it { is_expected.to contain(/class_name: 'Yummy::Bacon'/) }
-  end
-
-  describe "the model contains the correct words" do
-    subject { file("app/models/bacon_transition.rb") }
-
-    before { run_generator %w[Bacon BaconTransition] }
-
-    it { is_expected.to_not contain(/class_name:/) }
-    it { is_expected.to_not contain(/CreateYummy::Bacon/) }
-  end
-end

data/spec/statesman/adapters/mongoid_spec.rb

@@ -1,86 +0,0 @@
-require "spec_helper"
-require "statesman/adapters/shared_examples"
-require "statesman/exceptions"
-require "support/mongoid"
-require "mongoid"
-
-describe Statesman::Adapters::Mongoid, mongo: true do
-  after { Mongoid.purge! }
-
-  let(:observer) { double(Statesman::Machine, execute: nil) }
-  let(:model) { MyMongoidModel.create(current_state: :pending) }
-
-  it_behaves_like "an adapter", described_class, MyMongoidModelTransition
-
-  describe "#initialize" do
-    context "with unserialized metadata" do
-      before do
-        allow_any_instance_of(described_class).
-          to receive_messages(transition_class_hash_fields: [])
-      end
-
-      it "raises an exception if metadata is not serialized" do
-        expect do
-          described_class.new(MyMongoidModelTransition, MyMongoidModel,
-                              observer)
-        end.to raise_exception(Statesman::UnserializedMetadataError)
-      end
-    end
-  end
-
-  describe "#last" do
-    let(:adapter) do
-      described_class.new(MyMongoidModelTransition, model, observer)
-    end
-
-    context "with a previously looked up transition" do
-      before { adapter.create(:x, :y) }
-
-      before { adapter.last }
-
-      it "caches the transition" do
-        expect_any_instance_of(MyMongoidModel).
-          to_not receive(:my_mongoid_model_transitions)
-        adapter.last
-      end
-
-      context "and a new transition" do
-        before { adapter.create(:y, :z) }
-
-        it "retrieves the new transition from the database" do
-          expect(adapter.last.to_state).to eq("z")
-        end
-      end
-    end
-
-    context "when a new transition has been created elsewhere" do
-      let(:alternate_adapter) do
-        described_class.new(MyMongoidModelTransition, model, observer)
-      end
-
-      context "when explicitly not using the cache" do
-        context "when the transitions are in memory" do
-          before do
-            model.my_mongoid_model_transitions.entries
-            alternate_adapter.create(:y, :z)
-          end
-
-          it "reloads the value" do
-            expect(adapter.last(force_reload: true).to_state).to eq("z")
-          end
-        end
-
-        context "when the transitions are not in memory" do
-          before do
-            model.my_mongoid_model_transitions.reset
-            alternate_adapter.create(:y, :z)
-          end
-
-          it "reloads the value" do
-            expect(adapter.last(force_reload: true).to_state).to eq("z")
-          end
-        end
-      end
-    end
-  end
-end

data/spec/support/mongoid.rb

@@ -1,28 +0,0 @@
-require "mongoid"
-
-Mongoid.configure do |config|
-  config.connect_to("statesman_test")
-end
-
-class MyMongoidModel
-  include Mongoid::Document
-
-  field :current_state, type: String
-
-  has_many :my_mongoid_model_transitions
-end
-
-class MyMongoidModelTransition
-  include Mongoid::Document
-  include Mongoid::Timestamps
-
-  field :to_state, type: String
-  field :sort_key, type: Integer
-  field :statesman_metadata, type: Hash
-
-  index(sort_key: 1)
-
-  belongs_to :my_mongoid_model, index: true
-
-  include Statesman::Adapters::MongoidTransition
-end