statesman-multi_state 0.2.8 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 56b6d12e6735645ee756e41faf3c25a9db55ce2185555f996e0d97c20abaabc1
-  data.tar.gz: 5f3bc6ad945f8b2b15fc285a14be068da5aa8d3911ed34fdce80dcdbedd7745c
+  metadata.gz: 4341220f127a7664fa7f0f3457a58d8901284dedf43bec6b8f8fd8b7d18b52fe
+  data.tar.gz: e5ac0fe8d9f6de6cacc2bb4c9b89ddc7e9e1800920bc660dc169eb8507cc5ff8
 SHA512:
-  metadata.gz: 10d154e23d0d77bebcbc88f8e9aaad0f3ba92897a1ddfe53265486ecadaca65bc79e2b6c028c2294b290528bbcbf5fa71488e059fa65b890932d8524d7fff41b
-  data.tar.gz: 9cff0f4741c416da6696728115b777809f3d45230988786fc861abee6a2e43b5b887aac20c1a3765bed3bfdf5d80f36af0c57df7d8f4ec94994b6b36f57bf07f
+  metadata.gz: 2acbbdb9b3af2837f225a870fe483f16eeadd80a127a902da0180b62f9950e9ff8a641cf02296e2b71e12534485cfc65264ff910a5896c6d232359a2d15667af
+  data.tar.gz: 75da67f863766eb592e297a411dcced1cbc08c8f2df4215909ccb21f87e946a68e145b8dea9273b2a8b7113ae39a005a2a70d8821310b34c4a12fbcfcc97ce5c

data/lib/statesman/multi_state/active_record_macro.rb

@@ -50,14 +50,17 @@ module Statesman
 
               if #{initial_transition}
                 if @#{state_machine_name}.history.empty? && #{state_machine_klass}.initial_state
-                  @#{state_machine_name}.instance_variable_get(:@storage_adapter).create(nil, #{state_machine_klass}.initial_state) if @#{state_machine_name}.object.persisted?
+                  if @#{state_machine_name}.object.persisted? && self.class.current_role != ::ActiveRecord.reading_role
+                    @#{state_machine_name}.instance_variable_get(:@storage_adapter).create(nil, #{state_machine_klass}.initial_state)
+                  end
                 end
               end
               @#{state_machine_name}
             end
 
             def #{virtual_attribute_name}
-              super() || #{field_name}_current_state
+              value = read_attribute("#{virtual_attribute_name}")
+              value.nil? ? #{field_name}_current_state : value
             end
 
             def #{field_name}_current_state_human
@@ -66,6 +69,26 @@ module Statesman
             end
           CODE
 
+          # Define a public reader so form helpers, serializers, and other
+          # callers that use `public_send(field_name)` work. Guard against
+          # clobbering an existing column reader or user-defined method with
+          # the same name as `field_name`.
+          table_name_available = name.present? || (instance_variable_defined?(:@table_name) && @table_name.present?)
+          has_column_reader = if respond_to?(:column_names) && table_name_available &&
+                                 respond_to?(:table_exists?) && table_exists?
+                                column_names.include?(field_name.to_s)
+                              else
+                                false
+                              end
+
+          unless method_defined?(field_name) || private_method_defined?(field_name) || has_column_reader
+            generated_association_methods.class_eval <<~READER, __FILE__, __LINE__ + 1
+              def #{field_name}
+                #{field_name}_current_state
+              end
+            READER
+          end
+
           include(const_set("#{field_name}#{SecureRandom.hex(4)}_mod".classify, Module.new).tap do |mod|
             mod.module_eval do
               extend ActiveSupport::Concern
@@ -84,8 +107,18 @@ module Statesman
               class_eval <<~METHOD, __FILE__, __LINE__ + 1
                 def save_with_state(**options)
                   @registered_callbacks ||= []
-                  if #{virtual_attribute_name}_changed? && #{field_name}_can_transition_to?(#{virtual_attribute_name})
-                    @registered_callbacks << -> { #{field_name}_transition_to(#{virtual_attribute_name}, **options) }
+                  if #{virtual_attribute_name}.to_s != #{field_name}_current_state.to_s
+                    if #{field_name}_can_transition_to?(#{virtual_attribute_name})
+                      @registered_callbacks << -> { #{field_name}_transition_to(#{virtual_attribute_name}, **options) }
+                    else
+                      errors.add(
+                        :#{field_name},
+                        :invalid_transition,
+                        current_state: #{field_name}_current_state_human,
+                        target_state: I18n.t(#{virtual_attribute_name}, scope: "statesman.#{field_name}_#{base_klass.underscore}", default: #{virtual_attribute_name}.to_s)
+                      )
+                      return false
+                    end
                   end
 
                   if defined?(super)

data/lib/statesman/multi_state/locales/en.yml

@@ -0,0 +1,4 @@
+en:
+  errors:
+    messages:
+      invalid_transition: "cannot transition from %{current_state} to %{target_state}"

data/lib/statesman/multi_state/railtie.rb

@@ -14,6 +14,10 @@ module Statesman
           ActiveRecord::Reflection.singleton_class.prepend(Statesman::MultiState::Reflection::ReflectionExtension)
         end
       end
+
+      initializer 'statesman.multi_state.i18n' do |app|
+        app.config.i18n.load_path += Dir[File.expand_path('locales/*.yml', __dir__)]
+      end
     end
   end
 end

data/lib/statesman/multi_state/version.rb

@@ -2,6 +2,6 @@
 
 module Statesman
   module MultiState
-    VERSION = '0.2.8'
+    VERSION = '0.3.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: statesman-multi_state
 version: !ruby/object:Gem::Version
-  version: 0.2.8
+  version: 0.3.0
 platform: ruby
 authors:
 - Chedli Bourguiba
@@ -51,6 +51,7 @@ files:
 - lib/statesman/adapters/custom_active_record_queries.rb
 - lib/statesman/multi_state.rb
 - lib/statesman/multi_state/active_record_macro.rb
+- lib/statesman/multi_state/locales/en.yml
 - lib/statesman/multi_state/railtie.rb
 - lib/statesman/multi_state/reflection.rb
 - lib/statesman/multi_state/version.rb