statelint 0.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 3c171b698ac8e7b834abfd2a1106aa543f3c4e8c
+  data.tar.gz: e2250f8cc52a03abfb5b823d5dc85ae340f73cf8
+SHA512:
+  metadata.gz: 50c4bfde953ba79fac5e7df834f8c6c624a27999b3708b58554cffdc7d460560dd0199615d95e9aabee8c8d8c7b3615af2794c96260d60daf0ae475429072711
+  data.tar.gz: 30c22b4e9e4c61388b50b4fbbffeac283a02e1a880b0c9b8a2ae8777f345e279cebf2be6afdf4277b2c1df33187ac62545a53bd67f1a5b2819d61ae56d06ae30

data/.gitignore

@@ -0,0 +1,2 @@
+*~
+*.gem

data/Gemfile

@@ -0,0 +1,3 @@
+source "https://rubygems.org"
+
+gem 'j2119', '>=0.1.0'

data/LICENSE

@@ -0,0 +1,201 @@
+                                 Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+      "License" shall mean the terms and conditions for use, reproduction,
+      and distribution as defined by Sections 1 through 9 of this document.
+
+      "Licensor" shall mean the copyright owner or entity authorized by
+      the copyright owner that is granting the License.
+
+      "Legal Entity" shall mean the union of the acting entity and all
+      other entities that control, are controlled by, or are under common
+      control with that entity. For the purposes of this definition,
+      "control" means (i) the power, direct or indirect, to cause the
+      direction or management of such entity, whether by contract or
+      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      outstanding shares, or (iii) beneficial ownership of such entity.
+
+      "You" (or "Your") shall mean an individual or Legal Entity
+      exercising permissions granted by this License.
+
+      "Source" form shall mean the preferred form for making modifications,
+      including but not limited to software source code, documentation
+      source, and configuration files.
+
+      "Object" form shall mean any form resulting from mechanical
+      transformation or translation of a Source form, including but
+      not limited to compiled object code, generated documentation,
+      and conversions to other media types.
+
+      "Work" shall mean the work of authorship, whether in Source or
+      Object form, made available under the License, as indicated by a
+      copyright notice that is included in or attached to the work
+      (an example is provided in the Appendix below).
+
+      "Derivative Works" shall mean any work, whether in Source or Object
+      form, that is based on (or derived from) the Work and for which the
+      editorial revisions, annotations, elaborations, or other modifications
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and Derivative Works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control systems,
+      and issue tracking systems that are managed by, or on behalf of, the
+      Licensor for the purpose of discussing and improving the Work, but
+      excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
+
+      "Contributor" shall mean Licensor and any individual or Legal Entity
+      on behalf of whom a Contribution has been received by Licensor and
+      subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      copyright license to reproduce, prepare Derivative Works of,
+      publicly display, publicly perform, sublicense, and distribute the
+      Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
+
+   4. Redistribution. You may reproduce and distribute copies of the
+      Work or Derivative Works thereof in any medium, with or without
+      modifications, and in Source or Object form, provided that You
+      meet the following conditions:
+
+      (a) You must give any other recipients of the Work or
+          Derivative Works a copy of this License; and
+
+      (b) You must cause any modified files to carry prominent notices
+          stating that You changed the files; and
+
+      (c) You must retain, in the Source form of any Derivative Works
+          that You distribute, all copyright, patent, trademark, and
+          attribution notices from the Source form of the Work,
+          excluding those notices that do not pertain to any part of
+          the Derivative Works; and
+
+      (d) If the Work includes a "NOTICE" text file as part of its
+          distribution, then any Derivative Works that You distribute must
+          include a readable copy of the attribution notices contained
+          within such NOTICE file, excluding those notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright statement to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+      any Contribution intentionally submitted for inclusion in the Work
+      by You to the Licensor shall be under the terms and conditions of
+      this License, without any additional terms or conditions.
+      Notwithstanding the above, nothing herein shall supersede or modify
+      the terms of any separate license agreement you may have executed
+      with Licensor regarding such Contributions.
+
+   6. Trademarks. This License does not grant permission to use the trade
+      names, trademarks, service marks, or product names of the Licensor,
+      except as required for reasonable and customary use in describing the
+      origin of the Work and reproducing the content of the NOTICE file.
+
+   7. Disclaimer of Warranty. Unless required by applicable law or
+      agreed to in writing, Licensor provides the Work (and each
+      Contributor provides its Contributions) on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+      implied, including, without limitation, any warranties or conditions
+      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+      PARTICULAR PURPOSE. You are solely responsible for determining the
+      appropriateness of using or redistributing the Work and assume any
+      risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+      whether in tort (including negligence), contract, or otherwise,
+      unless required by applicable law (such as deliberate and grossly
+      negligent acts) or agreed to in writing, shall any Contributor be
+      liable to You for damages, including any direct, indirect, special,
+      incidental, or consequential damages of any character arising as a
+      result of this License or out of the use or inability to use the
+      Work (including but not limited to damages for loss of goodwill,
+      work stoppage, computer failure or malfunction, or any and all
+      other commercial damages or losses), even if such Contributor
+      has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Additional Liability. While redistributing
+      the Work or Derivative Works thereof, You may choose to offer,
+      and charge a fee for, acceptance of support, warranty, indemnity,
+      or other liability obligations and/or rights consistent with this
+      License. However, in accepting such obligations, You may act only
+      on Your own behalf and on Your sole responsibility, not on behalf
+      of any other Contributor, and only if You agree to indemnify,
+      defend, and hold each Contributor harmless for any liability
+      incurred by, or claims asserted against, such Contributor by reason
+      of your accepting any such warranty or additional liability.
+
+   END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "{}"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright {yyyy} {name of copyright owner}
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.

data/NOTICE.txt

@@ -0,0 +1,3 @@
+statelint
+
+Copyright 2016 Amazon.com, Inc. or its affiliates. All Rights Reserved.

data/README.md

@@ -0,0 +1,38 @@
+# statelint
+A Ruby gem that provides a command-line validator for Amazon States Language JSON files. 
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+```ruby
+gem 'statelint'
+```
+
+And then execute:
+
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install statelint
+
+## Usage
+
+statelint state-machine-spec, state-machinespec...
+
+There are no options. If you see no output, your state machine is fine.
+
+## To do
+
+Currently covers most of the grammatical constraints for state-machine 
+definitions.  The checking of JsonPath syntax is hand-built and probably
+imperfect.
+
+The Ruby JSON parser unfortunately does not detect duplicate keys
+in objects, so neither does statelint.
+
+## Contributing
+
+Bug reports and pull requests are welcome on GitHub 
+

data/Rakefile

@@ -0,0 +1,10 @@
+lib_dir = File.expand_path(File.join(File.dirname(__FILE__), "lib"))
+$:.unshift(lib_dir)
+$:.uniq!
+
+require 'rspec/core/rake_task'
+
+task :default => :spec
+
+RSpec::Core::RakeTask.new
+

data/bin/statelint

@@ -0,0 +1,31 @@
+#!/usr/bin/env ruby
+# Copyright 2016 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"). You may
+# not use this file except in compliance with the License. A copy of the
+# License is located at
+#
+#    http://aws.amazon.com/apache2.0/
+#
+# or in the LICENSE.txt file accompanying this file. This file is distributed
+# on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+# express or implied. See the License for the specific language governing
+# permissions and limitations under the License.
+
+require 'statelint'
+
+linter = StateMachineLint::Linter.new
+
+# arguments are JSON filenames
+ARGV.each do |file|
+  problems = linter.validate(ARGV[0])
+
+  if !problems.empty?
+    header = (problems.size == 1) ? 'One error:' : "#{problems.size} errors:"
+    puts header
+    problems.each do |problem|
+      puts " #{problem}"
+    end
+  end
+end
+

data/data/StateMachine.j2119

@@ -0,0 +1,112 @@
+This document specifies a JSON object called a "State Machine".
+A State Machine MUST have an object field named "States"; each field is a "State".
+A State Machine MUST have a string field named "StartAt".
+A State Machine MAY have a string field named "Comment".
+A State Machine MAY have a string field named "Version".
+A State Machine MAY have a positive-integer field named "TimeoutSeconds" whose value MUST be less than 99999999.
+A State MUST have a string field named "Type" whose value MUST be one of "Pass", "Succeed", "Fail", "Task", "Choice", "Wait", or "Parallel".
+A State whose "Type" field's value is "Pass" is a "Pass State".
+A State whose "Type" field's value is "Succeed" is a "Succeed State".
+A State whose "Type" field's value is "Fail" is a "Fail State".
+A State whose "Type" field's value is "Task" is a "Task State".
+A State whose "Type" field's value is "Choice" is a "Choice State".
+A State whose "Type" field's value is "Wait" is a "Wait State".
+A State whose "Type" field's value is "Parallel" is a "Parallel State".
+A State MAY have a string field named "Comment".
+Each of a Pass State, a Task State, a Wait State, and a Parallel State MAY have a boolean field named "End".
+A State whose "End" field's value is true is a "Terminal State".
+Each of a Succeed State and a Fail State is a "Terminal State".
+A State which is not a Terminal State or a Choice State MUST have a string field named "Next".
+A Terminal State MUST NOT have a field named "Next".
+A State MAY have a nullable-JSONPath field named "InputPath".
+A State MAY have a nullable-referencePath field named "ResultPath".
+A State MAY have a nullable-JSONPath field named "OutputPath".
+A Pass State MAY have a field named "Result".
+A Fail State MUST NOT have a field named "InputPath".
+A Fail State MUST NOT have a field named "ResultPath".
+A Fail State MUST NOT have a field named "OutputPath".
+A Fail State MUST have a string field named "Cause".
+A Fail State MUST have a string field named "Error".
+Each of a Task State and a Parallel State MAY have an object-array field named "Retry"; each element is a "Retrier".
+A Task State MUST have a URI field named "Resource".
+A Task State MAY have a positive-integer field named "TimeoutSeconds" whose value MUST be less than 99999999.
+A Task State MAY have a positive-integer field named "HeartbeatSeconds" whose value MUST be less than 99999999.
+A Retrier MUST have a string-array field named "ErrorEquals".
+A Retrier MAY have an positive-integer field named "IntervalSeconds".
+A Retrier MAY have a nonnegative-integer field named "MaxAttempts" whose value MUST be less than 99999999.
+A Retrier MAY have a float field named "BackoffRate" whose value MUST be greater than or equal to 1.0.
+Each of a Task State and a Parallel State MAY have an object-array field named "Catch"; each element is a "Catcher".
+A Catcher MUST have an string-array field named "ErrorEquals".
+A Catcher MUST have a string field named "Next".
+A Catcher MAY have a nullable-referencePath field named "ResultPath".
+A Choice State MUST have a nonempty-object-array field named "Choices"; each element is a "Choice Rule".
+A Choice State MUST NOT have a field named "Next".
+A Choice State MUST NOT have a field named "End".
+A Choice State MAY have a string field named "Default".
+A Choice Rule MAY have a nonempty-object-array field named "And"; each element is a "Nested Rule".
+A Choice Rule MAY have a nonempty-object-array field named "Or"; each element is a "Nested Rule".
+A Choice Rule MAY have an object field named "Not"; its value is a "Nested Rule".
+A Choice Rule MUST have a string field named "Next".
+A Choice Rule with an "And" field is a "Boolean".
+A Choice Rule with an "Or" field is a "Boolean".
+A Choice Rule with a "Not" field is a "Boolean".
+A Choice Rule MAY have a referencePath field named "Variable".
+A Choice Rule with a "Variable" field is a "Comparison".
+A Comparison MUST have a field named one of "StringEquals", "StringLessThan", "StringGreaterThan", "StringLessThanEquals", "StringGreaterThanEquals", "NumericEquals", "NumericLessThan", "NumericGreaterThan", "NumericLessThanEquals", "NumericGreaterThanEquals", "BooleanEquals", "TimestampEquals", "TimestampLessThan", "TimestampGreaterThan", "TimestampLessThanEquals", or "TimestampGreaterThanEquals".
+A Comparison MAY have a string field named "StringEquals".
+A Comparison MAY have a string field named "StringLessThan".
+A Comparison MAY have a string field named "StringGreaterThan".
+A Comparison MAY have a string field named "StringLessThanEquals".
+A Comparison MAY have a string field named "StringGreaterThanEquals".
+A Comparison MAY have a numeric field named "NumericEquals".
+A Comparison MAY have a numeric field named "NumericLessThan".
+A Comparison MAY have a numeric field named "NumericGreaterThan".
+A Comparison MAY have a numeric field named "NumericLessThanEquals".
+A Comparison MAY have a numeric field named "NumericGreaterThanEquals".
+A Comparison MAY have a boolean field named "BooleanEquals".
+A Comparison MAY have a timestamp field named "TimestampEquals".
+A Comparison MAY have a timestamp field named "TimestampLessThan".
+A Comparison MAY have a timestamp field named "TimestampGreaterThan".
+A Comparison MAY have a timestamp field named "TimestampLessThanEquals".
+A Comparison MAY have a timestamp field named "TimestampGreaterThanEquals".
+A Comparison MUST NOT have a field named "And".
+A Comparison MUST NOT have a field named "Or".
+A Comparison MUST NOT have a field named "Not".
+A Nested Rule MAY have a nonempty-object-array field named "And"; each element is a "Nested Rule".
+A Nested Rule MAY have a nonempty-object-array field named "Or"; each element is a "Nested Rule".
+A Nested Rule MAY have an object field named "Not"; its value is a "Nested Rule".
+A Nested Rule with an "And" field is a "Nested Boolean".
+A Nested Rule with an "Or" field is a "Nested Boolean".
+A Nested Rule with a "Not" field is a "Nested Boolean".
+A Nested Rule MUST NOT have a field named "Next".
+A Nested Rule MAY have a referencePath field named "Variable".
+A Nested Rule with a "Variable" field is a "Nested Comparison".
+A Nested Comparison MAY have a string field named "StringEquals".
+A Nested Comparison MAY have a string field named "StringLessThan".
+A Nested Comparison MAY have a string field named "StringGreaterThan".
+A Nested Comparison MAY have a string field named "StringLessThanEquals".
+A Nested Comparison MAY have a string field named "StringGreaterThanEquals".
+A Nested Comparison MAY have a numeric field named "NumericEquals".
+A Nested Comparison MAY have a numeric field named "NumericLessThan".
+A Nested Comparison MAY have a numeric field named "NumericGreaterThan".
+A Nested Comparison MAY have a numeric field named "NumericLessThanEquals".
+A Nested Comparison MAY have a numeric field named "NumericGreaterThanEquals".
+A Nested Comparison MAY have a boolean field named "BooleanEquals".
+A Nested Comparison MAY have a timestamp field named "TimestampEquals".
+A Nested Comparison MAY have a timestamp field named "TimestampLessThan".
+A Nested Comparison MAY have a timestamp field named "TimestampGreaterThan".
+A Nested Comparison MAY have a timestamp field named "TimestampLessThanEquals".
+A Nested Comparison MAY have a timestamp field named "TimestampGreaterThanEquals".
+A Nested Comparison MUST NOT have a field named "And".
+A Nested Comparison MUST NOT have a field named "Or".
+A Nested Comparison MUST NOT have a field named "Not".
+A Wait State MAY have a positive-integer field named "Seconds".
+A Wait State MAY have a referencePath field named "SecondsPath".
+A Wait State MAY have a timestamp field named "Timestamp".
+A Wait State MAY have a referencePath field named "TimestampPath".
+A Wait State MUST have only one of "Seconds", "SecondsPath", "Timestamp", and "TimestampPath".
+A Wait State MUST have a field named one of "Seconds", "SecondsPath", "Timestamp", or "TimestampPath".
+A Parallel State MUST have an object-array field named "Branches"; each element is a "Branch".
+A Branch MUST have an object field named "States"; each element is a "State".
+A Branch MUST have a string field named "StartAt".
+A Branch MAY have a string field named "Comment".

data/lib/statelint.rb

@@ -0,0 +1,41 @@
+# Copyright 2016 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"). You may
+# not use this file except in compliance with the License. A copy of the
+# License is located at
+#
+#    http://aws.amazon.com/apache2.0/
+#
+# or in the LICENSE.txt file accompanying this file. This file is distributed
+# on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+# express or implied. See the License for the specific language governing
+# permissions and limitations under the License.
+#!/usr/bin/env ruby
+
+$:.unshift("#{File.expand_path(File.dirname(__FILE__))}/../lib")
+require 'j2119'
+require 'statelint/state_node'
+
+# This module calls the J2119 validator on the supplised input, and
+#  then performs some States-Language specific semantic checks that
+#  aren't expressible in a J2119 schema
+
+module StateMachineLint
+
+  # TODO: Semantic validations:
+  # - Path and Reference Path validations
+  class Linter
+
+    def initialize
+      schema = File.dirname(__FILE__) + '/../data/StateMachine.j2119'
+      @validator = J2119::Validator.new schema
+    end
+
+    def validate json
+      problems = @validator.validate json
+      checker = StateNode.new
+      checker.check(@validator.parsed, @validator.root, problems)
+      problems
+    end
+  end
+end

data/lib/statelint/state_node.rb

@@ -0,0 +1,159 @@
+# Copyright 2016 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"). You may
+# not use this file except in compliance with the License. A copy of the
+# License is located at
+#
+#    http://aws.amazon.com/apache2.0/
+#
+# or in the LICENSE.txt file accompanying this file. This file is distributed
+# on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+# express or implied. See the License for the specific language governing
+# permissions and limitations under the License.
+#!/usr/bin/env ruby
+
+module StateMachineLint
+
+  # Semantic validation that can't be expressed in a J2119 schema
+  #
+  class StateNode
+
+    def initialize
+      # We push States nodes on here when we traverse them.  
+      #  Then, whenever we find a "Next" or "Default" or "StartAt" node,
+      #  we validate that the target is there, and record that that
+      #  target has an incoming pointer
+      #
+      @current_states_node = []
+      @current_states_incoming = []
+
+      # We keep track of all the state names and complain about
+      #  dupes
+      @all_state_names = {}
+    end
+
+    def check(node, path, problems)
+      if !node.is_a? Hash
+        return
+      end
+
+      is_machine_top = node.key?("States") && node['States'].is_a?(Hash)
+      if is_machine_top
+        @current_states_node << node['States']
+        start_at = node['StartAt']
+        if start_at && start_at.is_a?(String)
+          @current_states_incoming << [ start_at ]
+          if !node['States'].key?(start_at)
+            problems <<
+              "StartAt value #{start_at} not found in " +
+              "States field at #{path}"
+          end
+        else
+          @current_states_incoming << []
+        end
+
+        node['States'].keys.each do |name|
+          if @all_state_names[name]
+            problems <<
+              "State \"#{name}\", defined at #{path}.States, " +
+              "is also defined at #{@all_state_names[name]}"
+          else
+            @all_state_names[name] = "#{path}.States"
+          end
+        end
+      end
+
+      check_for_terminal(node, path, problems)
+
+      check_next(node, path, problems)
+        
+      check_States_ALL(node['Retry'], path + '.Retry', problems)
+      check_States_ALL(node['Catch'], path + '.Catch', problems)
+
+      node.each do |name, val|
+        if val.is_a?(Array)
+          i = 0
+          val.each do |element|
+            check(element, "#{path}.#{name}[#{i}]", problems)
+            i += 1
+          end
+        else
+          check(val, "#{path}.#{name}", problems)
+        end
+      end
+
+      if is_machine_top
+        states = @current_states_node.pop
+        incoming = @current_states_incoming.pop
+        missing = states.keys - incoming
+        missing.each do |state|
+          problems << "No transition found to state #{path}.#{state}"
+        end
+      end
+    end
+
+    def check_next(node, path, problems)
+      add_next(node, path, 'Next', problems)
+      add_next(node, path, 'Default', problems)
+    end
+
+    def add_next(node, path, field, problems)
+      if node[field] && node[field].is_a?(String)
+        transition_to = node[field]
+
+        if !@current_states_node.empty?
+          if @current_states_node[-1].key?(transition_to)
+            @current_states_incoming[-1] << transition_to
+          else
+            problems <<
+              "No state found named \"#{transition_to}\", referenced at " +
+              "#{path}.#{field}"
+          end
+        end
+      end
+    end
+
+    def check_for_terminal(node, path, problems)
+      if node['States'] && node['States'].is_a?(Hash)
+        terminal_found = false
+        node['States'].each_value do |state_node|
+          if state_node.is_a?(Hash)
+            if [ 'Succeed', 'Fail' ].include?(state_node['Type'])
+              terminal_found = true
+            elsif state_node['End'] == true
+              terminal_found = true
+            end
+          end
+        end
+
+        if !terminal_found
+          problems << "No terminal state found in machine at #{path}.States"
+        end
+      end
+    end
+    
+    def check_States_ALL(node, path, problems)
+      if !node.is_a?(Array)
+        return
+      end
+      
+      i = 0
+      node.each do |element|
+        if element.is_a?(Hash)
+          if element['ErrorEquals'].is_a?(Array)
+            ee = element['ErrorEquals']
+            if ee.include? 'States.ALL'
+              if i != (node.size - 1) || ee.size != 1
+                problems <<
+                  "#{path}[#{i}]: States.ALL can only appear in the last " +
+                  "element, and by itself."
+              end
+            end
+          end
+        end
+        i += 1
+      end
+    end
+  end
+end
+

data/statelint.gemspec

@@ -0,0 +1,17 @@
+Gem::Specification.new do |s|
+  s.name        = 'statelint'
+  s.version     = '0.1.0'
+  s.date        = '2016-09-28'
+  s.summary     = "State Machine JSON validator"
+  s.description = "Validates a JSON object representing a State Machine"
+  s.authors     = ["Tim Bray"]
+  s.email       = 'timbray@amazon.com'
+  s.executables << 'statelint'
+  s.files       = `git ls-files`.split("\n").reject do |f|
+    f.match(%r{^(spec|test)/})
+  end
+
+  s.homepage    = 'http://rubygems.org/gems/statelint'
+  s.license     = 'Apache 2.0'
+  s.add_runtime_dependency "j2119"
+end

metadata

@@ -0,0 +1,69 @@
+--- !ruby/object:Gem::Specification
+name: statelint
+version: !ruby/object:Gem::Version
+  version: 0.1.0
+platform: ruby
+authors:
+- Tim Bray
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2016-09-28 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: j2119
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+description: Validates a JSON object representing a State Machine
+email: timbray@amazon.com
+executables:
+- statelint
+extensions: []
+extra_rdoc_files: []
+files:
+- .gitignore
+- Gemfile
+- LICENSE
+- NOTICE.txt
+- README.md
+- Rakefile
+- bin/statelint
+- data/StateMachine.j2119
+- lib/statelint.rb
+- lib/statelint/state_node.rb
+- statelint.gemspec
+homepage: http://rubygems.org/gems/statelint
+licenses:
+- Apache 2.0
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.0.14.1
+signing_key: 
+specification_version: 4
+summary: State Machine JSON validator
+test_files: []