state_machines 0.200.0 → 0.201.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 10897c2b3fdaea1f4728eb063c09f7996c6164f938d814dc486c746c4e91c081
-  data.tar.gz: e7e89af7bfa089d2f1a7c7324f028223e530231e808e34398a2665c11992c168
+  metadata.gz: fcd3d5e6fc0f3982c8ddabc40480b43375d6e323957dd392ca4b3cc10f9c0f40
+  data.tar.gz: 89556aa64bb82045527f260098dd801acce298be5ad873ed7f250805b7839c87
 SHA512:
-  metadata.gz: cb901d7e14ae688dbfec57c312a6edc338156dc0b239a9f56f6898443bbb3ed33e1aad85a260b5ab6c6aa21f3513fdac1e19f24b09418d8994be6f6f80a50a41
-  data.tar.gz: ca11e59b75a28e0c3a9f27fae6a9ac194082a9a1a034d1160050f21c8645f69111e6179e64c5d0048143f5d095f789207372c9d2ef3b3d2a0a07e10cd154438d
+  metadata.gz: d44ae6b303dc577db3ed8aa70d7132521b8be94c3651fa9afe886e90c7561ebea686d1c743adc9464d08bd01d2903a4e75eabf7aa567abacab81d0b1c889fea4
+  data.tar.gz: b04cbf3f1cb69b943fdf19aa91f37b3376f976c4ed28bd08ab4aed18af6473b3508c05fe52317f10f2627660a67a3e8c3e8481a520ba2985a5c7c37316499e51

data/lib/state_machines/transition.rb

@@ -346,6 +346,19 @@ module StateMachines
       !halted
     end
 
+    # Completes a transition whose before phase has already run by executing
+    # its after callbacks, resuming any paused around callbacks first.  Used
+    # to finish transitions that were stored for deferred completion (e.g.
+    # generated mid-action from an event attribute) once their action has
+    # succeeded.
+    def complete_deferred_after_callbacks
+      if paused?
+        run_callbacks(after: true)
+      else
+        after
+      end
+    end
+
     private
 
     # Runs a block that may get paused.  If the block doesn't pause, then

data/lib/state_machines/transition_collection.rb

@@ -257,11 +257,38 @@ module StateMachines
             object.instance_variable_set(:@_state_machine_event_transitions, transitions_by_machine)
           end
         end
+
+        # Complete any transitions that other machines generated mid-action
+        # (e.g. an event attribute set in a before callback and picked up by
+        # the validation cycle) so their after callbacks run in this same
+        # action cycle instead of leaking into the next one (issue #91)
+        complete_nested_transitions unless skip_after
       else
         super
       end
     end
 
+    # Completes transitions that were stored for deferred completion by
+    # machines outside this collection while the action was running.  Their
+    # before callbacks and state persistence already happened mid-action;
+    # only their after callbacks remain.  Clears the stored references so
+    # they cannot leak into a later action cycle with stale data (issue #91).
+    def complete_nested_transitions
+      return if empty? || !success?
+
+      pending = object.instance_variable_get(:@_state_machine_event_transitions)
+      return unless pending
+
+      machines = map(&:machine)
+      pending.each_value do |transition|
+        next if machines.include?(transition.machine)
+
+        transition.machine.write(object, :event_transition, nil)
+        transition.complete_deferred_after_callbacks
+      end
+      object.instance_variable_set(:@_state_machine_event_transitions, nil)
+    end
+
     # Tracks that before callbacks have now completed
     def persist
       @before_run = true

data/lib/state_machines/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StateMachines
-  VERSION = '0.200.0'
+  VERSION = '0.201.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: state_machines
 version: !ruby/object:Gem::Version
-  version: 0.200.0
+  version: 0.201.0
 platform: ruby
 authors:
 - Abdelkader Boudih