state_machines 0.100.1 → 0.100.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a87715920a8f37a43cbac61b18e9a1c91d72b4b2d2228c3dc275dc05781efe9f
-  data.tar.gz: 7e098b96739caf0b91010ae21c626109b58fbd7325bfa309c0518055e040bcbb
+  metadata.gz: 7b5d883e6f3259de8981a9855e50d6f2d859bbd7e9e10a4cc5b4d91ae3fec65f
+  data.tar.gz: 9185125133d36eeed7ae95875a825e0e9a2e4d73b7de286c65be589965d2613d
 SHA512:
-  metadata.gz: 7c4905db4ba8245378cb89118143432d0fd009cefbef97846bbd12608c2dbb8b55627dceb71c2a044933acb3aeae4d57c21aa16c687b32883e18789b207da088
-  data.tar.gz: 3031f999997380d3def3b379ef794639463a2b0c82913e08f8829374fe5707ea36076e999965719db4dadcd31f8c9890fd40ff4bf6db9a3b2d081d99a771efe5
+  metadata.gz: 4786a92acf6011cc49c6e9f8daa0505d7bfcd26da0d244e351830aed0972ac12656ab39df4f9cf7b35fa4892c7afa02830b7ec0b33876a8624076e60fb273f21
+  data.tar.gz: e87573373f971cea02ebba3dcca45124f49d8ca6354c34756e55fd101deab5649ee349e62b05a3abb7d0fdde9ead78075984a089f7f3070fb4b4768c7af8fcc8

data/lib/state_machines/transition.rb

@@ -1,6 +1,11 @@
 # frozen_string_literal: true
 
 module StateMachines
+  # Module to extend Fiber instances for pausable state tracking
+  module PausableFiber
+    attr_accessor :state_machine_fiber_pausable
+  end
+
   # A transition represents a state change for a specific attribute.
   #
   # Transitions consist of:
@@ -39,6 +44,7 @@ module StateMachines
       @paused_fiber = nil
       @resuming = false
       @continuation_block = nil
+      @fiber_thread_storage = nil
 
       @event = machine.events.fetch(event)
       @from_state = machine.states.fetch(from_name)
@@ -196,7 +202,8 @@ module StateMachines
       # this is an idempotent call on an already-paused transition. Just return true.
       return true if @paused_fiber&.alive? && !options[:after]
 
-      # Extract pausable options
+      # Always use fibers for compatibility with existing pause/resume functionality
+      # The fiber argument can still be used to explicitly control fiber usage
       pausable_options = options.key?(:fiber) ? { fiber: options[:fiber] } : {}
 
       # Check if we're resuming from a pause
@@ -283,6 +290,7 @@ module StateMachines
       @paused_fiber = nil
       @resuming = false
       @continuation_block = nil
+      @fiber_thread_storage = nil
     end
 
     # Determines equality of transitions by testing whether the object, states,
@@ -375,41 +383,64 @@ module StateMachines
         # Handle different result types
         case result
         when Array
-          # Exception occurred inside the fiber
           if result[0] == :error
-            # Clean up state before re-raising
+            # Exception occurred inside the fiber
             @paused_fiber = nil
             raise result[1]
-          end
-        else
-          # Normal flow
-          # Check if fiber is still alive after resume
-          if @paused_fiber.alive?
-            # Still paused, keep the fiber
-            true
           else
-            # Fiber completed
-            @paused_fiber = nil
-            result == :halted
+            # Normal completion with thread storage export
+            @fiber_thread_storage = result[1] if result.length == 2 && result[1].is_a?(Hash)
+            result_value = result[0]
           end
+        else
+          # Direct result value (paused or simple completion)
+          result_value = result
+        end
+
+        # Check if fiber is still alive after resume
+        if @paused_fiber.alive?
+          # Still paused, keep the fiber
+          true
+        else
+          # Fiber completed
+          @paused_fiber = nil
+          result_value == :halted
         end
       else
+        # Capture current fiber's Thread.current storage to preserve object identity
+        # This is needed for compatibility but has limitations with dynamic assignments
+        parent_fiber_locals = Thread.current.keys.each_with_object({}) do |key, storage|
+          storage[key] = Thread.current[key]
+        end
+
         # Create a new fiber to run the block
         fiber = Fiber.new do
+          # Restore parent's Thread.current storage with exact same object references
+          parent_fiber_locals.each do |key, value|
+            Thread.current[key] = value
+          end
+
           # Mark that we're inside a pausable fiber
-          Thread.current[:state_machine_fiber_pausable] = true
+          Fiber.current.extend(StateMachines::PausableFiber)
+          Fiber.current.state_machine_fiber_pausable = true
           begin
             halted = !catch(:halt) do
               yield
               true
             end
-            halted ? :halted : :completed
+
+            # Export the final thread storage state along with the result
+            thread_storage = Thread.current.keys.each_with_object({}) do |key, storage|
+              storage[key] = Thread.current[key]
+            end
+
+            [halted ? :halted : :completed, thread_storage]
           rescue StandardError => e
             # Store the exception for re-raising
             [:error, e]
           ensure
             # Clean up the flag
-            Thread.current[:state_machine_fiber_pausable] = false
+            Fiber.current.state_machine_fiber_pausable = false
           end
         end
 
@@ -419,23 +450,28 @@ module StateMachines
         # Handle different result types
         case result
         when Array
-          # Exception occurred
           if result[0] == :error
-            # Clean up state before re-raising
+            # Exception occurred
             @paused_fiber = nil
             raise result[1]
-          end
-        else
-          # Normal flow
-          # Save if paused
-          if fiber.alive?
-            @paused_fiber = fiber
-            # Return true to indicate paused (treated as halted for flow control)
-            true
           else
-            # Fiber completed, return whether it was halted
-            result == :halted
+            # Normal completion - check if we have thread storage
+            @fiber_thread_storage = result[1] if result.length == 2 && result[1].is_a?(Hash)
+            result_value = result[0]
           end
+        else
+          # Direct result value (shouldn't happen with our new code)
+          result_value = result
+        end
+
+        # Save if paused
+        if fiber.alive?
+          @paused_fiber = fiber
+          # Return true to indicate paused (treated as halted for flow control)
+          true
+        else
+          # Fiber completed, return whether it was halted
+          result_value == :halted
         end
       end
     end
@@ -448,8 +484,9 @@ module StateMachines
       return if @resuming
 
       # Only yield if we're actually inside a fiber created by pausable
-      # We use a thread-local variable to track this
-      return unless Thread.current[:state_machine_fiber_pausable]
+      # We use a module extension to track this
+      current_fiber = Fiber.current
+      return unless current_fiber.respond_to?(:state_machine_fiber_pausable) && current_fiber.state_machine_fiber_pausable
 
       Fiber.yield
 
@@ -532,6 +569,10 @@ module StateMachines
     def after
       return if @after_run
 
+      # Restore the fiber's thread storage to ensure consistency
+      # This preserves Thread.current state from before/around callbacks to after callbacks
+      @fiber_thread_storage.each { |key, value| Thread.current[key] = value } if @fiber_thread_storage
+
       catch(:halt) do
         type = @success ? :after : :failure
         machine.callbacks[type].each { |callback| callback.call(object, context, self) }

data/lib/state_machines/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StateMachines
-  VERSION = '0.100.1'
+  VERSION = '0.100.4'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: state_machines
 version: !ruby/object:Gem::Version
-  version: 0.100.1
+  version: 0.100.4
 platform: ruby
 authors:
 - Abdelkader Boudih
@@ -135,7 +135,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.7
+rubygems_version: 3.6.9
 specification_version: 4
 summary: State machines for attributes
 test_files: []