stash_core_api 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eefa96b5608f5e886bec64e6bbecad120094e799c74c9e8c324ed58314174836
-  data.tar.gz: 729a6906231d22ccefbd8b7573eb64e8a08a7c08a7f2d20198bcb9c667813b08
+  metadata.gz: f22254286614f429f6ab5fb80d4741b920ceb613aa7618648274d90d5ce134d4
+  data.tar.gz: 1b02ccd11503e2a3660ca503fc975dce8b3939f56e21b5ff92923b80fc2ff579
 SHA512:
-  metadata.gz: b0c1cff131d164f24fb2e5b863385f1862e329cdac4f06ce89e5f80f3dcf23c879b1d75777c3869fc05048c622f42af34fb26f7ed582953b3ae48fa2ab2d557d
-  data.tar.gz: 2effd106f6e9b8ea1623f524568d6f77dffa18b1af8756140f58a0774e6c54b97ffa9377965b6f6c075979169761917d81e9ca944d6f283ebccff78d807139b0
+  metadata.gz: 0cb5d9d289c22e5ad5fa4f6df3b198ad3e44396fc4fca154b92280b20ec794e640e052923449bb0292b631ae37418cf7a24f9b93efa4943aa00334a93e1c186a
+  data.tar.gz: 74b01fab544b852e884d97124431ca93f0a78a5abb30c69cf6fa1ffa252f618e5092bc691bf5812e7213d97592881f359107bb50a04367dbacfbe6906f53005d

data/.rubocop.yml

@@ -0,0 +1,14 @@
+AllCops:
+  TargetRubyVersion: 2.4
+  DisplayCopNames: true
+
+Metrics:
+  Enabled: false
+Style/Documentation:
+  Enabled: false
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: consistent_comma
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: consistent_comma
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: consistent_comma

data/.travis.yml

@@ -1,5 +1,9 @@
 language: ruby
+before_install:
+  - gem install bundler
 rvm:
-  - 2.1
-  - 2.2
-before_install: gem update bundler
+  - 2.4
+  - 2.5
+  - 2.6
+matrix:
+  fast_finish: true

data/CHANGELOG.md

@@ -1,6 +1,19 @@
 Change Log
 ==========
 
+Version 1.1.7 *(2019-04-04)*
+----------------------------
+
+* Bump gem dependencies
+* Move development dependencies from gemspec to Gemfile
+* Add bundler/gem_tasks
+* Add rubocop + rubocop auto-correct
+
+Version 1.1.6 *(2019-04-04)*
+----------------------------
+
+* Add support for `commit/changes` and `compare/changes` endpoints
+
 Version 0.1.5 *(2018-01-11)*
 ----------------------------
 

data/Gemfile

@@ -1,7 +1,13 @@
+# frozen_string_literal: true
+
 source 'https://www.rubygems.org'
 
 gemspec
 
-group :development do
-  gem 'kramdown'
-end
+gem 'bundler', '~> 2.0'
+gem 'kramdown'
+gem 'rake', '~> 12.3'
+gem 'rspec', '~> 3.8'
+gem 'rubocop', '0.67.1'
+gem 'webmock', '~> 3.5'
+gem 'yard', '~> 0.9.11'

data/Rakefile

@@ -1,11 +1,15 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
 require 'bundler/setup'
+require 'bundler/gem_tasks'
 
 require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new
 
-task default: 'spec'
+require 'rubocop/rake_task'
+RuboCop::RakeTask.new
+
+task default: %i[spec rubocop]
 
 begin
   require 'yard'

data/lib/stash_core_api/api.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'stash_core_api/commits'
 require 'stash_core_api/pull_requests'
 require 'stash_core_api/compare'

data/lib/stash_core_api/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'stash_core_api/api'
 require 'stash_core_api/utils'
 

data/lib/stash_core_api/commits.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'stash_core_api/utils'
 
 module StashCoreAPI
@@ -18,7 +20,7 @@ module StashCoreAPI
     # @param withCounts [Boolean] optionally include the total number of
     #   commits and total number of unique authors
     def commits(path: nil, since: nil, until_: nil, limit: nil,
-      with_counts: nil)
+                with_counts: nil)
       endpoint = '/commits'
       if path || since || until_ || limit || with_counts
         endpoint = "#{endpoint}?"

data/lib/stash_core_api/compare.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'stash_core_api/utils'
 
 module StashCoreAPI
@@ -26,4 +28,3 @@ module StashCoreAPI
     end
   end
 end
-

data/lib/stash_core_api/error.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module StashCoreAPI
   # Base class for all errors emanating from Stash.
   class Error < StandardError
@@ -32,8 +34,8 @@ module StashCoreAPI
       404 => StashCoreAPI::Error::NotFound,
       405 => StashCoreAPI::Error::MethodNotAllowed,
       409 => StashCoreAPI::Error::Conflict,
-      415 => StashCoreAPI::Error::UnsupportedMediaType
-    }
+      415 => StashCoreAPI::Error::UnsupportedMediaType,
+    }.freeze
 
     # Initializes a new Error object
     #

data/lib/stash_core_api/pull_requests.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'stash_core_api/utils'
 
 module StashCoreAPI

data/lib/stash_core_api/request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'http'
 require 'json'
 require 'stash_core_api/error'
@@ -14,8 +16,8 @@ module StashCoreAPI
 
     def get
       response = HTTP
-        .basic_auth(user: @client.user, pass: @client.pass)
-        .get(req_url(@endpoint))
+                 .basic_auth(user: @client.user, pass: @client.pass)
+                 .get(req_url(@endpoint))
       process(response)
     end
 
@@ -26,13 +28,14 @@ module StashCoreAPI
       body = response.parse
 
       error = error(code, body)
-      fail(error) if error
+      raise(error) if error
+
       body
     end
 
     def error(code, body)
       klass = StashCoreAPI::Error::ERRORS[code]
-      klass.new(body) if klass
+      klass&.new(body)
     end
 
     def req_url(endpoint)

data/lib/stash_core_api/utils.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'stash_core_api/request'
 
 module StashCoreAPI
@@ -11,7 +13,7 @@ module StashCoreAPI
 
     def sanitized_path(path)
       # strip out any leading '/' which will break the Stash API
-      path.sub(/^\/*/, '')
+      path.sub(%r{^/*}, '')
     end
   end
 end

data/lib/stash_core_api/version.rb

@@ -1,6 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-# StashCoreAPI module
 module StashCoreAPI
-  VERSION = '0.1.6'
+  VERSION = '0.1.7'
 end

data/lib/stash_core_api.rb

@@ -1,3 +1,4 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 require 'stash_core_api/version'
 require 'stash_core_api/client'

data/spec/spec_helper.rb

@@ -1,4 +1,4 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
 require 'rspec'
 require 'stash_core_api'
@@ -20,7 +20,7 @@ def base_path(client)
 end
 
 def fixture_path
-  File.expand_path('../fixtures', __FILE__)
+  File.expand_path('fixtures', __dir__)
 end
 
 def fixture(file)

data/spec/stash_core_api/client_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe StashCoreAPI::Client do

data/spec/stash_core_api/commits_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe StashCoreAPI::Client do
@@ -17,7 +19,7 @@ RSpec.describe StashCoreAPI::Client do
         endpoint = "/#{base_path(client)}/commits"
         stub_get(client, endpoint).to_return(
           body: fixture('commits.json'),
-          headers: { 'Content-Type' => 'application/json' }
+          headers: { 'Content-Type' => 'application/json' },
         )
         commits = client.commits
         expect(commits['size']).to eq(25)
@@ -28,7 +30,7 @@ RSpec.describe StashCoreAPI::Client do
         endpoint = "/#{base_path(client)}/commits?limit=#{limit}"
         stub_get(client, endpoint).to_return(
           body: fixture('commits_with_limit.json'),
-          headers: { 'Content-Type' => 'application/json' }
+          headers: { 'Content-Type' => 'application/json' },
         )
         commits = client.commits(limit: 2)
         expect(commits['size']).to eq(limit)
@@ -36,13 +38,13 @@ RSpec.describe StashCoreAPI::Client do
     end
 
     context 'with_count' do
-      let(:count_keys) { %w( authorCount totalCount ) }
+      let(:count_keys) { %w[authorCount totalCount] }
 
       it 'does not include count keys if with_count is not set' do
         endpoint = "/#{base_path(client)}/commits"
         stub_get(client, endpoint).to_return(
           body: fixture('commits.json'),
-          headers: { 'Content-Type' => 'application/json' }
+          headers: { 'Content-Type' => 'application/json' },
         )
         commits = client.commits
         expect(count_keys - commits.keys).to eq(count_keys)
@@ -52,7 +54,7 @@ RSpec.describe StashCoreAPI::Client do
         endpoint = "/#{base_path(client)}/commits?withCounts=true"
         stub_get(client, endpoint).to_return(
           body: fixture('commits_with_with_count.json'),
-          headers: { 'Content-Type' => 'application/json' }
+          headers: { 'Content-Type' => 'application/json' },
         )
         commits = client.commits(with_counts: true)
         expect(count_keys - commits.keys).to be_empty
@@ -62,7 +64,7 @@ RSpec.describe StashCoreAPI::Client do
 
   describe '#commit_changes' do
     it 'should hit the approprate stash api with the given options' do
-      endpoint = "/commits/083f66ba3c6/changes?limit=1"
+      endpoint = '/commits/083f66ba3c6/changes?limit=1'
       expect(client).to receive(:perform_get).with(endpoint)
       client.commit_changes('083f66ba3c6', limit: 1)
     end
@@ -72,10 +74,10 @@ RSpec.describe StashCoreAPI::Client do
       stub_get(client, endpoint).to_return(
         status: 404,
         body: fixture('commit_changes_bad_sha.json'),
-        headers: { 'Content-Type' => 'application/json' }
+        headers: { 'Content-Type' => 'application/json' },
       )
       expect { client.commit_changes('083f66ba3c6') }.to raise_error(
-        StashCoreAPI::Error::NotFound, 'Commit "083f66ba3c6" does not exist in this repository'
+        StashCoreAPI::Error::NotFound, 'Commit "083f66ba3c6" does not exist in this repository',
       )
     end
   end

data/spec/stash_core_api/compare_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe StashCoreAPI::Client do
@@ -14,9 +16,9 @@ RSpec.describe StashCoreAPI::Client do
   describe '#compare' do
     describe '#changes' do
       it 'should hit the approprate stash api with the given options' do
-        endpoint = "/compare/changes?from=a&to=b&fromRepo=c&limit=1"
+        endpoint = '/compare/changes?from=a&to=b&fromRepo=c&limit=1'
         expect(client).to receive(:perform_get).with(endpoint)
-        changes = client.compare_changes('a', 'b', from_repo: 'c', limit: 1)
+        client.compare_changes('a', 'b', from_repo: 'c', limit: 1)
       end
 
       it 'should raise an error when the range is not valid' do
@@ -24,13 +26,12 @@ RSpec.describe StashCoreAPI::Client do
         stub_get(client, endpoint).to_return(
           status: 404,
           body: fixture('compare_changes_bad_range.json'),
-          headers: { 'Content-Type' => 'application/json' }
+          headers: { 'Content-Type' => 'application/json' },
         )
         expect { client.compare_changes('c', 'd') }.to raise_error(
-          StashCoreAPI::Error::NotFound, 'Object "c" does not exist in this repository'
+          StashCoreAPI::Error::NotFound, 'Object "c" does not exist in this repository',
         )
       end
     end
   end
 end
-

data/spec/stash_core_api/error_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe StashCoreAPI::Error do

data/spec/stash_core_api/pull_requests_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe StashCoreAPI::Client do
@@ -18,7 +20,7 @@ RSpec.describe StashCoreAPI::Client do
     it 'returns true if pr can be merged' do
       stub_get(client, endpoint).to_return(
         body: fixture('can_merge.json'),
-        headers: { 'Content-Type' => 'application/json' }
+        headers: { 'Content-Type' => 'application/json' },
       )
       expect(client.can_merge?(pr_id)).to be true
     end
@@ -26,7 +28,7 @@ RSpec.describe StashCoreAPI::Client do
     it 'returns false if pr cannot be merged' do
       stub_get(client, endpoint).to_return(
         body: fixture('cannot_merge.json'),
-        headers: { 'Content-Type' => 'application/json' }
+        headers: { 'Content-Type' => 'application/json' },
       )
       expect(client.can_merge?(pr_id)).to be false
     end
@@ -39,7 +41,7 @@ RSpec.describe StashCoreAPI::Client do
     it 'returns a JSON hash of body' do
       stub_get(client, endpoint).to_return(
         body: fixture('info.json'),
-        headers: { 'Content-Type' => 'application/json' }
+        headers: { 'Content-Type' => 'application/json' },
       )
       expect(client.info(pr_id)).to eq(JSON.parse(fixture('info.json').read))
     end
@@ -47,12 +49,12 @@ RSpec.describe StashCoreAPI::Client do
     it 'returns expected keys in hash' do
       stub_get(client, endpoint).to_return(
         body: fixture('info.json'),
-        headers: { 'Content-Type' => 'application/json' }
+        headers: { 'Content-Type' => 'application/json' },
       )
       info = client.info(pr_id)
-      expected_keys = %w( id version title state open closed createdDate
+      expected_keys = %w[ id version title state open closed createdDate
                           updatedDate fromRef toRef locked author reviewers
-                          participants link links )
+                          participants link links ]
       expect(info.keys).to eq(expected_keys)
     end
 
@@ -60,7 +62,7 @@ RSpec.describe StashCoreAPI::Client do
       it 'matches id in JSON body' do
         stub_get(client, endpoint).to_return(
           body: fixture('info.json'),
-          headers: { 'Content-Type' => 'application/json' }
+          headers: { 'Content-Type' => 'application/json' },
         )
         info = client.info(pr_id)
         expect(info['id']).to eq(pr_id)

data/spec/stash_core_api/request_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe StashCoreAPI::Request do
@@ -19,7 +21,7 @@ RSpec.describe StashCoreAPI::Request do
       stub_get(client, endpoint).to_return(
         body: fixture('unauthorized_error.json'),
         status: 401,
-        headers: { 'Content-Type' => 'application/json' }
+        headers: { 'Content-Type' => 'application/json' },
       )
       expect { request.get }.to raise_error(StashCoreAPI::Error::Unauthorized)
     end

data/spec/stash_core_api_spec.rb

@@ -1,4 +1,4 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 require 'stash_core_api'

data/stash_core_api.gemspec

@@ -1,6 +1,6 @@
-# -*- encoding: utf-8 -*-
+# frozen_string_literal: true
 
-require File.expand_path('../lib/stash_core_api/version', __FILE__)
+require File.expand_path('lib/stash_core_api/version', __dir__)
 
 Gem::Specification.new do |gem|
   gem.name          = 'stash_core_api'
@@ -17,13 +17,5 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ['lib']
 
-  gem.required_ruby_version = '>= 2.0'
-
-  gem.add_dependency 'http', '~> 0.9.8'
-
-  gem.add_development_dependency 'bundler', '~> 1.10'
-  gem.add_development_dependency 'rake', '~> 10.4'
-  gem.add_development_dependency 'rspec', '~> 3.4'
-  gem.add_development_dependency 'webmock', '~> 1.22'
-  gem.add_development_dependency 'yard', '~> 0.9.11'
+  gem.add_dependency 'http', '~> 2.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stash_core_api
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Alyssa Pohahau
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-04 00:00:00.000000000 Z
+date: 2019-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http
@@ -16,84 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.8
+        version: '2.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.8
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.10'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.10'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.4'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.4'
-- !ruby/object:Gem::Dependency
-  name: webmock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.22'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.22'
-- !ruby/object:Gem::Dependency
-  name: yard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.9.11
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.9.11
+        version: '2.2'
 description: Make basic auth requests to Stash Core REST API
 email: arp@squareup.com
 executables: []
@@ -101,6 +31,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - CHANGELOG.md
 - CONTRIBUTING.md
@@ -149,7 +80,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.0'
+      version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="