startling 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f8ebd457be41e100906ba33b538480973d89730b
-  data.tar.gz: dfba30c257a91102ca69b3b75ec5b4a74aecc234
+  metadata.gz: a8af8796ba134784e1a43a9cc6afe4206089989b
+  data.tar.gz: cd4fd0ad6d0a46f235acad5d66c1721cafb3cac0
 SHA512:
-  metadata.gz: 26f56b3a79cd2fd4e2ef22bc61266b2cae468248e221a75b982a3bdb57ba7d12e3818eeb8448bad34dd5002efe9aa24613ba2073c6aba45584db1bd6896f32ee
-  data.tar.gz: 2b6378cc90dd4ad98a3af97af04ac3b2317cb831e3dbccb3ebc6ab041ca3fbc3354b2fd08b09c0b182cfc2938f6939509d3c5a38cfe61a4ffd2108c311e5662d
+  metadata.gz: f9d77f0b239694944fca9d5cfbeb415d370c81952c23a262adecfbb7fac3839378c2ccdb10f695db4297dccf083f32ddd83fdbf35013067b7a26d8a327317b87
+  data.tar.gz: a13542fc2890aa0f63a873b1c6d69a72e0eb7e469105012f7e4c68cb4ad0cc3a98963587f66ddbfebbc3511b84a65c9b139fb00ff7630da204f134fa6f8306f9

data/lib/startling/command.rb

@@ -2,6 +2,7 @@ require 'cgi'
 require 'json'
 require 'highline/import'
 require 'shellwords'
+require_relative "story"
 require_relative "commands/base"
 require_relative 'commands/check_for_local_mods'
 require_relative 'commands/create_pull_request'

data/lib/startling/handlers/default_pull_request_handler.rb

@@ -1,21 +1,36 @@
+require 'highline/import'
 require_relative "pull_request_handler_base"
 
 module Startling
   module Handlers
     class DefaultPullRequestHandler < PullRequestHandlerBase
       def title
-        title = ask("Please input a pull request title: ")
+        title = get_title
         abort "Title must be specified." if title.empty?
         title
       end
 
       def body
-        Startling.pull_request_body
+        (story) ? story.pull_request_body_text : Startling.pull_request_body
       end
 
       def commit_message
         Startling.pull_request_commit_message
       end
+
+      private
+
+      def get_title
+        if story
+          story.pull_request_title
+        else
+          title = ask("Please input a pull request title: ")
+        end
+      end
+
+      def story
+        @story ||= @args.fetch(:story)
+      end
     end
   end
 end

data/lib/startling/story.rb

@@ -0,0 +1,11 @@
+module Startling
+  class Story
+    def pull_request_title
+      raise NotImplementedError
+    end
+
+    def pull_request_body_text
+      raise NotImplementedError
+    end
+  end
+end

data/lib/startling/version.rb

@@ -1,3 +1,3 @@
 module Startling
-  VERSION = "0.0.8"
+  VERSION = "0.0.9"
 end

data/spec/startling/handlers/default_pull_request_handler_spec.rb

@@ -0,0 +1,52 @@
+require 'spec_helper'
+require 'startling/handlers/default_pull_request_handler'
+
+describe Startling::Handlers::DefaultPullRequestHandler do
+  let(:args) { { story: nil } }
+  subject { Startling::Handlers::DefaultPullRequestHandler.new(args) }
+
+  it 'returns the commit message for empty commit' do
+    commit_message = 'Commit message'
+
+    allow(Startling).to receive(:pull_request_commit_message) { commit_message }
+
+    expect(subject.commit_message).to eq(commit_message)
+  end
+
+  context 'with story' do
+    let(:story) {
+      double(:story,
+        pull_request_title: 'Story title',
+        pull_request_body_text: 'Story url'
+      )
+    }
+    let(:args) { { story: story } }
+
+    it 'returns the story pull request title' do
+      expect(subject.title).to eq(story.pull_request_title)
+    end
+
+    it 'returns the story pull request body' do
+      expect(subject.body).to eq(story.pull_request_body_text)
+    end
+  end
+
+  context 'without story' do
+    it 'prompts for pull request title' do
+      title = 'Entered title'
+
+      allow_any_instance_of(Startling::Handlers::DefaultPullRequestHandler)
+        .to receive(:ask) { title }
+
+      expect(subject.title).to eq(title)
+    end
+
+    it 'returns the pull request body from configuration' do
+      body = 'Configured body'
+
+      allow(Startling).to receive(:pull_request_body) { body }
+
+      expect(subject.body).to eq(body)
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: startling
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Aaron Jensen
@@ -246,6 +246,7 @@ files:
 - lib/startling/handlers/pull_request_handler_base.rb
 - lib/startling/markdown.rb
 - lib/startling/shell.rb
+- lib/startling/story.rb
 - lib/startling/time_format_helpers.rb
 - lib/startling/version.rb
 - lib/startling/work.rb
@@ -258,6 +259,7 @@ files:
 - spec/startling/configuration_spec.rb
 - spec/startling/git_local_spec.rb
 - spec/startling/github/pull_request_spec.rb
+- spec/startling/handlers/default_pull_request_handler_spec.rb
 - spec/startling/time_format_helpers_spec.rb
 - spec/startling_configuration_spec.rb
 - spec/startling_spec.rb
@@ -300,6 +302,7 @@ test_files:
 - spec/startling/configuration_spec.rb
 - spec/startling/git_local_spec.rb
 - spec/startling/github/pull_request_spec.rb
+- spec/startling/handlers/default_pull_request_handler_spec.rb
 - spec/startling/time_format_helpers_spec.rb
 - spec/startling_configuration_spec.rb
 - spec/startling_spec.rb