startblock 1.4 → 1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d4cbd0cf6a715971b53dbfcce768380b9a8d4123
-  data.tar.gz: a0447a54c7c475e68a8088b549f25a1e3018e8f2
+  metadata.gz: 6664a02a0ccc220b3dcca7770939c7d45d1e6f47
+  data.tar.gz: 7c39990b64271627b0d32a9399f6f5fb3d35309b
 SHA512:
-  metadata.gz: 393010437012ddcc932f26bfd3807ee32234857d0431daba0fc844dcbdffc504d65f844c45e13c36ce1ba30164c78fccafc8ab9b974911b06a48ffde9a3118c0
-  data.tar.gz: 350e810d96d0727d7d4c9cee0b2d664501a9f13ea818206ce72f5212339847731b9e24374acd459854a1df333358cd321ff8b58454444b0ae78b124102eb11b5
+  metadata.gz: 72b585703b231102b10ef08edc6bf571a74434c95b68eb50031fc9253b8b53c7b1bae6e52d49a512222c675f10c39a463618ceb5c714dec7ede1184937c45dda
+  data.tar.gz: 3f1e4022007cd537d33efca15727600d0a7b33b83895c371961bfb3885a8942588478c138ce783ef8cf3d448fa99a56bf04a51fad46161c1fdf432e9a3faa1ed

data/CHANGELOG

@@ -2,12 +2,16 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
-## V1.5 - Unreleased
+## V1.5 - Olive Nickel - 2016-02-19
 
 ### Changed
+- Disable asset and helper generation in `rails generate` command
+
 ### Added
+- Add our test_helper.rb
+
 ### Removed
-### Fixed
+- Raise on missing I18n
 
 ## V1.4 - Maroon Lead - 2016-01-29
 

data/VERSION

@@ -1 +1 @@
-V1.4
+V1.5

data/lib/startblock/app_builder.rb

@@ -37,17 +37,22 @@ module Startblock
       inject_into_class "config/application.rb", "Application", config
     end
 
+    def disable_helper_generation
+      config = <<-RUBY
+    config.generators.stylesheets = false
+    config.generators.javascripts = false
+    config.generators.helper = false
+      RUBY
+
+      inject_into_class "config/application.rb", "Application", config
+    end
+
     def provide_setup_script
       remove_file "bin/setup"
       template "bin_setup.erb", "bin/setup"
       run "chmod a+x bin/setup"
     end
 
-    def configure_i18n_for_missing_translations
-      raise_on_missing_translations_in("development")
-      raise_on_missing_translations_in("test")
-    end
-
     def configuring_test_helper
       remove_file "test/test_helper.rb"
       template "test_helper.erb", "test/test_helper.rb"
@@ -138,13 +143,5 @@ end
     def setup_rubocop
       copy_file "rubocop.yml", ".rubocop.yml"
     end
-
-    private
-
-    def raise_on_missing_translations_in(environment)
-      config = 'config.action_view.raise_on_missing_translations = true'
-
-      uncomment_lines("config/environments/#{environment}.rb", config)
-    end
   end
 end

data/lib/startblock/generators/app_generator.rb

@@ -20,6 +20,7 @@ module Startblock
     def startblock_customization
       invoke :customize_gemfile
       invoke :setup_development_environment
+      invoke :setup_development_environment
       invoke :setup_testing_environment
       invoke :setup_staging_environment
       invoke :setup_secret_token
@@ -48,7 +49,11 @@ module Startblock
       build :raise_on_delivery_errors
       build :raise_on_unpermitted_parameters
       build :provide_setup_script
-      build :configure_i18n_for_missing_translations
+    end
+
+    def customize_applicationrb
+      say 'Configuring application.rb'
+      build :disable_helper_generation
     end
 
     def setup_testing_environment

data/lib/startblock/version.rb

@@ -1,5 +1,5 @@
 module Startblock
   RAILS_VERSION = "~> 4.2"
   RUBY_VERSION = IO.read("#{File.dirname(__FILE__)}/../../.ruby-version").strip
-  VERSION = "1.4"
+  VERSION = "1.5"
 end

data/templates/Gemfile.erb

@@ -28,7 +28,7 @@ end
 group :development, :test do
   gem "awesome_print"
   gem "dotenv-rails"
-  gem "rubocop"
+  gem "rubocop", "~> 0.32"
 end
 
 group :test do
@@ -37,6 +37,9 @@ group :test do
   gem "timecop"
   gem "shoulda"
   gem "mocha"
+  gem "launchy"
+  gem "poltergeist"
+  gem "database_cleaner"
 end
 
 group :staging, :production do

data/templates/test_helper.erb

@@ -1,4 +1,3 @@
-
 ENV['RAILS_ENV'] ||= 'test'
 require File.expand_path('../../config/environment', __FILE__)
 require 'rails/test_help'
@@ -9,19 +8,64 @@ require 'minitest/mock'
 require "mocha/mini_test"
 require "minitest/rails/capybara"
 require "minitest/reporters"
+require "database_cleaner"
+require 'capybara/poltergeist'
 
 Sidekiq::Testing.fake!
-Minitest::Reporters.use! Minitest::Reporters::ProgressReporter.new
+
+reporter_options = { color: true, slow_count: 5 }
+Minitest::Reporters.use! [Minitest::Reporters::DefaultReporter.new(reporter_options)]
+
+DatabaseCleaner.strategy = :transaction
+
+# Requires supporting ruby files with custom matchers and macros, etc,
+# in test/support/ and its subdirectories.
+Dir[Rails.root.join("test/support/**/*.rb")].each { |f| require f }
 
 class ActiveSupport::TestCase
   # Setup all fixtures in test/fixtures/*.yml for all tests in alphabetical order.
   fixtures :all
+
+  def self.check_for_valid_fixtures(name)
+    Object.const_get(name.to_s.camelize).all.each do |obj|
+      raise "Fixtures for #{name} should be valid - #{obj.errors.messages}" unless obj.valid?
+    end
+  end
 end
 
 class ActionDispatch::IntegrationTest
   include Capybara::DSL
+
+  use_transactional_fixtures = false
+
+
+  Capybara.register_driver :poltergeist do |app|
+    Capybara::Poltergeist::Driver.new(app, js_errors: true)
+  end
+  Capybara.javascript_driver = :poltergeist
+
+  setup do
+    DatabaseCleaner.strategy = :truncation
+    DatabaseCleaner.start
+  end
+
   teardown do
     Capybara.reset_sessions!
     Capybara.use_default_driver
+    DatabaseCleaner.clean
+  end
+
+  def wait_for_ajax
+    Timeout.timeout(Capybara.default_max_wait_time) do
+      loop until finished_all_ajax_requests?
+    end
+  end
+
+  def finished_all_ajax_requests?
+    page.evaluate_script('jQuery.active').zero?
+  end
+
+  def use_javascript
+    Capybara.current_driver = Capybara.javascript_driver
   end
 end

data/test/features/new_project_test.rb

@@ -80,4 +80,11 @@ class NewProjectTest < Minitest::Test
 
     assert development_rb_file.match(/letter_opener/), "Should have the letter opener"
   end
+
+  def test_helper_generation_should_be_disabled
+    application_rb_file = IO.read("#{project_path}/config/application.rb")
+
+    assert application_rb_file.match("config.generators.stylesheets = false"),
+      "Should disable stylesheet generation"
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: startblock
 version: !ruby/object:Gem::Version
-  version: '1.4'
+  version: '1.5'
 platform: ruby
 authors:
 - Jeroen van Baarsen
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-29 00:00:00.000000000 Z
+date: 2016-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest