starkit_banking 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 86a2b09250a0adfa32c784c8dc50b868d50dcd2d
-  data.tar.gz: e9d2e32b3cc8c32ac535ca20dcfdde22f0cbbe8d
+  metadata.gz: cdffd1bc3462bd19f302e078cfd230f5db1cdf12
+  data.tar.gz: 393f243dbd352c61fb7cfda3e23bbad89642b21e
 SHA512:
-  metadata.gz: 14034114643179888adf1cf8c5b5c5f48adc493d6fe5a3a14b5eca3f5d11758814db46af84d47e6bce34f14f6db2932a9faf271f9e935c8d524d98083b375eb5
-  data.tar.gz: 1c2b66c00fb8ae3494ca9b2ee82c21c6f1b6fa14f232a2ddbfaf436eee45d1a9dc7c01d85570787a3b336ee6e697aefc68a99fc010b247b4e4480910cc7f3b09
+  metadata.gz: f4cd1a4f2549e1760b717070f0e5c46225c267f53f137a075c6b34a3d7d7beed80a878fe4a7e1988bddb760353b9a6bb84d901a39d528280c6f786183df14742
+  data.tar.gz: a79002f92d08889dec21fedd41cacb8fa51aa8f40a090c586baf4d4d781eb57af6cbfdaeeed1c734376d26ff64eae3b3f2796df93446a57c34228cfa79e9d213

data/.gitignore

@@ -1,6 +1,5 @@
 /.bundle/
 /.yardoc
-/Gemfile.lock
 /_yardoc/
 /coverage/
 /doc/

data/Gemfile.lock

@@ -0,0 +1,69 @@
+PATH
+  remote: .
+  specs:
+    starkit_banking (0.1.3)
+      activerecord
+      activesupport
+      api_banking
+      money
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (5.0.0.1)
+      activesupport (= 5.0.0.1)
+    activerecord (5.0.0.1)
+      activemodel (= 5.0.0.1)
+      activesupport (= 5.0.0.1)
+      arel (~> 7.0)
+    activesupport (5.0.0.1)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    addressable (2.5.0)
+      public_suffix (~> 2.0, >= 2.0.2)
+    api_banking (0.1.16)
+      nokogiri
+      typhoeus
+    arel (7.1.4)
+    concurrent-ruby (1.0.2)
+    crack (0.4.3)
+      safe_yaml (~> 1.0.0)
+    ethon (0.9.1)
+      ffi (>= 1.3.0)
+    ffi (1.9.14)
+    hashdiff (0.3.0)
+    i18n (0.7.0)
+    mini_portile2 (2.1.0)
+    minitest (5.9.1)
+    money (6.7.1)
+      i18n (>= 0.6.4, <= 0.7.0)
+      sixarm_ruby_unaccent (>= 1.1.1, < 2)
+    nokogiri (1.6.8.1)
+      mini_portile2 (~> 2.1.0)
+    public_suffix (2.0.4)
+    rake (10.5.0)
+    safe_yaml (1.0.4)
+    sixarm_ruby_unaccent (1.1.1)
+    thread_safe (0.3.5)
+    typhoeus (1.1.0)
+      ethon (>= 0.9.0)
+    tzinfo (1.2.2)
+      thread_safe (~> 0.1)
+    vcr (3.0.3)
+    webmock (2.1.0)
+      addressable (>= 2.3.6)
+      crack (>= 0.3.2)
+      hashdiff
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  bundler (~> 1.9)
+  minitest
+  rake (~> 10.0)
+  starkit_banking!
+  vcr
+  webmock

data/README.md

@@ -1,6 +1,6 @@
 # Assumptions
 
-1. ApiBankingCred has 'password'
+~~1. ApiBankingCred has 'password'~~
 2. Payment should have IMT passcode (to resend email)
 ~~3. Payment Account to have credential method, that will return the ApiBankingCred (basis the envronment/star/bank_name of self)~~
 

data/lib/starkit_banking/api/client.rb

@@ -9,7 +9,10 @@ module StarkitBanking
         
     def exec(model)
       env = Environment.build(credentials(model))
-      req = request(model)
+      subscription = subscription(model)
+      raise ApiFault.new(OpenStruct.new(code: 'sb:412', subCode: nil, reasonText: "#{service_name} is not subscribed")) if subscription.nil?
+      
+      req = request(subscription, model)
                   
       res = invoke(env, req)
       

data/lib/starkit_banking/api/ybl/account/balance.rb

@@ -5,6 +5,10 @@ module StarkitBanking
         include ApiClient
       
         private 
+        
+        def service_name
+          'BALANCE ENQUIRY'
+        end
       
         def invoke(env, req)
           ApiBanking::FundsTransferByCustomerService2.get_balance(env, req)          
@@ -18,19 +22,19 @@ module StarkitBanking
           payment_account.credentials
         end
       
-        def request(payment_account)
+        def request(subscription, payment_account)
         
           request = ApiBanking::FundsTransferByCustomerService2::GetBalance::Request.new()
 
-          request.appID = app_id(payment_account)
+          request.appID = subscription.app_id
           request.customerID = payment_account.customer_id
           request.AccountNumber = payment_account.account_number
         
           request       
         end
       
-        def app_id(payment_account)
-          payment_account.service_subscriptions.find_by(service_name: 'BALANCE ENQUIRY').app_id
+        def subscription(payment_account)
+          payment_account.service_subscriptions.find_by(service_name: service_name)
         end
   
       end

data/lib/starkit_banking/api/ybl/account/mini_statement.rb

@@ -4,7 +4,11 @@ module StarkitBanking
       class GetMiniStatement
         include ApiClient
       
-        private 
+        private
+        
+        def service_name
+          'GET TRANSACTIONS'
+        end
         
         def invoke(env, req)
           ApiBanking::SocialBankingService.getTransactions(env, req)
@@ -30,7 +34,7 @@ module StarkitBanking
           payment_account.credentials
         end
       
-        def request(payment_account)
+        def request(subscription, payment_account)
           customerIdentity = ApiBanking::SocialBankingService::GetTransactions::CustomerIdentity.new()
           accountIdentity = ApiBanking::SocialBankingService::GetTransactions::AccountIdentity.new()
           request = ApiBanking::SocialBankingService::GetTransactions::Request.new()
@@ -39,7 +43,7 @@ module StarkitBanking
 
           accountIdentity.accountNo = payment_account.account_number
 
-          request.appID = app_id(payment_account)
+          request.appID = subscription.app_id
 
           request.customerIdentity = customerIdentity
           request.deviceID = rand(1000..9999).to_s
@@ -49,8 +53,8 @@ module StarkitBanking
           request
         end
 
-        def app_id(payment_account)
-          payment_account.service_subscriptions.find_by(service_name: 'GET TRANSACTIONS').app_id
+        def subscription(payment_account)
+          payment_account.service_subscriptions.find_by(service_name: service_name)
         end
       end
     end

data/lib/starkit_banking/api/ybl/payment/ft2.rb

@@ -4,7 +4,11 @@ module StarkitBanking
       class ByFT2
         include ApiClient
       
-        private 
+        private
+        
+        def service_name
+          'FUNDS TRANSFER'
+        end
       
         def invoke(env, req)
           ApiBanking::FundsTransferByCustomerService2.transfer(env, req)
@@ -18,7 +22,7 @@ module StarkitBanking
           payment.payment_account.credentials
         end
       
-        def request(payment)
+        def request(subscription, payment)
         
           address = ApiBanking::FundsTransferByCustomerService2::Transfer::Address.new()
           beneficiary = ApiBanking::FundsTransferByCustomerService2::Transfer::Beneficiary.new()
@@ -27,7 +31,7 @@ module StarkitBanking
           # every payment is identified by its ID, repeated API attempts can be identified when the ID is used as the URN
           @req_reference = request.uniqueRequestNo = payment.id 
         
-          request.appID = app_id(payment)
+          request.appID = subscription.app_id
           request.customerID = payment.payment_account.customer_id
           request.debitAccountNo = payment.payment_account.account_number
           request.transferType = payment.transfer_type || payment.transfer_type
@@ -44,8 +48,8 @@ module StarkitBanking
           request       
         end
       
-        def app_id(payment)
-          payment.payment_account.service_subscriptions.find_by(service_name: 'FUNDS TRANSFER').app_id
+        def subscription(payment)
+          payment.payment_account.service_subscriptions.find_by(service_name: service_name)
         end
   
       end

data/lib/starkit_banking/api/ybl/payment/get_status.rb

@@ -5,6 +5,10 @@ module StarkitBanking
         include ApiClient
       
         private 
+        
+        def service_name
+          'STATUS ENQUIRY'
+        end
       
         def invoke(env, req)
           ApiBanking::FundsTransferByCustomerService2.get_status(env, req)          
@@ -18,19 +22,19 @@ module StarkitBanking
           payment.payment_account.credentials
         end
       
-        def request(payment)
+        def request(subscription, payment)
         
           request = ApiBanking::FundsTransferByCustomerService2::GetStatus::Request.new()
 
-          request.appID = app_id(payment)
+          request.appID = subscription.app_id
           request.customerID = payment.payment_account.customer_id
           request.requestReferenceNo = payment.id
         
           request       
         end
       
-        def app_id(payment)
-          payment.payment_account.service_subscriptions.find_by(service_name: 'STATUS ENQUIRY').app_id
+        def subscription(payment)
+          payment.payment_account.service_subscriptions.find_by(service_name: service_name)
         end
   
       end

data/lib/starkit_banking/api/ybl/payment/imt.rb

@@ -5,6 +5,10 @@ module StarkitBanking
         include ApiClient
       
         private
+        
+        def service_name
+          'IMT TRANSFER'
+        end
       
         def invoke(env, req)
           ApiBanking::InstantMoneyTransferService.transfer(env, req)
@@ -19,13 +23,13 @@ module StarkitBanking
           Transfer::Status.new('INITIATED', res.initiateTransferResult.bankReferenceNo, 'IMT')
         end
       
-        def request(payment)
+        def request(subscription, payment)
           request = ApiBanking::InstantMoneyTransferService::InitiateTransfer::Request.new()
 
           # every payment is identified by its ID, repeated API attempts can be identified when the ID is used as the URN
           @req_reference = request.uniqueRequestNo = payment.id 
         
-          request.appID = app_id(payment)
+          request.appID = subscription.app_id
           request.customerID = payment.payment_account.customer_id
           request.beneficiaryMobileNo = payment.beneficiary_mobile_no
           request.transferAmount = payment.transfer_amount
@@ -35,8 +39,8 @@ module StarkitBanking
           request
         end
       
-        def app_id(payment)
-          payment.payment_account.service_subscriptions.find_by(service_name: 'IMT TRANSFER').app_id        
+        def subscription(payment)
+          payment.payment_account.service_subscriptions.find_by(service_name: service_name)
         end
       
       end

data/lib/starkit_banking/concerns/bank_account.rb

@@ -16,6 +16,7 @@ module StarkitBanking
     
     def credentials
       c = Finance::ApiBankingCred.find_by(environment: self.environment, bank_name: self.bank_name)
+      raise ApiFault.new(OpenStruct.new(code: 'sb:412', subCode: nil, reasonText: "Api Banking Credentials Not Available For #{self.bank_name}, #{self.environment}")) if c.nil?
       c.password = @password unless @password.nil?
       c
     end

data/lib/starkit_banking/version.rb

@@ -1,3 +1,3 @@
 module StarkitBanking
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: starkit_banking
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - akil
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-11-25 00:00:00.000000000 Z
+date: 2016-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -147,6 +147,7 @@ files:
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
+- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile