stanford-mods 3.3.9 → 3.3.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0729c421d4ffde7b9818ad6012d19ec0fc146c36fa60aa0f9384c2d02d87138f'
-  data.tar.gz: b14ae5c1aeb368ca68fc37c8f9021b99f95af3e670edb7e0b822aeba1f1ecc5d
+  metadata.gz: 885964c534e2c709a314a1d4d01e6f7f4cc4ac04ba04976d59c4ec699854c017
+  data.tar.gz: 6d305fe8a02ccd15a2571ae8295207553966841513143013d01cc7731d3e429e
 SHA512:
-  metadata.gz: dfe5bb3f80cdd0daead674f3a5e7d382dd05c4923efc7b35de192a2b2771e42fa8c78ae489b3790bc7b23a737902790e5e6e34f959008317f028bbab8e4f40d1
-  data.tar.gz: '01498aa51983570655d823eb897507e5a0c0954689d5040ced4b813031f767fc120c25298a10d797c8ad69b2d9398cea405572c54b13a24697f787d3318608b1'
+  metadata.gz: 6bb746a838909b70a9000ebab153be83bc0cf6b490dc037e997d9b2c64b222e48b23eb82f8bff4c7c8ec820f612dc748405830a7a8d82bcad03459b0d194f406
+  data.tar.gz: 44543ab5586fb344900af3b70b478e01e1e988368db343456a79b4a19d566423ad3372a4359d188633be6ecf82280e03ddb9b06ee0fba29401856eb7ec0e164e

data/lib/stanford-mods/concerns/searchworks_subjects.rb

@@ -74,14 +74,18 @@ module Stanford
       end
 
       # Values are the contents of:
-      #  all subject subelements except subject/cartographic plus  genre top level element
+      #  all subject subelements except subject/cartographic plus genre top level element
       # @return [Array<String>] values for the subject_all_search Solr field for this document or nil if none
       def subject_all_search
-        topic_search + geographic_search + subject_other_search + subject_other_subvy_search
+        topic_search + geographic_search + subject_other_search + subject_other_subvy_search + top_level_genres
       end
 
       protected #----------------------------------------------------------
 
+      def top_level_genres
+        term_values(:genre) || []
+      end
+
       # convenience method for subject/name/namePart values (to avoid parsing the mods for the same thing multiple times)
       def subject_names
         mods_ng_xml.subject.name_el

data/lib/stanford-mods/imprint.rb

@@ -10,6 +10,8 @@ module Stanford
     # however, the date_parsing class only does years, and this does finer tuned dates and also
     # reformats them according to the encoding.
     class Imprint
+      BCE_CHAR_SORT_MAP = { '0' => '9', '1' => '8', '2' => '7', '3' => '6', '4' => '5', '5' => '4', '6' => '3', '7' => '2', '8' => '1', '9' => '0' }.freeze
+
       attr_reader :element
 
       # @param [Nokogiri::XML::Node] an originInfo node
@@ -170,19 +172,25 @@ module Stanford
             date.year
           end
 
-          str = if year < 1
-            (-1 * year - 1000).to_s
+          str = if year > 0
+            # for CE dates, we can just pad them out to 4 digits and sort normally...
+            year.to_s.rjust(4, "0")
           else
-            year.to_s
+            #  ... but for BCE, because we're sorting lexically, we need to invert the digits (replacing 0 with 9, 1 with 8, etc.),
+            #  we prefix it with a hyphen (which will sort before any digit) and the number of digits (also inverted) to get
+            # it to sort correctly.
+            inverted_year = year.abs.to_s.chars.map { |c| BCE_CHAR_SORT_MAP[c] }.join
+            length_prefix = BCE_CHAR_SORT_MAP[inverted_year.to_s.length.to_s]
+            "-#{length_prefix}#{inverted_year}"
           end
 
           case value.precision
           when :decade
-            str[0..2] + "-"
+            str[0...-1] + "-"
           when :century
-            str[0..1] + "--"
+            str[0...-2] + "--"
           else
-            str.rjust(4, "0")
+            str
           end
         end
 

data/lib/stanford-mods/version.rb

@@ -1,6 +1,6 @@
 module Stanford
   module Mods
     # this is the Ruby Gem version
-    VERSION = '3.3.9'.freeze
+    VERSION = '3.3.11'.freeze
   end
 end

data/spec/origin_info_spec.rb

@@ -383,7 +383,7 @@ describe "computations from /originInfo field" do
       end
 
       it 'returns the earliest date with the funky lexical sort encoding' do
-        expect(record.pub_year_sort_str).to eq '-751'
+        expect(record.pub_year_sort_str).to eq '-6750'
       end
     end
 
@@ -400,7 +400,23 @@ describe "computations from /originInfo field" do
       end
 
       it 'returns the earliest date of the range with the funky lexical sort encoding' do
-        expect(record.pub_year_sort_str).to eq '-751'
+        expect(record.pub_year_sort_str).to eq '-6750'
+      end
+    end
+
+    context 'with a really old BCE date (e.g. ky899rv1161)' do
+      let(:modsxml) do
+        <<-EOF
+          <mods xmlns="http://www.loc.gov/mods/v3">
+            <originInfo>
+              <dateIssued encoding="edtf">Y-12345</dateIssued>
+            </originInfo>
+          </mods>
+        EOF
+      end
+
+      it 'returns the earliest date of the range with the funky lexical sort encoding' do
+        expect(record.pub_year_sort_str).to eq '-487654'
       end
     end
 

data/spec/searchworks_subject_spec.rb

@@ -238,6 +238,9 @@ describe "Subject fields (searchworks.rb)" do
         @smods_rec.from_str(@ng_mods_no_subject.to_s)
         expect(@smods_rec.subject_all_search).to eq []
       end
+      it "should contain top level <genre> element data" do
+        expect(@smods_rec.subject_all_search).to include(@genre)
+      end
       it "should not contain cartographic sub element" do
         expect(@smods_rec.subject_all_search).not_to include(@cart_coord)
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stanford-mods
 version: !ruby/object:Gem::Version
-  version: 3.3.9
+  version: 3.3.11
 platform: ruby
 authors:
 - Naomi Dushay
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-12-01 00:00:00.000000000 Z
+date: 2025-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mods
@@ -214,7 +214,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.13
+rubygems_version: 3.5.11
 signing_key:
 specification_version: 4
 summary: Stanford specific wrangling of MODS metadata