stanford-mods 3.3.8 → 3.3.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b1e3a3a94c0657e2e29e3290209d67ea16d1f10d1cece61e334543f33c8cde7f
-  data.tar.gz: 17edb99128248caed061cc87d4d547bf896b7a915d08fdad9e2f209f2d6457fe
+  metadata.gz: cb1b017fccf0e3f74a5c0594e5a21a43f7816055b2c67486392af2308ce85860
+  data.tar.gz: b992e7323c4e096d0714d5391a9c4206745c536f99b2fad92fbe9b1affb89645
 SHA512:
-  metadata.gz: ec96c2955e6e96205b83395953413bfb2662af53f2725c9c13149688ac6c15b2da8cf4e46fa8aea8ac299b212204bbf680cdfa876780169a25707661903c259b
-  data.tar.gz: 1e5a8ddd8ad2e2a90ea37363335f1655fe6a4ef58b5d37089b38be265f00a91f617f7593f4b617d0f7dc1d066045ec926f207d2d308fa9c748170a03545e4cf7
+  metadata.gz: d28ee675c3f53cf6052b732883487475ec44519a5a79241a0de4e1aa798daae208a6f6d5c951d561745a8035b35f5f8716788f9e7520833a5cdc49d19533d832
+  data.tar.gz: e992ac4964d4b857084427c6a2e291c1c2cbe219d5b524be328a86aa1670cbe0993cc803d66c374b0460ba41239318b5f05533f9060fac7415220983886a7ca9

data/lib/stanford-mods/imprint.rb

@@ -10,6 +10,8 @@ module Stanford
     # however, the date_parsing class only does years, and this does finer tuned dates and also
     # reformats them according to the encoding.
     class Imprint
+      BCE_CHAR_SORT_MAP = { '0' => '9', '1' => '8', '2' => '7', '3' => '6', '4' => '5', '5' => '4', '6' => '3', '7' => '2', '8' => '1', '9' => '0' }.freeze
+
       attr_reader :element
 
       # @param [Nokogiri::XML::Node] an originInfo node
@@ -46,7 +48,7 @@ module Stanford
         end.compact.flatten
       end
 
-      # called by mods_display gem, so made public
+      # called by mods_display gem
       def publisher_vals_str
         return if element.publisher.text.strip.empty?
 
@@ -56,6 +58,13 @@ module Stanford
         compact_and_join_with_delimiter(publishers, ' : ')
       end
 
+      # called by mods_display gem
+      def edition_vals_str
+        element.edition.reject do |e|
+          e.text.strip.empty?
+        end.map(&:text).join(' ').strip
+      end
+
       private
 
       def compact_and_join_with_delimiter(values, delimiter)
@@ -77,12 +86,6 @@ module Stanford
         value.strip.end_with?('.', ',', ':', ';')
       end
 
-      def edition_vals_str
-        element.edition.reject do |e|
-          e.text.strip.empty?
-        end.map(&:text).join(' ').strip
-      end
-
       # PLACE processing methods ------
 
       def place_vals_str
@@ -169,19 +172,25 @@ module Stanford
             date.year
           end
 
-          str = if year < 1
-            (-1 * year - 1000).to_s
+          str = if year > 0
+            # for CE dates, we can just pad them out to 4 digits and sort normally...
+            year.to_s.rjust(4, "0")
           else
-            year.to_s
+            #  ... but for BCE, because we're sorting lexically, we need to invert the digits (replacing 0 with 9, 1 with 8, etc.),
+            #  we prefix it with a hyphen (which will sort before any digit) and the number of digits (also inverted) to get
+            # it to sort correctly.
+            inverted_year = year.abs.to_s.chars.map { |c| BCE_CHAR_SORT_MAP[c] }.join
+            length_prefix = BCE_CHAR_SORT_MAP[inverted_year.to_s.length.to_s]
+            "-#{length_prefix}#{inverted_year}"
           end
 
           case value.precision
           when :decade
-            str[0..2] + "-"
+            str[0...-1] + "-"
           when :century
-            str[0..1] + "--"
+            str[0...-2] + "--"
           else
-            str.rjust(4, "0")
+            str
           end
         end
 

data/lib/stanford-mods/version.rb

@@ -1,6 +1,6 @@
 module Stanford
   module Mods
     # this is the Ruby Gem version
-    VERSION = '3.3.8'.freeze
+    VERSION = '3.3.10'.freeze
   end
 end

data/spec/origin_info_spec.rb

@@ -383,7 +383,7 @@ describe "computations from /originInfo field" do
       end
 
       it 'returns the earliest date with the funky lexical sort encoding' do
-        expect(record.pub_year_sort_str).to eq '-751'
+        expect(record.pub_year_sort_str).to eq '-6750'
       end
     end
 
@@ -400,7 +400,23 @@ describe "computations from /originInfo field" do
       end
 
       it 'returns the earliest date of the range with the funky lexical sort encoding' do
-        expect(record.pub_year_sort_str).to eq '-751'
+        expect(record.pub_year_sort_str).to eq '-6750'
+      end
+    end
+
+    context 'with a really old BCE date (e.g. ky899rv1161)' do
+      let(:modsxml) do
+        <<-EOF
+          <mods xmlns="http://www.loc.gov/mods/v3">
+            <originInfo>
+              <dateIssued encoding="edtf">Y-12345</dateIssued>
+            </originInfo>
+          </mods>
+        EOF
+      end
+
+      it 'returns the earliest date of the range with the funky lexical sort encoding' do
+        expect(record.pub_year_sort_str).to eq '-487654'
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stanford-mods
 version: !ruby/object:Gem::Version
-  version: 3.3.8
+  version: 3.3.10
 platform: ruby
 authors:
 - Naomi Dushay
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-11-30 00:00:00.000000000 Z
+date: 2025-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mods
@@ -214,7 +214,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.13
+rubygems_version: 3.5.9
 signing_key:
 specification_version: 4
 summary: Stanford specific wrangling of MODS metadata