stanford-mods 3.3.2 → 3.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 33e5860d1c199fb9d7da0e55e49ccad107ee9438fd2b21f80008bdfb4a807ee5
-  data.tar.gz: 86a3a03dab961a6717f5bd96ca9f603aff70114549f38dda13ef2743b1d3543b
+  metadata.gz: 5fa228dc93f0f24e8f5c5b9b96106761ef03fcb2ad25fe2c9083fb6d1025a1a5
+  data.tar.gz: eb507bdb0c5d07dc0b2d6aa6f5b4132d54f5d1fbeac528a91eb5ea2c97c3ad17
 SHA512:
-  metadata.gz: fdb0d00f24950da177f470afd6339aa36e4dc6db460e4746b3321a9bad91202ff8becffbecf9875271a43f039a3a71d91c1c3e9c76bd1eaa2a202fdb61c2d5a9
-  data.tar.gz: 331d43a66da3c06ea5a3312043db2e15c90edbe2166cc2b1f3d0c48b02088885274e18cc78b314132bd359431a5a0da69261d89bd55c5b24114f7c3cd7fa8ffc
+  metadata.gz: b6bd720575deaefb97c80bacbddde3a2c9e6b8d48c469575ec22a04dbbf5f1ec6fc18c48951a4ff45619ed6c305608c4e954bc4d07b87201d825ae13c4dee7ce
+  data.tar.gz: ce40138bb0489021788b64f08fc689bd23ce7c376fde6f8b9a5d897b57a3c7205c023e5b09834495ec9557a75f1efab68a484cae30df0140be074d6097bbf432

data/.github/workflows/ruby.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby: [jruby-9.3.2.0, 2.7, '3.0', '3.1']
+        ruby: ['3.1', '3.2']
     steps:
     - uses: actions/checkout@v2
     - name: Set up Ruby

data/lib/stanford-mods/concerns/origin_info.rb

@@ -27,6 +27,9 @@ module Stanford
 
         edtf_date = date.date
 
+        # Protect against cases in which Date.edtf returns nil (e.g., 1uuu)
+        return unless edtf_date
+
         if edtf_date.is_a?(EDTF::Interval)
           edtf_date.from.year
         else

data/lib/stanford-mods/concerns/searchworks.rb

@@ -9,7 +9,7 @@ module Stanford
         mods_ng_xml.language.flat_map do |n|
           # get languageTerm codes and add their translations to the result
           result = n.code_term.flat_map do |ct|
-            if ct.authority =~ /^iso639/
+            if ct.authority.to_s =~ /^iso639/
               vals = ct.text.split(/[,|\ ]/).reject { |x| x.strip.empty? }
               vals.select { |v| ISO_639.find(v.strip) }.map do |v|
                 iso639_val = ISO_639.find(v.strip).english_name
@@ -114,11 +114,11 @@ module Stanford
         val.uniq
       end
 
-      # @return [String] value with the numeric catkey in it, or nil if none exists
+      # @return [String] value with the catkey in it, or nil if none exists
       def catkey
         catkey = term_values([:record_info, :recordIdentifier])
 
-        catkey.first&.tr('a', '') # ensure catkey is numeric only
+        catkey.first&.tr('a', '') # remove prefix from SUL catkeys
       end
     end # class Record
   end # Module Mods

data/lib/stanford-mods/version.rb

@@ -1,6 +1,6 @@
 module Stanford
   module Mods
     # this is the Ruby Gem version
-    VERSION = '3.3.2'.freeze
+    VERSION = '3.3.4'.freeze
   end
 end

data/spec/origin_info_spec.rb

@@ -318,6 +318,22 @@ describe "computations from /originInfo field" do
         expect(record.pub_year_display_str).to eq nil
       end
     end
+
+    context 'with a date not handled by EDTF' do
+      let(:modsxml) do
+        <<-EOF
+          <mods xmlns="http://www.loc.gov/mods/v3">
+            <originInfo>
+              <dateIssued encoding="marc">1uuu</dateIssued>
+            </originInfo>
+          </mods>
+        EOF
+      end
+
+      it 'ignores the date' do
+        expect(record.pub_year_display_str).to eq nil
+      end
+    end
   end
 
   context '#pub_year_sort_str' do

data/spec/searchworks_spec.rb

@@ -13,7 +13,7 @@ describe "Searchworks mixin for Stanford::Mods::Record" do
       expect(langs.size).to eq(3)
       expect(langs).to include("Persian", "Arabic", "Dutch")
       expect(langs).not_to include("Dutch; Flemish")
-    end 
+    end
     it "should return a language string from lookup for a valid language code that has a type=code specified but no authority" do
       m = "<mods #{@ns_decl}> <language><languageTerm type='code'>eng</languageTerm></language></mods>"
       @smods_rec.from_str m
@@ -63,6 +63,13 @@ describe "Searchworks mixin for Stanford::Mods::Record" do
       expect(langs.size).to eq 1
       expect(langs).to include "English"
     end
+    it "handles codes without authority elements" do
+      m = "<mods #{@ns_decl}><language><languageTerm type='code'>eng</languageTerm></language></mods>"
+      @smods_rec.from_str m
+      langs = @smods_rec.sw_language_facet
+      expect(langs.size).to eq 1
+      expect(langs).to include "English"
+    end
   end
 
   context "sw author methods" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stanford-mods
 version: !ruby/object:Gem::Version
-  version: 3.3.2
+  version: 3.3.4
 platform: ruby
 authors:
 - Naomi Dushay
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-02-15 00:00:00.000000000 Z
+date: 2023-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mods
@@ -214,7 +214,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Stanford specific wrangling of MODS metadata