stanford-mods 3.0.0 → 3.3.0

data/spec/imprint_spec.rb

@@ -108,7 +108,7 @@ describe Stanford::Mods::Imprint do
     it 'presents centuries' do
       smods_rec.from_str <<-XML
         #{mods_origin_info_start_str}
-          <dateIssued encoding="edtf">18XX</dateIssued>
+          <dateIssued encoding="edtf">18xx</dateIssued>
         #{mods_origin_info_end_str}
       XML
 
@@ -120,7 +120,7 @@ describe Stanford::Mods::Imprint do
     it 'presents decades' do
       smods_rec.from_str <<-XML
         #{mods_origin_info_start_str}
-          <dateIssued encoding="edtf">147X</dateIssued>
+          <dateIssued encoding="edtf">147x</dateIssued>
         #{mods_origin_info_end_str}
       XML
 
@@ -129,7 +129,7 @@ describe Stanford::Mods::Imprint do
       expect(updated_element).to eq '1470s'
     end
 
-    it 'adds A.D. to early years' do
+    it 'adds CE to early years' do
       smods_rec.from_str <<-XML
         #{mods_origin_info_start_str}
           <dateIssued encoding="edtf">988</dateIssued>
@@ -138,10 +138,10 @@ describe Stanford::Mods::Imprint do
 
       imp = stanford_mods_imprint(smods_rec)
       updated_element = imp.send(:date_str)
-      expect(updated_element).to eq '988 A.D.'
+      expect(updated_element).to eq '988 CE'
     end
 
-    it 'adds B.C. to B.C. years' do
+    it 'adds BCE to BCE years' do
       smods_rec.from_str <<-XML
         #{mods_origin_info_start_str}
           <dateIssued encoding="edtf">-5</dateIssued>
@@ -150,10 +150,10 @@ describe Stanford::Mods::Imprint do
 
       imp = stanford_mods_imprint(smods_rec)
       updated_element = imp.send(:date_str)
-      expect(updated_element).to eq '6 B.C.'
+      expect(updated_element).to eq '6 BCE'
     end
 
-    it 'has special handling for the year 0 (1 B.C.)' do
+    it 'has special handling for the year 0 (1 BCE)' do
       smods_rec.from_str <<-XML
         #{mods_origin_info_start_str}
           <dateIssued>0</dateIssued>
@@ -162,7 +162,7 @@ describe Stanford::Mods::Imprint do
 
       imp = stanford_mods_imprint(smods_rec)
       updated_element = imp.send(:date_str)
-      expect(updated_element).to eq '1 B.C.'
+      expect(updated_element).to eq '1 BCE'
     end
 
     it 'presents years + months' do
@@ -189,6 +189,31 @@ describe Stanford::Mods::Imprint do
       expect(updated_element).to eq 'April  2, 1948'
     end
 
+    it 'handles very precise EDTF ranges' do
+      smods_rec.from_str <<-XML
+        #{mods_origin_info_start_str}
+          <dateIssued encoding="edtf">2014-01/2020-12-31</dateIssued>
+        #{mods_origin_info_end_str}
+      XML
+
+      imp = stanford_mods_imprint(smods_rec)
+      updated_element = imp.send(:date_str)
+      expect(updated_element).to eq 'January 2014 - December 31, 2020'
+    end
+
+    xit 'handles BC EDTF centuries' do
+      # ruby-edtf apparently can't handle this format
+      smods_rec.from_str <<-XML
+        #{mods_origin_info_start_str}
+          <dateIssued encoding="edtf">-09XX</dateIssued>
+        #{mods_origin_info_end_str}
+      XML
+
+      imp = stanford_mods_imprint(smods_rec)
+      updated_element = imp.send(:date_str)
+      expect(updated_element).to eq '10th century BCE'
+    end
+
     it 'handles the approximate qualifier' do
       smods_rec.from_str <<-XML
         #{mods_origin_info_start_str}
@@ -210,13 +235,13 @@ describe Stanford::Mods::Imprint do
 
       imp = stanford_mods_imprint(smods_rec)
       updated_element = imp.send(:date_str)
-      expect(updated_element).to eq '[322 A.D.?]'
+      expect(updated_element).to eq '[322 CE?]'
     end
 
     it 'handles the inferred qualifier' do
       smods_rec.from_str <<-XML
         #{mods_origin_info_start_str}
-          <dateIssued encoding="edtf" qualifier="inferred">190X</dateIssued>
+          <dateIssued encoding="edtf" qualifier="inferred">190x</dateIssued>
         #{mods_origin_info_end_str}
       XML
 

data/spec/lib/stanford-mods/coordinate_spec.rb

@@ -9,10 +9,6 @@ describe Stanford::Mods::Coordinate do
       expect(described_class.new('W80°--E100°/N487°--S42°')).not_to be_valid
     end
 
-    it 'rejects coordinates without degree symbols' do
-      expect(described_class.new('W 650--W 100/N 700--N 550')).not_to be_valid
-    end
-
     it 'rejects malformed coordinates' do
       expect(described_class.new('(E29°--E35/°S12°--S16°).')).not_to be_valid
     end
@@ -43,7 +39,9 @@ describe Stanford::Mods::Coordinate do
       %((W 170⁰--E 55⁰/N 40⁰--S 36⁰).) =>
         '-170.0 -36.0 55.0 40.0', # superscript 0 is almost a degree character..
       %((W 0°-W 0°/S 90°---S 90°)) =>
-        '-0.0 -90.0 -0.0 -90.0' # one dash, two dashes, three dashes.. what's the difference?
+        '-0.0 -90.0 -0.0 -90.0', # one dash, two dashes, three dashes.. what's the difference?
+      %((W 030.6--E 068.1/N 041.7--S 042.4)) =>
+        '-30.6 -42.4 68.1 41.7'
     }.each do |value, expected|
       describe 'parsing' do
         let(:subject) { described_class.new(value) }