stanford-mods 2.6.0 → 2.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: cee6b06bb95f5c410a2b021f8d2b2d82254e52d5
-  data.tar.gz: cb1d846be2f33d5420edeef5705f704fadb9d804
+SHA256:
+  metadata.gz: 922ecb4ab53df951ef735de705037f218347938cac621886b54dc71463c215a6
+  data.tar.gz: 5426c132435bdc34a74df664b4bcbc6797682482689e0843ebdc7527e8df0715
 SHA512:
-  metadata.gz: 5b28846bce27f831c74cb88d708691643a24fc1183e593e42068c4b032254dd3ab47094550e45a8c4a2eb43fd02a866e06343506817c22d7f0bdb27dbb5c907a
-  data.tar.gz: 54f09f4ec848dfe215bea0559a6e0ae62d17d186e2fa8483aa155495ee27b4b34b3db7de9f0c7e7b102f65dbcd59f4a51ccb7fe97c7eadd640cba1e6c5e4ebcb
+  metadata.gz: eb12a388c219e4b9f99746d543ecc38cc1a67bc68302dc4255c81a088ffaad2fada7f6387b9525441d199c7ec536f54ba109f38ad92bf2d1d6d771077cdbc6d5
+  data.tar.gz: 2b904ae85c26eef0717a8e1250a7385889b00fe55c2e8ee59c83798f55f46e4e0ee4593f054dc3ab1a02e18095813ba3b16632f77340ddc212a54f36a871931a

data/.github/workflows/ruby.yml

@@ -0,0 +1,24 @@
+name: CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  tests:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [jruby-9.2.14.0, 2.7, 3.0]
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+    - name: Install dependencies
+      run: bundle install
+    - name: Run tests
+      run: bundle exec rake

data/.rubocop.yml

@@ -2,8 +2,8 @@ inherit_from: .rubocop_todo.yml
 
 require: rubocop-rspec
 
-Metrics/LineLength:
-  Max: 120
+Layout/LineLength:
+  Max: 200
 
 # shut hound up re: quote styles
 Style/StringLiterals:

data/.rubocop_todo.yml

@@ -1,19 +1,11 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-08-08 21:42:13 -0700 using RuboCop version 0.57.1.
+# on 2020-03-13 16:37:30 -0700 using RuboCop version 0.80.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: Include, TreatCommentsAsGroupSeparators.
-# Include: **/*.gemfile, **/Gemfile, **/gems.rb
-Bundler/OrderedGems:
-  Exclude:
-    - 'Gemfile'
-
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
@@ -22,32 +14,20 @@ Layout/AccessModifierIndentation:
   Exclude:
     - 'lib/stanford-mods/origin_info.rb'
 
-# Offense count: 27
+# Offense count: 22
 # Cop supports --auto-correct.
-Layout/AlignArray:
+Layout/ArrayAlignment:
   Exclude:
     - 'lib/stanford-mods/searchworks.rb'
     - 'spec/imprint_spec.rb'
 
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
-# SupportedHashRocketStyles: key, separator, table
-# SupportedColonStyles: key, separator, table
-# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
-Layout/AlignHash:
-  Exclude:
-    - 'spec/fixtures/searchworks_imprint_data.rb'
-    - 'spec/fixtures/searchworks_pub_date_data.rb'
-    - 'spec/fixtures/spotlight_pub_date_data.rb'
-
 # Offense count: 12
 # Cop supports --auto-correct.
 Layout/BlockEndNewline:
   Exclude:
     - 'spec/name_spec.rb'
 
-# Offense count: 20
+# Offense count: 10
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth.
 # SupportedStyles: case, end
@@ -71,11 +51,23 @@ Layout/EmptyLineAfterMagicComment:
 
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
+# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
 Layout/ExtraSpacing:
   Exclude:
     - 'lib/stanford-mods/searchworks.rb'
 
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
+# SupportedHashRocketStyles: key, separator, table
+# SupportedColonStyles: key, separator, table
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Layout/HashAlignment:
+  Exclude:
+    - 'spec/fixtures/searchworks_imprint_data.rb'
+    - 'spec/fixtures/searchworks_pub_date_data.rb'
+    - 'spec/fixtures/spotlight_pub_date_data.rb'
+
 # Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
@@ -120,7 +112,8 @@ Layout/SpaceAfterComma:
 
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment.
+# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
+# SupportedStylesForExponentOperator: space, no_space
 Layout/SpaceAroundOperators:
   Exclude:
     - 'lib/stanford-mods/searchworks.rb'
@@ -134,20 +127,20 @@ Layout/SpaceInsideBlockBraces:
   Exclude:
     - 'lib/stanford-mods/searchworks.rb'
 
-# Offense count: 11
+# Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: AllowInHeredoc.
 Layout/TrailingWhitespace:
   Exclude:
-    - 'lib/stanford-mods/searchworks.rb'
     - 'spec/searchworks_spec.rb'
 
-# Offense count: 33
+# Offense count: 31
 Metrics/AbcSize:
-  Max: 56
+  Max: 57
 
-# Offense count: 102
+# Offense count: 97
 # Configuration parameters: CountComments, ExcludedMethods.
+# ExcludedMethods: refine
 Metrics/BlockLength:
   Max: 795
 
@@ -156,28 +149,29 @@ Metrics/BlockLength:
 Metrics/ClassLength:
   Max: 377
 
-# Offense count: 20
+# Offense count: 18
 Metrics/CyclomaticComplexity:
-  Max: 26
-
-# Offense count: 118
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 199
+  Max: 32
 
-# Offense count: 32
-# Configuration parameters: CountComments.
+# Offense count: 31
+# Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 52
 
-# Offense count: 16
+# Offense count: 14
 Metrics/PerceivedComplexity:
-  Max: 20
+  Max: 25
+
+# Offense count: 1
+# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
+# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
+Naming/FileName:
+  Exclude:
+    - 'lib/stanford-mods.rb'
 
 # Offense count: 24
-# Configuration parameters: Blacklist.
-# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+# Configuration parameters: ForbiddenDelimiters.
+# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
   Exclude:
     - 'spec/geo_spatial_spec.rb'
@@ -187,7 +181,7 @@ Naming/HeredocDelimiterNaming:
     - 'spec/searchworks_basic_spec.rb'
 
 # Offense count: 3
-# Configuration parameters: EnforcedStyle.
+# Configuration parameters: EnforcedStyle, IgnoredPatterns.
 # SupportedStyles: snake_case, camelCase
 Naming/MethodName:
   Exclude:
@@ -195,24 +189,24 @@ Naming/MethodName:
     - 'lib/stanford-mods/searchworks.rb'
 
 # Offense count: 2
-# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
+Naming/MethodParameterName:
+  Exclude:
+    - 'lib/stanford-mods/imprint.rb'
+
+# Offense count: 2
+# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
-# NamePrefixBlacklist: is_, has_, have_
-# NameWhitelist: is_a?
+# ForbiddenPrefixes: is_, has_, have_
+# AllowedMethods: is_a?
 # MethodDefinitionMacros: define_method, define_singleton_method
 Naming/PredicateName:
   Exclude:
     - 'spec/**/*'
     - 'lib/stanford-mods/origin_info.rb'
 
-# Offense count: 2
-# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at
-Naming/UncommunicativeMethodParamName:
-  Exclude:
-    - 'lib/stanford-mods/imprint.rb'
-
-# Offense count: 8
+# Offense count: 30
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: snake_case, camelCase
 Naming/VariableName:
@@ -221,12 +215,6 @@ Naming/VariableName:
     - 'lib/stanford-mods/origin_info.rb'
     - 'lib/stanford-mods/searchworks.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Performance/UnneededSort:
-  Exclude:
-    - 'lib/stanford-mods/origin_info.rb'
-
 # Offense count: 3
 RSpec/AnyInstance:
   Exclude:
@@ -245,7 +233,7 @@ RSpec/BeforeAfterAll:
     - 'spec/searchworks_subject_spec.rb'
     - 'spec/searchworks_title_spec.rb'
 
-# Offense count: 142
+# Offense count: 137
 # Configuration parameters: Prefixes.
 # Prefixes: when, with, without
 RSpec/ContextWording:
@@ -283,6 +271,7 @@ RSpec/DescribeClass:
     - 'spec/sw_publication_spec.rb'
 
 # Offense count: 14
+# Cop supports --auto-correct.
 RSpec/EmptyLineAfterFinalLet:
   Exclude:
     - 'spec/name_spec.rb'
@@ -290,7 +279,7 @@ RSpec/EmptyLineAfterFinalLet:
     - 'spec/physical_location_spec.rb'
     - 'spec/sw_publication_spec.rb'
 
-# Offense count: 147
+# Offense count: 134
 # Configuration parameters: Max.
 RSpec/ExampleLength:
   Exclude:
@@ -305,7 +294,8 @@ RSpec/ExampleLength:
     - 'spec/searchworks_subject_spec.rb'
     - 'spec/searchworks_title_spec.rb'
 
-# Offense count: 114
+# Offense count: 111
+# Cop supports --auto-correct.
 # Configuration parameters: CustomTransform, IgnoredWords.
 RSpec/ExampleWording:
   Exclude:
@@ -324,12 +314,13 @@ RSpec/FilePath:
     - 'spec/lib/stanford-mods/coordinate_spec.rb'
 
 # Offense count: 2
+# Cop supports --auto-correct.
 # Configuration parameters: .
 # SupportedStyles: implicit, each, example
 RSpec/HookArgument:
   EnforcedStyle: each
 
-# Offense count: 1102
+# Offense count: 935
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
   Exclude:
@@ -342,6 +333,7 @@ RSpec/InstanceVariable:
     - 'spec/searchworks_title_spec.rb'
 
 # Offense count: 2
+# Cop supports --auto-correct.
 RSpec/LetBeforeExamples:
   Exclude:
     - 'spec/origin_info_spec.rb'
@@ -357,17 +349,18 @@ RSpec/MultipleDescribes:
   Exclude:
     - 'spec/geo_spatial_spec.rb'
 
-# Offense count: 114
+# Offense count: 100
 # Configuration parameters: AggregateFailuresByDefault.
 RSpec/MultipleExpectations:
   Max: 9
 
 # Offense count: 2
+# Configuration parameters: IgnoreSharedExamples.
 RSpec/NamedSubject:
   Exclude:
     - 'spec/lib/stanford-mods/coordinate_spec.rb'
 
-# Offense count: 38
+# Offense count: 36
 RSpec/NestedGroups:
   Max: 5
 
@@ -396,8 +389,8 @@ Style/Alias:
 
 # Offense count: 30
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods.
-# SupportedStyles: line_count_based, semantic, braces_for_chaining
+# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
+# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
 # ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
 # FunctionalMethods: let, let!, subject, watch
 # IgnoredMethods: lambda, proc, it
@@ -409,7 +402,7 @@ Style/BlockDelimiters:
     - 'lib/stanford-mods/searchworks_subjects.rb'
     - 'spec/name_spec.rb'
 
-# Offense count: 67
+# Offense count: 65
 Style/CommentedKeyword:
   Exclude:
     - 'lib/stanford-mods.rb'
@@ -469,6 +462,13 @@ Style/ExpandPathArguments:
   Exclude:
     - 'stanford-mods.gemspec'
 
+# Offense count: 36
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
 # Offense count: 3
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
@@ -487,7 +487,7 @@ Style/IfUnlessModifier:
     - 'lib/stanford-mods/date_parsing.rb'
     - 'lib/stanford-mods/imprint.rb'
 
-# Offense count: 3
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: InverseMethods, InverseBlocks.
 Style/InverseMethods:
@@ -509,6 +509,11 @@ Style/MultilineTernaryOperator:
   Exclude:
     - 'lib/stanford-mods/physical_location.rb'
 
+# Offense count: 1
+Style/MultipleComparison:
+  Exclude:
+    - 'lib/stanford-mods/origin_info.rb'
+
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedOctalStyle.
@@ -517,6 +522,16 @@ Style/NumericLiteralPrefix:
   Exclude:
     - 'spec/date_parsing_spec.rb'
 
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/stanford-mods/origin_info.rb'
+    - 'lib/stanford-mods/searchworks.rb'
+
 # Offense count: 8
 # Cop supports --auto-correct.
 Style/PerlBackrefs:
@@ -531,6 +546,26 @@ Style/PreferredHashMethods:
   Exclude:
     - 'lib/stanford-mods/searchworks.rb'
 
+# Offense count: 5
+# Cop supports --auto-correct.
+Style/RedundantCondition:
+  Exclude:
+    - 'lib/stanford-mods/origin_info.rb'
+    - 'lib/stanford-mods/searchworks.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+  Exclude:
+    - 'lib/stanford-mods/date_parsing.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantSort:
+  Exclude:
+    - 'lib/stanford-mods/origin_info.rb'
+
 # Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
@@ -555,6 +590,17 @@ Style/RescueStandardError:
   Exclude:
     - 'lib/stanford-mods/imprint.rb'
 
+# Offense count: 18
+# Cop supports --auto-correct.
+# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods.
+# AllowedMethods: present?, blank?, presence, try, try!
+Style/SafeNavigation:
+  Exclude:
+    - 'lib/stanford-mods/date_parsing.rb'
+    - 'lib/stanford-mods/imprint.rb'
+    - 'lib/stanford-mods/searchworks.rb'
+    - 'lib/stanford-mods/searchworks_subjects.rb'
+
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
@@ -576,7 +622,7 @@ Style/StderrPuts:
   Exclude:
     - 'Rakefile'
 
-# Offense count: 13
+# Offense count: 12
 # Cop supports --auto-correct.
 # Configuration parameters: MinSize.
 # SupportedStyles: percent, brackets
@@ -592,12 +638,13 @@ Style/SymbolProc:
     - 'lib/stanford-mods/searchworks.rb'
     - 'lib/stanford-mods/searchworks_subjects.rb'
 
-# Offense count: 5
+# Offense count: 1
 # Cop supports --auto-correct.
-Style/UnneededCondition:
+# Configuration parameters: EnforcedStyleForMultiline.
+# SupportedStylesForMultiline: comma, consistent_comma, no_comma
+Style/TrailingCommaInArrayLiteral:
   Exclude:
-    - 'lib/stanford-mods/origin_info.rb'
-    - 'lib/stanford-mods/searchworks.rb'
+    - 'spec/date_parsing_spec.rb'
 
 # Offense count: 125
 # Cop supports --auto-correct.
@@ -609,7 +656,7 @@ Style/WordArray:
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: all_comparison_operators, equality_operators_only
+# SupportedStyles: forbid_for_all_comparison_operators, forbid_for_equality_operators_only, require_for_all_comparison_operators, require_for_equality_operators_only
 Style/YodaCondition:
   Exclude:
     - 'lib/stanford-mods/date_parsing.rb'

data/Gemfile

@@ -2,13 +2,3 @@ source 'https://rubygems.org'
 
 # See stanford-mods.gemspec for this gem's dependencies
 gemspec
-
-group :test, :development do
-  gem 'rubocop', require: false
-  gem 'rubocop-rspec', require: false
-  gem 'pry-byebug', require: false, platform: [:ruby_20, :ruby_21]
-  gem 'coveralls', require: false
-end
-
-# Pin to activesupport 4.x for older versions of ruby
-gem 'activesupport', '~> 4.2' if RUBY_VERSION < '2.2.2'

data/lib/stanford-mods/coordinate.rb

@@ -16,12 +16,14 @@ module Stanford
       # @return [String] the coordinate in WKT/CQL ENVELOPE representation
       def as_envelope
         return unless valid?
+
         "ENVELOPE(#{bounds[:min_x]}, #{bounds[:max_x]}, #{bounds[:max_y]}, #{bounds[:min_y]})"
       end
 
       # @return [String] the coordinate in Solr 4.x+ bbox-format representation
       def as_bbox
         return unless valid?
+
         "#{bounds[:min_x]} #{bounds[:min_y]} #{bounds[:max_x]} #{bounds[:max_y]}"
       end
 
@@ -44,6 +46,7 @@ module Stanford
         @bounds ||= begin
           matches = cleaner_coordinate(value).match %r{\A(?<lat>[EW].+-+.+)\s*/\s*(?<lng>[NS].+-+.+)\Z}
           return {} unless matches
+
           min_x, max_x = matches['lat'].split(/-+/).map { |x| coord_to_decimal(x) }.minmax
           min_y, max_y = matches['lng'].split(/-+/).map { |y| coord_to_decimal(y) }.minmax
           { min_x: min_x, min_y: min_y, max_x: max_x, max_y: max_y }

data/lib/stanford-mods/date_parsing.rb

@@ -1,3 +1,5 @@
+require 'active_support/core_ext/integer/inflections'
+
 module Stanford
   module Mods
     # Parsing date strings
@@ -32,6 +34,7 @@ module Stanford
       # @return [Boolean] true if the year is between -999 and (current year + 1); false otherwise
       def self.year_str_valid?(year_str)
         return false unless year_str && (year_str.match(/^\d{1,4}$/) || year_str.match(/^-\d{1,3}$/))
+
         (-1000 < year_str.to_i) && (year_str.to_i < Date.today.year + 2)
       end
 
@@ -39,6 +42,7 @@ module Stanford
       # @return [Boolean] true if the year is between -9999 and (current year + 1); false otherwise
       def self.year_int_valid?(year)
         return false unless year.is_a? Integer
+
         (-1000 < year.to_i) && (year < Date.today.year + 2)
       end
 
@@ -59,6 +63,7 @@ module Stanford
         return display_str_for_bc if orig_date_str.match(BC_REGEX)
         # decade next in case there are 4 digits, e.g. 1950s
         return display_str_for_decade if orig_date_str.match(DECADE_4CHAR_REGEXP) || orig_date_str.match(DECADE_S_REGEXP)
+
         result = sortable_year_for_yyyy_or_yy
         unless result
           # try removing brackets between digits in case we have 169[5] or [18]91
@@ -81,6 +86,7 @@ module Stanford
         return if orig_date_str == '0000-00-00' # shpc collection has these useless dates
         # B.C. first in case there are 4 digits, e.g. 1600 B.C.
         return sortable_year_int_for_bc if orig_date_str.match(BC_REGEX)
+
         result = sortable_year_for_yyyy_or_yy
         result ||= sortable_year_for_decade # 19xx or 20xx
         result ||= sortable_year_for_century
@@ -102,6 +108,7 @@ module Stanford
         return if orig_date_str == '0000-00-00' # shpc collection has these useless dates
         # B.C. first in case there are 4 digits, e.g. 1600 B.C.
         return sortable_year_str_for_bc if orig_date_str.match(BC_REGEX)
+
         result = sortable_year_for_yyyy_or_yy
         result ||= sortable_year_for_decade # 19xx or 20xx
         result ||= sortable_year_for_century
@@ -144,6 +151,7 @@ module Stanford
       # @return [String, nil] 4 digit year (e.g. 1865, 0950) if orig_date_str matches pattern, nil otherwise
       def sortable_year_for_yy
         return unless orig_date_str
+
         slash_matches = orig_date_str.match(/\d{1,2}\/\d{1,2}\/\d{2}/)
         if slash_matches
           date_obj = Date.strptime(orig_date_str, '%m/%d/%y')
@@ -196,6 +204,7 @@ module Stanford
       def sortable_year_for_century
         return unless orig_date_str
         return if orig_date_str =~ /B\.C\./
+
         century_matches = orig_date_str.match(CENTURY_4CHAR_REGEXP)
         if century_matches
           return $1 + '00' if $1.length == 2
@@ -215,12 +224,12 @@ module Stanford
       def display_str_for_century
         return unless orig_date_str
         return if orig_date_str =~ /B\.C\./
+
         century_str_matches = orig_date_str.match(CENTURY_WORD_REGEXP)
         return century_str_matches.to_s if century_str_matches
 
         century_matches = orig_date_str.match(CENTURY_4CHAR_REGEXP)
         if century_matches
-          require 'active_support/core_ext/integer/inflections'
           return "#{($1.to_i + 1).ordinalize} century"
         end
       end
@@ -262,6 +271,7 @@ module Stanford
       # @return [String, nil] String sortable -ddd if orig_date_str matches pattern; nil otherwise
       def sortable_year_str_for_early_numeric
         return unless orig_date_str.match(EARLY_NUMERIC)
+
         if orig_date_str =~ /^\-/
           # negative number becomes x - 1000 for sorting; -005 for -995
           num = orig_date_str[1..-1].to_i - 1000
@@ -275,6 +285,7 @@ module Stanford
       # @return [Integer, nil] Integer sortable -ddd if orig_date_str matches pattern; nil otherwise
       def sortable_year_int_for_early_numeric
         return orig_date_str.to_i if orig_date_str.match(EARLY_NUMERIC)
+
         orig_date_str.to_i if orig_date_str =~ /^-\d{4}$/
       end
 
@@ -290,6 +301,7 @@ module Stanford
         return '1 B.C.' if orig_date_str == '0'
         # negative number becomes B.C.
         return "#{orig_date_str[1..-1].to_i + 1} B.C." if orig_date_str =~ /^\-/
+
         # remove leading 0s from early dates
         "#{orig_date_str.to_i} A.D."
       end
@@ -304,6 +316,7 @@ module Stanford
         # need more in string than only 2 digits
         return if orig_date_str.match(/^\d\d$/) || orig_date_str.match(/^\D*\d\d\D*$/)
         return if orig_date_str =~ /\d\s*B.C./ # skip B.C. dates
+
         date_obj = Date.parse(orig_date_str)
         date_obj.year.to_s
       rescue ArgumentError