stanford-mods 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f1bb292e526add1944d2595260b5edfdd66950fb
-  data.tar.gz: e814a340c6e3ceff0f0d5b373631409c3f5f0253
+  metadata.gz: a99ffd1547688f19839564988a43e698223bc3ac
+  data.tar.gz: 261a71cbde0d578de0c1b6f43fe329bf531c20ab
 SHA512:
-  metadata.gz: e9f4f142a9b09f8a61d82570b1fe0588dd3224645de7047e9b9229ff47c0efc15a12bba4583d0edce2ed2d36a2beddddb66edc3ea1edcc9010a6146136c8e1a5
-  data.tar.gz: b17d44c20f7bf39645f0659ddf034d6846c13ee6a548da2386b454269144882314acb34cfbde2d7a0baacd4e63f0d9d59aa9a859c4acf41f4cc651c15eb3ae18
+  metadata.gz: 996cc6f68f4fb8f3154a21423668e188826c46305ab2cd1445c871f0bcf7a20c0e362332b42ceebdee9be8a70e2ad0420532516356009ef4b7b1c1327e4cb3b3
+  data.tar.gz: 7ebf7b202fd71b7c546fde56f1064092f116e146f023c44a7d4f993ce39db0f88d402306fcdae44f081cffbd82fffdc5aeecb06c764567fc52c5df413ed87ccd

data/README.rdoc

@@ -59,6 +59,7 @@ Example Using SearchWorks Mixins:
 6. Create new Pull Request
 
 == Releases
+* <b>1.0.1</b> sw_title_display keeps appropriate trailing punct more or less per spec in solrmarc-sw sw_index.properties
 * <b>1.0.0</b> sw_full_title now includes partName and partNumber; sw_title_display created to be like sw_full_title but without trailing punctuation; sw format for typeOfResource sound recording; genre value is librettos, plural; sw format algorithm accommodates first letter upcase; genre value report does NOT map to a format, genre value 'project report' with ToR text is 'Book'
 * <b>0.0.27</b> add genres 'Issue brief', 'Book chapter' and 'Working paper' to map to searchworks format 'Book'
 * <b>0.0.26</b> map typeOfResource 'sound recording-musical' to searchworks format 'Music - Recording' with spaces

data/lib/stanford-mods/searchworks.rb

@@ -151,17 +151,24 @@ module Stanford
 
           result = parts ? preParts + ". " + parts : preParts
           result += "." if !result.match(/[[:punct:]]$/)
+          result.strip!
           result = nil if result.empty?
           result
         else
           nil
         end
       end
-      
+
+      # like sw_full_title without trailing \,/;:.
+      # spec from solrmarc-sw   sw_index.properties
+      #    title_display = custom, removeTrailingPunct(245abdefghijklmnopqrstuvwxyz, [\\\\,/;:], ([A-Za-z]{4}|[0-9]{3}|\\)|\\,))
       # @return [String] value for title_display (like title_full_display without trailing punctuation)
       def sw_title_display
         result = sw_full_title ? sw_full_title : nil
-        result.sub!(/[[:punct:]]$/, '') if result
+        if result
+          result.sub!(/[\.,;:\/\\]+$/, '')
+          result.strip!
+        end
         result
       end
       

data/lib/stanford-mods/version.rb

@@ -1,6 +1,6 @@
 module Stanford
   module Mods
     # this is the Ruby Gem version
-    VERSION = "1.0.0"
+    VERSION = "1.0.1"
   end
 end

data/spec/searchworks_pub_dates_spec.rb

@@ -1,7 +1,7 @@
 # encoding: UTF-8
 require 'spec_helper'
 
-describe "Date methods in Searchworks mixin for Stanford::Mods::Record" do
+describe "Date methods (searchworks.rb)" do
 
   before(:all) do
     @smods_rec = Stanford::Mods::Record.new

data/spec/searchworks_subject_spec.rb

@@ -1,7 +1,7 @@
 # encoding: UTF-8
 require 'spec_helper'
 
-describe "Searchworks Subject fields from Searchworks mixin for Stanford::Mods::Record" do
+describe "Subject fields (searchworks.rb)" do
 
   before(:all) do
     @smods_rec = Stanford::Mods::Record.new

data/spec/searchworks_title_spec.rb

@@ -1,7 +1,7 @@
 # encoding: UTF-8
 require 'spec_helper'
 
-describe "title fields from Searchworks mixin for Stanford::Mods::Record" do
+describe "title fields (searchworks.rb)" do
   before(:all) do
     @smods_rec = Stanford::Mods::Record.new
     @ns_decl = "xmlns='#{Mods::MODS_NS}'"
@@ -246,6 +246,64 @@ describe "title fields from Searchworks mixin for Stanford::Mods::Record" do
   end # sw_full_title
   
   context "sw_title_display removes end punctuation of sw_full_title_display" do
+
+    # title_display = custom, removeTrailingPunct(245abdefghijklmnopqrstuvwxyz, [\\\\,/;:], ([A-Za-z]{4}|[0-9]{3}|\\)|\\,))
+    context "should remove trailing \,/;:." do
+      it "retains other trailing chars" do
+        m = "<mods #{@ns_decl}><titleInfo>
+              <title>The Jerk?</title>
+            </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Jerk?'
+        m = "<mods #{@ns_decl}><titleInfo>
+              <title>The Jerk!</title>
+            </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Jerk!'
+      end
+      it "removes trailing comma" do
+        m = "<mods #{@ns_decl}><titleInfo>
+              <title>The Jerk,</title>
+            </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Jerk'
+      end
+      it "removes trailing semicolon" do
+        m = "<mods #{@ns_decl}><titleInfo>
+              <title>The Jerk;</title>
+            </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Jerk'
+      end
+      it "removes trailing colon" do
+        m = "<mods #{@ns_decl}><titleInfo>
+              <title>The Jerk:</title>
+            </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Jerk'
+      end
+      it "removes trailing slash" do
+        m = "<mods #{@ns_decl}><titleInfo>
+              <title>The Jerk /</title>
+            </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Jerk'
+      end
+      it "removes trailing backslash" do
+        m = "<mods #{@ns_decl}><titleInfo>
+              <title>The Jerk \</title>
+            </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Jerk'
+      end
+      it "removes multiple trailing punctuation" do
+        m = "<mods #{@ns_decl}><titleInfo>
+              <title>The Jerk.,\</title>
+            </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Jerk'
+      end
+    end
     context "no subtitle" do
       it "end title with a period" do
         m = "<mods #{@ns_decl}>
@@ -272,7 +330,7 @@ describe "title fields from Searchworks mixin for Stanford::Mods::Record" do
             <title>Olympics!</title>
           </titleInfo></mods>"
         @smods_rec.from_str(m)
-        expect(@smods_rec.sw_title_display).to eq 'The Olympics'
+        expect(@smods_rec.sw_title_display).to eq 'The Olympics!'
       end
     end # no subtitle
     context "subtitle" do
@@ -315,7 +373,7 @@ describe "title fields from Searchworks mixin for Stanford::Mods::Record" do
             <subTitle>a history?</subTitle>
           </titleInfo></mods>"
         @smods_rec.from_str(m)
-        expect(@smods_rec.sw_title_display).to eq 'The Olympics : a history'
+        expect(@smods_rec.sw_title_display).to eq 'The Olympics : a history?'
       end
     end # subtitle
     context "partName" do
@@ -446,14 +504,14 @@ describe "title fields from Searchworks mixin for Stanford::Mods::Record" do
             <partNumber>Part 1!</partNumber>
           </titleInfo></mods>"
         @smods_rec.from_str(m)
-        expect(@smods_rec.sw_title_display).to eq 'The Olympics : a history. Part 1'
+        expect(@smods_rec.sw_title_display).to eq 'The Olympics : a history. Part 1!'
         m = "<mods #{@ns_decl}>
           <titleInfo>
             <title>cfb</title>
             <partNumber>1894?</partNumber>
           </titleInfo></mods>"
         @smods_rec.from_str(m)
-        expect(@smods_rec.sw_title_display).to eq 'cfb. 1894'
+        expect(@smods_rec.sw_title_display).to eq 'cfb. 1894?'
       end
     end # no partName but partNumber
   end # sw_title_display

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stanford-mods
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Naomi Dushay
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-26 00:00:00.000000000 Z
+date: 2014-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mods