stanford-mods 0.0.10 → 0.0.11

data/README.rdoc

@@ -60,6 +60,7 @@ Example Using SearchWorks Mixins:
 
 == Releases
 
+* <b>0.0.11</b> escape regex special characters when using short title in a regex
 * <b>0.0.10</b> get rid of ignore_me files
 * <b>0.0.9</b> add sw_subject_names and sw_subject_titles methods to searchworks mixin
 * <b>0.0.8</b> require stanford-mods/searchworks in stanford-mods (top level)

data/lib/stanford-mods/searchworks.rb

@@ -100,13 +100,13 @@ module Stanford
       
       # @return [String] value for title_245_search, title_display, title_full_display
       def sw_full_title
-        full_titles ? full_titles.find { |s| s =~ Regexp.new(sw_short_title) } : nil
+        full_titles ? full_titles.find { |s| s =~ Regexp.new(Regexp.escape(sw_short_title)) } : nil
       end
       
       # this includes all titles except 
       # @return [Array<String>] values for title_variant_search
       def sw_addl_titles
-        full_titles.select { |s| s !~ Regexp.new(sw_short_title) }
+        full_titles.select { |s| s !~ Regexp.new(Regexp.escape(sw_short_title)) }
       end
       
       # Returns a sortable version of the main title

data/lib/stanford-mods/version.rb

@@ -1,6 +1,6 @@
 module Stanford
   module Mods
     # this is the Ruby Gem version
-    VERSION = "0.0.10"
+    VERSION = "0.0.11"
   end
 end

data/spec/searchworks_spec.rb

@@ -132,6 +132,13 @@ describe "Searchworks mixin for Stanford::Mods::Record" do
       it "should be a String" do
         @smods_rec.sw_full_title.should == 'The Jerk A Tale of Tourettes'
       end
+      it 'should escape regex characters in the sw_short_title' do
+        m = "<mods #{@ns_decl}><titleInfo>
+            <title>Pius V. Saint, [Michaele Gisleri),</title>
+          </titleInfo></mods>"
+        @smods_rec.from_str m
+        @smods_rec.sw_full_title.should == 'Pius V. Saint, [Michaele Gisleri),'     
+      end
     end
     context "additional titles (for title_variant_search)" do
       before(:all) do
@@ -153,6 +160,15 @@ describe "Searchworks mixin for Stanford::Mods::Record" do
       it "should include all alternative titles" do
         @addl_titles.should include('Alternative')
       end
+      it 'shold escape the short title in the regexp' do
+         m = "<mods #{@ns_decl}>
+            <titleInfo type='alternative'><title>Alternative</title></titleInfo>
+            <titleInfo><title>[Jerk)</title><nonSort>The</nonSort></titleInfo>
+            <titleInfo><title>Joke]</title></titleInfo>
+            </mods>"
+          @smods_rec.from_str(m)
+          @addl_titles = @smods_rec.sw_addl_titles
+      end
     end    
     context "sort title" do
       it "should be a String" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stanford-mods
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.11
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-07 00:00:00.000000000 Z
+date: 2013-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mods
@@ -167,18 +167,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -3519337351591429375
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -3519337351591429375
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24