standard_procedure_operations 0.4.1 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9d90e57e4b3e01cb8a83ce7be2f368f31eed30a96ed73ac619ab513609a18d96
-  data.tar.gz: fdbb00026f173b2eb8bb2569d2c7135799b0ad2478a147293973932837597c66
+  metadata.gz: 04267db639d0804b8fdc04e3a6cbe07531ff5870948f0ba95d91c4383188c331
+  data.tar.gz: 02fef265e8c2bae6ba1c5178fccb9fad3b0eca6f1bd87b4bbb0d321a47e55f40
 SHA512:
-  metadata.gz: 358365e5739fca1314b5905e90bc0b17e76be041158164535b22c6d22f324239f302e455ad0973925dc7bb4180673f2663ecc5af90beee8e197f586f9059b557
-  data.tar.gz: d833dcb1aecb3d7fa12810ca45f447074f89d6fa775a6f3ab3da674b3e782cb0193217111a5253b1c8cd0f802fe089a4748eb5a956136c8aeadb5928171da371
+  metadata.gz: 48a5aaf6c3c5f3b92bd274c62a1578b43c72212452b51ff934cdc3ff9ea8ad1eb8bd597d65db64185620a3cf1cde939bbfd19b78a8f297746d6d3b563b64a430
+  data.tar.gz: 97dbb727aa71212ba5bc485f83f1f5f68a07f3c40a08e37fe115b45246921c249917a5eee4fc841b6d23291cfa8f99d4e1bc80ae78472e62471e1b671f42f7b5

data/README.md

@@ -75,8 +75,7 @@ class PrepareDocumentForDownload < Operations::Task
     inputs :document
 
     self.filename = "#{Faker::Lorem.word}#{File.extname(document.filename.to_s)}"
-    # State transition defined statically
-  end
+end
   go_to :return_filename
 
   result :return_filename do |results|

data/app/models/operations/task/data_carrier.rb

@@ -1,6 +1,4 @@
 class Operations::Task::DataCarrier < OpenStruct
-  # go_to method removed to enforce static state transitions
-
   def fail_with(message) = task.fail_with(message)
 
   def call(sub_task_class, **data, &result_handler) = task.call(sub_task_class, **data, &result_handler)

data/app/models/operations/task/state_management/decision_handler.rb

@@ -44,12 +44,6 @@ class Operations::Task::StateManagement::DecisionHandler
     condition = @conditions.find { |condition| data.instance_eval(&condition) }
     raise Operations::NoDecision.new("No conditions matched #{@name}") if condition.nil?
     index = @conditions.index condition
-
-    # Check if we're in a testing environment (data is TestResultCarrier)
-    if data.respond_to?(:next_state=)
-      data.go_to(@destinations[index])
-    else
-      task.go_to(@destinations[index], data.to_h)
-    end
+    data.go_to(@destinations[index])
   end
 end

data/app/models/operations/task/state_management/wait_handler.rb

@@ -6,9 +6,8 @@ class Operations::Task::StateManagement::WaitHandler
     instance_eval(&config)
   end
 
-  def condition(destination = nil, options = {}, &condition)
+  def condition(options = {}, &condition)
     @conditions << condition
-    @destinations << destination if destination
     @condition_labels ||= {}
     condition_index = @conditions.size - 1
     @condition_labels[condition_index] = options[:label] if options[:label]
@@ -16,18 +15,12 @@ class Operations::Task::StateManagement::WaitHandler
 
   def go_to(state) = @destinations << state
 
-  def condition_labels
-    @condition_labels ||= {}
-  end
+  def condition_labels = @condition_labels ||= {}
 
   def call(task, data)
     raise Operations::CannotWaitInForeground.new("#{task.class} cannot wait in the foreground", task) unless task.background?
     condition = @conditions.find { |condition| data.instance_eval(&condition) }
-    if condition.nil?
-      task.go_to(task.state, data.to_h)
-    else
-      index = @conditions.index condition
-      task.go_to(@destinations[index], data.to_h)
-    end
+    next_state = (condition.nil? || @conditions.index(condition).nil?) ? task.state : @destinations[@conditions.index(condition)]
+    data.go_to next_state
   end
 end

data/app/models/operations/task/testing.rb

@@ -2,9 +2,9 @@ module Operations::Task::Testing
   extend ActiveSupport::Concern
 
   class_methods do
-    def handling state, **data, &block
+    def handling state, background: false, **data, &block
       # Create a task specifically for testing - avoid serialization issues
-      task = new(state: state)
+      task = new(state: state, background: background)
       # Use our own test-specific data carrier so we can examine results
       data = TestResultCarrier.new(data.merge(task: task))
 
@@ -22,7 +22,7 @@ module Operations::Task::Testing
 
   # Instead of extending DataCarrier (which no longer has go_to),
   # create a new class with similar functionality but keeps the go_to method for testing
-  class TestResultCarrier < OpenStruct
+  class TestResultCarrier < Operations::Task::DataCarrier
     def go_to(state, message = nil)
       self.next_state = state
       self.status_message = message || next_state.to_s
@@ -41,10 +41,7 @@ module Operations::Task::Testing
 
     def call(sub_task_class, **data, &result_handler)
       record_sub_task sub_task_class
-      # Return mock data for testing
-      result = {answer: 42}
-      result_handler&.call(result)
-      result
+      super
     end
 
     def start(sub_task_class, **data, &result_handler)

data/lib/operations/version.rb

@@ -1,3 +1,3 @@
 module Operations
-  VERSION = "0.4.1"
+  VERSION = "0.4.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: standard_procedure_operations
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.3
 platform: ruby
 authors:
 - Rahoul Baruah