standard_procedure_operations 0.4.0 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 61d128fb2351976c6771cd7b9d0e5b929c45b14c7e0e91911dd7e0b26990cadf
-  data.tar.gz: 9cd6b3bd8402f2cec3a4ad272f349af643bc8696fb95e4cad4d4e6530c1e0b9e
+  metadata.gz: 40faff52f3486a0ce989b2ea1fdb8350d8872827391331d0e5d8ad78c4e86a0a
+  data.tar.gz: b3667d26ebea3598955b0d4bf71eed3e22774c4aaf589ea3851c02454144a539
 SHA512:
-  metadata.gz: 145bb9834d6f9c95c2c9208b1e30fde979f1ec131cca1814f14b0cdfa14eae4a768b431bc8f75c4c2fec75fe948d966cf8b074772ff82f2f0fdccb584fa76e49
-  data.tar.gz: 13b0383ef1e585d40846d561bbd71027897e01c6f6f4a5e6216c3670ef12092e3793d4da96806b0e79db92889f3cc336e8a14b892d287ed1c6b2924e0d9c3afc
+  metadata.gz: a84bbf1163fbc9515450cf129bc9385043bb21f5d9d1e5c6135318f44caec11c1971801acdcd7e541915815e067898f36f7ffdbdb4e133b38f4a3a50156276aa
+  data.tar.gz: 4e6bbab0ababc9eb6a24f9b9dacbf4e755e08c44fd8a6da01502f59a5e763945df8cccd9198e0ef5532a80d31cccec81fb4eaafb5fa390fd682daf8e408fd66e

data/README.md

@@ -75,8 +75,7 @@ class PrepareDocumentForDownload < Operations::Task
     inputs :document
 
     self.filename = "#{Faker::Lorem.word}#{File.extname(document.filename.to_s)}"
-    # State transition defined statically
-  end
+end
   go_to :return_filename
 
   result :return_filename do |results|

data/app/models/operations/task/data_carrier.rb

@@ -1,12 +1,12 @@
 class Operations::Task::DataCarrier < OpenStruct
-  # go_to method removed to enforce static state transitions
-
   def fail_with(message) = task.fail_with(message)
 
   def call(sub_task_class, **data, &result_handler) = task.call(sub_task_class, **data, &result_handler)
 
   def start(sub_task_class, **data, &result_handler) = task.start(sub_task_class, **data, &result_handler)
 
+  def go_to(state, data = nil) = task.go_to state, data || self
+
   def complete(results) = task.complete(results)
 
   def inputs(*names)

data/app/models/operations/task/state_management/action_handler.rb

@@ -1,33 +1,17 @@
 class Operations::Task::StateManagement::ActionHandler
   attr_accessor :next_state
 
-  def initialize name, inputs = [], optional = [], &action
+  def initialize name, &action
     @name = name.to_sym
-    @required_inputs = inputs
-    @optional_inputs = optional
+    @required_inputs = []
+    @optional_inputs = []
     @action = action
     @next_state = nil
   end
 
   def call(task, data)
-    # Execute the action block in the context of the data carrier
-    result = data.instance_exec(&@action)
-
-    # If state hasn't changed (no go_to in the action) and we have a static next_state,
-    # perform the transition now
-    if @next_state && task.state == @name.to_s
-      # Get the current data as a hash to preserve changes made in the action
-      current_data = data.to_h
-
-      # If next_state is a symbol that matches an input parameter name, use that parameter's value
-      if @required_inputs.include?(@next_state) || @optional_inputs.include?(@next_state)
-        target_state = data.send(@next_state)
-        task.go_to(target_state, current_data) if target_state
-      else
-        task.go_to(@next_state, current_data)
-      end
+    data.instance_exec(&@action).tap do |result|
+      data.go_to @next_state unless @next_state.nil?
     end
-
-    result
   end
 end

data/app/models/operations/task/state_management/decision_handler.rb

@@ -37,26 +37,13 @@ class Operations::Task::StateManagement::DecisionHandler
 
   private def handle_single_condition(task, data)
     next_state = data.instance_eval(&@conditions.first) ? @true_state : @false_state
-    if next_state.respond_to?(:call)
-      data.instance_eval(&next_state)
-    elsif data.respond_to?(:next_state=)
-      # Check if we're in a testing environment (data is TestResultCarrier)
-      data.go_to(next_state)
-    else
-      task.go_to(next_state, data.to_h)
-    end
+    next_state.respond_to?(:call) ? data.instance_eval(&next_state) : data.go_to(next_state, data)
   end
 
   private def handle_multiple_conditions(task, data)
     condition = @conditions.find { |condition| data.instance_eval(&condition) }
     raise Operations::NoDecision.new("No conditions matched #{@name}") if condition.nil?
     index = @conditions.index condition
-
-    # Check if we're in a testing environment (data is TestResultCarrier)
-    if data.respond_to?(:next_state=)
-      data.go_to(@destinations[index])
-    else
-      task.go_to(@destinations[index], data.to_h)
-    end
+    data.go_to(@destinations[index])
   end
 end

data/app/models/operations/task/state_management.rb

@@ -13,7 +13,7 @@ module Operations::Task::StateManagement
 
     def decision(name, &config) = state_handlers[name.to_sym] = DecisionHandler.new(name, &config)
 
-    def action(name, inputs: [], optional: [], &handler) = state_handlers[name.to_sym] = ActionHandler.new(name, inputs, optional, &handler)
+    def action(name, &handler) = state_handlers[name.to_sym] = ActionHandler.new(name, &handler)
 
     def wait_until(name, &config) = state_handlers[name.to_sym] = WaitHandler.new(name, &config)
 

data/app/models/operations/task/testing.rb

@@ -5,7 +5,7 @@ module Operations::Task::Testing
     def handling state, **data, &block
       # Create a task specifically for testing - avoid serialization issues
       task = new(state: state)
-      # Use our own test-specific data carrier that has go_to
+      # Use our own test-specific data carrier so we can examine results
       data = TestResultCarrier.new(data.merge(task: task))
 
       # Testing doesn't use the database, so handle serialization by overriding task's go_to

data/lib/operations/version.rb

@@ -1,3 +1,3 @@
 module Operations
-  VERSION = "0.4.0"
+  VERSION = "0.4.2"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: standard_procedure_operations
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.2
 platform: ruby
 authors:
 - Rahoul Baruah
 bindir: bin
 cert_chain: []
-date: 2025-03-09 00:00:00.000000000 Z
+date: 2025-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails