standard_pagination 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d60e0bc850fa3f5f3efdfc07c355de37b9c4d569d86f05ddd47962c20e4a1636
-  data.tar.gz: dd47c304ed63c9f5a6df5f7c69a07eff5ef32fe495b372fe1cc0b1b072af52e7
+  metadata.gz: c8213902bdeb4fed07cf6c759eb52fc064a4f62154a25a7c92dafba705232a7d
+  data.tar.gz: 6fc78271275b84da5b601836cd6b03e100545b43a8c79ffc6ef8ea30a761e139
 SHA512:
-  metadata.gz: f07018870793cd23b22a8043c8e0aa34977dbf46547355922e90855135ee36fa6fb60cccc452f4bebff45ca4667cdd9456e4a176f5f922bde78dfc977dbc407e
-  data.tar.gz: 5a0762267cadaf3fad98ad90b2dd7cef1dfee4862bc66ee8d4b1dcf0c1e5966e8384afebe1063c50f434c1b0d073add3b47d39e1c131096cf170a5fa9d468c5e
+  metadata.gz: 41c6e457018dd8e2c9d320cd7ea298a7c8812cefd64ff47d1828d12851cdcbe6e45da01add2a7cf70b8cda166789b4d851dec5812cc6f8fb8443e6737f914f50
+  data.tar.gz: 631d2e4e9ad5bd57077073417663f19e709912171918b6dd39feaf8370848f7d9fb6ac8ea228ec41b5fe334a992393593a47b622c450c6bfbe7204d78c6efd4d

data/CHANGELOG.md

@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.1.2] - 2026-10-26
+
+### Added
+- `config.limit_key` accepts an Array of aliases, e.g. `%w[limit per_page]`; the first one the request sends wins. For APIs whose clients use both (luminality-web). The out-of-range redirect drops all of them. (Meant for 0.1.1, but that PR auto-merged before this commit landed.)
+
+## [0.1.1] - 2026-10-25
+
+### Fixed
+- `Controller#paginate` raised `NoMethodError` (`select_values` for Array) when given an in-memory Array, such as an assembled audit timeline. The inline-DISTINCT count check added late in 0.1.0 assumed an ActiveRecord relation. Arrays paginate again, and a spec covers them. Found while adopting the gem in fundbright-web.
+
 ## [0.1.0] - 2026-10-25
 
 ### Added

data/README.md

@@ -45,7 +45,7 @@ Delete `max_limit` (or `client_limit`) from `config/initializers/pagy.rb`. Leave
 StandardPagination.configure do |c|
   c.default_limit = 20            # rows when a call site passes no limit:
   c.max_limit = 100               # cap on a client-chosen page size
-  c.limit_key = "limit"           # param a client sets it with ("per_page" in luminality)
+  c.limit_key = "limit"           # param a client sets it with; an Array accepts aliases, e.g. %w[limit per_page]
   c.client_limit_formats = %i[json]
   c.tiebreak = true
   c.raise_range_error = true

data/lib/standard_pagination/config.rb

@@ -4,7 +4,8 @@ module StandardPagination
     attr_accessor :default_limit
     # Largest page size a client may request when client limits are on.
     attr_accessor :max_limit
-    # Request param a client sets the page size with (when allowed).
+    # Request param a client sets the page size with (when allowed). An Array
+    # accepts aliases; the first one the request sends wins.
     attr_accessor :limit_key
     # Formats for which `paginate` honours the client's page size by default.
     # HTML pages keep the size the call site chose.

data/lib/standard_pagination/controller.rb

@@ -96,12 +96,18 @@ module StandardPagination
       cap = pagination_client_limit_cap(client_limit)
       return limit unless cap
 
-      requested = params[StandardPagination.config.limit_key].to_s
+      # The first configured key the request sends wins.
+      key = pagination_limit_keys.find { |candidate| params[candidate].present? }
+      requested = key ? params[key].to_s : ""
       return limit unless requested.match?(/\A\d+\z/) && requested.to_i.positive?
 
       [ requested.to_i, cap ].min
     end
 
+    def pagination_limit_keys
+      Array(StandardPagination.config.limit_key).map(&:to_s)
+    end
+
     def pagination_client_limit_cap(client_limit)
       client_limit = pagination_client_limit_format? if client_limit.nil?
 
@@ -144,7 +150,7 @@ module StandardPagination
       if last_page
         query[page_key] = last_page
       else
-        query = query.except((options[:limit_key] || Pagy::DEFAULT[:limit_key]).to_s, StandardPagination.config.limit_key)
+        query = query.except((options[:limit_key] || Pagy::DEFAULT[:limit_key]).to_s, *pagination_limit_keys)
         # Nothing left to drop: the bad option came from the call site or a
         # param this gem doesn't know, so redirecting would only repeat it.
         return head(:bad_request) if query == original

data/lib/standard_pagination/stable_order.rb

@@ -39,8 +39,11 @@ module StandardPagination
       relation.from_clause.empty?
     end
 
-    # `select("DISTINCT category")` leaves distinct_value unset.
+    # `select("DISTINCT category")` leaves distinct_value unset. False for
+    # anything that isn't a relation (arrays, search results).
     def inline_distinct?(relation)
+      return false unless defined?(::ActiveRecord::Relation) && relation.is_a?(::ActiveRecord::Relation)
+
       relation.select_values.any? { |value| !value.is_a?(Symbol) && value.to_s.match?(/\bdistinct\b/i) }
     end
 

data/lib/standard_pagination/version.rb

@@ -1,3 +1,3 @@
 module StandardPagination
-  VERSION = "0.1.0"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: standard_pagination
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Jaryl Sim