standard_id 0.14.3 → 0.14.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3ef63474df3107460650e529f2c8cf46ec3b0998f81db90ece5cf37d95ec14fc
-  data.tar.gz: 3c0e147ce91c2442d05157507d088aa8f1a6fcb52b7e38c4e15b2d5cb6da9fde
+  metadata.gz: 47ce66e4e4b242fd96a90cda7b20a9316e31642551ebe6c94ae660336f8f0b2c
+  data.tar.gz: a1a6d6f746f2ef0590aec0b5d6c4cc51472e04030af53e30d8546495d2556f03
 SHA512:
-  metadata.gz: 0571fe2ae8b0e429f8c9ab8d3f7f73e475e1395297d392460fce1d7db0d75b880baeebbd7e34befbba7e58fc37684255902ea1358b5bbed2be6b6e2a29489c36
-  data.tar.gz: 791d1b6618bd054da2e57b2ee7f626eb60af647070b1d075ceb1f274e92ec4b3912b601ec076af3ad81357f957c1dfa460810d448a628c93c1791b299b127be2
+  metadata.gz: f323ce02474f8d4fc98a8aa4466616f15e58b9a5f6174336c91c0f9bc02c22e95862909963d0470271b49dc588fb0abcfcd2434c17a7ece79952d7547ed81ddf
+  data.tar.gz: 03a24d819ad4f699be3d97ce26e8dcf04873b373ff55c03e31f0de475a014198053a1927bf6539de40c0398855490be01ea4bc77dbe093d1f381f67eddfb8608

data/db/migrate/20260414200000_add_target_created_at_index_to_code_challenges.rb

@@ -0,0 +1,7 @@
+class AddTargetCreatedAtIndexToCodeChallenges < ActiveRecord::Migration[8.0]
+  def change
+    add_index :standard_id_code_challenges,
+      [:realm, :channel, :target, :created_at],
+      name: "index_code_challenges_on_target_created_at"
+  end
+end

data/lib/standard_id/passwordless/base_strategy.rb

@@ -28,18 +28,30 @@ module StandardId
       protected
 
       def create_challenge!(username)
-        code = generate_otp_code
+        ActiveRecord::Base.transaction do
+          invalidate_active_challenges!(username)
+
+          code = generate_otp_code
+
+          StandardId::CodeChallenge.create!(
+            realm: "authentication",
+            channel: connection_type,
+            target: username,
+            code: code,
+            expires_at: StandardId.config.passwordless.code_ttl.seconds.from_now,
+            ip_address: StandardId::Utils::IpNormalizer.normalize(request.remote_ip),
+            user_agent: request.user_agent
+          )
+        end
+      end
 
-        cc = StandardId::CodeChallenge.create!(
-          realm: "authentication",
-          channel: connection_type,
-          target: username,
-          code: code,
-          expires_at: StandardId.config.passwordless.code_ttl.seconds.from_now,
-          ip_address: StandardId::Utils::IpNormalizer.normalize(request.remote_ip),
-          user_agent: request.user_agent
-        )
-        cc
+      # Uses update_all for a single UPDATE statement (no N+1). This bypasses
+      # ActiveRecord callbacks intentionally — CodeChallenge has no after-save
+      # hooks today. If callbacks are added to CodeChallenge#use!, revisit this.
+      def invalidate_active_challenges!(username)
+        StandardId::CodeChallenge.active
+          .where(realm: "authentication", channel: connection_type, target: username)
+          .update_all(used_at: Time.current)
       end
 
       def generate_otp_code

data/lib/standard_id/passwordless/verification_service.rb

@@ -200,11 +200,10 @@ module StandardId
       end
 
       def find_active_challenge
-        StandardId::CodeChallenge.active.find_by(
-          realm: "authentication",
-          channel: @channel,
-          target: @target
-        )
+        StandardId::CodeChallenge.active
+          .where(realm: "authentication", channel: @channel, target: @target)
+          .order(created_at: :desc)
+          .first
       end
 
       # NOTE: The update! here can raise ActiveRecord::RecordInvalid, which is

data/lib/standard_id/version.rb

@@ -1,3 +1,3 @@
 module StandardId
-  VERSION = "0.14.3"
+  VERSION = "0.14.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: standard_id
 version: !ruby/object:Gem::Version
-  version: 0.14.3
+  version: 0.14.4
 platform: ruby
 authors:
 - Jaryl Sim
@@ -205,6 +205,7 @@ files:
 - db/migrate/20260311000000_add_provider_to_standard_id_identifiers.rb
 - db/migrate/20260311100000_create_standard_id_refresh_tokens.rb
 - db/migrate/20260311100001_add_nullify_to_refresh_token_previous_token_fk.rb
+- db/migrate/20260414200000_add_target_created_at_index_to_code_challenges.rb
 - lib/generators/standard_id/install/install_generator.rb
 - lib/generators/standard_id/install/templates/standard_id.rb
 - lib/standard_config.rb