standard_audit 0.11.0 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b89dc74bd119d2e0f1ff5080cef706439e68b61c79d2a6b653fcd5a74e265ae1
-  data.tar.gz: 86686ea3bb611a13e8c8947ef3e0b63aad63eb47bfa1e48b16abba377a426f7f
+  metadata.gz: 697434bf73f4588971d9fda7503f13f53a848ab4fe058fbc05be5b567a186d6f
+  data.tar.gz: e5bad881dc6a5ab13ae22d13777176120967161f40356dcd6522ab4616492c1f
 SHA512:
-  metadata.gz: b06e7ee9a3b5d79191cb47a532cf81efb95e3bb722015540be79ce4bb9412ab13b8e69985a66d368c8dcdfb099f34f1ca1d3f0d894bfc90cc409615782dde921
-  data.tar.gz: bb1e9316eba648a8d238becb75d33f705b82f509310e8c3e0d562656accac2b44339e49551e026ae0357bf57dda8fe8251f6f1d6c7df655777d5b157c3d17b0a
+  metadata.gz: feb2b3354808c948aff042e0a3354ac2344c3e4ac1b03f0c375645ff7b1aaf1ec27253e87e764652ee7d52710a4c7aecd7748ba13475afa001a0c27f55a2ca79
+  data.tar.gz: a83422f4ef6b6ca319c29c450ae7cf82457cc5ad342345947a867e2243ef701c2bb0310a5b1d99f5cbf9c322b756f5094c42e77e53eb6ea3b828a834f94bfacc

data/CHANGELOG.md

@@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.11.1] - 2026-09-24
+
+### Fixed
+
+- **`rake standard_audit:anonymize_actor[gid]` and `standard_audit:export_actor[gid]` no longer raise `NoMethodError`.** The tasks passed the GlobalID string straight into `AuditLog.anonymize_actor!` / `export_for_actor`, which called `to_global_id` on it. Both methods now accept a record, a `GlobalID`, or a GlobalID string. A string is parsed, not located, so erasure works after the subject's row has been deleted; an invalid string raises `ArgumentError`. What gets anonymized is unchanged.
+- **`rake standard_audit:cleanup` no longer deletes logs older than 90 days when `retention_days` is nil.** nil means keep forever, but the task fell back to a hard-coded 90. `cleanup` and `archive` (which always defaulted to 90) now take the days argument, else `config.retention_days`, else abort with a message saying how to set one.
+- **`cleanup`/`archive` reject a days value that is not a positive integer.** `cleanup[abc]` used to become `0` days, i.e. delete every row. `0`, negatives and non-numeric values now abort. `StandardAudit::CleanupJob` is unchanged.
+- **`StandardAudit::Subscriber` and `StandardAudit::EventSubscriber` report swallowed errors to `Rails.error`.** A failed audit write was only logged, so it never reached error tracking. It is now also reported with `handled: true` and context `{ <config.audit_error_context_key> => event_name, subscriber: <class name> }`. The log line is kept.
+
 ## [0.11.0] - 2026-07-31
 
 ### Security

data/README.md

@@ -499,6 +499,16 @@ This:
 - Clears `ip_address`, `user_agent`, and `session_id`
 - Removes metadata keys listed in `anonymizable_metadata_keys`
 
+Both `anonymize_actor!` and `export_for_actor` accept the subject as a record,
+a `GlobalID`, or a GlobalID string (`"gid://myapp/User/123"`). A string is
+parsed, never located, so erasure still works after the user's own row has been
+deleted — the usual order for an erasure request. Anything that is not a valid
+GlobalID raises `ArgumentError`.
+
+```ruby
+StandardAudit::AuditLog.anonymize_actor!("gid://myapp/User/123")
+```
+
 ### Right to Access (Export)
 
 Export all audit data for a specific user:
@@ -525,7 +535,9 @@ STANDARD_AUDIT_RETENTION_DAYS=365   # keep 365 days
 ```
 
 Infinite retention (the default) is the compliance-safe behavior: nothing is
-ever auto-deleted. For financial/legal domains that is usually what you want;
+ever auto-deleted. The `standard_audit:cleanup` and `standard_audit:archive`
+rake tasks respect this: with no days argument and a nil `retention_days` they
+abort rather than fall back to a default window. For financial/legal domains that is usually what you want;
 enabling a finite window is a deliberate decision.
 
 ### Production retention warning (StandardHealth)
@@ -635,10 +647,12 @@ rake standard_audit:verify
 # Record the parent digest each existing row was signed against
 rake standard_audit:relink_checksums
 
-# Delete logs older than N days (default: retention_days config or 90)
+# Delete logs older than N days
 rake standard_audit:cleanup[180]
+# ...or older than config.retention_days
+rake standard_audit:cleanup
 
-# Archive old logs to a JSON file before deleting
+# Archive old logs to a JSON file before deleting (same days rules)
 rake standard_audit:archive[90,audit_backup.json]
 
 # Show statistics
@@ -651,6 +665,15 @@ rake "standard_audit:anonymize_actor[gid://myapp/User/123]"
 rake "standard_audit:export_actor[gid://myapp/User/123,export.json]"
 ```
 
+`cleanup` and `archive` take the window from the days argument, else
+`config.retention_days`; if neither is set they abort (a nil `retention_days`
+means keep forever, so there is no implicit 90-day default). Days must be a
+positive integer — `0`, negatives and non-numeric values abort instead of
+deleting everything.
+
+`anonymize_actor` and `export_actor` take a GlobalID string and work even after
+the user record has been deleted.
+
 ## Database Support
 
 The migration uses `json` column type by default, which works across:

data/app/models/standard_audit/audit_log.rb

@@ -92,8 +92,11 @@ module StandardAudit
 
     # -- GDPR methods --
 
-    def self.anonymize_actor!(record)
-      gid = record.to_global_id.to_s
+    # `subject` may be a record, a GlobalID, or a GlobalID string
+    # ("gid://app/User/1"). A string is parsed, never located, so erasure and
+    # export still work after the subject's own row has been deleted.
+    def self.anonymize_actor!(subject)
+      gid = subject_gid_for(subject)
       logs = where("actor_gid = ? OR target_gid = ?", gid, gid)
       count = logs.count
 
@@ -122,8 +125,8 @@ module StandardAudit
       count
     end
 
-    def self.export_for_actor(record)
-      gid = record.to_global_id.to_s
+    def self.export_for_actor(subject)
+      gid = subject_gid_for(subject)
       logs = where("actor_gid = ? OR target_gid = ?", gid, gid).chronological
 
       records = logs.map do |log|
@@ -149,6 +152,22 @@ module StandardAudit
       }
     end
 
+    # Normalises a GDPR subject to its GlobalID string. Parses rather than
+    # locates, so it works when the subject's row no longer exists.
+    def self.subject_gid_for(subject)
+      gid =
+        case subject
+        when GlobalID then subject
+        when String then GlobalID.parse(subject)
+        else subject.respond_to?(:to_global_id) ? subject.to_global_id : nil
+        end
+
+      raise ArgumentError, "expected a record, a GlobalID, or a GlobalID string (gid://app/Model/id), got #{subject.inspect}" unless gid
+
+      gid.to_s
+    end
+    private_class_method :subject_gid_for
+
     # Recomputes the checksum from the record's current field values and the
     # given previous checksum. Useful for verification without saving.
     def compute_checksum_value(previous_checksum: nil)

data/lib/standard_audit/event_subscriber.rb

@@ -48,10 +48,27 @@ module StandardAudit
       )
     rescue => e
       Rails.logger.error("[StandardAudit] Error handling Rails.event: #{e.class}: #{e.message}")
+      report_error(e, name)
     end
 
     private
 
+    # The event handler rescues so a failed audit write cannot break the
+    # instrumented code path, but a log line alone is invisible to error
+    # tracking — so report it as handled too.
+    def report_error(error, event_name)
+      return unless Rails.respond_to?(:error) && Rails.error
+
+      Rails.error.report(
+        error,
+        handled: true,
+        context: { StandardAudit.config.audit_error_context_key => event_name,
+                   subscriber: self.class.name }
+      )
+    rescue => report_failure
+      Rails.logger.error("[StandardAudit] Error reporting audit failure: #{report_failure.class}: #{report_failure.message}")
+    end
+
     def matches_subscription?(name)
       StandardAudit.config.subscriptions.any? { |pattern| pattern_match?(pattern, name) }
     end

data/lib/standard_audit/subscriber.rb

@@ -25,6 +25,22 @@ module StandardAudit
 
     private
 
+    # The event handler rescues so a failed audit write cannot break the
+    # instrumented code path, but a log line alone is invisible to error
+    # tracking — so report it as handled too.
+    def report_error(error, event_name)
+      return unless Rails.respond_to?(:error) && Rails.error
+
+      Rails.error.report(
+        error,
+        handled: true,
+        context: { StandardAudit.config.audit_error_context_key => event_name,
+                   subscriber: self.class.name }
+      )
+    rescue => report_failure
+      Rails.logger.error("[StandardAudit] Error reporting audit failure: #{report_failure.class}: #{report_failure.message}")
+    end
+
     def handle_event(event)
       return unless StandardAudit.config.enabled
 
@@ -68,6 +84,7 @@ module StandardAudit
       end
     rescue => e
       Rails.logger.error("[StandardAudit] Error creating audit log: #{e.class}: #{e.message}")
+      report_error(e, event.name)
     end
 
     def extract_metadata(payload, config)

data/lib/standard_audit/version.rb

@@ -1,3 +1,3 @@
 module StandardAudit
-  VERSION = "0.11.0"
+  VERSION = "0.11.1"
 end

data/lib/tasks/standard_audit_tasks.rake

@@ -1,16 +1,44 @@
+module StandardAudit
+  module RakeSupport
+    module_function
+
+    # Resolves the retention window for cleanup/archive: the task argument,
+    # else config.retention_days, else abort. nil retention means "keep
+    # forever", so there is deliberately no hard-coded fallback. Anything that
+    # is not a positive integer aborts — `cleanup[abc]` used to become 0 days,
+    # i.e. delete everything.
+    def resolve_days!(task_name, arg)
+      raw = arg.presence || StandardAudit.config.retention_days
+
+      if raw.nil?
+        abort "standard_audit:#{task_name}: no retention window. Pass days " \
+              "(rake \"standard_audit:#{task_name}[90]\") or set config.retention_days " \
+              "/ STANDARD_AUDIT_RETENTION_DAYS. A nil retention_days means keep forever."
+      end
+
+      days = Integer(raw.to_s.strip, 10, exception: false)
+      unless days&.positive?
+        abort "standard_audit:#{task_name}: days must be a positive integer, got #{raw.inspect}"
+      end
+
+      days
+    end
+  end
+end
+
 namespace :standard_audit do
-  desc "Delete audit logs older than specified days (default: 90)"
+  desc "Delete audit logs older than N days (default: config.retention_days; aborts if neither is set)"
   task :cleanup, [:days] => :environment do |_t, args|
-    days = (args[:days] || StandardAudit.config.retention_days || 90).to_i
+    days = StandardAudit::RakeSupport.resolve_days!("cleanup", args[:days])
     cutoff = days.days.ago
 
     deleted = StandardAudit::AuditLog.where("occurred_at < ?", cutoff).delete_all
     puts "Deleted #{deleted} audit logs older than #{days} days"
   end
 
-  desc "Archive audit logs to JSON file"
+  desc "Archive audit logs older than N days to a JSON file (default: config.retention_days; aborts if neither is set)"
   task :archive, [:days, :output] => :environment do |_t, args|
-    days = (args[:days] || 90).to_i
+    days = StandardAudit::RakeSupport.resolve_days!("archive", args[:days])
     output = args[:output] || "audit_logs_archive_#{Date.current}.json"
     cutoff = days.days.ago
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: standard_audit
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.1
 platform: ruby
 authors:
 - Jaryl Sim