standard 1.39.0 → 1.39.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b15a7085baa8421e82fec821f8562214b001cfe17bd6a02f7a061bc892f047fa
-  data.tar.gz: f67e28527faebd95dc452a57f8994523c11f2f3e5be6c28da458d374852c5f9e
+  metadata.gz: 1d4af941058eb542737ef5766b38878bf776cc1d2c2f63483259a083289d6ead
+  data.tar.gz: bb2ee384fe411f73b28a82dc71b7076c9fe5d434484d1ee2f86b71244a73724f
 SHA512:
-  metadata.gz: d6040219e08da54f2ccfff731e787228e9226b20ba0380530513a41b0f29946eecf1503e41cd93e8f6beca3259258a713ad2f6815099325074a11ec2fcaf8915
-  data.tar.gz: 6749ee4c00f5cad2c52b774e96048f82769046a9527dccc6515e0ee75ed274987d72f11d6422407c747ceed15c8b9c12a884c94573657af07811d7f013889135
+  metadata.gz: 3660c9dbacfb529228e9a537993b8a3a7890be024dc8c4c58483d2a49c6068b0b717ee75fc2ff4b854fdd60f3dfd3c20e6591fe7dd2a556c190ad1fadc78ca18
+  data.tar.gz: 5f52474c6dc41df0cf2df552931c73c905cd5316c68081bfc893ac15a2fe4ef6ec7db37e1883ffbff2444b9a668c625b135e0ac5ac5741de90cefceb0978af71

data/.github/workflows/test.yml

@@ -25,7 +25,7 @@ jobs:
     runs-on: ${{ matrix.os }}
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up Ruby ${{ matrix.ruby-version }}
         uses: ruby/setup-ruby@v1
         with:

data/.github/workflows/update.yml

@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -45,7 +45,7 @@ jobs:
         id: date
         run: echo "::set-output name=date::$(date +'%Y-%m-%d')"
       - name: Create Pull Request
-        uses: peter-evans/create-pull-request@v3
+        uses: peter-evans/create-pull-request@v6
         with:
           reviewers: camilopayan
           commit-message: '[ ${{ steps.date.outputs.date }} ] - Update dependencies'

data/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 ## Unreleased
 
+## 1.39.2
+
+* Ensure a URI scheme on file paths from the built-in LSP [#642](https://github.com/standardrb/standard/pull/642).
+
+## 1.39.1
+
+* Fix LSP when `format` is set [#638](https://github.com/standardrb/standard/issues/638)
+* Fix LSP when todo is present (I think) [vscode-standard-ruby#26](https://github.com/standardrb/vscode-standard-ruby/issues/26)
+
 ## 1.39.0
 
 * Add support for LSP Code Actions / Quick Fix under Ruby LSP [#636](https://github.com/standardrb/standard/pull/636)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    standard (1.39.0)
+    standard (1.39.2)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.0)
       rubocop (~> 1.64.0)

data/README.md

@@ -11,7 +11,8 @@ configuration** to all of RuboCop's built-in rules as well as those included in
 [rubocop-performance](https://github.com/rubocop/rubocop-performance). It also
 supports plugins built with
 [lint_roller](https://github.com/standardrb/lint_roller), like
-[standard-rails](https://github.com/standardrb/standard-rails).
+[standard-rails](https://github.com/standardrb/standard-rails) and
+[standard-sorbet](https://github.com/standardrb/standard-sorbet).
 
 Standard Ruby was created and is maintained by the team at [Test
 Double](https://testdouble.com), because we appreciate the importance of
@@ -35,7 +36,7 @@ good idea. People also agree it's easier to work in codebases that exhibit a
 consistent style and format. So, what's the problem? **No two developers will
 ever agree on what all the rules and format should be.**
 
-This has resulted in innumerable teams arguing how to configure their linters
+This has resulted in innumerable teams arguing about how to configure their linters
 and formatters over literal decades. Some teams routinely divert time and energy
 from whatever they're building to reach consensus on where commas should go.
 Other teams have an overzealous tech lead who sets up everything _his favorite
@@ -76,17 +77,18 @@ is in using one at all and not in the particulars of how it's configured.
 ### Install
 
 Getting started is as easy as `gem install standard` or throwing it in your
-project's Gemfile:
+project's Gemfile and running `bundle install`:
 
 ```ruby
-gem "standard", group: [:development, :test]
+gem "standard"
 ```
 
-### Running Standard
+### Running Standard Ruby
 
-Once installed, you can either run it as a CLI or as a Rake task.
+Once installed, you can run Standard from the command line via its built-in
+executable or as a Rake task.
 
-The CLI is called `standardrb` to distinguish it from
+Standard Ruby's binary is named `standardrb` to distinguish it from
 [StandardJS](https://github.com/standard/standard):
 
 ```
@@ -137,8 +139,8 @@ $ rake standard:fix_unsafely
 
 So long as your code is checked into source control, there's no mortal harm in
 running with unsafe fixes enabled. If the changes look good to you and your
-tests pass, then it's probably less error prone than manually editing everything
-by hand.
+tests pass, then it's probably no more error prone than manually editing
+every change by hand.
 
 ## Integrating Standard into your workflow
 
@@ -151,7 +153,7 @@ continuous integration systems.
 
 We've added a number of editing guides for getting started:
 
-- [VS Code](https://github.com/standardrb/vscode-standard-ruby)
+- [VS Code](https://github.com/standardrb/standard/wiki/IDE:-vscode)
 - [vim](https://github.com/standardrb/standard/wiki/IDE:-vim)
 - [neovim](https://github.com/standardrb/standard/wiki/IDE:-neovim)
 - [RubyMine](https://www.jetbrains.com/help/ruby/rubocop.html#disable_rubocop)
@@ -165,19 +167,32 @@ added!
 
 #### Language Server Protocol support
 
-If you don't see your preferred editor above, Standard Ruby also ships with a
-built-in [language
-server](https://microsoft.github.io/language-server-protocol/) that many modern
-editors can support natively, even without a Standard-specific plugin.
-
-You can run the server by supplying the `--lsp` flag:
-
-```
-standardrb --lsp
-```
-
-If your editor offers LSP support, it probably has a place to configure the
-above command and will subsequently manage the server process for you.
+If you don't see your preferred editor above, Standard Ruby also offers robust
+[language server](https://microsoft.github.io/language-server-protocol/) support,
+in two ways, both included with the `standard` gem:
+
+1. A [Ruby LSP](https://github.com/Shopify/ruby-lsp) add-on, which (if
+the `standard` gem is in your `Gemfile`) will be loaded automatically
+2. A language server executable, which can be run from the command line
+   with `standardrb --lsp`
+
+| Capability  | Ruby LSP Add-on | Internal Server |
+| ------------- | ------------- | ------------- |
+| Diagnostics (Linting) | ✅ ([Pull](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_pullDiagnostics)) | ✅ ([Push](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_publishDiagnostics)) |
+| [Formatting](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_formatting)  | ✅ | ✅ |
+| [Code Actions](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_codeAction) | ✅ | ❌ |
+| Everything else  | ❌  | ❌ |
+
+Due to the advantages of Pull diagnostics and its inclusion of Code Actions
+("Quick Fixes" in VS Code parlance), we recommend using Standard's [Ruby LSP
+add-on](https://github.com/standardrb/standard/wiki/IDE:-vscode#using-ruby-lsp)
+where possible.
+
+Regardless of which language server you use, many editors have added LSP
+support, with each bringing their own approach to configuration. Many LSP
+features should "just work", but when in doubt, please consult our [editor
+guides above](#editor-support) as well as your editor's own documentation on how
+to configure LSP formatters and linters.
 
 ### CI support
 
@@ -477,6 +492,7 @@ Here are a few examples of Ruby Standard-compliant teams & projects:
 * [Brave Software](https://github.com/brave-intl/publishers)
 * [Collective Idea](https://collectiveidea.com/)
 * [Culture Foundry](https://www.culturefoundry.com/)
+* [Datadog](https://www.datadoghq.com/)
 * [Donut](https://www.donut.com/)
 * [Elevate Labs](https://elevatelabs.com)
 * [Envoy](https://www.envoy.com)

data/lib/ruby_lsp/standard/addon.rb

@@ -36,7 +36,7 @@ module RubyLsp
                 register_options: Interface::DidChangeWatchedFilesRegistrationOptions.new(
                   watchers: [
                     Interface::FileSystemWatcher.new(
-                      glob_pattern: "**/.standard.yml",
+                      glob_pattern: "**/.standard{,_todo}.yml",
                       kind: Constant::WatchKind::CREATE | Constant::WatchKind::CHANGE | Constant::WatchKind::DELETE
                     )
                   ]

data/lib/standard/lsp/diagnostic.rb

@@ -82,7 +82,7 @@ module Standard
             document_changes: [
               Interface::TextDocumentEdit.new(
                 text_document: Interface::OptionalVersionedTextDocumentIdentifier.new(
-                  uri: @uri.to_s,
+                  uri: ensure_uri_scheme(@uri.to_s).to_s,
                   version: nil
                 ),
                 edits: correctable? ? offense_replacements : []
@@ -113,7 +113,7 @@ module Standard
             document_changes: [
               Interface::TextDocumentEdit.new(
                 text_document: Interface::OptionalVersionedTextDocumentIdentifier.new(
-                  uri: @uri.to_s,
+                  uri: ensure_uri_scheme(@uri.to_s).to_s,
                   version: nil
                 ),
                 edits: line_disable_comment
@@ -163,6 +163,12 @@ module Standard
       def correctable?
         !@offense.corrector.nil?
       end
+
+      def ensure_uri_scheme(uri)
+        uri = URI.parse(uri)
+        uri.scheme = "file" if uri.scheme.nil?
+        uri
+      end
     end
   end
 end

data/lib/standard/lsp/routes.rb

@@ -72,8 +72,15 @@ module Standard
         @logger.puts "Ignoring workspace/didChangeConfiguration"
       end
 
+      CONFIGURATION_FILE_PATTERNS = [
+        ".standard.yml",
+        ".standard_todo.yml"
+      ].freeze
+
       handle "workspace/didChangeWatchedFiles" do |request|
-        if request[:params][:changes].any? { |change| change[:uri].end_with?(".standard.yml") }
+        if request[:params][:changes].any? { |change|
+          CONFIGURATION_FILE_PATTERNS.any? { |path| change[:uri].end_with?(path) }
+        }
           @logger.puts "Configuration file changed; restart required"
           @kills_server.call
         end

data/lib/standard/lsp/stdin_rubocop_runner.rb

@@ -12,8 +12,10 @@ module Standard
       DEFAULT_RUBOCOP_OPTIONS = {
         stderr: true,
         force_exclusion: true,
-        format: "RuboCop::Formatter::BaseFormatter",
-        raise_cop_error: true
+        formatters: ["RuboCop::Formatter::BaseFormatter"],
+        raise_cop_error: true,
+        todo_file: nil,
+        todo_ignore_files: []
       }.freeze
 
       def initialize(config)
@@ -27,7 +29,7 @@ module Standard
         super(
           config.rubocop_options.merge(DEFAULT_RUBOCOP_OPTIONS),
           config.rubocop_config_store
-          )
+        )
       end
 
       def run(path, contents)

data/lib/standard/version.rb

@@ -1,3 +1,3 @@
 module Standard
-  VERSION = Gem::Version.new("1.39.0")
+  VERSION = Gem::Version.new("1.39.2")
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: standard
 version: !ruby/object:Gem::Version
-  version: 1.39.0
+  version: 1.39.2
 platform: ruby
 authors:
 - Justin Searls
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-06-24 00:00:00.000000000 Z
+date: 2024-07-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -188,7 +188,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.9
+rubygems_version: 3.5.14
 signing_key:
 specification_version: 4
 summary: Ruby Style Guide, with linter & automatic code fixer