standard 1.28.0 → 1.29.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f90048ed9d5a6f7fb709f72f0ce48e3afca1207f4b75ec7673baaa77b7a15ed8
-  data.tar.gz: e29c6e2e9c919611bfaf1ec1fb2907c0bb2552eb06a7a4340e45140ec0c0a2ad
+  metadata.gz: d0beb51ce9976fc9de3f3daad988e62190aaf87c9641850bcd6f0b0e2503745b
+  data.tar.gz: 94cffff45294c2b64124c0b655fbe448d314e5bd1aa7d30dbde08f75326ff413
 SHA512:
-  metadata.gz: 53482d43182ade55a2828dd8fbd877c54dfc88cddf7dfdc842fb6a2ade273930fd43422dac37687f42617bfc35d2c65ac2b11211abad4e4d7f1a5409b5fa6cf3
-  data.tar.gz: 84a62318f010f8361e94120f579fe24eca5d0ae7efc3cabe7175817f6ce799857ce95abbf59acfe3d898396464cd55231b2d29fd80dbfe781a9a561401e87312
+  metadata.gz: e5a7d941184da2cc685816c9f1b7a895686b4c915502455e6576a317d1451f3eb2cf696d9891c835a2e929c090053d25450da8548f6efd95043de114b5a36441
+  data.tar.gz: 0efce415cf6e84eff032d114ee0c25de76cf964c56359c1e018325c6d4dfb8c2de0afca63549ba6754fff18825fd50151018fee4bc3c95d78d3c7213dfb7f083

data/.github/workflows/test.yml

@@ -16,7 +16,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        ruby-version: [2.6, 2.7, '3.0', 3.1, 3.2]
+        ruby-version: [2.7, '3.0', 3.1, 3.2, head]
 
     runs-on: ${{ matrix.os }}
 

data/CHANGELOG.md

@@ -1,5 +1,37 @@
 # Changelog
 
+## 1.29.0
+
+* Updates standard-performance to [1.1.0](https://github.com/standardrb/standard-performacne/releases/tag/v1.1.0)
+* Updates rubocop to [1.52.0](https://github.com/rubocop/rubocop/releases/tag/v1.52.0)
+  * Enables Style/ExactRegexpMatch, Style/RedundantArrayConstructor, Style/RedundantFilterChain, Style/RedundantRegexpConstructor
+
+## 1.28.5
+
+* Make LSP behave more nicely with nvim-lspconfig [#564](https://github.com/standardrb/standard/pull/564)
+
+## 1.28.4
+
+* Fix [standard-rails#7](https://github.com/standardrb/standard-rails/issues/7#issuecomment-1563505365)
+
+## 1.28.3
+
+* Older ruby support fixes from [@pboling](https://github.com/pboling):
+    - [#559](https://github.com/standardrb/standard/issues/559)
+    - [#561](https://github.com/standardrb/standard/issues/560)
+    - [#561](https://github.com/standardrb/standard/issues/561)
+
+## 1.28.2
+
+* Attempts to fix the not-actually fixed plugin behavior in 1.28.1
+
+## 1.28.1
+
+* Fixes plugin behavior caused by setting `DisabledByDefault: true` in `AllCops`
+  Effectively, a single lint_roller plugin whose `rules` were of type `:object`
+  would inadvertently mark all previously-defined rules as invalid.
+  [#557](https://github.com/standardrb/standard/pull/557)
+
 ## 1.28.0
 
 * Refactor Standard into 3 gems and convert all built-in configuration into

data/Gemfile.lock

@@ -1,12 +1,12 @@
 PATH
   remote: .
   specs:
-    standard (1.28.0)
+    standard (1.29.0)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.0)
-      rubocop (~> 1.50.2)
+      rubocop (~> 1.52.0)
       standard-custom (~> 1.0.0)
-      standard-performance (~> 1.0.1)
+      standard-performance (~> 1.1.0)
 
 GEM
   remote: https://rubygems.org/
@@ -23,13 +23,13 @@ GEM
     method_source (1.0.0)
     minitest (5.18.0)
     parallel (1.23.0)
-    parser (3.2.2.0)
+    parser (3.2.2.1)
       ast (~> 2.4.1)
     rainbow (3.1.1)
     rake (13.0.6)
     regexp_parser (2.8.0)
     rexml (3.2.5)
-    rubocop (1.50.2)
+    rubocop (1.52.0)
       json (~> 2.3)
       parallel (~> 1.10)
       parser (>= 3.2.0.0)
@@ -39,9 +39,9 @@ GEM
       rubocop-ast (>= 1.28.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.28.0)
+    rubocop-ast (1.29.0)
       parser (>= 3.2.1.0)
-    rubocop-performance (1.16.0)
+    rubocop-performance (1.18.0)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
     ruby-progressbar (1.13.0)
@@ -53,9 +53,9 @@ GEM
     simplecov_json_formatter (0.1.4)
     standard-custom (1.0.0)
       lint_roller (~> 1.0)
-    standard-performance (1.0.1)
+    standard-performance (1.1.0)
       lint_roller (~> 1.0)
-      rubocop-performance (~> 1.16.0)
+      rubocop-performance (~> 1.18.0)
     unicode-display_width (2.4.2)
 
 PLATFORMS

data/README.md

@@ -15,7 +15,7 @@ supports plugins built with
 
 Standard Ruby was created and is maintained by the team at [Test
 Double](https://testdouble.com), because we appreciate the importance of
-balancing predictably consistent code with preserving developers' autonomy. 💚
+balancing predictable, consistent code with preserving developer autonomy. 💚
 
 Topics covered in this README:
 
@@ -37,7 +37,7 @@ ever agree on what all the rules and format should be.**
 
 This has resulted in innumerable teams arguing how to configure their linters
 and formatters over literal decades. Some teams routinely divert time and energy
-from whatever they're building to reach concensus on where commas should go.
+from whatever they're building to reach consensus on where commas should go.
 Other teams have an overzealous tech lead who sets up everything _his favorite
 way_ and then imposes his will on others. It's not uncommon to witness
 passive-aggressive programmers change a contentious rule back-and-forth,
@@ -63,9 +63,9 @@ for most of the ways people use Ruby, most of the time.
 
 If you adopt Standard Ruby, what's in it for you? Time saved that would've been
 spent arguing over how to set things up. Also, seamless upgrades: we stay on top
-of each new RuboCop rule ship an updated configuration  on a monthly release
+of each new RuboCop rule and update our configuration on a monthly release
 cadence. But the best part of adopting Standard as your linter and formatter?
-You'll spend a whole lot less time thinking about linters and formatters.
+**You'll spend a whole lot less time thinking about linters and formatters.**
 
 So please, give Standard Ruby a try. If you're like [these
 folks](#who-uses-standard-ruby), you'll soon realize that the value of a linter
@@ -110,7 +110,7 @@ A majority of Standard's rules can be safely fixed automatically.
 
 ```
 # CLI
-$ standard --fix
+$ standardrb --fix
 
 # Rake
 $ rake standard:fix
@@ -432,6 +432,11 @@ extend_config:
 
 ### Running Standard's rules via RuboCop
 
+**Please note that the following usage is not supported and may break at any
+time. Use at your own risk and please refrain from opening GitHub issues with
+respect to loading Standard or its plugins' YAML configurations for use by
+the `rubocop` CLI.**
+
 If you find that neither plugins or configuration extensions meet your needs or
 if you have some other reason to run Standard's rules with RuboCop's CLI (e.g.,
 to continue using your favorite IDE/tooling/workflow with RuboCop support) Evil
@@ -466,6 +471,7 @@ Here are a few examples of Ruby Standard-compliant teams & projects:
 * [Brave Software](https://github.com/brave-intl/publishers)
 * [Collective Idea](https://collectiveidea.com/)
 * [Culture Foundry](https://www.culturefoundry.com/)
+* [Donut](https://www.donut.com/)
 * [Elevate Labs](https://elevatelabs.com)
 * [Envoy](https://www.envoy.com)
 * [Evil Martians](https://evilmartians.com)

data/config/base.yml

@@ -1153,6 +1153,8 @@ Style/EvalWithLocation:
 Style/EvenOdd:
   Enabled: false
 
+Style/ExactRegexpMatch:
+    Enabled: true
 Style/ExpandPathArguments:
   Enabled: false
 
@@ -1498,6 +1500,9 @@ Style/RandomWithOffset:
 Style/RedundantArgument:
   Enabled: false
 
+Style/RedundantArrayConstructor:
+  Enabled: true
+
 Style/RedundantAssignment:
   Enabled: true
 
@@ -1531,6 +1536,9 @@ Style/RedundantFetchBlock:
 Style/RedundantFileExtensionInRequire:
   Enabled: true
 
+Style/RedundantFilterChain:
+  Enabled: false
+
 Style/RedundantFreeze:
   Enabled: true
 
@@ -1555,6 +1563,9 @@ Style/RedundantPercentQ:
 Style/RedundantRegexpCharacterClass:
   Enabled: true
 
+Style/RedundantRegexpConstructor:
+  Enabled: true
+
 Style/RedundantRegexpEscape:
   Enabled: true
 

data/config/ruby-1.8.yml

@@ -11,3 +11,6 @@ Style/FileWrite:
 
 Style/FileRead:
   Enabled: false
+
+Layout/DotPosition:
+  Enabled: false

data/config/ruby-1.9.yml

@@ -5,3 +5,7 @@ Style/Encoding:
 
 Style/HashConversion:
   Enabled: false
+
+# Percent delimiters are not supported until Ruby 2.0
+Style/PercentLiteralDelimiters:
+  Enabled: false

data/config/ruby-3.1.yml

@@ -1,4 +1,4 @@
-inherit_from: ./base.yml
+inherit_from: ./ruby-3.2.yml
 
 AllCops:
   TargetRubyVersion: 3.1

data/config/ruby-3.2.yml

@@ -0,0 +1,4 @@
+inherit_from: ./base.yml
+
+AllCops:
+  TargetRubyVersion: 3.2

data/lib/standard/base/plugin.rb

@@ -55,6 +55,8 @@ module Standard::Base
         "ruby-3.0.yml"
       elsif desired_version < Gem::Version.new("3.2")
         "ruby-3.1.yml"
+      elsif desired_version < Gem::Version.new("3.3")
+        "ruby-3.2.yml"
       else
         default
       end

data/lib/standard/creates_config_store.rb

@@ -19,9 +19,9 @@ module Standard
       RuboCop::ConfigStore.new.tap do |config_store|
         options_config = @assigns_rubocop_yaml.call(config_store, standard_config)
         @sets_target_ruby_version.call(options_config, standard_config)
-        @configures_ignored_paths.call(options_config, standard_config)
         @combines_plugin_configs.call(options_config, standard_config)
         @merges_user_config_extensions.call(options_config, standard_config)
+        @configures_ignored_paths.call(options_config, standard_config)
       end
     end
   end

data/lib/standard/lsp/routes.rb

@@ -75,6 +75,10 @@ module Standard
         @writer.write({id: request[:id], result: format_file(uri)})
       end
 
+      handle "workspace/didChangeConfiguration" do |_request|
+        @logger.puts "Ignoring workspace/didChangeConfiguration"
+      end
+
       handle "workspace/didChangeWatchedFiles" do |request|
         if request[:params][:changes].any? { |change| change[:uri].end_with?(".standard.yml") }
           @logger.puts "Configuration file changed; restart required"

data/lib/standard/plugin/merges_plugins_into_rubocop_config.rb

@@ -27,17 +27,16 @@ module Standard
 
       def call(options_config, standard_config, plugins, permit_merging:)
         runner_context = @creates_runner_context.call(standard_config)
-        plugin_config = combine_rubocop_configs(options_config, runner_context, plugins).to_h
+        plugin_config = combine_rubocop_configs(options_config, runner_context, plugins, permit_merging: permit_merging).to_h
         merge_config_into_all_cops!(options_config, plugin_config)
         merge_config_into_standard!(options_config, plugin_config, permit_merging: permit_merging)
       end
 
       private
 
-      def combine_rubocop_configs(options_config, runner_context, plugins)
+      def combine_rubocop_configs(options_config, runner_context, plugins, permit_merging:)
+        all_cop_keys_configured_by_plugins = all_cop_keys_previously_configured_by_plugins(options_config, permit_merging: permit_merging)
         fake_out_rubocop_default_configuration(options_config) do |fake_config|
-          all_cop_keys_configured_by_plugins = []
-
           plugins.reduce(fake_config) do |combined_config, plugin|
             RuboCop::ConfigLoader.instance_variable_set(:@default_configuration, combined_config)
             next_config, path = config_for_plugin(plugin, runner_context)
@@ -49,7 +48,7 @@ module Standard
             )
             delete_already_configured_keys!(combined_config.keys, next_config, dont_delete_keys: ["AllCops"])
 
-            RuboCop::ConfigLoader.merge_with_default(next_config, path)
+            RuboCop::ConfigLoader.merge_with_default(next_config, path, unset_nil: false)
           end
         end
       end
@@ -60,7 +59,8 @@ module Standard
         if rules.type == :path
           [RuboCop::ConfigLoader.load_file(rules.value), rules.value]
         elsif rules.type == :object
-          [RuboCop::Config.new(rules.value), nil]
+          path = plugin.method(:rules).source_location[0]
+          [RuboCop::Config.create(rules.value, path, check: true), path]
         elsif rules.type == :error
           raise "Plugin `#{plugin.about&.name || plugin.inspect}' failed to load with error: #{rules.value.respond_to?(:message) ? rules.value.message : rules.value}"
         end
@@ -123,13 +123,32 @@ module Standard
         end
       end
 
+      def all_cop_keys_previously_configured_by_plugins(options_config, permit_merging:)
+        if permit_merging
+          []
+        else
+          Array(options_config["AllCops"]&.keys) - RuboCop::ConfigLoader.default_configuration["AllCops"].keys
+        end
+      end
+
       def fake_out_rubocop_default_configuration(options_config)
-        og_default_config = RuboCop::ConfigLoader.instance_variable_get(:@default_configuration)
+        og_default_config = RuboCop::ConfigLoader.default_configuration
+        set_target_rails_version_on_all_cops_because_its_technically_not_allowed!(options_config)
         result = yield blank_rubocop_config(options_config)
         RuboCop::ConfigLoader.instance_variable_set(:@default_configuration, og_default_config)
         result
       end
 
+      # Avoid a warning that would otherwise be emitted by any plugin that set TargetRailsVersion
+      # because it's not a default AllCops key specified in RuboCop's embedded default config.
+      #
+      # See: https://github.com/rubocop/rubocop/pull/11833
+      def set_target_rails_version_on_all_cops_because_its_technically_not_allowed!(options_config)
+        return if !options_config.key?("AllCops") || options_config["AllCops"].key?("TargetRailsVersion")
+
+        options_config["AllCops"]["TargetRailsVersion"] = nil
+      end
+
       def blank_rubocop_config(example_config)
         RuboCop::Config.new(example_config.to_h.slice(*MANDATORY_RUBOCOP_CONFIG_KEYS), "")
       end

data/lib/standard/version.rb

@@ -1,3 +1,3 @@
 module Standard
-  VERSION = Gem::Version.new("1.28.0")
+  VERSION = Gem::Version.new("1.29.0")
 end

data/standard.gemspec

@@ -23,11 +23,11 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
   spec.metadata["rubygems_mfa_required"] = "true"
 
-  spec.add_dependency "rubocop", "~> 1.50.2"
+  spec.add_dependency "rubocop", "~> 1.52.0"
 
   spec.add_dependency "lint_roller", "~> 1.0"
   spec.add_dependency "standard-custom", "~> 1.0.0"
-  spec.add_dependency "standard-performance", "~> 1.0.1"
+  spec.add_dependency "standard-performance", "~> 1.1.0"
 
   # not semver: first three are lsp protocol version, last is patch
   spec.add_dependency "language_server-protocol", "~> 3.17.0.2"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: standard
 version: !ruby/object:Gem::Version
-  version: 1.28.0
+  version: 1.29.0
 platform: ruby
 authors:
 - Justin Searls
-autorequire:
+autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-04-22 00:00:00.000000000 Z
+date: 2023-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.50.2
+        version: 1.52.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.50.2
+        version: 1.52.0
 - !ruby/object:Gem::Dependency
   name: lint_roller
   requirement: !ruby/object:Gem::Requirement
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.1
+        version: 1.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.1
+        version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: language_server-protocol
   requirement: !ruby/object:Gem::Requirement
@@ -80,7 +80,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 3.17.0.2
-description:
+description: 
 email:
 - searls@gmail.com
 executables:
@@ -116,6 +116,7 @@ files:
 - config/ruby-2.7.yml
 - config/ruby-3.0.yml
 - config/ruby-3.1.yml
+- config/ruby-3.2.yml
 - docs/ARCHITECTURE.md
 - docs/NEW_RUBIES.md
 - docs/RELEASE.md
@@ -166,7 +167,7 @@ metadata:
   source_code_uri: https://github.com/standardrb/standard
   changelog_uri: https://github.com/standardrb/standard/blob/main/CHANGELOG.md
   rubygems_mfa_required: 'true'
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -181,8 +182,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
-signing_key:
+rubygems_version: 3.1.6
+signing_key: 
 specification_version: 4
 summary: Ruby Style Guide, with linter & automatic code fixer
 test_files: []