standard 1.28.0 → 1.28.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f90048ed9d5a6f7fb709f72f0ce48e3afca1207f4b75ec7673baaa77b7a15ed8
-  data.tar.gz: e29c6e2e9c919611bfaf1ec1fb2907c0bb2552eb06a7a4340e45140ec0c0a2ad
+  metadata.gz: 38cefe66ce8063af630a8ce4e21f3565ae614d9b4b06ec977f42586123d110ba
+  data.tar.gz: 6281549367fe086c1c6118662c741ab1042493c2f98942fd1b6f6e64755bfb8f
 SHA512:
-  metadata.gz: 53482d43182ade55a2828dd8fbd877c54dfc88cddf7dfdc842fb6a2ade273930fd43422dac37687f42617bfc35d2c65ac2b11211abad4e4d7f1a5409b5fa6cf3
-  data.tar.gz: 84a62318f010f8361e94120f579fe24eca5d0ae7efc3cabe7175817f6ce799857ce95abbf59acfe3d898396464cd55231b2d29fd80dbfe781a9a561401e87312
+  metadata.gz: 4c6bf6c09d594f5a6bc2af47597e502d79717e8a5540d5214b20eb00222281bad3bcc01b2d48db1048df88229a67fc29ba1e2f7336aaf28e596b1aeed9cb5f11
+  data.tar.gz: ba211a922855471058ad9053684958532f82d8d160f763dd119d6bfa373dd0b63a408946e7134081b823c791f83febfa544a300232cfb8a4d2f0e0daad51ac15

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 # Changelog
 
+## 1.28.2
+
+* Attempts to fix the not-actually fixed plugin behavior in 1.28.1
+
+## 1.28.1
+
+* Fixes plugin behavior caused by setting `DisabledByDefault: true` in `AllCops`
+  Effectively, a single lint_roller plugin whose `rules` were of type `:object`
+  would inadvertently mark all previously-defined rules as invalid.
+  [#557](https://github.com/standardrb/standard/pull/557)
+
 ## 1.28.0
 
 * Refactor Standard into 3 gems and convert all built-in configuration into

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    standard (1.28.0)
+    standard (1.28.2)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.0)
       rubocop (~> 1.50.2)
@@ -23,7 +23,7 @@ GEM
     method_source (1.0.0)
     minitest (5.18.0)
     parallel (1.23.0)
-    parser (3.2.2.0)
+    parser (3.2.2.1)
       ast (~> 2.4.1)
     rainbow (3.1.1)
     rake (13.0.6)

data/README.md

@@ -15,7 +15,7 @@ supports plugins built with
 
 Standard Ruby was created and is maintained by the team at [Test
 Double](https://testdouble.com), because we appreciate the importance of
-balancing predictably consistent code with preserving developers' autonomy. 💚
+balancing predictable, consistent code with preserving developer autonomy. 💚
 
 Topics covered in this README:
 
@@ -37,7 +37,7 @@ ever agree on what all the rules and format should be.**
 
 This has resulted in innumerable teams arguing how to configure their linters
 and formatters over literal decades. Some teams routinely divert time and energy
-from whatever they're building to reach concensus on where commas should go.
+from whatever they're building to reach consensus on where commas should go.
 Other teams have an overzealous tech lead who sets up everything _his favorite
 way_ and then imposes his will on others. It's not uncommon to witness
 passive-aggressive programmers change a contentious rule back-and-forth,
@@ -63,9 +63,9 @@ for most of the ways people use Ruby, most of the time.
 
 If you adopt Standard Ruby, what's in it for you? Time saved that would've been
 spent arguing over how to set things up. Also, seamless upgrades: we stay on top
-of each new RuboCop rule ship an updated configuration  on a monthly release
+of each new RuboCop rule and update our configuration on a monthly release
 cadence. But the best part of adopting Standard as your linter and formatter?
-You'll spend a whole lot less time thinking about linters and formatters.
+**You'll spend a whole lot less time thinking about linters and formatters.**
 
 So please, give Standard Ruby a try. If you're like [these
 folks](#who-uses-standard-ruby), you'll soon realize that the value of a linter
@@ -110,7 +110,7 @@ A majority of Standard's rules can be safely fixed automatically.
 
 ```
 # CLI
-$ standard --fix
+$ standardrb --fix
 
 # Rake
 $ rake standard:fix

data/lib/standard/plugin/merges_plugins_into_rubocop_config.rb

@@ -27,17 +27,16 @@ module Standard
 
       def call(options_config, standard_config, plugins, permit_merging:)
         runner_context = @creates_runner_context.call(standard_config)
-        plugin_config = combine_rubocop_configs(options_config, runner_context, plugins).to_h
+        plugin_config = combine_rubocop_configs(options_config, runner_context, plugins, permit_merging: permit_merging).to_h
         merge_config_into_all_cops!(options_config, plugin_config)
         merge_config_into_standard!(options_config, plugin_config, permit_merging: permit_merging)
       end
 
       private
 
-      def combine_rubocop_configs(options_config, runner_context, plugins)
+      def combine_rubocop_configs(options_config, runner_context, plugins, permit_merging:)
+        all_cop_keys_configured_by_plugins = all_cop_keys_previously_configured_by_plugins(options_config, permit_merging: permit_merging)
         fake_out_rubocop_default_configuration(options_config) do |fake_config|
-          all_cop_keys_configured_by_plugins = []
-
           plugins.reduce(fake_config) do |combined_config, plugin|
             RuboCop::ConfigLoader.instance_variable_set(:@default_configuration, combined_config)
             next_config, path = config_for_plugin(plugin, runner_context)
@@ -49,7 +48,7 @@ module Standard
             )
             delete_already_configured_keys!(combined_config.keys, next_config, dont_delete_keys: ["AllCops"])
 
-            RuboCop::ConfigLoader.merge_with_default(next_config, path)
+            RuboCop::ConfigLoader.merge_with_default(next_config, path, unset_nil: false)
           end
         end
       end
@@ -60,7 +59,8 @@ module Standard
         if rules.type == :path
           [RuboCop::ConfigLoader.load_file(rules.value), rules.value]
         elsif rules.type == :object
-          [RuboCop::Config.new(rules.value), nil]
+          path = plugin.method(:rules).source_location[0]
+          [RuboCop::Config.create(rules.value, path, check: true), path]
         elsif rules.type == :error
           raise "Plugin `#{plugin.about&.name || plugin.inspect}' failed to load with error: #{rules.value.respond_to?(:message) ? rules.value.message : rules.value}"
         end
@@ -123,13 +123,32 @@ module Standard
         end
       end
 
+      def all_cop_keys_previously_configured_by_plugins(options_config, permit_merging:)
+        if permit_merging
+          []
+        else
+          Array(options_config["AllCops"]&.keys) - RuboCop::ConfigLoader.default_configuration["AllCops"].keys
+        end
+      end
+
       def fake_out_rubocop_default_configuration(options_config)
-        og_default_config = RuboCop::ConfigLoader.instance_variable_get(:@default_configuration)
+        og_default_config = RuboCop::ConfigLoader.default_configuration
+        set_target_rails_version_on_all_cops_because_its_technically_not_allowed!(options_config)
         result = yield blank_rubocop_config(options_config)
         RuboCop::ConfigLoader.instance_variable_set(:@default_configuration, og_default_config)
         result
       end
 
+      # Avoid a warning that would otherwise be emitted by any plugin that set TargetRailsVersion
+      # because it's not a default AllCops key specified in RuboCop's embedded default config.
+      #
+      # See: https://github.com/rubocop/rubocop/pull/11833
+      def set_target_rails_version_on_all_cops_because_its_technically_not_allowed!(options_config)
+        return if !options_config.key?("AllCops") || options_config["AllCops"].key?("TargetRailsVersion")
+
+        options_config["AllCops"]["TargetRailsVersion"] = nil
+      end
+
       def blank_rubocop_config(example_config)
         RuboCop::Config.new(example_config.to_h.slice(*MANDATORY_RUBOCOP_CONFIG_KEYS), "")
       end

data/lib/standard/version.rb

@@ -1,3 +1,3 @@
 module Standard
-  VERSION = Gem::Version.new("1.28.0")
+  VERSION = Gem::Version.new("1.28.2")
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: standard
 version: !ruby/object:Gem::Version
-  version: 1.28.0
+  version: 1.28.2
 platform: ruby
 authors:
 - Justin Searls
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-04-22 00:00:00.000000000 Z
+date: 2023-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop