standard 0.8.1 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bdafc85bb1387d3491c006a507b527d3831a5980520a918131bb242e899d3a35
-  data.tar.gz: 4339051c4e2a9f268de90aa67a3de7bf2dbe3abbad8377b73ce1f471f747d210
+  metadata.gz: ae2564522ac361e37d4c51c9962fe5b0bbca2fd7c4b37ae1880c619778a46966
+  data.tar.gz: 00b84978d2e64b59ecd757a46a7f562e7d9f1ecaeb0c03062140628c78565658
 SHA512:
-  metadata.gz: 3877c41ad4ee463801623eded88e7a715f521acd81bce6b2eb4de86353e379793c6262aec87c7c3034f507249da78a5712232d64d26a829a32bd1bb17d2ed72b
-  data.tar.gz: 0c74aa040926c89a1587398c712c29943775c8f943113fbf347f79132116c5c237a67e40d8ca98d0c2be4bd059238d9b8c69088c4f6f964bb9a7362e3e1fb375
+  metadata.gz: 91a99adab0683f57682af967b4936777444974f9f19c5cda438df911c3ce1ad37f099968eb1d47a4ebe541c96ae50cdb1967e89056e683e5dc71a7b29b03a3e8
+  data.tar.gz: 2c26f2ad10033b682b870cdaa66e6b60eb537a483f34d880d2bd90e70a3ef27e8421d06c13d261d74ca196748d8f3be2c915ae2e96e098c3bae1bdbe23f42c14

data/CHANGELOG.md

@@ -1,5 +1,39 @@
 # Changelog
 
+## 0.11.0 
+
+* Update rubocop-performance from 1.9.1 to [1.9.2](https://github.com/rubocop-hq/rubocop-performance/releases/tag/v1.9.2)
+* Update rubocop from 1.4.2 to [1.7.0](https://github.com/rubocop-hq/rubocop/releases/tag/v1.7.0)
+* Changed `Style/NegatedIf` to `postfix`
+
+## 0.10.2
+
+* Remove
+  [`Lint/DuplicateBranch`](https://github.com/testdouble/standard/pull/228)
+
+## 0.10.1
+
+* Remove [`Performance/ArraySemiInfiniteRangeSlice`](https://github.com/testdouble/standard/pull/225#discussion_r532678908)
+
+## 0.10.0
+
+* Update rubocop-performance from 1.8.1 to [1.9.1](https://github.com/rubocop-hq/rubocop-performance/releases/tag/v1.9.1) enabling:
+  * [`Performance/BlockGivenWithExplicitBlock`](https://github.com/rubocop-hq/rubocop-performance/pull/173)
+  * [`Performance/ConstantRegexp`](https://github.com/rubocop-hq/rubocop-performance/pull/174)
+  * [`Performance/ArraySemiInfiniteRangeSlice`](https://github.com/rubocop-hq/rubocop-performance/pull/175)
+* Update rubocop from 1.2.0 to [1.4.2](https://github.com/rubocop-hq/rubocop/releases/tag/v1.4.2) enabling:
+  * [`Style/NilLambda`](https://github.com/rubocop-hq/rubocop/pull/9020)
+  * [`Lint/DuplicateBranch`](https://github.com/rubocop-hq/rubocop/pull/8404)
+
+## 0.9.0
+
+* Update rubocop from 1.0.0 to [1.2.0](https://github.com/rubocop-hq/rubocop/releases/tag/v1.2.0) enabling:
+  * [`Lint/DuplicateRegexpCharacterClassElement`](https://github.com/rubocop-hq/rubocop/pull/8896)
+  * [`Style/ArgumentsForwarding`](https://github.com/rubocop-hq/rubocop/pull/7646)
+* Don't find offense in `Style/SemanticBlocks` when a top-level `rescue` is used
+  in a `do`/`end` functional block, fixing
+  [#205](https://github.com/testdouble/standard/issues/205)
+
 ## 0.8.1
 
 * Make it match semver

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    standard (0.8.1)
-      rubocop (= 1.0.0)
-      rubocop-performance (= 1.8.1)
+    standard (0.11.0)
+      rubocop (= 1.7.0)
+      rubocop-performance (= 1.9.2)
 
 GEM
   remote: https://rubygems.org/
@@ -14,31 +14,31 @@ GEM
     gimme (0.5.0)
     method_source (1.0.0)
     minitest (5.14.2)
-    parallel (1.19.2)
-    parser (2.7.2.0)
+    parallel (1.20.1)
+    parser (3.0.0.0)
       ast (~> 2.4.1)
     pry (0.13.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
     rainbow (3.0.0)
     rake (13.0.1)
-    regexp_parser (1.8.2)
+    regexp_parser (2.0.3)
     rexml (3.2.4)
-    rubocop (1.0.0)
+    rubocop (1.7.0)
       parallel (~> 1.10)
       parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8)
+      regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 0.6.0)
+      rubocop-ast (>= 1.2.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (1.0.0)
+    rubocop-ast (1.4.0)
       parser (>= 2.7.1.5)
-    rubocop-performance (1.8.1)
-      rubocop (>= 0.87.0)
+    rubocop-performance (1.9.2)
+      rubocop (>= 0.90.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    ruby-progressbar (1.10.1)
+    ruby-progressbar (1.11.0)
     simplecov (0.19.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)

data/README.md

@@ -367,7 +367,7 @@ Refer to RuboCop's [documentation on
 formatters](https://rubocop.readthedocs.io/en/latest/formatters/) for more
 information.
 
-## How do I run standard in my editor?
+## How do I run Standard in my editor?
 
 It can be very handy to know about failures while editing to shorten the
 feedback loop. Some editors support asynchronously running linters.
@@ -378,6 +378,10 @@ feedback loop. Some editors support asynchronously running linters.
 - [vim (via ALE)](https://github.com/testdouble/standard/wiki/IDE:-vim)
 - [VS Code](https://github.com/testdouble/standard/wiki/IDE:-vscode)
 
+## How do I use Standard with Rubocop extensions?
+
+This is not officially supported by Standard. However, Evil Martians wrote up [a regularly updated guide](https://evilmartians.com/chronicles/rubocoping-with-legacy-bring-your-ruby-code-up-to-standard) on how to do so.
+
 ## Does Standard work with [Insert other tool name here]?
 
 Maybe! Start by searching the repository to see if there's an existing issue open for

data/config/base.yml

@@ -56,10 +56,10 @@ Layout/BlockAlignment:
 Layout/BlockEndNewline:
   Enabled: true
 
-# Disabled because IndentOneStep can't be configured for one-liner cases. See:
-# https://github.com/rubocop-hq/rubocop/issues/6447
-# Layout/CaseIndentation:
-  # Enabled: true
+Layout/CaseIndentation:
+  # Disabled because IndentOneStep can't be configured for one-liner cases. See:
+  # https://github.com/rubocop-hq/rubocop/issues/6447
+  Enabled: false
 
 Layout/ClosingHeredocIndentation:
   Enabled: true
@@ -173,6 +173,10 @@ Layout/IndentationConsistency:
   Enabled: true
   EnforcedStyle: normal
 
+Layout/IndentationStyle:
+  Enabled: true
+  IndentationWidth: ~
+
 Layout/IndentationWidth:
   Enabled: true
   Width: 2
@@ -181,10 +185,10 @@ Layout/IndentationWidth:
 Layout/InitialIndentation:
   Enabled: true
 
-Layout/LeadingEmptyLines:
+Layout/LeadingCommentSpace:
   Enabled: true
 
-Layout/LeadingCommentSpace:
+Layout/LeadingEmptyLines:
   Enabled: true
 
 Layout/MultilineArrayBraceLayout:
@@ -250,6 +254,9 @@ Layout/SpaceAroundEqualsInParameterDefault:
 Layout/SpaceAroundKeyword:
   Enabled: true
 
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
 Layout/SpaceAroundOperators:
   Enabled: true
   AllowForAlignment: true
@@ -314,10 +321,6 @@ Layout/SpaceInsideStringInterpolation:
   Enabled: true
   EnforcedStyle: no_space
 
-Layout/IndentationStyle:
-  Enabled: true
-  IndentationWidth: ~
-
 Layout/TrailingEmptyLines:
   Enabled: true
   EnforcedStyle: final_newline
@@ -372,6 +375,9 @@ Lint/DuplicateHashKey:
 Lint/DuplicateMethods:
   Enabled: true
 
+Lint/DuplicateRegexpCharacterClassElement:
+  Enabled: true
+
 Lint/DuplicateRequire:
   Enabled: true
 
@@ -545,9 +551,6 @@ Lint/ShadowedArgument:
 Lint/ShadowedException:
   Enabled: true
 
-Layout/SpaceAroundMethodCallOperator:
-  Enabled: true
-
 Lint/Syntax:
   Enabled: true
 
@@ -594,6 +597,13 @@ Migration/DepartmentName:
 Naming/BinaryOperatorParameterName:
   Enabled: true
 
+Naming/BlockParameterName:
+  Enabled: true
+  MinNameLength: 1
+  AllowNamesEndingInNumbers: true
+  AllowedNames: []
+  ForbiddenNames: []
+
 Naming/ClassAndModuleCamelCase:
   Enabled: true
 
@@ -604,13 +614,6 @@ Naming/HeredocDelimiterCase:
   Enabled: true
   EnforcedStyle: uppercase
 
-Naming/BlockParameterName:
-  Enabled: true
-  MinNameLength: 1
-  AllowNamesEndingInNumbers: true
-  AllowedNames: []
-  ForbiddenNames: []
-
 Naming/VariableName:
   Enabled: true
   EnforcedStyle: snake_case
@@ -621,6 +624,9 @@ Performance/BigDecimalWithNumericArgument:
 Performance/BindCall:
   Enabled: true
 
+Performance/BlockGivenWithExplicitBlock:
+  Enabled: true
+
 Performance/Caller:
   Enabled: true
 
@@ -630,6 +636,9 @@ Performance/CollectionLiteralInLoop:
 Performance/CompareWithBlock:
   Enabled: true
 
+Performance/ConstantRegexp:
+  Enabled: true
+
 Performance/Count:
   Enabled: true
 
@@ -723,7 +732,6 @@ Security/YAMLLoad:
   Enabled: true
   SafeAutoCorrect: false
 
-
 Standard/SemanticBlocks:
   ProceduralMethods:
     - benchmark
@@ -766,6 +774,10 @@ Style/AndOr:
   Enabled: true
   EnforcedStyle: always
 
+Style/ArgumentsForwarding:
+  Enabled: true
+  AllowOnlyRestArgument: true
+
 Style/ArrayJoin:
   Enabled: true
 
@@ -886,7 +898,6 @@ Style/IfWithSemicolon:
 
 Style/InfiniteLoop:
   Enabled: true
-  SafeAutoCorrect: true
 
 Style/KeywordParametersOrder:
   Enabled: true
@@ -928,7 +939,7 @@ Style/MultilineWhenThen:
 
 Style/NegatedIf:
   Enabled: true
-  EnforcedStyle: both
+  EnforcedStyle: postfix
 
 Style/NegatedWhile:
   Enabled: true
@@ -964,6 +975,9 @@ Style/NilComparison:
   Enabled: true
   EnforcedStyle: predicate
 
+Style/NilLambda:
+  Enabled: true
+
 Style/NonNilCheck:
   Enabled: true
   IncludeSemanticChanges: false
@@ -1011,6 +1025,9 @@ Style/RedundantAssignment:
 Style/RedundantBegin:
   Enabled: true
 
+Style/RedundantCondition:
+  Enabled: true
+
 Style/RedundantConditional:
   Enabled: true
 
@@ -1026,9 +1043,15 @@ Style/RedundantFileExtensionInRequire:
 Style/RedundantFreeze:
   Enabled: true
 
+Style/RedundantInterpolation:
+  Enabled: true
+
 Style/RedundantParentheses:
   Enabled: true
 
+Style/RedundantPercentQ:
+  Enabled: true
+
 Style/RedundantRegexpCharacterClass:
   Enabled: true
 
@@ -1042,6 +1065,9 @@ Style/RedundantReturn:
 Style/RedundantSelf:
   Enabled: true
 
+Style/RedundantSort:
+  Enabled: true
+
 Style/RedundantSortBy:
   Enabled: true
 
@@ -1158,18 +1184,6 @@ Style/TrivialAccessors:
 Style/UnlessElse:
   Enabled: true
 
-Style/RedundantCondition:
-  Enabled: true
-
-Style/RedundantInterpolation:
-  Enabled: true
-
-Style/RedundantPercentQ:
-  Enabled: true
-
-Style/RedundantSort:
-  Enabled: true
-
 Style/UnpackFirst:
   Enabled: true
 

data/config/ruby-1.8.yml

@@ -1,8 +1,7 @@
 inherit_from: ./ruby-1.9.yml
 
-Style/Lambda:
-  Enabled: false
-
 Style/HashSyntax:
   EnforcedStyle: hash_rockets
 
+Style/Lambda:
+  Enabled: false

data/lib/standard/cop/semantic_blocks.rb

@@ -1,7 +1,8 @@
 module RuboCop::Cop
   module Standard
-    class SemanticBlocks < RuboCop::Cop::Cop
+    class SemanticBlocks < RuboCop::Cop::Base
       include RuboCop::Cop::IgnoredMethods
+      extend RuboCop::Cop::AutoCorrector
 
       def on_send(node)
         return unless node.arguments?
@@ -18,20 +19,18 @@ module RuboCop::Cop
       end
 
       def on_block(node)
-        return if ignored_node?(node) || proper_block_style?(node)
+        return if ignored_node?(node) ||
+          proper_block_style?(node) ||
+          (!node.braces? && rescue_child_block?(node))
 
-        add_offense(node, location: :begin)
-      end
-
-      def autocorrect(node)
-        return if correction_would_break_code?(node)
+        add_offense(node.loc.begin, message: message(node)) do |corrector|
+          return if correction_would_break_code?(node)
 
-        if node.single_line?
-          replace_do_end_with_braces(node.loc)
-        elsif node.braces?
-          replace_braces_with_do_end(node.loc)
-        else
-          replace_do_end_with_braces(node.loc)
+          if node.braces?
+            replace_braces_with_do_end(corrector, node.loc)
+          else
+            replace_do_end_with_braces(corrector, node.loc)
+          end
         end
       end
 
@@ -47,29 +46,25 @@ module RuboCop::Cop
         end
       end
 
-      def replace_braces_with_do_end(loc)
+      def replace_braces_with_do_end(corrector, loc)
         b = loc.begin
         e = loc.end
 
-        lambda do |corrector|
-          corrector.insert_before(b, " ") unless whitespace_before?(b)
-          corrector.insert_before(e, " ") unless whitespace_before?(e)
-          corrector.insert_after(b, " ") unless whitespace_after?(b)
-          corrector.replace(b, "do")
-          corrector.replace(e, "end")
-        end
+        corrector.insert_before(b, " ") unless whitespace_before?(b)
+        corrector.insert_before(e, " ") unless whitespace_before?(e)
+        corrector.insert_after(b, " ") unless whitespace_after?(b)
+        corrector.replace(b, "do")
+        corrector.replace(e, "end")
       end
 
-      def replace_do_end_with_braces(loc)
+      def replace_do_end_with_braces(corrector, loc)
         b = loc.begin
         e = loc.end
 
-        lambda do |corrector|
-          corrector.insert_after(b, " ") unless whitespace_after?(b, 2)
+        corrector.insert_after(b, " ") unless whitespace_after?(b, 2)
 
-          corrector.replace(b, "{")
-          corrector.replace(e, "}")
-        end
+        corrector.replace(b, "{")
+        corrector.replace(e, "}")
       end
 
       def whitespace_before?(range)
@@ -118,7 +113,7 @@ module RuboCop::Cop
       end
 
       def rescue_child_block?(node)
-        node.children.any?(&:rescue_type?)
+        node.children.any? { |node| node.rescue_type? || node.ensure_type? }
       end
 
       def non_parenthesized_keyword_args?(node)

data/lib/standard/version.rb

@@ -1,3 +1,3 @@
 module Standard
-  VERSION = Gem::Version.new("0.8.1")
+  VERSION = Gem::Version.new("0.11.0")
 end

data/standard.gemspec

@@ -19,8 +19,8 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "1.0.0"
-  spec.add_dependency "rubocop-performance", "1.8.1"
+  spec.add_dependency "rubocop", "1.7.0"
+  spec.add_dependency "rubocop-performance", "1.9.2"
 
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "minitest", "~> 5.0"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: standard
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.11.0
 platform: ruby
 authors:
 - Justin Searls
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-10-26 00:00:00.000000000 Z
+date: 2021-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.7.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.7.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 1.9.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 1.9.2
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -190,7 +190,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: Ruby Style Guide, with linter & automatic code fixer