standard 0.5.0 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 59c4fae3fd70f49e1adf75b0d405296751ba18c8a41df7fa538b6efa77214b5c
-  data.tar.gz: 73b864e4973762b2662880e4a0aa4f3c839794b1392a6160466947dd34f55529
+  metadata.gz: 15ed22fe01a211ccfbe8bf7861eace8d51dcda8a31b5eb9ad5d1b92022d9666c
+  data.tar.gz: 4a4baa10c02e9877bf0a949d9e2c8aca8453d8d09ec78ee9879d6aa61abee6ce
 SHA512:
-  metadata.gz: facf91b5c424f7f6d6871131315fa705a7f8bf43a8c34d1b9d2e8de50ebc0ab5cd68eed98a20a22326e4de33eb41f41b42f82bda3905245214d343137e956cfd
-  data.tar.gz: 92d9eb12a61ffa3acd0a425e3ba11421699d513cab44b4e453cb6c2f1140d2e88efc42d8f9c06518e540510425af8a5f09dd7f540356e068e22f7cec62590724
+  metadata.gz: 79338dde1ea560a30e3667391e63cd7804807ee8616c4d33d84400809fec35e3b35abd9275d05d61285ce93bf491a006c987e753ac814f752041f5a1fac75e8f
+  data.tar.gz: 9ed1dde0608ea7a37d9a98bfcac9ecf4f4dcc5bd16f6a9ed647837884db82d051d0b7adf0d8b4edf1f79451812e9831f06527bac18fe560356caed74d462a859

data/.github/workflows/test.yml

@@ -0,0 +1,23 @@
+name: Tests
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 2.7
+    - name: Install dependencies
+      run: bundle
+    - name: Run tests
+      run: bundle exec rake

data/CHANGELOG.md

@@ -1,5 +1,54 @@
 # Changelog
 
+## 0.6.2
+
+* Update rubocop from 0.91 to
+  [0.91.1](https://github.com/rubocop-hq/rubocop/releases/tag/v0.91.1)
+* Update rubocop-performance from 1.8.0 to 1.8.1:
+  * Enable `Performance/Sum`
+
+## 0.6.1
+
+* Update Rubocop from
+  [0.90](https://github.com/rubocop-hq/rubocop/releases/tag/v0.90.0)
+  to
+  [0.91](https://github.com/rubocop-hq/rubocop/releases/tag/v0.91.0),
+  enabling:
+  * [`Lint/UselessTimes`](https://github.com/rubocop-hq/rubocop/pull/8702)
+  * [`Layout/BeginEndAlignment`](https://github.com/rubocop-hq/rubocop/pull/8628)
+  * [`Lint/ConstantDefinitionInBlock`](https://github.com/rubocop-hq/rubocop/pull/8707)
+  * [`Lint/IdentityComparison`](https://github.com/rubocop-hq/rubocop/pull/8699/)
+  re-enabling after bug fixes:
+  * [`Bundler/DuplicatedGem`](https://github.com/rubocop-hq/rubocop/pull/8666)
+  * [`Naming/BinaryOperatorParameterName`](https://github.com/rubocop-hq/rubocop/issues/8664)
+
+## 0.6.0
+
+* Update Rubocop from
+  [0.89.1](https://github.com/rubocop-hq/rubocop/releases/tag/v0.89.1)
+  to
+  [0.90](https://github.com/rubocop-hq/rubocop/releases/tag/v0.90.0),
+  enabling:
+  * [`Style/KeywordParametersOrder`](https://github.com/rubocop-hq/rubocop/pull/8563)
+  * [`Lint/DuplicateRequire`](https://github.com/rubocop-hq/rubocop/pull/8474)
+  * [`Lint/TrailingCommaInAttributeDeclaration`](https://github.com/rubocop-hq/rubocop/pull/8549)
+* Update [`Style/Alias` to prefer `alias_method`](https://github.com/testdouble/standard/pull/196)
+* Update rubocop-performance from 1.7.1 to 1.8.0:
+  * Plan to enable [`Performance/Sum`](https://github.com/rubocop-hq/rubocop-performance/pull/137) in the future, but there is currently a bug in the implementation
+* Add `ruby-2.3.yml` to add support for 2.3.
+
+## 0.5.2
+
+* Turned off `Lint/MissingSuper`, because it effectively bans a common idiom in
+  Sorbet ([#195](https://github.com/testdouble/standard/issues/195)) and might
+  be a bit too heavy-handed/opinionated for cases where a class is designed
+  intentionally to not run its parent's initializer (like abstract superclasses
+  more generally)
+
+## 0.5.1
+
+* Enabled `Style/MultilineWhenThen`
+
 ## 0.5.0
 
 * Update Rubocop from
@@ -96,4 +145,3 @@
 ## 0.3.0
 
 * Update Standard to track Rubocop 0.82.0 ([commit](https://github.com/testdouble/standard/commit/d663ea62d519c659087ad606bfed031c6303ff20))
-

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    standard (0.5.0)
-      rubocop (~> 0.89.1)
-      rubocop-performance (~> 1.7.1)
+    standard (0.6.2)
+      rubocop (= 0.91.1)
+      rubocop-performance (= 1.8.1)
 
 GEM
   remote: https://rubygems.org/
@@ -13,7 +13,7 @@ GEM
     docile (1.3.2)
     gimme (0.5.0)
     method_source (1.0.0)
-    minitest (5.14.1)
+    minitest (5.14.2)
     parallel (1.19.2)
     parser (2.7.1.4)
       ast (~> 2.4.1)
@@ -22,23 +22,24 @@ GEM
       method_source (~> 1.0)
     rainbow (3.0.0)
     rake (13.0.1)
-    regexp_parser (1.7.1)
+    regexp_parser (1.8.0)
     rexml (3.2.4)
-    rubocop (0.89.1)
+    rubocop (0.91.1)
       parallel (~> 1.10)
       parser (>= 2.7.1.1)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.7)
       rexml
-      rubocop-ast (>= 0.3.0, < 1.0)
+      rubocop-ast (>= 0.4.0, < 1.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.3.0)
+    rubocop-ast (0.4.2)
       parser (>= 2.7.1.4)
-    rubocop-performance (1.7.1)
-      rubocop (>= 0.82.0)
+    rubocop-performance (1.8.1)
+      rubocop (>= 0.87.0)
+      rubocop-ast (>= 0.4.0)
     ruby-progressbar (1.10.1)
-    simplecov (0.18.5)
+    simplecov (0.19.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
     simplecov-html (0.12.2)

data/README.md

@@ -1,6 +1,6 @@
 ## Standard - Ruby style guide, linter, and formatter
 
-[![CircleCI](https://circleci.com/gh/testdouble/standard.svg?style=svg)](https://circleci.com/gh/testdouble/standard)
+[![Tests](https://github.com/testdouble/standard/workflows/Tests/badge.svg)](https://github.com/testdouble/standard/actions?query=workflow%3ATests)
 [![Ruby Style Guide](https://img.shields.io/badge/code_style-standard-brightgreen.svg)](https://github.com/testdouble/standard)
 [![Gem Version](https://badge.fury.io/rb/standard.svg)](https://rubygems.org/gems/standard)
 
@@ -100,7 +100,7 @@ When you run Standard in the future it will ignore these files as if they lived
 `ignore` section in the `.standard.yml` file.
 
 As you refactor your existing project you can remove files from the list.  You can
-also regenerate the todo file at anytime by re-running the above command.
+also regenerate the todo file at any time by re-running the above command.
 
 ### Using with Rake
 

data/config/base.yml

@@ -7,6 +7,13 @@ AllCops:
   DisabledByDefault: true
   Exclude: []
 
+Bundler/DuplicatedGem:
+  Enabled: true
+  Include:
+    - '**/*.gemfile'
+    - '**/Gemfile'
+    - '**/gems.rb'
+
 Bundler/InsecureProtocolSource:
   Enabled: true
   Include:
@@ -32,16 +39,15 @@ Layout/ArrayAlignment:
   Enabled: true
   EnforcedStyle: with_fixed_indentation
 
-Layout/HashAlignment:
+Layout/AssignmentIndentation:
   Enabled: true
-  EnforcedHashRocketStyle: key
-  EnforcedColonStyle: key
-  EnforcedLastArgumentHashStyle: always_inspect
+  IndentationWidth: ~
 
-Layout/ParameterAlignment:
+Layout/BeginEndAlignment:
   Enabled: true
-  EnforcedStyle: with_fixed_indentation
-  IndentationWidth: ~
+  EnforcedStyleAlignWith: start_of_line
+  AutoCorrect: true
+  Severity: warning
 
 Layout/BlockAlignment:
   Enabled: true
@@ -149,15 +155,17 @@ Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
   IndentationWidth: ~
 
-Layout/AssignmentIndentation:
-  Enabled: true
-  IndentationWidth: ~
-
 Layout/FirstHashElementIndentation:
   Enabled: true
   EnforcedStyle: consistent
   IndentationWidth: ~
 
+Layout/HashAlignment:
+  Enabled: true
+  EnforcedHashRocketStyle: key
+  EnforcedColonStyle: key
+  EnforcedLastArgumentHashStyle: always_inspect
+
 Layout/HeredocIndentation:
   Enabled: true
 
@@ -208,6 +216,11 @@ Layout/MultilineOperationIndentation:
   EnforcedStyle: indented
   IndentationWidth: ~
 
+Layout/ParameterAlignment:
+  Enabled: true
+  EnforcedStyle: with_fixed_indentation
+  IndentationWidth: ~
+
 Layout/RescueEnsureAlignment:
   Enabled: true
 
@@ -335,6 +348,9 @@ Lint/BooleanSymbol:
 Lint/CircularArgumentReference:
   Enabled: true
 
+Lint/ConstantDefinitionInBlock:
+  Enabled: true
+
 Lint/Debugger:
   Enabled: true
 
@@ -350,10 +366,13 @@ Lint/DuplicateCaseCondition:
 Lint/DuplicateElsifCondition:
   Enabled: true
 
+Lint/DuplicateHashKey:
+  Enabled: true
+
 Lint/DuplicateMethods:
   Enabled: true
 
-Lint/DuplicateHashKey:
+Lint/DuplicateRequire:
   Enabled: true
 
 Lint/DuplicateRescueException:
@@ -397,6 +416,9 @@ Lint/FloatOutOfRange:
 Lint/FormatParameterMismatch:
   Enabled: true
 
+Lint/IdentityComparison:
+  Enabled: true
+
 Lint/ImplicitStringConcatenation:
   Enabled: true
 
@@ -423,9 +445,6 @@ Lint/MissingCopEnableDirective:
   Enabled: true
   MaximumRangeSize: .inf
 
-Lint/MissingSuper:
-  Enabled: true
-
 Lint/MixedRegexpCaptureTypes:
   Enabled: true
 
@@ -535,6 +554,9 @@ Lint/Syntax:
 Lint/TopLevelReturnWithArgument:
   Enabled: true
 
+Lint/TrailingCommaInAttributeDeclaration:
+  Enabled: true
+
 Lint/UnderscorePrefixedVariableName:
   Enabled: true
 
@@ -559,6 +581,9 @@ Lint/UselessElseWithoutRescue:
 Lint/UselessSetterCall:
   Enabled: true
 
+Lint/UselessTimes:
+  Enabled: true
+
 Lint/Void:
   Enabled: true
   CheckForMethodsWithNoSideEffects: false
@@ -566,6 +591,9 @@ Lint/Void:
 Migration/DepartmentName:
   Enabled: true
 
+Naming/BinaryOperatorParameterName:
+  Enabled: true
+
 Naming/ClassAndModuleCamelCase:
   Enabled: true
 
@@ -596,6 +624,9 @@ Performance/BindCall:
 Performance/Caller:
   Enabled: true
 
+Performance/CollectionLiteralInLoop:
+  Enabled: false
+
 Performance/CompareWithBlock:
   Enabled: true
 
@@ -670,6 +701,10 @@ Performance/StartWith:
 Performance/StringReplacement:
   Enabled: true
 
+Performance/Sum:
+  Enabled: true
+  AutoCorrect: true
+
 Performance/UnfreezeString:
   Enabled: true
 
@@ -729,7 +764,7 @@ Standard/SemanticBlocks:
 
 Style/Alias:
   Enabled: true
-  EnforcedStyle: prefer_alias
+  EnforcedStyle: prefer_alias_method
 
 Style/AndOr:
   Enabled: true
@@ -854,6 +889,9 @@ Style/InfiniteLoop:
   Enabled: true
   SafeAutoCorrect: true
 
+Style/KeywordParametersOrder:
+  Enabled: true
+
 Style/LambdaCall:
   Enabled: true
   EnforcedStyle: call
@@ -886,6 +924,9 @@ Style/MultilineMemoization:
   Enabled: true
   EnforcedStyle: keyword
 
+Style/MultilineWhenThen:
+  Enabled: true
+
 Style/NegatedIf:
   Enabled: true
   EnforcedStyle: both

data/config/ruby-2.2.yml

@@ -1,7 +1,4 @@
-inherit_from: ./base.yml
-
-AllCops:
-  TargetRubyVersion: 2.4 # The oldest supported
+inherit_from: ./ruby-2.3.yml
 
 Layout:
   HeredocIndentation:

data/config/ruby-2.3.yml

@@ -0,0 +1,8 @@
+inherit_from: ./base.yml
+
+AllCops:
+  TargetRubyVersion: 2.4 # The oldest supported
+
+Performance:
+  Sum:
+    Enabled: false

data/docs/RELEASE.md

@@ -0,0 +1,42 @@
+# How to release Standard Ruby
+
+Because this gem was generated with the [bundler `gem`
+command](https://bundler.io/man/bundle-gem.1.html), [our Rakefile](/Rakefile)
+loads `bundler/gem_tasks`, which provides a lot of the commands one needs
+to manage a gem's release lifecycle:
+
+```
+$ rake -T
+rake build            # Build standard-x.x.x.gem into the pkg directory
+rake clean            # Remove any temporary products
+rake clobber          # Remove any generated files
+rake install          # Build and install standard-x.x.x.gem into system gems
+rake install:local    # Build and install standard-x.x.x.gem into system gems without network access
+rake release[remote]  # Create tag vx.x.x and build and push standard-0.5.2.gem to rubygems.org
+```
+
+Most of these commands are depended on (read: run by) `rake release`, which is
+really the only one we'll need for releasing the gem to
+[Rubygems.org](https://rubygems.org/gems/standard).
+
+## Release steps
+
+1. Make sure git is up to date and `bundle exec rake` exits cleanly
+2. If you upgraded a Rubocop dependency, be sure to lock it down in
+   `standard.gemspec`. Until Rubocop hits 1.0, we're going to stick to exact
+   release dependencies (e.g. "0.91.0" instead of "~> 0.91")
+3. Bump the appropriate version segment in `lib/standard/version.rb` (basic
+   semantic versioning rules apply; if the release updates Rubocop, follow its
+   version bump at a minimum—if rubocop saw minor bump, we'll also bump the
+   minor version)
+4. Run `bundle` so that Bundler writes this version to `Gemfile.lock`
+5. Update `CHANGELOG.md` as exhaustively as you are able and set the top header
+   to that of the new version
+6. Commit `lib/standard/version.rb`, `Gemfile.lock`, and `CHANGELOG.md` together
+   with the message equal to the new version (e.g. "0.42.1")
+7. Finally, run `bundle exec rake release`, which will hopefully succeed
+8. Provide your multi-factor-auth token when prompted to finish publishing the
+   gem
+9. [Tweet](https://twitter.com) about your awesome new release! (Shameless
+   self-promotion is the most important part of open source software)
+

data/lib/standard/creates_config_store/assigns_rubocop_yaml.rb

@@ -16,6 +16,8 @@ class Standard::CreatesConfigStore
         "ruby-1.9.yml"
       elsif desired_version < Gem::Version.new("2.3")
         "ruby-2.2.yml"
+      elsif desired_version < Gem::Version.new("2.4")
+        "ruby-2.3.yml"
       else
         "base.yml"
       end

data/lib/standard/version.rb

@@ -1,3 +1,3 @@
 module Standard
-  VERSION = Gem::Version.new("0.5.0")
+  VERSION = Gem::Version.new("0.6.2")
 end

data/standard.gemspec

@@ -19,8 +19,8 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 0.89.1"
-  spec.add_dependency "rubocop-performance", "~> 1.7.1"
+  spec.add_dependency "rubocop", "0.91.1"
+  spec.add_dependency "rubocop-performance", "1.8.1"
 
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "minitest", "~> 5.0"

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: standard
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.2
 platform: ruby
 authors:
 - Justin Searls
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-08-22 00:00:00.000000000 Z
+date: 2020-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 0.89.1
+        version: 0.91.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 0.89.1
+        version: 0.91.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 1.7.1
+        version: 1.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 1.7.1
+        version: 1.8.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -130,7 +130,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- ".circleci/config.yml"
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".standard.yml"
 - CHANGELOG.md
@@ -145,6 +145,8 @@ files:
 - config/ruby-1.8.yml
 - config/ruby-1.9.yml
 - config/ruby-2.2.yml
+- config/ruby-2.3.yml
+- docs/RELEASE.md
 - exe/standardrb
 - lib/standard.rb
 - lib/standard/builds_config.rb

data/.circleci/config.yml

@@ -1,36 +0,0 @@
-# Ruby CircleCI 2.0 configuration file
-#
-# Check https://circleci.com/docs/2.0/language-ruby/ for more details
-#
-version: 2
-jobs:
-  build:
-    docker:
-       - image: circleci/ruby:2.7.0-node-browsers
-    working_directory: ~/repo
-
-    steps:
-      - checkout
-      - restore_cache:
-          keys:
-          - v1-dependencies-{{ checksum "Gemfile.lock" }}
-          - v1-dependencies-
-
-      - run:
-          name: install dependencies
-          command: |
-            bundle update --bundler
-            bundle install --jobs=4 --retry=3 --path vendor/bundle
-
-      - save_cache:
-          paths:
-            - ./vendor/bundle
-          key: v1-dependencies-{{ checksum "Gemfile.lock" }}
-
-      - run:
-          name: test
-          command: bundle exec rake test
-
-      - run:
-          name: lint
-          command: bundle exec rake standard:fix